174729 2017-07-21 15:17:29 -0700 Crash in many WebKit apps marking a connection invalid under Messages::NetworkProcessProxy::canAuthenticateAgainstProtectionSpace 2018-09-19 10:19:27 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=189660 InRadar P2 Normal --- 1 beidson beidson commit-queue ggaren thorton oldest_to_newest 1331144 0 beidson 2017-07-21 15:17:29 -0700 Crash in many WebKit apps marking a connection invalid under Messages::NetworkProcessProxy::canAuthenticateAgainstProtectionSpace This is the top of the crash stack: IPC::Connection::markCurrentlyDispatchedMessageAsInvalid() <== WebPageProxy::canAuthenticateAgainstProtectionSpace NetworkProcessProxy::CanAuthenticateAgainstProtectionSpace void IPC::handleMessage<Messages::NetworkProcessProxy::CanAuthenticateAgainstProtectionSpace, WebKit::NetworkProcessProxy... NetworkProcessProxy checks the validity of the WebPageProxy but not the WebFrameProxy. Then the WebPageProxy message checks the frameID, finds it is invalid, then tries to mark its connection invalid... but it doesn't have a connection. On the surface this seems bizarre, but it's an okay state to be in. The NetworkingProcess cannot possible know about the validity of WebPage and WebFrame identifiers by the time it messages the UIProcess directly for this CanAuthenticateAgainstProtectionSpace event. Previously, the CanAuthenticateAgainstProtectionSpace event went from Network -> Web -> UIProcess and, in that case, the message check handling it was valid. But since we short circuited the WebProcess out of handling this event, the message check no longer holds. The NetworkProcessProxy just needs to validate the ids up front. <rdar://problem/28822272> 1331152 1 316127 beidson 2017-07-21 15:26:18 -0700 Created attachment 316127 Patch 1331164 2 316127 commit-queue 2017-07-21 15:49:52 -0700 Comment on attachment 316127 Patch Rejecting attachment 316127 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -c /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WKFileUploadPanel.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/NetworkProcessProxy.o UIProcess/Network/NetworkProcessProxy.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/4163957 1331171 3 316132 beidson 2017-07-21 15:55:29 -0700 Created attachment 316132 Patch 1331212 4 316132 commit-queue 2017-07-21 17:15:03 -0700 Comment on attachment 316132 Patch Clearing flags on attachment: 316132 Committed r219754: <http://trac.webkit.org/changeset/219754> 1331213 5 commit-queue 2017-07-21 17:15:05 -0700 All reviewed patches have been landed. Closing bug. 316127 2017-07-21 15:26:18 -0700 2017-07-21 15:55:27 -0700 Patch bug-174729-20170721152617.patch text/plain 3372 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcxZWRmYTE4NmRmYzNmMDk4 ODY3ZDE1OWUwMjk1MDgxNzQ4YjM0YjIuLmE2ZjA1OGEyZDc0ZWU0NzE2N2M4ZTlhNjdjODRiN2Iy ZDcyODM1MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjggQEAKIDIwMTctMDctMjEgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIENyYXNoIGluIG1hbnkgV2ViS2l0 IGFwcHMgbWFya2luZyBhIGNvbm5lY3Rpb24gaW52YWxpZCB1bmRlciBNZXNzYWdlczo6TmV0d29y a1Byb2Nlc3NQcm94eTo6Y2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZS4KKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI4ODIyMjcyPiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NDcyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFByZXZpb3VzbHksIHdoZW4gYSBOZXR3b3JrTG9hZCBnZW5lcmF0 ZWQgYSAiQ2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZSIgZXZlbnQsIHRoZSBt ZXNzYWdlIHdlbnQgZnJvbQorICAgICAgICBOZXR3b3JrIHByb2Nlc3MgLT4gV2ViIHByb2Nlc3Mg LT4gVUkgcHJvY2Vzcy4KKworICAgICAgICBJbiB0aGF0IGNhc2UsIE1FU1NBR0VfQ0hFQ0tpbmcg dGhlIHZhbGlkaXR5IG9mIHRoZSBmcmFtZSBpbiBXZWJQYWdlUHJveHkgbWFkZSBzZW5zZS4KKwor ICAgICAgICBJbiByMjAyNTExIHdlIGN1dCB0aGUgV2ViUHJvY2VzcyBvdXQgb2YgdGhpcyBhbmQg aGFkIE5ldHdvcmtpbmcgZ28gc3RyYWlnaHQgdG8gVUkgcHJvY2Vzcy4KKworICAgICAgICBBcyBh IHJlc3VsdCwgdGhlIG1lc3NhZ2UgY2hlY2sgYmVjYW1lIGludmFsaWQuIFRoZSBOZXR3b3JraW5n IHByb2Nlc3MgY2Fubm90IHBvc3NpYmxlIGtub3cgdGhlIHZhbGlkaXR5IG9mIAorICAgICAgICBw YXJ0aWN1bGFyIFdlYlBhZ2Ugb3IgV2ViRnJhbWUgaWRlbnRpZmllcnMuCisKKyAgICAgICAgV2Ug c2ltcGx5IG5lZWQgdG8gdmFsaWRhdGUgdGhlIGlucHV0IGluIE5ldHdvcmtQcm9jZXNzUHJveHku CisKKyAgICAgICAgKiBVSVByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc1Byb3h5LmNwcDoK KyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3NQcm94eTo6Y2FuQXV0aGVudGljYXRlQWdh aW5zdFByb3RlY3Rpb25TcGFjZSk6IFZhbGlkYXRlIGJvdGggdGhlIHBhZ2UgYW5kIGZyYW1lIGlk cyBiZWZvcmUKKyAgICAgICAgICBwYXNzaW5nIHRoZSBjYWxsIGFsb25nIHRvIHRoZSBXZWJQYWdl UHJveHkuIEFsc28sIGlmIGVpdGhlciBvZiB0aG9zZSB2YWxpZGF0aW9ucyBmYWlsLCByZXNwb25k IHRvIHRoZSBuZXR3b3JrIHByb2Nlc3MuCisKKzIwMTctMDctMjEgIEJyYWR5IEVpZHNvbiAgPGJl aWRzb25AYXBwbGUuY29tPgorCiAgICAgICAgIEdldCByaWQgb2YgV2ViQ29yZSBJY29uRGF0YWJh c2UgY29kZS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3NDcwMAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3JrL05l dHdvcmtQcm9jZXNzUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTmV0d29yay9O ZXR3b3JrUHJvY2Vzc1Byb3h5LmNwcAppbmRleCA4YzhmODMzYmZhNTJiMThkYWRlMmI3NDNiOTI0 MDg4NTllY2Y1ZmI0Li5lZmMyMmEwMDY2N2E4ZGZlYzk1ODg5YjMyMTBhZmQ2M2UwZmFkMTIxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNz UHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1By b2Nlc3NQcm94eS5jcHAKQEAgLTM2NywxMSArMzY3LDIwIEBAIHZvaWQgTmV0d29ya1Byb2Nlc3NQ cm94eTo6bG9nRGlhZ25vc3RpY01lc3NhZ2VXaXRoVmFsdWUodWludDY0X3QgcGFnZUlELCBjb25z dCBTCiAjaWYgVVNFKFBST1RFQ1RJT05fU1BBQ0VfQVVUSF9DQUxMQkFDSykKIHZvaWQgTmV0d29y a1Byb2Nlc3NQcm94eTo6Y2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZSh1aW50 NjRfdCBsb2FkZXJJRCwgdWludDY0X3QgcGFnZUlELCB1aW50NjRfdCBmcmFtZUlELCBjb25zdCBX ZWJDb3JlOjpQcm90ZWN0aW9uU3BhY2UmIHByb3RlY3Rpb25TcGFjZSkKIHsKLSAgICBXZWJQYWdl UHJveHkqIHBhZ2UgPSBXZWJQcm9jZXNzUHJveHk6OndlYlBhZ2UocGFnZUlEKTsKLSAgICBpZiAo IXBhZ2UpCi0gICAgICAgIHJldHVybjsKKyAgICAvLyBOZXR3b3JrUHJvY2VzcyBzdGF0ZSBjYW5u b3QgYXN5bmNocm9ub3VzbHkgYmUga2VwdCBpbiBzeW5jIHdpdGggdGhlc2Ugb2JqZWN0cworICAg IC8vIGxpa2Ugd2UgZXhwZWN0IFdlYlByb2Nlc3MgPC0+IFVJUHJvY2VzcyBzdGF0ZSB0byBiZSBr ZXB0IGluIHN5bmMuCisgICAgLy8gU28gdGhlcmUncyBubyBndWFyYW50ZWUgdGhlIG1lc3NhZ2Vk IFdlYlBhZ2VQcm94eSBvciBXZWJGcmFtZVByb3h5IGV4aXN0IGhlcmUgaW4gdGhlIFVJUHJvY2Vz cy4KKyAgICAvLyBXZSBuZWVkIHRvIHZhbGlkYXRlIGJvdGggdGhlIHBhZ2UgYW5kIHRoZSBmcmFt ZSB1cCBmcm9udC4KKyAgICBpZiAoYXV0byogcGFnZSA9IFdlYlByb2Nlc3NQcm94eTo6d2ViUGFn ZShwYWdlSUQpKSB7CisgICAgICAgIGlmIChhdXRvKiBmcmFtZSA9IHBhZ2UtPnByb2Nlc3MoKS53 ZWJGcmFtZShmcmFtZUlEKSkgeworICAgICAgICAgICAgcGFnZS0+Y2FuQXV0aGVudGljYXRlQWdh aW5zdFByb3RlY3Rpb25TcGFjZShsb2FkZXJJRCwgZnJhbWVJRCwgcHJvdGVjdGlvblNwYWNlKTsK KyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgIH0KICAgICAKLSAgICBwYWdlLT5j YW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKGxvYWRlcklELCBmcmFtZUlELCBw cm90ZWN0aW9uU3BhY2UpOworICAgIC8vIEluIHRoZSBjYXNlIHdoZXJlIHdlIHdpbGwgbm90IGJl IGFibGUgdG8gcmVwbHkgdG8gdGhpcyBtZXNzYWdlIHdpdGggYSBjbGllbnQgcmVwbHksCisgICAg Ly8gd2Ugc2hvdWxkIG1lc3NhZ2UgYmFjayBhIGRlZmF1bHQgdG8gdGhlIE5ldHdvcmtpbmcgcHJv Y2Vzcy4KKyAgICBzZW5kKE1lc3NhZ2VzOjpOZXR3b3JrUHJvY2Vzczo6Q29udGludWVDYW5BdXRo ZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKGxvYWRlcklELCBmYWxzZSksIDApOwogfQog I2VuZGlmCiAK 316132 2017-07-21 15:55:29 -0700 2017-07-21 17:15:03 -0700 Patch bug-174729-20170721155528.patch text/plain 3354 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcxZWRmYTE4NmRmYzNmMDk4 ODY3ZDE1OWUwMjk1MDgxNzQ4YjM0YjIuLjg2MTgwZjZkZGI0NWU3MDVkZjk4ZjE2OTgyODliZmJh YmE1OTE4MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjggQEAKIDIwMTctMDctMjEgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIENyYXNoIGluIG1hbnkgV2ViS2l0 IGFwcHMgbWFya2luZyBhIGNvbm5lY3Rpb24gaW52YWxpZCB1bmRlciBNZXNzYWdlczo6TmV0d29y a1Byb2Nlc3NQcm94eTo6Y2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZS4KKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI4ODIyMjcyPiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NDcyOQorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0 b24uCisKKyAgICAgICAgUHJldmlvdXNseSwgd2hlbiBhIE5ldHdvcmtMb2FkIGdlbmVyYXRlZCBh ICJDYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlIiBldmVudCwgdGhlIG1lc3Nh Z2Ugd2VudCBmcm9tCisgICAgICAgIE5ldHdvcmsgcHJvY2VzcyAtPiBXZWIgcHJvY2VzcyAtPiBV SSBwcm9jZXNzLgorCisgICAgICAgIEluIHRoYXQgY2FzZSwgTUVTU0FHRV9DSEVDS2luZyB0aGUg dmFsaWRpdHkgb2YgdGhlIGZyYW1lIGluIFdlYlBhZ2VQcm94eSBtYWRlIHNlbnNlLgorCisgICAg ICAgIEluIHIyMDI1MTEgd2UgY3V0IHRoZSBXZWJQcm9jZXNzIG91dCBvZiB0aGlzIGFuZCBoYWQg TmV0d29ya2luZyBnbyBzdHJhaWdodCB0byBVSSBwcm9jZXNzLgorCisgICAgICAgIEFzIGEgcmVz dWx0LCB0aGUgbWVzc2FnZSBjaGVjayBiZWNhbWUgaW52YWxpZC4gVGhlIE5ldHdvcmtpbmcgcHJv Y2VzcyBjYW5ub3QgcG9zc2libGUga25vdyB0aGUgdmFsaWRpdHkgb2YgCisgICAgICAgIHBhcnRp Y3VsYXIgV2ViUGFnZSBvciBXZWJGcmFtZSBpZGVudGlmaWVycy4KKworICAgICAgICBXZSBzaW1w bHkgbmVlZCB0byB2YWxpZGF0ZSB0aGUgaW5wdXQgaW4gTmV0d29ya1Byb2Nlc3NQcm94eS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuY3BwOgorICAg ICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzc1Byb3h5OjpjYW5BdXRoZW50aWNhdGVBZ2FpbnN0 UHJvdGVjdGlvblNwYWNlKTogVmFsaWRhdGUgYm90aCB0aGUgcGFnZSBhbmQgZnJhbWUgaWRzIGJl Zm9yZQorICAgICAgICAgIHBhc3NpbmcgdGhlIGNhbGwgYWxvbmcgdG8gdGhlIFdlYlBhZ2VQcm94 eS4gQWxzbywgaWYgZWl0aGVyIG9mIHRob3NlIHZhbGlkYXRpb25zIGZhaWwsIHJlc3BvbmQgdG8g dGhlIG5ldHdvcmsgcHJvY2Vzcy4KKworMjAxNy0wNy0yMSAgQnJhZHkgRWlkc29uICA8YmVpZHNv bkBhcHBsZS5jb20+CisKICAgICAgICAgR2V0IHJpZCBvZiBXZWJDb3JlIEljb25EYXRhYmFzZSBj b2RlLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0 NzAwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29y a1Byb2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdv cmtQcm9jZXNzUHJveHkuY3BwCmluZGV4IDhjOGY4MzNiZmE1MmIxOGRhZGUyYjc0M2I5MjQwODg1 OWVjZjVmYjQuLjQ2ZDRiMmJmNDY5ZDFhNWVlMDA3MTMwNGQ1ZDM5NzlkMmY1OWY0NzkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vz c1Byb3h5LmNwcApAQCAtMzY3LDExICszNjcsMjAgQEAgdm9pZCBOZXR3b3JrUHJvY2Vzc1Byb3h5 Ojpsb2dEaWFnbm9zdGljTWVzc2FnZVdpdGhWYWx1ZSh1aW50NjRfdCBwYWdlSUQsIGNvbnN0IFMK ICNpZiBVU0UoUFJPVEVDVElPTl9TUEFDRV9BVVRIX0NBTExCQUNLKQogdm9pZCBOZXR3b3JrUHJv Y2Vzc1Byb3h5OjpjYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKHVpbnQ2NF90 IGxvYWRlcklELCB1aW50NjRfdCBwYWdlSUQsIHVpbnQ2NF90IGZyYW1lSUQsIGNvbnN0IFdlYkNv cmU6OlByb3RlY3Rpb25TcGFjZSYgcHJvdGVjdGlvblNwYWNlKQogewotICAgIFdlYlBhZ2VQcm94 eSogcGFnZSA9IFdlYlByb2Nlc3NQcm94eTo6d2ViUGFnZShwYWdlSUQpOwotICAgIGlmICghcGFn ZSkKLSAgICAgICAgcmV0dXJuOworICAgIC8vIE5ldHdvcmtQcm9jZXNzIHN0YXRlIGNhbm5vdCBh c3luY2hyb25vdXNseSBiZSBrZXB0IGluIHN5bmMgd2l0aCB0aGVzZSBvYmplY3RzCisgICAgLy8g bGlrZSB3ZSBleHBlY3QgV2ViUHJvY2VzcyA8LT4gVUlQcm9jZXNzIHN0YXRlIHRvIGJlIGtlcHQg aW4gc3luYy4KKyAgICAvLyBTbyB0aGVyZSdzIG5vIGd1YXJhbnRlZSB0aGUgbWVzc2FnZWQgV2Vi UGFnZVByb3h5IG9yIFdlYkZyYW1lUHJveHkgZXhpc3QgaGVyZSBpbiB0aGUgVUlQcm9jZXNzLgor ICAgIC8vIFdlIG5lZWQgdG8gdmFsaWRhdGUgYm90aCB0aGUgcGFnZSBhbmQgdGhlIGZyYW1lIHVw IGZyb250LgorICAgIGlmIChhdXRvKiBwYWdlID0gV2ViUHJvY2Vzc1Byb3h5Ojp3ZWJQYWdlKHBh Z2VJRCkpIHsKKyAgICAgICAgaWYgKHBhZ2UtPnByb2Nlc3MoKS53ZWJGcmFtZShmcmFtZUlEKSkg eworICAgICAgICAgICAgcGFnZS0+Y2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFj ZShsb2FkZXJJRCwgZnJhbWVJRCwgcHJvdGVjdGlvblNwYWNlKTsKKyAgICAgICAgICAgIHJldHVy bjsKKyAgICAgICAgfQorICAgIH0KICAgICAKLSAgICBwYWdlLT5jYW5BdXRoZW50aWNhdGVBZ2Fp bnN0UHJvdGVjdGlvblNwYWNlKGxvYWRlcklELCBmcmFtZUlELCBwcm90ZWN0aW9uU3BhY2UpOwor ICAgIC8vIEluIHRoZSBjYXNlIHdoZXJlIHdlIHdpbGwgbm90IGJlIGFibGUgdG8gcmVwbHkgdG8g dGhpcyBtZXNzYWdlIHdpdGggYSBjbGllbnQgcmVwbHksCisgICAgLy8gd2Ugc2hvdWxkIG1lc3Nh Z2UgYmFjayBhIGRlZmF1bHQgdG8gdGhlIE5ldHdvcmtpbmcgcHJvY2Vzcy4KKyAgICBzZW5kKE1l c3NhZ2VzOjpOZXR3b3JrUHJvY2Vzczo6Q29udGludWVDYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJv dGVjdGlvblNwYWNlKGxvYWRlcklELCBmYWxzZSksIDApOwogfQogI2VuZGlmCiAK