174724 2017-07-21 14:13:45 -0700 Fail gracefully when xcrun fails in IOSSimulatorPort constructor 2017-07-21 15:20:42 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbedard jbedard aakash_jain buildbot commit-queue glenn jeremyj-wk lforschler oldest_to_newest 1331109 0 jbedard 2017-07-21 14:13:45 -0700 There is no reason to let an error encountered when trying to detect a running simulator prevent test expectation linting or style checking. We should ignore such an exception until setting up iOS simulators for testing. 1331115 1 316120 jbedard 2017-07-21 14:18:46 -0700 Created attachment 316120 Patch 1331117 2 jbedard 2017-07-21 14:20:06 -0700 <rdar://problem/33446618> tracks this internally. 1331124 3 316120 aakash_jain 2017-07-21 14:25:57 -0700 Comment on attachment 316120 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316120&action=review > Tools/Scripts/webkitpy/port/ios_simulator.py:82 > + IOSSimulatorPort._CURRENT_DEVICE = Device(Simulator(host).current_device()) what's the exception? If Simulator(host).current_device() is None, then it might be better to check for it being non None, instead of try except. 1331127 4 jbedard 2017-07-21 14:29:12 -0700 (In reply to Aakash Jain from comment #3) > Comment on attachment 316120 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316120&action=review > > > Tools/Scripts/webkitpy/port/ios_simulator.py:82 > > + IOSSimulatorPort._CURRENT_DEVICE = Device(Simulator(host).current_device()) > > what's the exception? > > If Simulator(host).current_device() is None, then it might be better to > check for it being non None, instead of try except. We had an engineer with a unique personal configuration hit this, 'xcrun simctl' commands would fail, so Simulator(host) would throw a webkitpy.common.system.executive.ScriptError. If he were running tests on the Simulator, I'd say we let the exception be thrown, but this code is triggered during style checking and test expectation linting. 1331128 5 316120 aakash_jain 2017-07-21 14:34:29 -0700 Comment on attachment 316120 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316120&action=review > Tools/Scripts/webkitpy/port/ios_simulator.py:83 > + except: ok. we should use "except ScriptError:" 1331132 6 316125 jbedard 2017-07-21 14:42:35 -0700 Created attachment 316125 Patch for landing 1331145 7 316125 commit-queue 2017-07-21 15:20:41 -0700 Comment on attachment 316125 Patch for landing Clearing flags on attachment: 316125 Committed r219747: <http://trac.webkit.org/changeset/219747> 1331146 8 commit-queue 2017-07-21 15:20:42 -0700 All reviewed patches have been landed. Closing bug. 316120 2017-07-21 14:18:46 -0700 2017-07-21 14:42:34 -0700 Patch bug-174724-20170721141845.patch text/plain 1745 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxOTc0MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTA3LTIxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGYWlsIGdyYWNlZnVsbHkgd2hlbiB4Y3J1biBmYWlscyBpbiBJT1NTaW11 bGF0b3JQb3J0IGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzQ3MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5Ogor ICAgICAgICAoSU9TU2ltdWxhdG9yUG9ydC5fX2luaXRfXyk6IElnbm9yZSBhbnkgZXJyb3JzIHdo ZW4gYXR0ZW1wdGluZyB0byBmaW5kIGEgcnVubmluZworICAgICAgICBzaW11bGF0b3IuIEVycm9y cyBoZXJlIHNob3VsZCBiZSB0cmVhdGVkIHRoZSBzYW1lIGFzIG5vIHNpbXVsYXRvcnMgZm91bmQu CisKIDIwMTctMDctMjEgIFlvdXN1a2UgS2ltb3RvICA8WW91c3VrZS5LaW1vdG9Ac29ueS5jb20+ CiAKICAgICAgICAgW0NNYWtlXSBBZGQgYW4gb3B0aW9uIHRvIHN0b3AgYnVpbGQgYWZ0ZXIgZ2Vu ZXJhdGluZyBwcm9qZWN0IGZpbGVzCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv aW9zX3NpbXVsYXRvci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvaW9zX3NpbXVsYXRvci5weQkocmV2aXNpb24gMjE5NjkwKQorKysgVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L2lvc19zaW11bGF0b3IucHkJKHdvcmtpbmcgY29weSkKQEAgLTc4LDcgKzc4 LDExIEBAIGNsYXNzIElPU1NpbXVsYXRvclBvcnQoSU9TUG9ydCk6CiAgICAgICAgIF9sb2cuZGVi dWcoJ0lPU1NpbXVsYXRvclBvcnQgX2RldmljZV9jbGFzcyBpcyAlcycsIHNlbGYuX2RldmljZV9j bGFzcykKIAogICAgICAgICBpZiBub3QgSU9TU2ltdWxhdG9yUG9ydC5fQ1VSUkVOVF9ERVZJQ0U6 Ci0gICAgICAgICAgICBJT1NTaW11bGF0b3JQb3J0Ll9DVVJSRU5UX0RFVklDRSA9IERldmljZShT aW11bGF0b3IoaG9zdCkuY3VycmVudF9kZXZpY2UoKSkKKyAgICAgICAgICAgIHRyeToKKyAgICAg ICAgICAgICAgICBJT1NTaW11bGF0b3JQb3J0Ll9DVVJSRU5UX0RFVklDRSA9IERldmljZShTaW11 bGF0b3IoaG9zdCkuY3VycmVudF9kZXZpY2UoKSkKKyAgICAgICAgICAgIGV4Y2VwdDoKKyAgICAg ICAgICAgICAgICAjIEZhaWx1cmUgdG8gZmluZCBhIGN1cnJlbnQgZGV2aWNlIHNob3VsZCBub3Qg cmVzdWx0IGluIGFuIGV4Y2VwdGlvbiBiZWluZyB0aHJvd24KKyAgICAgICAgICAgICAgICBJT1NT aW11bGF0b3JQb3J0Ll9DVVJSRU5UX0RFVklDRSA9IERldmljZShOb25lKQogICAgICAgICBzZWxm Ll9jdXJyZW50X2RldmljZSA9IElPU1NpbXVsYXRvclBvcnQuX0NVUlJFTlRfREVWSUNFCiAgICAg ICAgIGlmIG5vdCBzZWxmLl9jdXJyZW50X2RldmljZToKICAgICAgICAgICAgIHNlbGYuc2V0X29w dGlvbignZGVkaWNhdGVkX3NpbXVsYXRvcnMnLCBUcnVlKQo= 316125 2017-07-21 14:42:35 -0700 2017-07-21 15:20:41 -0700 Patch for landing bug-174724-20170721144235.patch text/plain 2059 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxOTc0NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTA3LTIxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGYWlsIGdyYWNlZnVsbHkgd2hlbiB4Y3J1biBmYWlscyBpbiBJT1NTaW11 bGF0b3JQb3J0IGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzQ3MjQKKworICAgICAgICBSZXZpZXdlZCBieSBBYWthc2ggSmFpbi4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5OgorICAg ICAgICAoSU9TU2ltdWxhdG9yUG9ydC5fX2luaXRfXyk6IElnbm9yZSBhbnkgZXJyb3JzIHdoZW4g YXR0ZW1wdGluZyB0byBmaW5kIGEgcnVubmluZworICAgICAgICBzaW11bGF0b3IuIEVycm9ycyBo ZXJlIHNob3VsZCBiZSB0cmVhdGVkIHRoZSBzYW1lIGFzIG5vIHNpbXVsYXRvcnMgZm91bmQuCisK IDIwMTctMDctMjEgIFlvdXN1a2UgS2ltb3RvICA8WW91c3VrZS5LaW1vdG9Ac29ueS5jb20+CiAK ICAgICAgICAgW0NNYWtlXSBBZGQgYW4gb3B0aW9uIHRvIHN0b3AgYnVpbGQgYWZ0ZXIgZ2VuZXJh dGluZyBwcm9qZWN0IGZpbGVzCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9z X3NpbXVsYXRvci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv aW9zX3NpbXVsYXRvci5weQkocmV2aXNpb24gMjE5NzQ1KQorKysgVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L2lvc19zaW11bGF0b3IucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDcg QEAgaW1wb3J0IHN1YnByb2Nlc3MKIGltcG9ydCB0aW1lCiAKIGZyb20gd2Via2l0cHkuY29tbW9u Lm1lbW9pemVkIGltcG9ydCBtZW1vaXplZAorZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmV4 ZWN1dGl2ZSBpbXBvcnQgU2NyaXB0RXJyb3IKIGZyb20gd2Via2l0cHkucG9ydC5kZXZpY2UgaW1w b3J0IERldmljZQogZnJvbSB3ZWJraXRweS5wb3J0LmlvcyBpbXBvcnQgSU9TUG9ydAogZnJvbSB3 ZWJraXRweS54Y29kZS5zaW11bGF0b3IgaW1wb3J0IFNpbXVsYXRvciwgUnVudGltZSwgRGV2aWNl VHlwZQpAQCAtNzgsNyArNzksMTEgQEAgY2xhc3MgSU9TU2ltdWxhdG9yUG9ydChJT1NQb3J0KToK ICAgICAgICAgX2xvZy5kZWJ1ZygnSU9TU2ltdWxhdG9yUG9ydCBfZGV2aWNlX2NsYXNzIGlzICVz Jywgc2VsZi5fZGV2aWNlX2NsYXNzKQogCiAgICAgICAgIGlmIG5vdCBJT1NTaW11bGF0b3JQb3J0 Ll9DVVJSRU5UX0RFVklDRToKLSAgICAgICAgICAgIElPU1NpbXVsYXRvclBvcnQuX0NVUlJFTlRf REVWSUNFID0gRGV2aWNlKFNpbXVsYXRvcihob3N0KS5jdXJyZW50X2RldmljZSgpKQorICAgICAg ICAgICAgdHJ5OgorICAgICAgICAgICAgICAgIElPU1NpbXVsYXRvclBvcnQuX0NVUlJFTlRfREVW SUNFID0gRGV2aWNlKFNpbXVsYXRvcihob3N0KS5jdXJyZW50X2RldmljZSgpKQorICAgICAgICAg ICAgZXhjZXB0IFNjcmlwdEVycm9yOgorICAgICAgICAgICAgICAgICMgRmFpbHVyZSB0byBmaW5k IGEgY3VycmVudCBkZXZpY2Ugc2hvdWxkIG5vdCByZXN1bHQgaW4gYW4gZXhjZXB0aW9uIGJlaW5n IHRocm93bgorICAgICAgICAgICAgICAgIElPU1NpbXVsYXRvclBvcnQuX0NVUlJFTlRfREVWSUNF ID0gRGV2aWNlKE5vbmUpCiAgICAgICAgIHNlbGYuX2N1cnJlbnRfZGV2aWNlID0gSU9TU2ltdWxh dG9yUG9ydC5fQ1VSUkVOVF9ERVZJQ0UKICAgICAgICAgaWYgbm90IHNlbGYuX2N1cnJlbnRfZGV2 aWNlOgogICAgICAgICAgICAgc2VsZi5zZXRfb3B0aW9uKCdkZWRpY2F0ZWRfc2ltdWxhdG9ycycs IFRydWUpCg==