174721 2017-07-21 12:14:20 -0700 WebResourceLoadStatisticsStore::m_operatingDates is unsafely modified from several threads 2017-07-21 13:40:18 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson bfulgham commit-queue ggaren rniwa webkit-bug-importer oldest_to_newest 1331050 0 cdumez 2017-07-21 12:14:20 -0700 WebResourceLoadStatisticsStore::m_operatingDates is unsafely modified from several threads. 1331051 1 cdumez 2017-07-21 12:14:46 -0700 <rdar://problem/33400343> 1331054 2 316108 cdumez 2017-07-21 12:18:46 -0700 Created attachment 316108 Patch 1331089 3 316108 bfulgham 2017-07-21 13:32:17 -0700 Comment on attachment 316108 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316108&action=review > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:286 > + }); I didn’t look closely enough at what that routine did! Thank you for fixing this. 1331093 4 316108 commit-queue 2017-07-21 13:40:17 -0700 Comment on attachment 316108 Patch Clearing flags on attachment: 316108 Committed r219739: <http://trac.webkit.org/changeset/219739> 1331094 5 commit-queue 2017-07-21 13:40:18 -0700 All reviewed patches have been landed. Closing bug. 316108 2017-07-21 12:18:46 -0700 2017-07-21 13:40:17 -0700 Patch bug-174721-20170721121845.patch text/plain 2484 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcxZWRmYTE4NmRmYzNmMDk4 ODY3ZDE1OWUwMjk1MDgxNzQ4YjM0YjIuLmU2ODRmMDE0NzgxZjdmODFkOTJmNmVmNjllYWExYmIy OGQxZmQ2NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTctMDctMjEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBXZWJSZXNvdXJjZUxvYWRTdGF0aXN0 aWNzU3RvcmU6Om1fb3BlcmF0aW5nRGF0ZXMgaXMgdW5zYWZlbHkgbW9kaWZpZWQgZnJvbSBzZXZl cmFsIHRocmVhZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3NDcyMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzM0MDAzNDM+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViUmVzb3VyY2VMb2FkU3Rh dGlzdGljc1N0b3JlOjptX29wZXJhdGluZ0RhdGVzIGlzIHN1cHBvc2VkIHRvIG9ubHkgYmUgbW9k aWZpZWQgb24KKyAgICAgICAgdGhlIGJhY2tncm91bmQgdGhyZWFkLiBIb3dldmVyLCBXZWJSZXNv dXJjZUxvYWRTdGF0aXN0aWNzU3RvcmU6OnBlcmZvcm1EYWlseVRhc2tzKCkKKyAgICAgICAgd2Fz IG1pc3Rha2VubHkgY2FsbGluZyBpbmNsdWRlVG9kYXlBc09wZXJhdGluZ0RhdGVJZk5lY2Vzc2Fy eSgpIG9uIHRoZSBtYWluIHRocmVhZCwKKyAgICAgICAgd2hpY2ggd291bGQgbW9kaWZ5IG1fb3Bl cmF0aW5nRGF0ZXMuIFRoaXMgY291bGQgbGVhZCB0byBjcmFzaGVzIHN1Y2ggYXMgdGhlCisgICAg ICAgIG9uZSBpbiA8cmRhcjovL3Byb2JsZW0vMzM0MDAzNDM+LCBhcyB0aGUgbWFpbiB0aHJlYWQg bWF5IG1vZGlmeSBtX29wZXJhdGluZ0RhdGVzCisgICAgICAgIHdoaWxlIHdlIGFyZSBpbnRlcmF0 aW5nIG92ZXIgaXQgb24gdGhlIGJhY2tncm91bmQgdGhyZWFkIHRvIHNhdmUgaXQgdG8gZGlzay4K KworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmU6OnBlcmZv cm1EYWlseVRhc2tzKToKKyAgICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkU3RhdGlzdGlj c1N0b3JlOjppbmNsdWRlVG9kYXlBc09wZXJhdGluZ0RhdGVJZk5lY2Vzc2FyeSk6CisKIDIwMTct MDctMjEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEdldCBy aWQgb2YgV2ViQ29yZSBJY29uRGF0YWJhc2UgY29kZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY3BwCmluZGV4 IDRlMjg4MWFiM2VmZjAzYjM4Y2ZmMWIxN2NhNDliYzFhMmI1OGQ4YzAuLjdlNjE5MTMyNWI0NjZm OTFkZDg4MzYxMmJjYjMwN2M3ZjYwMzE3ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmNwcApAQCAtMjgx LDcgKzI4MSw5IEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpwZXJmb3Jt RGFpbHlUYXNrcygpCiB7CiAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKIAotICAgIGlu Y2x1ZGVUb2RheUFzT3BlcmF0aW5nRGF0ZUlmTmVjZXNzYXJ5KCk7CisgICAgbV9zdGF0aXN0aWNz UXVldWUtPmRpc3BhdGNoKFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyldIHsK KyAgICAgICAgaW5jbHVkZVRvZGF5QXNPcGVyYXRpbmdEYXRlSWZOZWNlc3NhcnkoKTsKKyAgICB9 KTsKICAgICBpZiAobV9wYXJhbWV0ZXJzLnNob3VsZFN1Ym1pdFRlbGVtZXRyeSkKICAgICAgICAg c3VibWl0VGVsZW1ldHJ5KCk7CiB9CkBAIC03MzIsNiArNzM0LDggQEAgVmVjdG9yPFN0cmluZz4g V2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjp0b3BQcml2YXRlbHlDb250cm9sbGVkRG9t YWluc1RvUmUKIAogdm9pZCBXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmU6OmluY2x1ZGVU b2RheUFzT3BlcmF0aW5nRGF0ZUlmTmVjZXNzYXJ5KCkKIHsKKyAgICBBU1NFUlQoIVJ1bkxvb3A6 OmlzTWFpbigpKTsKKwogICAgIGF1dG8gdG9kYXkgPSBPcGVyYXRpbmdEYXRlOjp0b2RheSgpOwog ICAgIGlmICghbV9vcGVyYXRpbmdEYXRlcy5pc0VtcHR5KCkgJiYgdG9kYXkgPD0gbV9vcGVyYXRp bmdEYXRlcy5sYXN0KCkpCiAgICAgICAgIHJldHVybjsK