174706 2017-07-20 22:02:57 -0700 Noise when AudioChannel lengths don't match. 2017-07-21 12:48:53 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue eric.carlson jer.noble webkit-bug-importer oldest_to_newest 1330917 0 jeremyj-wk 2017-07-20 22:02:57 -0700 Noise when AudioChannel lengths don't match. 1330918 1 jeremyj-wk 2017-07-20 22:03:25 -0700 <rdar://problem/33389856> WebRTC 17A320/B188: Blaring static through AirPods when allowing camera/mic on webrtc session 1330919 2 316068 jeremyj-wk 2017-07-20 22:27:02 -0700 Created attachment 316068 Patch 1330956 3 316068 eric.carlson 2017-07-21 06:41:08 -0700 Comment on attachment 316068 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316068&action=review > Source/WebCore/ChangeLog:9 > + When AudioChannel lengths don't match, it don't do the copy. This leaves uninitialized data in the audio buffer. Nit: "it don't do the copy. This leaves uninitialized data in the audio buffer." => "returning early leaves uninitialized data in the audio buffer." 1331060 4 jeremyj-wk 2017-07-21 12:31:12 -0700 (In reply to Eric Carlson from comment #3) > Comment on attachment 316068 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316068&action=review > > > Source/WebCore/ChangeLog:9 > > + When AudioChannel lengths don't match, it don't do the copy. This leaves uninitialized data in the audio buffer. > > Nit: "it don't do the copy. This leaves uninitialized data in the audio > buffer." => "returning early leaves uninitialized data in the audio buffer." "When AudioChannel lengths don't match it returns early leaving uninitialized data in the audio buffer." 1331061 5 316111 jeremyj-wk 2017-07-21 12:33:05 -0700 Created attachment 316111 Patch 1331062 6 316112 jeremyj-wk 2017-07-21 12:34:24 -0700 Created attachment 316112 Patch for landing. 1331063 7 jeremyj-wk 2017-07-21 12:35:23 -0700 Eric, I accidentally wiped out your r+. 1331073 8 316112 commit-queue 2017-07-21 12:48:52 -0700 Comment on attachment 316112 Patch for landing. Clearing flags on attachment: 316112 Committed r219736: <http://trac.webkit.org/changeset/219736> 1331074 9 commit-queue 2017-07-21 12:48:53 -0700 All reviewed patches have been landed. Closing bug. 316068 2017-07-20 22:27:02 -0700 2017-07-21 12:33:28 -0700 Patch bug-174706-20170720222701.patch text/plain 1557 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjg1YWFmNmM4NDQwMjcw MDljN2JlNmQ3NzYxYTRiNTY1Y2Q1Mjg2ZS4uZTAzNjIxMmZkNDgwNGFlMDg3YzZkMDIwNDM0MmE0 MDllMjJkNzc1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA3LTIwICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBOb2lzZSB3aGVuIEF1ZGlv Q2hhbm5lbCBsZW5ndGhzIGRvbid0IG1hdGNoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0NzA2CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzMzMzg5 ODU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hl biBBdWRpb0NoYW5uZWwgbGVuZ3RocyBkb24ndCBtYXRjaCwgaXQgZG9uJ3QgZG8gdGhlIGNvcHku IFRoaXMgbGVhdmVzIHVuaW5pdGlhbGl6ZWQgZGF0YSBpbiB0aGUgYXVkaW8gYnVmZmVyLgorICAg ICAgICBUaGlzIGNoYW5nZSB6ZXJvcyBvdXQgdGhlIGRhdGEsIHNvIHRoZXJlIGlzbid0IG9iamVj dGlvbmFibGUgbm9pc2Ugc2VudCB0byB0aGUgc3BlYWtlci4KKworICAgICAgICAqIHBsYXRmb3Jt L2F1ZGlvL0F1ZGlvQ2hhbm5lbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0NoYW5uZWw6 OmNvcHlGcm9tKToKKwogMjAxNy0wNy0yMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIERyb3AgbGVnYWN5IFhQYXRoRXhjZXB0aW9uIHR5cGUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0F1ZGlvQ2hhbm5lbC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9BdWRpb0NoYW5uZWwuY3BwCmluZGV4IDY1NzY1ZGZmMmI2 MjAyNzJjMzEwNWVlMTYxNDVkYzJhOThjOWRlNWYuLjkwOTVjZjQ3Mzg3MmUwMjBhOWY2ZTdjZWUz NWYzYTAyOTQ4YTZiOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv L0F1ZGlvQ2hhbm5lbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVk aW9DaGFubmVsLmNwcApAQCAtNTksMTAgKzU5LDggQEAgdm9pZCBBdWRpb0NoYW5uZWw6OmNvcHlG cm9tKGNvbnN0IEF1ZGlvQ2hhbm5lbCogc291cmNlQ2hhbm5lbCkKIHsKICAgICBib29sIGlzU2Fm ZSA9IChzb3VyY2VDaGFubmVsICYmIHNvdXJjZUNoYW5uZWwtPmxlbmd0aCgpID49IGxlbmd0aCgp KTsKICAgICBBU1NFUlQoaXNTYWZlKTsKLSAgICBpZiAoIWlzU2FmZSkKLSAgICAgICAgcmV0dXJu OwogCi0gICAgaWYgKHNvdXJjZUNoYW5uZWwtPmlzU2lsZW50KCkpIHsKKyAgICBpZiAoIWlzU2Fm ZSB8fCBzb3VyY2VDaGFubmVsLT5pc1NpbGVudCgpKSB7CiAgICAgICAgIHplcm8oKTsKICAgICAg ICAgcmV0dXJuOwogICAgIH0K 316111 2017-07-21 12:33:05 -0700 2017-07-21 12:34:09 -0700 Patch bug-174706-20170721123304.patch text/plain 1556 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjg1YWFmNmM4NDQwMjcw MDljN2JlNmQ3NzYxYTRiNTY1Y2Q1Mjg2ZS4uN2E1YjcxOTk0OGM4OGM3NWE3ZmQ2MjJjMDliOTky NGFkM2M0MDhhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA3LTIwICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBOb2lzZSB3aGVuIEF1ZGlv Q2hhbm5lbCBsZW5ndGhzIGRvbid0IG1hdGNoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0NzA2CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzMzMzg5 ODU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hl biBBdWRpb0NoYW5uZWwgbGVuZ3RocyBkb24ndCBtYXRjaCwgY29weUZyb20oKSByZXR1cm5zIGVh cmx5IGxlYXZpbmcgdW5pbml0aWFsaXplZCBkYXRhIGluIHRoZSBhdWRpbyBidWZmZXIuCisgICAg ICAgIFRoaXMgY2hhbmdlIHplcm9zIG91dCB0aGUgZGF0YSwgc28gdGhlcmUgaXNuJ3Qgb2JqZWN0 aW9uYWJsZSBub2lzZSBzZW50IHRvIHRoZSBzcGVha2VyLgorCisgICAgICAgICogcGxhdGZvcm0v YXVkaW8vQXVkaW9DaGFubmVsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQ2hhbm5lbDo6 Y29weUZyb20pOgorCiAyMDE3LTA3LTIwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgRHJvcCBsZWdhY3kgWFBhdGhFeGNlcHRpb24gdHlwZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9DaGFubmVsLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0F1ZGlvQ2hhbm5lbC5jcHAKaW5kZXggNjU3NjVkZmYyYjYy MDI3MmMzMTA1ZWUxNjE0NWRjMmE5OGM5ZGU1Zi4uOTA5NWNmNDczODcyZTAyMGE5ZjZlN2NlZTM1 ZjNhMDI5NDhhNmI5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v QXVkaW9DaGFubmVsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9BdWRp b0NoYW5uZWwuY3BwCkBAIC01OSwxMCArNTksOCBAQCB2b2lkIEF1ZGlvQ2hhbm5lbDo6Y29weUZy b20oY29uc3QgQXVkaW9DaGFubmVsKiBzb3VyY2VDaGFubmVsKQogewogICAgIGJvb2wgaXNTYWZl ID0gKHNvdXJjZUNoYW5uZWwgJiYgc291cmNlQ2hhbm5lbC0+bGVuZ3RoKCkgPj0gbGVuZ3RoKCkp OwogICAgIEFTU0VSVChpc1NhZmUpOwotICAgIGlmICghaXNTYWZlKQotICAgICAgICByZXR1cm47 CiAKLSAgICBpZiAoc291cmNlQ2hhbm5lbC0+aXNTaWxlbnQoKSkgeworICAgIGlmICghaXNTYWZl IHx8IHNvdXJjZUNoYW5uZWwtPmlzU2lsZW50KCkpIHsKICAgICAgICAgemVybygpOwogICAgICAg ICByZXR1cm47CiAgICAgfQo= 316112 2017-07-21 12:34:24 -0700 2017-07-21 12:48:52 -0700 Patch for landing. bug-174706-20170721123423.patch text/plain 1554 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjg1YWFmNmM4NDQwMjcw MDljN2JlNmQ3NzYxYTRiNTY1Y2Q1Mjg2ZS4uZWQ1NzNkZDgzNzNlYTM3ODQ5MjExODlmNTJjYTVj NDhiNjY1M2U1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA3LTIwICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBOb2lzZSB3aGVuIEF1ZGlv Q2hhbm5lbCBsZW5ndGhzIGRvbid0IG1hdGNoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0NzA2CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzMzMzg5 ODU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgorCisgICAgICAgIFdoZW4g QXVkaW9DaGFubmVsIGxlbmd0aHMgZG9uJ3QgbWF0Y2gsIGNvcHlGcm9tKCkgcmV0dXJucyBlYXJs eSBsZWF2aW5nIHVuaW5pdGlhbGl6ZWQgZGF0YSBpbiB0aGUgYXVkaW8gYnVmZmVyLgorICAgICAg ICBUaGlzIGNoYW5nZSB6ZXJvcyBvdXQgdGhlIGRhdGEsIHNvIHRoZXJlIGlzbid0IG9iamVjdGlv bmFibGUgbm9pc2Ugc2VudCB0byB0aGUgc3BlYWtlci4KKworICAgICAgICAqIHBsYXRmb3JtL2F1 ZGlvL0F1ZGlvQ2hhbm5lbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0NoYW5uZWw6OmNv cHlGcm9tKToKKwogMjAxNy0wNy0yMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIERyb3AgbGVnYWN5IFhQYXRoRXhjZXB0aW9uIHR5cGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0F1ZGlvQ2hhbm5lbC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9hdWRpby9BdWRpb0NoYW5uZWwuY3BwCmluZGV4IDY1NzY1ZGZmMmI2MjAy NzJjMzEwNWVlMTYxNDVkYzJhOThjOWRlNWYuLjkwOTVjZjQ3Mzg3MmUwMjBhOWY2ZTdjZWUzNWYz YTAyOTQ4YTZiOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0F1 ZGlvQ2hhbm5lbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9D aGFubmVsLmNwcApAQCAtNTksMTAgKzU5LDggQEAgdm9pZCBBdWRpb0NoYW5uZWw6OmNvcHlGcm9t KGNvbnN0IEF1ZGlvQ2hhbm5lbCogc291cmNlQ2hhbm5lbCkKIHsKICAgICBib29sIGlzU2FmZSA9 IChzb3VyY2VDaGFubmVsICYmIHNvdXJjZUNoYW5uZWwtPmxlbmd0aCgpID49IGxlbmd0aCgpKTsK ICAgICBBU1NFUlQoaXNTYWZlKTsKLSAgICBpZiAoIWlzU2FmZSkKLSAgICAgICAgcmV0dXJuOwog Ci0gICAgaWYgKHNvdXJjZUNoYW5uZWwtPmlzU2lsZW50KCkpIHsKKyAgICBpZiAoIWlzU2FmZSB8 fCBzb3VyY2VDaGFubmVsLT5pc1NpbGVudCgpKSB7CiAgICAgICAgIHplcm8oKTsKICAgICAgICAg cmV0dXJuOwogICAgIH0K