174655 2017-07-19 10:54:44 -0700 AX: Web page reloaded when a node is labelling multiple childnodes 2017-07-19 12:18:46 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 n_wang webkit-unassigned aboxhall apinheiro buildbot cfleizach commit-queue dmazzoni jcraig jdiggs n_wang samuel_white webkit-bug-importer oldest_to_newest 1330404 0 n_wang 2017-07-19 10:54:44 -0700 stuck in a loop 298 com.apple.WebCore 0x00007fffb3446745 WebCore::accessibleNameForNode(WebCore::Node*, WebCore::Node*) + 549 299 com.apple.WebCore 0x00007fffb3448b01 WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements(WTF::Vector<WebCore::Element*, 0ul, WTF::CrashOnOverflow, 16ul>&) const + 129 300 com.apple.WebCore 0x00007fffb3448ca3 WebCore::AccessibilityNodeObject::ariaLabeledByAttribute() const + 83 301 com.apple.WebCore 0x00007fffb3446248 WebCore::AccessibilityNodeObject::ariaLabeledByText(WTF::Vector<WebCore::AccessibilityText, 0ul, WTF::CrashOnOverflow, 16ul>&) const + 40 302 com.apple.WebCore 0x00007fffb3445575 WebCore::AccessibilityNodeObject::alternativeText(WTF::Vector<WebCore::AccessibilityText, 0ul, WTF::CrashOnOverflow, 16ul>&) const + 277 303 com.apple.WebCore 0x00007fffb3447ae3 WebCore::AccessibilityNodeObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 483 304 com.apple.WebCore 0x00007fffb3459b12 WebCore::AccessibilityRenderObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 770 305 com.apple.WebCore 0x00007fffb3447b2d WebCore::AccessibilityNodeObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 557 306 com.apple.WebCore 0x00007fffb3459b12 WebCore::AccessibilityRenderObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 770 307 com.apple.WebCore 0x00007fffb3447b2d WebCore::AccessibilityNodeObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 557 308 com.apple.WebCore 0x00007fffb3459b12 WebCore::AccessibilityRenderObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 770 309 com.apple.WebCore 0x00007fffb3446745 WebCore::accessibleNameForNode(WebCore::Node*, WebCore::Node*) + 549 <rdar://problem/32853980> 1330419 1 315939 n_wang 2017-07-19 11:04:57 -0700 Created attachment 315939 patch 1330434 2 315939 cfleizach 2017-07-19 11:27:38 -0700 Comment on attachment 315939 patch View in context: https://bugs.webkit.org/attachment.cgi?id=315939&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1738 > + downcast<AccessibilityNodeObject>(*child).ariaLabeledByElements(labeledByElements); is it necessary to do this downcast? isn't ariaLabeledByElements on AXObject? 1330435 3 315939 n_wang 2017-07-19 11:32:27 -0700 Comment on attachment 315939 patch View in context: https://bugs.webkit.org/attachment.cgi?id=315939&action=review >> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1738 >> + downcast<AccessibilityNodeObject>(*child).ariaLabeledByElements(labeledByElements); > > is it necessary to do this downcast? isn't ariaLabeledByElements on AXObject? NO, it's only on AXNodeObject 1330472 4 315939 commit-queue 2017-07-19 12:18:44 -0700 Comment on attachment 315939 patch Clearing flags on attachment: 315939 Committed r219661: <http://trac.webkit.org/changeset/219661> 1330473 5 commit-queue 2017-07-19 12:18:46 -0700 All reviewed patches have been landed. Closing bug. 315939 2017-07-19 11:04:57 -0700 2017-07-19 12:18:44 -0700 patch patch.txt text/plain 4665 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxOTY1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA3LTE5ICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFdlYiBwYWdlIHJlbG9hZGVkIHdo ZW4gYSBub2RlIGlzIGxhYmVsbGluZyBtdWx0aXBsZSBjaGlsZG5vZGVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ2NTUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlIGFyZSBhc2tpbmcgZm9y IHRoZSBhcmlhLWxhYmVsbGVkYnkgYXR0cmlidXRlIG9mIGEgbm9kZSBhbmQgaXRzCisgICAgICAg IHNpYmxpbmcgaXMgYWxzbyBsYWJlbGxlZCBieSB0aGUgc2FtZSBub2RlLCB3ZSBnZXQgaW50byBh biBpbmZpbml0ZSBsb29wCisgICAgICAgIGluIHRleHRVbmRlckVsZW1lbnQgc2luY2Ugd2Ugb25s eSBpZ25vcmUgb25lIGNoaWxkLiBBZGRlZCBjaGVja3MgZm9yIAorICAgICAgICBzaWJsaW5ncyB0 byBhdm9pZCBzdWNoIGxvb3AuCisKKyAgICAgICAgVGVzdDogYWNjZXNzaWJpbGl0eS9tYWMvYXJp YS1sYWJlbGxlZGJ5LW11bHRpcGxlLWNoaWxkLWNyYXNoLmh0bWwKKworICAgICAgICAqIGFjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QWNjZXNzaWJpbGl0eU5vZGVPYmplY3Q6OnRleHRVbmRlckVsZW1lbnQpOgorCiAyMDE3LTA3LTE4 ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtFTUVdIEJ1aWxkIGZhaWx1cmUgd2l0aCBDbGFuZy0zLjggb24gSW5pdERhdGFSZWdpc3Ry eS5jcHAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5v ZGVPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwCShyZXZpc2lvbiAyMTk0OTcpCisrKyBTb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTczMSw2ICsxNzMxLDE0IEBAIFN0cmluZyBBY2Nlc3NpYmlsaXR5Tm9kZU9i amVjdDo6dGV4dFVuZGUKICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIGlmIChpczxB Y2Nlc3NpYmlsaXR5Tm9kZU9iamVjdD4oKmNoaWxkKSkgeworICAgICAgICAgICAgLy8gV2Ugc2hv dWxkIGlnbm9yZSB0aGUgY2hpbGQgaWYgaXQncyBsYWJlbGVkIGJ5IHRoaXMgbm9kZS4KKyAgICAg ICAgICAgIC8vIFRoaXMgY291bGQgaGFwcGVuIHdoZW4gdGhpcyBub2RlIGxhYmVscyBtdWx0aXBs ZSBjaGlsZCBub2RlcyBhbmQgd2UgZGlkbid0CisgICAgICAgICAgICAvLyBza2lwIGluIHRoZSBh Ym92ZSBpZ25vcmVkQ2hpbGROb2RlIGNoZWNrLgorICAgICAgICAgICAgVmVjdG9yPEVsZW1lbnQq PiBsYWJlbGVkQnlFbGVtZW50czsKKyAgICAgICAgICAgIGRvd25jYXN0PEFjY2Vzc2liaWxpdHlO b2RlT2JqZWN0PigqY2hpbGQpLmFyaWFMYWJlbGVkQnlFbGVtZW50cyhsYWJlbGVkQnlFbGVtZW50 cyk7CisgICAgICAgICAgICBpZiAobGFiZWxlZEJ5RWxlbWVudHMuY29udGFpbnMobm9kZSkpCisg ICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICAKICAgICAgICAgICAgIFZlY3Rv cjxBY2Nlc3NpYmlsaXR5VGV4dD4gdGV4dE9yZGVyOwogICAgICAgICAgICAgZG93bmNhc3Q8QWNj ZXNzaWJpbGl0eU5vZGVPYmplY3Q+KCpjaGlsZCkuYWx0ZXJuYXRpdmVUZXh0KHRleHRPcmRlcik7 CiAgICAgICAgICAgICBpZiAodGV4dE9yZGVyLnNpemUoKSA+IDAgJiYgdGV4dE9yZGVyWzBdLnRl eHQubGVuZ3RoKCkpIHsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxOTQ5NykKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA3LTE5ICBO YW4gV2FuZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFdlYiBwYWdlIHJlbG9h ZGVkIHdoZW4gYSBub2RlIGlzIGxhYmVsbGluZyBtdWx0aXBsZSBjaGlsZG5vZGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ2NTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkv bWFjL2FyaWEtbGFiZWxsZWRieS1tdWx0aXBsZS1jaGlsZC1jcmFzaC1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL2FyaWEtbGFiZWxsZWRieS1tdWx0aXBs ZS1jaGlsZC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxNy0wNy0xMyAgTWF0dCBMZXdpcyAgPGps ZXdpczNAYXBwbGUuY29tPgogCiAgICAgICAgIFNraXBwZWQgbXVsdGlwbGUgaHR0cC90ZXN0cy93 ZWJydGMvIHRlc3Qgb24gaU9TIHNpbXVsYXRvci4KSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2li aWxpdHkvbWFjL2FyaWEtbGFiZWxsZWRieS1tdWx0aXBsZS1jaGlsZC1jcmFzaC1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvYXJpYS1sYWJl bGxlZGJ5LW11bHRpcGxlLWNoaWxkLWNyYXNoLWV4cGVjdGVkLnR4dAkobm9uZXhpc3RlbnQpCisr KyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy9hcmlhLWxhYmVsbGVkYnktbXVsdGlwbGUt Y2hpbGQtY3Jhc2gtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTQgQEAK K0hlYWRlcgorSGVhZGVyMgorRGVzY3JpcHRpb24gdGV4dAorCitUaGlzIHRlc3RzIHRoYXQgd2hl biBhIG5vZGUgaXMgbGFiZWxsaW5nIG11bHRpcGxlIGNoaWxkIG5vZGVzIGl0IHdvbid0IGNhdXNl IGNyYXNoLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1l c3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworQVhEZXNjcmlwdGlvbjog RGVzY3JpcHRpb24gdGV4dAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNU IENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2FyaWEtbGFi ZWxsZWRieS1tdWx0aXBsZS1jaGlsZC1jcmFzaC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2FjY2Vzc2liaWxpdHkvbWFjL2FyaWEtbGFiZWxsZWRieS1tdWx0aXBsZS1jaGlsZC1jcmFz aC5odG1sCShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2Fy aWEtbGFiZWxsZWRieS1tdWx0aXBsZS1jaGlsZC1jcmFzaC5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0wLDAgKzEsMzMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwv L0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPGRpdiBp ZD0iaGQiPgorPGRpdiByb2xlPSJoZWFkaW5nIiBpZD0iaGVhZGluZyIgYXJpYS1sZXZlbD0iNyIg YXJpYS1sYWJlbGxlZGJ5PSJoZCI+SGVhZGVyPC9kaXY+Cis8ZGl2IHJvbGU9ImhlYWRpbmciIGlk PSJoZWFkaW5nMiIgYXJpYS1sZXZlbD0iNyIgYXJpYS1sYWJlbGxlZGJ5PSJoZCI+SGVhZGVyMjwv ZGl2PgorCis8cD5EZXNjcmlwdGlvbiB0ZXh0PC9wPgorPC9kaXY+CisKKzxwIGlkPSJkZXNjcmlw dGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBk ZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0IHdoZW4gYSBub2RlIGlzIGxhYmVsbGluZyBtdWx0 aXBsZSBjaGlsZCBub2RlcyBpdCB3b24ndCBjYXVzZSBjcmFzaC4iKTsKKworICAgIGlmICh3aW5k b3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICAKKyAgICAgICAgdmFyIGhlYWRpbmcg PSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoImhlYWRpbmci KTsKKyAgICAgICAgLy8gRG8gbm90IGNyYXNoCisgICAgICAgIGRlYnVnKGhlYWRpbmcuZGVzY3Jp cHRpb24pOworICAgIH0KKworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJj ZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K