174651 2017-07-19 07:36:19 -0700 Minor Node->Element type tightening fixes 2017-07-20 07:37:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling buildbot commit-queue kling sam oldest_to_newest 1330359 0 kling 2017-07-19 07:36:19 -0700 Accumulated some minor Node* -> Element*/Element& changes while passing through focus code. 1330360 1 315919 kling 2017-07-19 07:39:39 -0700 Created attachment 315919 Patch 1330361 2 buildbot 2017-07-19 07:41:39 -0700 Attachment 315919 did not pass style-queue: ERROR: Source/WebCore/editing/Editor.h:404: The parameter name "selection" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1330555 3 315919 sam 2017-07-19 22:16:33 -0700 Comment on attachment 315919 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315919&action=review > Source/WebCore/dom/Document.cpp:386 > + Frame* frame = element.document().frame(); You could use auto* here. > Source/WebCore/editing/Editor.cpp:466 > + Element* target = findEventTargetFromSelection(); You could use auto* here. > Source/WebCore/editing/Editor.cpp:474 > + Element* target = findEventTargetFromSelection(); You could use auto* here. > Source/WebCore/editing/Editor.cpp:782 > + Element* target = findEventTargetFromSelection(); You could use auto* here. > Source/WebCore/editing/Editor.cpp:809 > + Element* target = selection.start().element(); You could use auto* here. 1330620 4 315919 commit-queue 2017-07-20 07:37:18 -0700 Comment on attachment 315919 Patch Clearing flags on attachment: 315919 Committed r219685: <http://trac.webkit.org/changeset/219685> 1330621 5 commit-queue 2017-07-20 07:37:19 -0700 All reviewed patches have been landed. Closing bug. 315919 2017-07-19 07:39:39 -0700 2017-07-20 07:37:18 -0700 Patch bug-174651.diff text/plain 6405 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZTc0YzIzZDA2Ny4uMTMxZDQxY2QzMzMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNy0wNy0xOSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgTWlub3IgTm9kZS0+RWxlbWVudCB0eXBlIHRpZ2h0ZW5pbmcgZml4ZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDY1MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRpZ2h0ZW4gdXAg c29tZSBOb2RlKiBpbnRvIEVsZW1lbnQqIG9yIGV2ZW4gYmV0dGVyLCBFbGVtZW50Ji4KKworICAg ICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjphY2NlcHRzRWRpdGlu Z0ZvY3VzKTogVGFrZSBhIGNvbnN0IEVsZW1lbnQmLgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l bnQ6OnNldEZvY3VzZWRFbGVtZW50KToKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpFZGl0b3I6OmZpbmRFdmVudFRhcmdldEZyb20pOiBSZXR1cm4gYW4g RWxlbWVudCouCisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6OmZpbmRFdmVudFRhcmdldEZyb21T ZWxlY3Rpb24pOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6cGFzdGVBc1BsYWlu VGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6OnBhc3RlQXNGcmFnbWVudCk6CisgICAg ICAgIChXZWJDb3JlOjpFZGl0b3I6OmRpc3BhdGNoQ1BQRXZlbnQpOgorICAgICAgICAqIGVkaXRp bmcvRWRpdG9yLmg6CisgICAgICAgICogcGFnZS9EcmFnQ29udHJvbGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6ZGlzcGF0Y2hUZXh0SW5wdXRFdmVudEZvcik6CisK IDIwMTctMDctMTcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IG92ZXJsYXkgcGFnZSBoaWdobGlnaHQgZG9lc24ndCBkaXNhcHBlYXIg d2hlbiBhIHBhZ2UgaXMgY29uc3RhbnRseSB1cGRhdGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAK aW5kZXggODIyZjIxYWM5NzcuLjFmMzM4ZmNlMGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAK QEAgLTM3OCwxMyArMzc4LDEyIEBAIHN0YXRpYyBXaWRnZXQqIHdpZGdldEZvckVsZW1lbnQoRWxl bWVudCogZm9jdXNlZEVsZW1lbnQpCiAgICAgcmV0dXJuIGRvd25jYXN0PFJlbmRlcldpZGdldD4o KnJlbmRlcmVyKS53aWRnZXQoKTsKIH0KIAotc3RhdGljIGJvb2wgYWNjZXB0c0VkaXRpbmdGb2N1 cyhOb2RlKiBub2RlKQorc3RhdGljIGJvb2wgYWNjZXB0c0VkaXRpbmdGb2N1cyhjb25zdCBFbGVt ZW50JiBlbGVtZW50KQogewotICAgIEFTU0VSVChub2RlKTsKLSAgICBBU1NFUlQobm9kZS0+aGFz RWRpdGFibGVTdHlsZSgpKTsKKyAgICBBU1NFUlQoZWxlbWVudC5oYXNFZGl0YWJsZVN0eWxlKCkp OwogCi0gICAgTm9kZSogcm9vdCA9IG5vZGUtPnJvb3RFZGl0YWJsZUVsZW1lbnQoKTsKLSAgICBG cmFtZSogZnJhbWUgPSBub2RlLT5kb2N1bWVudCgpLmZyYW1lKCk7CisgICAgYXV0byogcm9vdCA9 IGVsZW1lbnQucm9vdEVkaXRhYmxlRWxlbWVudCgpOworICAgIEZyYW1lKiBmcmFtZSA9IGVsZW1l bnQuZG9jdW1lbnQoKS5mcmFtZSgpOwogICAgIGlmICghZnJhbWUgfHwgIXJvb3QpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIApAQCAtMzc4NSw3ICszNzg0LDcgQEAgYm9vbCBEb2N1bWVudDo6c2V0 Rm9jdXNlZEVsZW1lbnQoRWxlbWVudCogZWxlbWVudCwgRm9jdXNEaXJlY3Rpb24gZGlyZWN0aW9u LCBGb2MKICAgICB9CiAKICAgICBpZiAobmV3Rm9jdXNlZEVsZW1lbnQgJiYgbmV3Rm9jdXNlZEVs ZW1lbnQtPmlzRm9jdXNhYmxlKCkpIHsKLSAgICAgICAgaWYgKG5ld0ZvY3VzZWRFbGVtZW50LT5p c1Jvb3RFZGl0YWJsZUVsZW1lbnQoKSAmJiAhYWNjZXB0c0VkaXRpbmdGb2N1cyhuZXdGb2N1c2Vk RWxlbWVudC5nZXQoKSkpIHsKKyAgICAgICAgaWYgKG5ld0ZvY3VzZWRFbGVtZW50LT5pc1Jvb3RF ZGl0YWJsZUVsZW1lbnQoKSAmJiAhYWNjZXB0c0VkaXRpbmdGb2N1cygqbmV3Rm9jdXNlZEVsZW1l bnQpKSB7CiAgICAgICAgICAgICAvLyBkZWxlZ2F0ZSBibG9ja3MgZm9jdXMgY2hhbmdlCiAgICAg ICAgICAgICBmb2N1c0NoYW5nZUJsb2NrZWQgPSB0cnVlOwogICAgICAgICAgICAgZ290byBTZXRG b2N1c2VkTm9kZURvbmU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRv ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKaW5kZXggNGYyOTBlMmE3 MmQuLmU5OGExYzY0NjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRv ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCkBAIC00NjMsNyAr NDYzLDcgQEAgdm9pZCBFZGl0b3I6OmNsZWFyVGV4dCgpCiAKIHZvaWQgRWRpdG9yOjpwYXN0ZUFz UGxhaW5UZXh0KGNvbnN0IFN0cmluZyYgcGFzdGluZ1RleHQsIGJvb2wgc21hcnRSZXBsYWNlKQog ewotICAgIE5vZGUqIHRhcmdldCA9IGZpbmRFdmVudFRhcmdldEZyb21TZWxlY3Rpb24oKTsKKyAg ICBFbGVtZW50KiB0YXJnZXQgPSBmaW5kRXZlbnRUYXJnZXRGcm9tU2VsZWN0aW9uKCk7CiAgICAg aWYgKCF0YXJnZXQpCiAgICAgICAgIHJldHVybjsKICAgICB0YXJnZXQtPmRpc3BhdGNoRXZlbnQo VGV4dEV2ZW50OjpjcmVhdGVGb3JQbGFpblRleHRQYXN0ZShkb2N1bWVudCgpLmRvbVdpbmRvdygp LCBwYXN0aW5nVGV4dCwgc21hcnRSZXBsYWNlKSk7CkBAIC00NzEsNyArNDcxLDcgQEAgdm9pZCBF ZGl0b3I6OnBhc3RlQXNQbGFpblRleHQoY29uc3QgU3RyaW5nJiBwYXN0aW5nVGV4dCwgYm9vbCBz bWFydFJlcGxhY2UpCiAKIHZvaWQgRWRpdG9yOjpwYXN0ZUFzRnJhZ21lbnQoUmVmPERvY3VtZW50 RnJhZ21lbnQ+JiYgcGFzdGluZ0ZyYWdtZW50LCBib29sIHNtYXJ0UmVwbGFjZSwgYm9vbCBtYXRj aFN0eWxlLCBNYWlsQmxvY2txdW90ZUhhbmRsaW5nIHJlc3BlY3RzTWFpbEJsb2NrcXVvdGUpCiB7 Ci0gICAgTm9kZSogdGFyZ2V0ID0gZmluZEV2ZW50VGFyZ2V0RnJvbVNlbGVjdGlvbigpOworICAg IEVsZW1lbnQqIHRhcmdldCA9IGZpbmRFdmVudFRhcmdldEZyb21TZWxlY3Rpb24oKTsKICAgICBp ZiAoIXRhcmdldCkKICAgICAgICAgcmV0dXJuOwogICAgIHRhcmdldC0+ZGlzcGF0Y2hFdmVudChU ZXh0RXZlbnQ6OmNyZWF0ZUZvckZyYWdtZW50UGFzdGUoZG9jdW1lbnQoKS5kb21XaW5kb3coKSwg V1RGTW92ZShwYXN0aW5nRnJhZ21lbnQpLCBzbWFydFJlcGxhY2UsIG1hdGNoU3R5bGUsIHJlc3Bl Y3RzTWFpbEJsb2NrcXVvdGUpKTsKQEAgLTc3OSw3ICs3NzksNyBAQCB2b2lkIEVkaXRvcjo6Y2xl YXJMYXN0RWRpdENvbW1hbmQoKQogLy8gdGhlIGV2ZW50IGhhbmRsZXIgTk9UIHNldHRpbmcgdGhl IHJldHVybiB2YWx1ZSB0byBmYWxzZQogYm9vbCBFZGl0b3I6OmRpc3BhdGNoQ1BQRXZlbnQoY29u c3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIERhdGFUcmFuc2ZlckFjY2Vzc1BvbGljeSBwb2xp Y3kpCiB7Ci0gICAgTm9kZSogdGFyZ2V0ID0gZmluZEV2ZW50VGFyZ2V0RnJvbVNlbGVjdGlvbigp OworICAgIEVsZW1lbnQqIHRhcmdldCA9IGZpbmRFdmVudFRhcmdldEZyb21TZWxlY3Rpb24oKTsK ICAgICBpZiAoIXRhcmdldCkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKQEAgLTgwNCw5ICs4MDQs OSBAQCBib29sIEVkaXRvcjo6ZGlzcGF0Y2hDUFBFdmVudChjb25zdCBBdG9taWNTdHJpbmcmIGV2 ZW50VHlwZSwgRGF0YVRyYW5zZmVyQWNjZXNzUAogICAgIHJldHVybiAhbm9EZWZhdWx0UHJvY2Vz c2luZzsKIH0KIAotTm9kZSogRWRpdG9yOjpmaW5kRXZlbnRUYXJnZXRGcm9tKGNvbnN0IFZpc2li bGVTZWxlY3Rpb24mIHNlbGVjdGlvbikgY29uc3QKK0VsZW1lbnQqIEVkaXRvcjo6ZmluZEV2ZW50 VGFyZ2V0RnJvbShjb25zdCBWaXNpYmxlU2VsZWN0aW9uJiBzZWxlY3Rpb24pIGNvbnN0CiB7Ci0g ICAgTm9kZSogdGFyZ2V0ID0gc2VsZWN0aW9uLnN0YXJ0KCkuZWxlbWVudCgpOworICAgIEVsZW1l bnQqIHRhcmdldCA9IHNlbGVjdGlvbi5zdGFydCgpLmVsZW1lbnQoKTsKICAgICBpZiAoIXRhcmdl dCkKICAgICAgICAgdGFyZ2V0ID0gZG9jdW1lbnQoKS5ib2R5T3JGcmFtZXNldCgpOwogICAgIGlm ICghdGFyZ2V0KQpAQCAtODE1LDcgKzgxNSw3IEBAIE5vZGUqIEVkaXRvcjo6ZmluZEV2ZW50VGFy Z2V0RnJvbShjb25zdCBWaXNpYmxlU2VsZWN0aW9uJiBzZWxlY3Rpb24pIGNvbnN0CiAgICAgcmV0 dXJuIHRhcmdldDsKIH0KIAotTm9kZSogRWRpdG9yOjpmaW5kRXZlbnRUYXJnZXRGcm9tU2VsZWN0 aW9uKCkgY29uc3QKK0VsZW1lbnQqIEVkaXRvcjo6ZmluZEV2ZW50VGFyZ2V0RnJvbVNlbGVjdGlv bigpIGNvbnN0CiB7CiAgICAgcmV0dXJuIGZpbmRFdmVudFRhcmdldEZyb20obV9mcmFtZS5zZWxl Y3Rpb24oKS5zZWxlY3Rpb24oKSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0 aW5nL0VkaXRvci5oIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaAppbmRleCBjODI5 ZmQxOTEzYy4uZTcwMzYzNTZkMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv RWRpdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaApAQCAtNDAxLDcg KzQwMSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGNsZWFyTWlzc3BlbGxpbmdzQW5kQmFkR3JhbW1h cihjb25zdCBWaXNpYmxlU2VsZWN0aW9uJik7CiAgICAgdm9pZCBtYXJrTWlzc3BlbGxpbmdzQW5k QmFkR3JhbW1hcihjb25zdCBWaXNpYmxlU2VsZWN0aW9uJik7CiAKLSAgICBOb2RlKiBmaW5kRXZl bnRUYXJnZXRGcm9tKGNvbnN0IFZpc2libGVTZWxlY3Rpb24mIHNlbGVjdGlvbikgY29uc3Q7Cisg ICAgRWxlbWVudCogZmluZEV2ZW50VGFyZ2V0RnJvbShjb25zdCBWaXNpYmxlU2VsZWN0aW9uJiBz ZWxlY3Rpb24pIGNvbnN0OwogCiAgICAgV0VCQ09SRV9FWFBPUlQgU3RyaW5nIHNlbGVjdGVkVGV4 dCgpIGNvbnN0OwogICAgIFN0cmluZyBzZWxlY3RlZFRleHRGb3JEYXRhVHJhbnNmZXIoKSBjb25z dDsKQEAgLTU0MSw3ICs1NDEsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBlZGl0b3JVSVVwZGF0 ZVRpbWVyRmlyZWQoKTsKIAotICAgIE5vZGUqIGZpbmRFdmVudFRhcmdldEZyb21TZWxlY3Rpb24o KSBjb25zdDsKKyAgICBFbGVtZW50KiBmaW5kRXZlbnRUYXJnZXRGcm9tU2VsZWN0aW9uKCkgY29u c3Q7CiAKICAgICBib29sIHVuaWZpZWRUZXh0Q2hlY2tlckVuYWJsZWQoKSBjb25zdDsKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcAppbmRleCAxMWIwMzZjYzdhNi4uYTQ0Nzli MDFjZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCkBAIC01MTcsNyAr NTE3LDcgQEAgYm9vbCBEcmFnQ29udHJvbGxlcjo6ZGlzcGF0Y2hUZXh0SW5wdXRFdmVudEZvcihG cmFtZSogaW5uZXJGcmFtZSwgY29uc3QgRHJhZ0RhdGEKIHsKICAgICBBU1NFUlQobV9wYWdlLmRy YWdDYXJldENvbnRyb2xsZXIoKS5oYXNDYXJldCgpKTsKICAgICBTdHJpbmcgdGV4dCA9IG1fcGFn ZS5kcmFnQ2FyZXRDb250cm9sbGVyKCkuaXNDb250ZW50UmljaGx5RWRpdGFibGUoKSA/IGVtcHR5 U3RyaW5nKCkgOiBkcmFnRGF0YS5hc1BsYWluVGV4dCgpOwotICAgIE5vZGUqIHRhcmdldCA9IGlu bmVyRnJhbWUtPmVkaXRvcigpLmZpbmRFdmVudFRhcmdldEZyb20obV9wYWdlLmRyYWdDYXJldENv bnRyb2xsZXIoKS5jYXJldFBvc2l0aW9uKCkpOworICAgIEVsZW1lbnQqIHRhcmdldCA9IGlubmVy RnJhbWUtPmVkaXRvcigpLmZpbmRFdmVudFRhcmdldEZyb20obV9wYWdlLmRyYWdDYXJldENvbnRy b2xsZXIoKS5jYXJldFBvc2l0aW9uKCkpOwogICAgIHJldHVybiB0YXJnZXQtPmRpc3BhdGNoRXZl bnQoVGV4dEV2ZW50OjpjcmVhdGVGb3JEcm9wKGlubmVyRnJhbWUtPmRvY3VtZW50KCktPmRvbVdp bmRvdygpLCB0ZXh0KSk7CiB9CiAK