174637 2017-07-18 12:15:23 -0700 lldb: Add type summary for StringView 2017-07-18 15:54:05 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates jer.noble jfbastien lforschler sam oldest_to_newest 1330051 0 dbates 2017-07-18 12:15:23 -0700 We should add a type summary for StringView objects to print the length and contents of the StringView similar to what we do for other string types. Currently you can get the effect of pretty printing a StringView by converting it to String using StringView.toString() and then printing the string in lldb. It would be more convenient to support pretty printing a StringView directly. 1330053 1 315813 dbates 2017-07-18 12:19:17 -0700 Created attachment 315813 Patch 1330133 2 sam 2017-07-18 14:47:52 -0700 Cool. How does one install these? Do they work in Xcode too? 1330178 3 dbates 2017-07-18 15:52:35 -0700 (In reply to Sam Weinig from comment #2) > Cool. How does one install these? Installation instructions are at the top of the file: <https://trac.webkit.org/browser/trunk/Tools/lldb/lldb_webkit.py?rev=216701#L24>. If you don't want to always have these type summaries enabled and just want to try them out in a single lldb/Xcode debug session just execute: command script import {Path to WebKit Root}/Tools/lldb/lldb_webkit.py in your lldb/Xcode lldb session. > Do they work in Xcode too? Yes, it works in an Xcode lldb session. 1330179 4 315813 dbates 2017-07-18 15:54:04 -0700 Comment on attachment 315813 Patch Clearing flags on attachment: 315813 Committed r219637: <http://trac.webkit.org/changeset/219637> 1330180 5 dbates 2017-07-18 15:54:05 -0700 All reviewed patches have been landed. Closing bug. 315813 2017-07-18 12:19:17 -0700 2017-07-18 15:54:04 -0700 Patch bug-174637-20170718121915.patch text/plain 4608 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NTIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDI0ZjgwZDE3MjRiNjM2MDllNDkxNTI1YjU2M2MzZWM2 ZTgxM2JlYi4uZGJmNzc4M2VlZWZhMTc1NmNiZTgyNDgwZTIzYjNiZjA2NTQ0ZjAyZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMw IEBACisyMDE3LTA3LTE4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBsbGRiOiBBZGQgdHlwZSBzdW1tYXJ5IGZvciBTdHJpbmdWaWV3CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ2MzcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3IgZGVidWdnaW5nIGNvbnZlbmll bmNlLCBhZGRzIGEgcHJldHR5LXByaW50IHR5cGUgc3VtbWFyeSBmb3IgU3RyaW5nVmlldy4gRXZh bHVhdGluZyBhCisgICAgICAgIFN0cmluZ1ZpZXcgb2JqZWN0IHdpbGwgcHJpbnQgb3V0cHV0IHRo YXQgaGFzIHRoZSBmb3JtOgorCisgICAgICAgICAgICAoV1RGOjpTdHJpbmdWaWV3KSAkNCA9IHsg bGVuZ3RoID0gMiwgY29udGVudHMgPSAnbGknIH0geworICAgICAgICAgICAgICBtX2NoYXJhY3Rl cnMgPSAweDAwMDAwMDAxMWI1N2FiYjUgImVlZWVlZWZqaDBuIgorICAgICAgICAgICAgICBtX2xl bmd0aCA9IDIKKyAgICAgICAgICAgICAgbV9pczhCaXQgPSB0cnVlCisgICAgICAgICAgICAgIG1f dW5kZXJseWluZ1N0cmluZyA9IDB4MDAwMDYxNDAwMDAwMGE5MAorICAgICAgICAgICAgfQorCisg ICAgICAgICogbGxkYi9sbGRiX3dlYmtpdC5weToKKyAgICAgICAgKF9fbGxkYl9pbml0X21vZHVs ZSk6IFVzZSBXVEZTdHJpbmdWaWV3X1N1bW1hcnlQcm92aWRlciB0byBmb3JtYXQgU3RyaW5nVmll dyB0eXBlcy4KKyAgICAgICAgKFdURlN0cmluZ1ZpZXdfU3VtbWFyeVByb3ZpZGVyKToKKyAgICAg ICAgKFdURlN0cmluZ1ZpZXdQcm92aWRlcik6CisgICAgICAgIChXVEZTdHJpbmdWaWV3UHJvdmlk ZXIuX19pbml0X18pOgorICAgICAgICAoV1RGU3RyaW5nVmlld1Byb3ZpZGVyLmlzXzhiaXQpOiBB Y2Nlc3MgZmllbGQgU3RyaW5nVmlldy5tX2lzOEJpdC4KKyAgICAgICAgKFdURlN0cmluZ1ZpZXdQ cm92aWRlci5nZXRfbGVuZ3RoKTogQWNjZXNzIGZpZWxkIFN0cmluZ1ZpZXcubV9sZW5ndGguCisg ICAgICAgIChXVEZTdHJpbmdWaWV3UHJvdmlkZXIuZ2V0X2NoYXJhY3RlcnMpOiBBY2Nlc3MgZmll bGQgU3RyaW5nVmlldy5tX2NoYXJhY3RlcnMuCisgICAgICAgIChXVEZTdHJpbmdWaWV3UHJvdmlk ZXIudG9fc3RyaW5nKTogUmV0dXJucyB0aGUgc3RyaW5nIHJlcHJlc2VudGVkIGJ5IHRoZSBTdHJp bmdWaWV3LgorCiAyMDE3LTA3LTE0ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjE5NTEwLgpkaWZmIC0t Z2l0IGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weSBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQu cHkKaW5kZXggZjM2MGZhMGYyZWEzMWY4YmFlM2EzZTlhNmZmNThhMjZkNzk0MjMzMy4uZGQ2NGJh Nzg5YTEwODY1NGI4NjkzY2Y4NjY3ZDI4MjdhMzNiNTQxZiAxMDA2NDQKLS0tIGEvVG9vbHMvbGxk Yi9sbGRiX3dlYmtpdC5weQorKysgYi9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5CkBAIC0zNyw2 ICszNyw3IEBAIGRlZiBfX2xsZGJfaW5pdF9tb2R1bGUoZGVidWdnZXIsIGRpY3QpOgogICAgIGRl YnVnZ2VyLkhhbmRsZUNvbW1hbmQoJ2NvbW1hbmQgc2NyaXB0IGFkZCAtZiBsbGRiX3dlYmtpdC5i dGpzIGJ0anMnKQogICAgIGRlYnVnZ2VyLkhhbmRsZUNvbW1hbmQoJ3R5cGUgc3VtbWFyeSBhZGQg LS1leHBhbmQgLUYgbGxkYl93ZWJraXQuV1RGU3RyaW5nX1N1bW1hcnlQcm92aWRlciBXVEY6OlN0 cmluZycpCiAgICAgZGVidWdnZXIuSGFuZGxlQ29tbWFuZCgndHlwZSBzdW1tYXJ5IGFkZCAtLWV4 cGFuZCAtRiBsbGRiX3dlYmtpdC5XVEZTdHJpbmdJbXBsX1N1bW1hcnlQcm92aWRlciBXVEY6OlN0 cmluZ0ltcGwnKQorICAgIGRlYnVnZ2VyLkhhbmRsZUNvbW1hbmQoJ3R5cGUgc3VtbWFyeSBhZGQg LS1leHBhbmQgLUYgbGxkYl93ZWJraXQuV1RGU3RyaW5nVmlld19TdW1tYXJ5UHJvdmlkZXIgV1RG OjpTdHJpbmdWaWV3JykKICAgICBkZWJ1Z2dlci5IYW5kbGVDb21tYW5kKCd0eXBlIHN1bW1hcnkg YWRkIC0tZXhwYW5kIC1GIGxsZGJfd2Via2l0LldURkF0b21pY1N0cmluZ19TdW1tYXJ5UHJvdmlk ZXIgV1RGOjpBdG9taWNTdHJpbmcnKQogICAgIGRlYnVnZ2VyLkhhbmRsZUNvbW1hbmQoJ3R5cGUg c3VtbWFyeSBhZGQgLS1leHBhbmQgLUYgbGxkYl93ZWJraXQuV1RGVmVjdG9yX1N1bW1hcnlQcm92 aWRlciAteCAiV1RGOjpWZWN0b3I8Lis+JCInKQogICAgIGRlYnVnZ2VyLkhhbmRsZUNvbW1hbmQo J3R5cGUgc3VtbWFyeSBhZGQgLS1leHBhbmQgLUYgbGxkYl93ZWJraXQuV1RGSGFzaFRhYmxlX1N1 bW1hcnlQcm92aWRlciAteCAiV1RGOjpIYXNoVGFibGU8Lis+JCInKQpAQCAtNDgsNiArNDksNyBA QCBkZWYgX19sbGRiX2luaXRfbW9kdWxlKGRlYnVnZ2VyLCBkaWN0KToKICAgICBkZWJ1Z2dlci5I YW5kbGVDb21tYW5kKCd0eXBlIHN1bW1hcnkgYWRkIC1GIGxsZGJfd2Via2l0LldlYkNvcmVMYXlv dXRQb2ludF9TdW1tYXJ5UHJvdmlkZXIgV2ViQ29yZTo6TGF5b3V0UG9pbnQnKQogICAgIGRlYnVn Z2VyLkhhbmRsZUNvbW1hbmQoJ3R5cGUgc3VtbWFyeSBhZGQgLUYgbGxkYl93ZWJraXQuV2ViQ29y ZVVSTF9TdW1tYXJ5UHJvdmlkZXIgV2ViQ29yZTo6VVJMJykKIAorCiBkZWYgV1RGU3RyaW5nX1N1 bW1hcnlQcm92aWRlcih2YWxvYmosIGRpY3QpOgogICAgIHByb3ZpZGVyID0gV1RGU3RyaW5nUHJv dmlkZXIodmFsb2JqLCBkaWN0KQogICAgIHJldHVybiAieyBsZW5ndGggPSAlZCwgY29udGVudHMg PSAnJXMnIH0iICUgKHByb3ZpZGVyLmdldF9sZW5ndGgoKSwgcHJvdmlkZXIudG9fc3RyaW5nKCkp CkBAIC02MCw2ICs2MiwxMSBAQCBkZWYgV1RGU3RyaW5nSW1wbF9TdW1tYXJ5UHJvdmlkZXIodmFs b2JqLCBkaWN0KToKICAgICByZXR1cm4gInsgbGVuZ3RoID0gJWQsIGlzOGJpdCA9ICVkLCBjb250 ZW50cyA9ICclcycgfSIgJSAocHJvdmlkZXIuZ2V0X2xlbmd0aCgpLCBwcm92aWRlci5pc184Yml0 KCksIHByb3ZpZGVyLnRvX3N0cmluZygpKQogCiAKK2RlZiBXVEZTdHJpbmdWaWV3X1N1bW1hcnlQ cm92aWRlcih2YWxvYmosIGRpY3QpOgorICAgIHByb3ZpZGVyID0gV1RGU3RyaW5nVmlld1Byb3Zp ZGVyKHZhbG9iaiwgZGljdCkKKyAgICByZXR1cm4gInsgbGVuZ3RoID0gJWQsIGNvbnRlbnRzID0g JyVzJyB9IiAlIChwcm92aWRlci5nZXRfbGVuZ3RoKCksIHByb3ZpZGVyLnRvX3N0cmluZygpKQor CisKIGRlZiBXVEZBdG9taWNTdHJpbmdfU3VtbWFyeVByb3ZpZGVyKHZhbG9iaiwgZGljdCk6CiAg ICAgcmV0dXJuIFdURlN0cmluZ19TdW1tYXJ5UHJvdmlkZXIodmFsb2JqLkdldENoaWxkTWVtYmVy V2l0aE5hbWUoJ21fc3RyaW5nJyksIGRpY3QpCiAKQEAgLTI1NCw2ICsyNjEsMzAgQEAgY2xhc3Mg V1RGU3RyaW5nSW1wbFByb3ZpZGVyOgogICAgICAgICByZXR1cm4gc2VsZi52YWxvYmouR2V0VmFs dWVBc1Vuc2lnbmVkKCkgIT0gMAogCiAKK2NsYXNzIFdURlN0cmluZ1ZpZXdQcm92aWRlcjoKKyAg ICBkZWYgX19pbml0X18oc2VsZiwgdmFsb2JqLCBkaWN0KToKKyAgICAgICAgc2VsZi52YWxvYmog PSB2YWxvYmoKKworICAgIGRlZiBpc184Yml0KHNlbGYpOgorICAgICAgICByZXR1cm4gYm9vbChz ZWxmLnZhbG9iai5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdtX2lzOEJpdCcpLkdldFZhbHVlQXNV bnNpZ25lZCgwKSkKKworICAgIGRlZiBnZXRfbGVuZ3RoKHNlbGYpOgorICAgICAgICByZXR1cm4g c2VsZi52YWxvYmouR2V0Q2hpbGRNZW1iZXJXaXRoTmFtZSgnbV9sZW5ndGgnKS5HZXRWYWx1ZUFz VW5zaWduZWQoMCkKKworICAgIGRlZiBnZXRfY2hhcmFjdGVycyhzZWxmKToKKyAgICAgICAgcmV0 dXJuIHNlbGYudmFsb2JqLkdldENoaWxkTWVtYmVyV2l0aE5hbWUoJ21fY2hhcmFjdGVycycpCisK KyAgICBkZWYgdG9fc3RyaW5nKHNlbGYpOgorICAgICAgICBlcnJvciA9IGxsZGIuU0JFcnJvcigp CisKKyAgICAgICAgaWYgbm90IHNlbGYuZ2V0X2NoYXJhY3RlcnMoKSBvciBub3Qgc2VsZi5nZXRf bGVuZ3RoKCk6CisgICAgICAgICAgICByZXR1cm4gdSIiCisKKyAgICAgICAgaWYgc2VsZi5pc184 Yml0KCk6CisgICAgICAgICAgICByZXR1cm4gbHN0cmluZ190b19zdHJpbmcoc2VsZi5nZXRfY2hh cmFjdGVycygpLCBlcnJvciwgc2VsZi5nZXRfbGVuZ3RoKCkpCisgICAgICAgIHJldHVybiB1c3Ry aW5nX3RvX3N0cmluZyhzZWxmLmdldF9jaGFyYWN0ZXJzKCksIGVycm9yLCBzZWxmLmdldF9sZW5n dGgoKSkKKworCiBjbGFzcyBXVEZTdHJpbmdQcm92aWRlcjoKICAgICBkZWYgX19pbml0X18oc2Vs ZiwgdmFsb2JqLCBkaWN0KToKICAgICAgICAgc2VsZi52YWxvYmogPSB2YWxvYmoK