174624 2017-07-18 05:28:12 -0700 Web Automation: error details not passed to DidEvaluateJavaScriptFunction message when callback was not called before page unload 2017-07-18 23:10:22 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned bburg joepeck oldest_to_newest 1329958 0 cgarcia 2017-07-18 05:28:12 -0700 There's a variable errorMessage, but it's unused. 1329959 1 315791 cgarcia 2017-07-18 05:29:51 -0700 Created attachment 315791 Patch 1330148 2 315791 bburg 2017-07-18 15:09:31 -0700 Comment on attachment 315791 Patch r=me 1330307 3 cgarcia 2017-07-18 23:10:22 -0700 Committed r219651: <http://trac.webkit.org/changeset/219651> 315791 2017-07-18 05:29:51 -0700 2017-07-18 15:09:31 -0700 Patch wk2-error-details.diff text/plain 2120 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZmNhMWNkNzNlZTEuLjhkMzI3ZGI4MDFjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE3IEBACiAyMDE3LTA3LTE4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAorICAgICAgICBXZWIgQXV0b21hdGlvbjogZXJyb3IgZGV0YWlscyBub3QgcGFzc2Vk IHRvIERpZEV2YWx1YXRlSmF2YVNjcmlwdEZ1bmN0aW9uIG1lc3NhZ2Ugd2hlbiBjYWxsYmFjayB3 YXMgbm90IGNhbGxlZCBiZWZvcmUgcGFnZSB1bmxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDYyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlJ3MgYSB2YXJpYWJsZSBlcnJvck1lc3NhZ2Us IGJ1dCBpdCdzIHVudXNlZC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJB dXRvbWF0aW9uU2Vzc2lvblByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQXV0b21hdGlv blNlc3Npb25Qcm94eTo6ZGlkQ2xlYXJXaW5kb3dPYmplY3RGb3JGcmFtZSk6IFBhc3MgZXJyb3JN ZXNzYWdlIGluc3RlYWQgb2YgU3RyaW5nKCkgdG8gRGlkRXZhbHVhdGVKYXZhU2NyaXB0RnVuY3Rp b24uCisKKzIwMTctMDctMTggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgorCiAgICAgICAgIFdlYiBBdXRvbWF0aW9uOiBldmFsdWF0ZUphdmFTY3JpcHRGdW5jdGlv biBzaG91bGQgYWx3YXlzIG5vdGlmeSB0aGUgd2ViIHByb2Nlc3MgYmVmb3JlIHJldHVybmluZyBl YXJseQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0 NjIzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dl YkF1dG9tYXRpb25TZXNzaW9uUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1 dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5jcHAKaW5kZXggMmQ0MjU1Yjg5MWMu LjhlZTQyNzQyNzg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvQXV0b21h dGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5LmNwcApAQCAtMjI0 LDcgKzIyNCw3IEBAIHZvaWQgV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eTo6ZGlkQ2xlYXJXaW5k b3dPYmplY3RGb3JGcmFtZShXZWJGcmFtZSYgZnJhbWUpCiAKICAgICBhdXRvIHBlbmRpbmdGcmFt ZUNhbGxiYWNrcyA9IG1fd2ViRnJhbWVQZW5kaW5nRXZhbHVhdGVKYXZhU2NyaXB0Q2FsbGJhY2tz TWFwLnRha2UoZnJhbWVJRCk7CiAgICAgZm9yICh1aW50NjRfdCBjYWxsYmFja0lEIDogcGVuZGlu Z0ZyYW1lQ2FsbGJhY2tzKQotICAgICAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5wYXJlbnRQ cm9jZXNzQ29ubmVjdGlvbigpLT5zZW5kKE1lc3NhZ2VzOjpXZWJBdXRvbWF0aW9uU2Vzc2lvbjo6 RGlkRXZhbHVhdGVKYXZhU2NyaXB0RnVuY3Rpb24oY2FsbGJhY2tJRCwgU3RyaW5nKCksIGVycm9y VHlwZSksIDApOworICAgICAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5wYXJlbnRQcm9jZXNz Q29ubmVjdGlvbigpLT5zZW5kKE1lc3NhZ2VzOjpXZWJBdXRvbWF0aW9uU2Vzc2lvbjo6RGlkRXZh bHVhdGVKYXZhU2NyaXB0RnVuY3Rpb24oY2FsbGJhY2tJRCwgZXJyb3JNZXNzYWdlLCBlcnJvclR5 cGUpLCAwKTsKIH0KIAogdm9pZCBXZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5OjpldmFsdWF0ZUph dmFTY3JpcHRGdW5jdGlvbih1aW50NjRfdCBwYWdlSUQsIHVpbnQ2NF90IGZyYW1lSUQsIGNvbnN0 IFN0cmluZyYgZnVuY3Rpb24sIFZlY3RvcjxTdHJpbmc+IGFyZ3VtZW50cywgYm9vbCBleHBlY3Rz SW1wbGljaXRDYWxsYmFja0FyZ3VtZW50LCBpbnQgY2FsbGJhY2tUaW1lb3V0LCB1aW50NjRfdCBj YWxsYmFja0lEKQo=