174623 2017-07-18 05:19:28 -0700 Web Automation: evaluateJavaScriptFunction should always notify the web process before returning early 2017-07-18 23:08:38 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned bburg joepeck oldest_to_newest 1329956 0 cgarcia 2017-07-18 05:19:28 -0700 It currently returns early if page, frame or scriptObject are nullptr, in which cases the UI process is not notified. This causes test testShouldNotBeAbleToDoAnythingTheFrameIsDeletedFromUnderUs to hang, because message DidEvaluateJavaScriptFunction is never sent when the given frame no longer exists. We should send DidEvaluateJavaScriptFunction with WindowNotFound in case of page is nullptr and FrameNotFound if the frame is nullptr. The scriptObject early return is actually wrong, because scriptObjectForFrame creates a new script if there's isn't one for the given frame. 1329957 1 315790 cgarcia 2017-07-18 05:20:44 -0700 Created attachment 315790 Patch 1330156 2 315790 bburg 2017-07-18 15:20:57 -0700 Comment on attachment 315790 Patch Good catch, r = me 1330306 3 cgarcia 2017-07-18 23:08:38 -0700 Committed r219650: <http://trac.webkit.org/changeset/219650> 315790 2017-07-18 05:20:44 -0700 2017-07-18 15:20:57 -0700 Patch wk2-evaluate-script-frame-not-found.diff text/plain 3179 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOGYzYTQ3NmMxMzMuLmZjYTFjZDczZWUxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSw1ICsx LDIyIEBACiAyMDE3LTA3LTE4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAorICAgICAgICBXZWIgQXV0b21hdGlvbjogZXZhbHVhdGVKYXZhU2NyaXB0RnVuY3Rp b24gc2hvdWxkIGFsd2F5cyBub3RpZnkgdGhlIHdlYiBwcm9jZXNzIGJlZm9yZSByZXR1cm5pbmcg ZWFybHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NDYyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0 IGN1cnJlbnRseSByZXR1cm5zIGVhcmx5IGlmIHBhZ2UsIGZyYW1lIG9yIHNjcmlwdE9iamVjdCBh cmUgbnVsbHB0ciwgaW4gd2hpY2ggY2FzZXMgdGhlIFVJIHByb2Nlc3MgaXMgbm90CisgICAgICAg IG5vdGlmaWVkLiBUaGlzIGNhdXNlcyB0ZXN0IHRlc3RTaG91bGROb3RCZUFibGVUb0RvQW55dGhp bmdUaGVGcmFtZUlzRGVsZXRlZEZyb21VbmRlclVzIHRvIGhhbmcsIGJlY2F1c2UgbWVzc2FnZQor ICAgICAgICBEaWRFdmFsdWF0ZUphdmFTY3JpcHRGdW5jdGlvbiBpcyBuZXZlciBzZW50IHdoZW4g dGhlIGdpdmVuIGZyYW1lIG5vIGxvbmdlciBleGlzdHMuIFdlIHNob3VsZCBzZW5kCisgICAgICAg IERpZEV2YWx1YXRlSmF2YVNjcmlwdEZ1bmN0aW9uIHdpdGggV2luZG93Tm90Rm91bmQgaW4gY2Fz ZSBvZiBwYWdlIGlzIG51bGxwdHIgYW5kIEZyYW1lTm90Rm91bmQgaWYgdGhlIGZyYW1lIGlzCisg ICAgICAgIG51bGxwdHIuIFRoZSBzY3JpcHRPYmplY3QgZWFybHkgcmV0dXJuIGlzIGFjdHVhbGx5 IHdyb25nLCBiZWNhdXNlIHNjcmlwdE9iamVjdEZvckZyYW1lIGNyZWF0ZXMgYSBuZXcgc2NyaXB0 IGlmCisgICAgICAgIHRoZXJlJ3MgaXNuJ3Qgb25lIGZvciB0aGUgZ2l2ZW4gZnJhbWUuCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYkF1dG9tYXRpb25TZXNzaW9uUHJveHk6OmV2YWx1YXRl SmF2YVNjcmlwdEZ1bmN0aW9uKToKKworMjAxNy0wNy0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgV2ViIEF1dG9tYXRpb246IHBlbmRpbmcg ZXZhbHVhdGUgc2NyaXB0IGNhbGxiYWNrcyBhcmUgc3RvcmVkIHdpdGggdGhlIHdyb25nIGZyYW1l IElEIHdoZW4gdXNpbmcgdGhlIGRlZmF1bHQgbWFpbiBmcmFtZQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0NjIyCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHku Y3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNl c3Npb25Qcm94eS5jcHAKaW5kZXggZDExNjRhZTlhODUuLjJkNDI1NWI4OTFjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lv blByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJB dXRvbWF0aW9uU2Vzc2lvblByb3h5LmNwcApAQCAtMjMwLDE2ICsyMzAsMjAgQEAgdm9pZCBXZWJB dXRvbWF0aW9uU2Vzc2lvblByb3h5OjpkaWRDbGVhcldpbmRvd09iamVjdEZvckZyYW1lKFdlYkZy YW1lJiBmcmFtZSkKIHZvaWQgV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eTo6ZXZhbHVhdGVKYXZh U2NyaXB0RnVuY3Rpb24odWludDY0X3QgcGFnZUlELCB1aW50NjRfdCBmcmFtZUlELCBjb25zdCBT dHJpbmcmIGZ1bmN0aW9uLCBWZWN0b3I8U3RyaW5nPiBhcmd1bWVudHMsIGJvb2wgZXhwZWN0c0lt cGxpY2l0Q2FsbGJhY2tBcmd1bWVudCwgaW50IGNhbGxiYWNrVGltZW91dCwgdWludDY0X3QgY2Fs bGJhY2tJRCkKIHsKICAgICBXZWJQYWdlKiBwYWdlID0gV2ViUHJvY2Vzczo6c2luZ2xldG9uKCku d2ViUGFnZShwYWdlSUQpOwotICAgIGlmICghcGFnZSkKKyAgICBpZiAoIXBhZ2UpIHsKKyAgICAg ICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkucGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2Vu ZChNZXNzYWdlczo6V2ViQXV0b21hdGlvblNlc3Npb246OkRpZEV2YWx1YXRlSmF2YVNjcmlwdEZ1 bmN0aW9uKGNhbGxiYWNrSUQsIHsgfSwKKyAgICAgICAgICAgIEluc3BlY3Rvcjo6UHJvdG9jb2w6 OkF1dG9tYXRpb25IZWxwZXJzOjpnZXRFbnVtQ29uc3RhbnRWYWx1ZShJbnNwZWN0b3I6OlByb3Rv Y29sOjpBdXRvbWF0aW9uOjpFcnJvck1lc3NhZ2U6OldpbmRvd05vdEZvdW5kKSksIDApOwogICAg ICAgICByZXR1cm47Ci0KKyAgICB9CiAgICAgV2ViRnJhbWUqIGZyYW1lID0gZnJhbWVJRCA/IFdl YlByb2Nlc3M6OnNpbmdsZXRvbigpLndlYkZyYW1lKGZyYW1lSUQpIDogcGFnZS0+bWFpbldlYkZy YW1lKCk7Ci0gICAgaWYgKCFmcmFtZSkKKyAgICBpZiAoIWZyYW1lKSB7CisgICAgICAgIFdlYlBy b2Nlc3M6OnNpbmdsZXRvbigpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmQoTWVzc2Fn ZXM6OldlYkF1dG9tYXRpb25TZXNzaW9uOjpEaWRFdmFsdWF0ZUphdmFTY3JpcHRGdW5jdGlvbihj YWxsYmFja0lELCB7IH0sCisgICAgICAgICAgICBJbnNwZWN0b3I6OlByb3RvY29sOjpBdXRvbWF0 aW9uSGVscGVyczo6Z2V0RW51bUNvbnN0YW50VmFsdWUoSW5zcGVjdG9yOjpQcm90b2NvbDo6QXV0 b21hdGlvbjo6RXJyb3JNZXNzYWdlOjpGcmFtZU5vdEZvdW5kKSksIDApOwogICAgICAgICByZXR1 cm47CisgICAgfQogCiAgICAgSlNPYmplY3RSZWYgc2NyaXB0T2JqZWN0ID0gc2NyaXB0T2JqZWN0 Rm9yRnJhbWUoKmZyYW1lKTsKLSAgICBpZiAoIXNjcmlwdE9iamVjdCkKLSAgICAgICAgcmV0dXJu OworICAgIEFTU0VSVChzY3JpcHRPYmplY3QpOwogCiAgICAgZnJhbWVJRCA9IGZyYW1lLT5mcmFt ZUlEKCk7CiAgICAgSlNWYWx1ZVJlZiBleGNlcHRpb24gPSBudWxscHRyOwo=