174622 2017-07-18 04:01:08 -0700 Web Automation: pending evaluate script callbacks are stored with the wrong frame ID when using the default main frame 2017-07-18 23:07:10 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159957 InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg joepeck webkit-bug-importer oldest_to_newest 1329952 0 cgarcia 2017-07-18 04:01:08 -0700 The frameHandle argument is optional in evaluateJavaScriptFunction(), when not provided we pass 0 to the web process. Then, the proxy gets the web page main frame when received frame ID is 0, but the given frameID is still used as key of m_webFramePendingEvaluateJavaScriptCallbacksMap and also passed to the javascript function as argument. I think r203442 was actually a workaround to this bug, making it even more hidden. m_webFrameScriptObjectMap and m_webFramePendingEvaluateJavaScriptCallbacksMap should never have a 0 as key, since the always use a frame ID and the frame identifier counter starts at 1. This is causing test testShouldDetectPageLoadsWhileWaitingOnAnAsyncScriptAndReturnAnError to hang, because when the page is unloaded and didClearWindowObjectForFrame is called, we try to get the pending callbacks of frame 1, but they were stored as frame 0 so DidEvaluateJavaScriptFunction message is never sent to the Ui process. 1329953 1 315789 cgarcia 2017-07-18 04:05:46 -0700 Created attachment 315789 Patch 1330168 2 webkit-bug-importer 2017-07-18 15:32:40 -0700 <rdar://problem/33387829> 1330169 3 315789 bburg 2017-07-18 15:36:38 -0700 Comment on attachment 315789 Patch r=me Great catch! 1330305 4 cgarcia 2017-07-18 23:07:10 -0700 Committed r219649: <http://trac.webkit.org/changeset/219649> 315789 2017-07-18 04:05:46 -0700 2017-07-18 15:36:38 -0700 Patch wd-async-script-hang.diff text/plain 3511 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZTg0ZDVhYTZmZGQuLjhmM2E0NzZjMTMzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSw1ICsx LDI4IEBACiAyMDE3LTA3LTE4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAorICAgICAgICBXZWIgQXV0b21hdGlvbjogcGVuZGluZyBldmFsdWF0ZSBzY3JpcHQg Y2FsbGJhY2tzIGFyZSBzdG9yZWQgd2l0aCB0aGUgd3JvbmcgZnJhbWUgSUQgd2hlbiB1c2luZyB0 aGUgZGVmYXVsdCBtYWluIGZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzQ2MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgZnJhbWVIYW5kbGUgYXJndW1lbnQgaXMgb3B0aW9uYWwgaW4gZXZh bHVhdGVKYXZhU2NyaXB0RnVuY3Rpb24oKSwgd2hlbiBub3QgcHJvdmlkZWQgd2UgcGFzcyAwIHRv IHRoZSB3ZWIKKyAgICAgICAgcHJvY2Vzcy4gVGhlIHByb3h5IGdldHMgdGhlIHdlYiBwYWdlIG1h aW4gZnJhbWUgd2hlbiByZWNlaXZlZCBmcmFtZSBJRCBpcyAwLCBidXQgdGhlIGdpdmVuIGZyYW1l SUQgaXMKKyAgICAgICAgc3RpbGwgdXNlZCBhcyBrZXkgb2YgbV93ZWJGcmFtZVBlbmRpbmdFdmFs dWF0ZUphdmFTY3JpcHRDYWxsYmFja3NNYXAgYW5kIGFsc28gcGFzc2VkIHRvIHRoZSBqYXZhc2Ny aXB0IGZ1bmN0aW9uCisgICAgICAgIGFzIGFyZ3VtZW50LiBJIHRoaW5rIHIyMDM0NDIgd2FzIGFj dHVhbGx5IGEgd29ya2Fyb3VuZCB0byB0aGlzIGJ1ZywgbWFraW5nIGl0IGV2ZW4gbW9yZSBoaWRk ZW4uIEJvdGgKKyAgICAgICAgbV93ZWJGcmFtZVNjcmlwdE9iamVjdE1hcCBhbmQgbV93ZWJGcmFt ZVBlbmRpbmdFdmFsdWF0ZUphdmFTY3JpcHRDYWxsYmFja3NNYXAgc2hvdWxkIG5ldmVyIGhhdmUg MCBhcyBhCisgICAgICAgIGtleSwgc2luY2UgdGhleSBhbHdheXMgdXNlIGEgZnJhbWUgSUQsIGFu ZCB0aGUgZnJhbWUgaWRlbnRpZmllciBjb3VudGVyIHN0YXJ0cyBhdCAxLiBUaGlzIGlzIGNhdXNp bmcgdGVzdAorICAgICAgICB0ZXN0U2hvdWxkRGV0ZWN0UGFnZUxvYWRzV2hpbGVXYWl0aW5nT25B bkFzeW5jU2NyaXB0QW5kUmV0dXJuQW5FcnJvciB0byBoYW5nLCBiZWNhdXNlIHdoZW4gdGhlIHBh Z2UgaXMgdW5sb2FkZWQKKyAgICAgICAgYW5kIGRpZENsZWFyV2luZG93T2JqZWN0Rm9yRnJhbWUg aXMgY2FsbGVkLCB3ZSB0cnkgdG8gZ2V0IHRoZSBwZW5kaW5nIGNhbGxiYWNrcyBvZiBmcmFtZSAx LCBidXQgdGhleSB3ZXJlIHN0b3JlZAorICAgICAgICBhcyBmcmFtZSAwIHNvIERpZEV2YWx1YXRl SmF2YVNjcmlwdEZ1bmN0aW9uIG1lc3NhZ2UgaXMgbmV2ZXIgc2VudCB0byB0aGUgVUkgcHJvY2Vz cy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lv blByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQXV0b21hdGlvblNlc3Npb25Qcm94eTo6 ZXZhbHVhdGVKYXZhU2NyaXB0RnVuY3Rpb24pOiBVc2UgYWx3YXlzIHRoZSBhY3R1YWwgZnJhbWVJ RCBmcm9tIHRoZSBXZWJGcmFtZQorICAgICAgICB3ZSBhcmUgdXNpbmcuCisgICAgICAgICogV2Vi UHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHkuaDogRG8gbm90IGFs bG93IDAgYXMgYSBrZXkgb2YKKyAgICAgICAgbV93ZWJGcmFtZVBlbmRpbmdFdmFsdWF0ZUphdmFT Y3JpcHRDYWxsYmFja3NNYXAgYW5kIG1fd2ViRnJhbWVTY3JpcHRPYmplY3RNYXAuCisKKzIwMTct MDctMTggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAg ICAgIFdlYkRyaXZlcjogaGFuZGxlIGludmFsaWQgc2VsZWN0b3IgZXJyb3JzCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ2MTkKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Np b25Qcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRv bWF0aW9uU2Vzc2lvblByb3h5LmNwcAppbmRleCA0N2JiNjMyMDIxNC4uZDExNjRhZTlhODUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRp b25TZXNzaW9uUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0 aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHkuY3BwCkBAIC0yNDEsNiArMjQxLDcgQEAgdm9p ZCBXZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5OjpldmFsdWF0ZUphdmFTY3JpcHRGdW5jdGlvbih1 aW50NjRfdCBwYWdlSUQsIHVpbnQKICAgICBpZiAoIXNjcmlwdE9iamVjdCkKICAgICAgICAgcmV0 dXJuOwogCisgICAgZnJhbWVJRCA9IGZyYW1lLT5mcmFtZUlEKCk7CiAgICAgSlNWYWx1ZVJlZiBl eGNlcHRpb24gPSBudWxscHRyOwogICAgIEpTR2xvYmFsQ29udGV4dFJlZiBjb250ZXh0ID0gZnJh bWUtPmpzQ29udGV4dCgpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv QXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5LmggYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5LmgKaW5kZXggMThk NDAzODE2M2YuLjRiOTc5NDQzYWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5LmgKKysrIGIvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5oCkBA IC03MSw4ICs3MSw4IEBAIHByaXZhdGU6CiAKICAgICBTdHJpbmcgbV9zZXNzaW9uSWRlbnRpZmll cjsKIAotICAgIEhhc2hNYXA8dWludDY0X3QsIEpTT2JqZWN0UmVmLCBEZWZhdWx0SGFzaDx1aW50 NjRfdD46Okhhc2gsIFdURjo6VW5zaWduZWRXaXRoWmVyb0tleUhhc2hUcmFpdHM8dWludDY0X3Q+ PiBtX3dlYkZyYW1lU2NyaXB0T2JqZWN0TWFwOwotICAgIEhhc2hNYXA8dWludDY0X3QsIFZlY3Rv cjx1aW50NjRfdD4sIERlZmF1bHRIYXNoPHVpbnQ2NF90Pjo6SGFzaCwgV1RGOjpVbnNpZ25lZFdp dGhaZXJvS2V5SGFzaFRyYWl0czx1aW50NjRfdD4+IG1fd2ViRnJhbWVQZW5kaW5nRXZhbHVhdGVK YXZhU2NyaXB0Q2FsbGJhY2tzTWFwOworICAgIEhhc2hNYXA8dWludDY0X3QsIEpTT2JqZWN0UmVm PiBtX3dlYkZyYW1lU2NyaXB0T2JqZWN0TWFwOworICAgIEhhc2hNYXA8dWludDY0X3QsIFZlY3Rv cjx1aW50NjRfdD4+IG1fd2ViRnJhbWVQZW5kaW5nRXZhbHVhdGVKYXZhU2NyaXB0Q2FsbGJhY2tz TWFwOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==