174610 2017-07-17 21:58:49 -0700 Update layout test fast/forms/content-with-margins-inside-button.html to work when button has a default color 2017-08-02 04:57:17 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P5 Minor --- 1 mcatanzaro Ms2ger bugs-noreply commit-queue darin Ms2ger oldest_to_newest 1329883 0 mcatanzaro 2017-07-17 21:58:49 -0700 Layout test fast/forms/content-with-margins-inside-button.html is failing for GTK since, most likely, r217674 ("[GTK] Bump GTK+ and its dependencies in jhbuild"). However it cannot be simply rebaselined since it is a reftest. The text color inside the button no longer matches. Updating expectations accordingly. 1333692 1 316838 Ms2ger 2017-08-01 03:03:35 -0700 Created attachment 316838 Patch 1333761 2 darin 2017-08-01 08:49:47 -0700 I don’t wish to be pedantic, but I believe that a bug like this one should not have the [GTK] prefix. We try to use those prefixes for changes that are truly specific to a particular port, changes that can’t possibly affect other ports, as opposed to patches that are motivated by a problem that shows only on one port, but are changes to cross-platform code. 1333820 3 316838 commit-queue 2017-08-01 09:42:21 -0700 Comment on attachment 316838 Patch Clearing flags on attachment: 316838 Committed r220104: <http://trac.webkit.org/changeset/220104> 1333821 4 commit-queue 2017-08-01 09:42:23 -0700 All reviewed patches have been landed. Closing bug. 1334195 5 Ms2ger 2017-08-02 04:57:17 -0700 (In reply to Darin Adler from comment #2) > I don’t wish to be pedantic, but I believe that a bug like this one should > not have the [GTK] prefix. We try to use those prefixes for changes that are > truly specific to a particular port, changes that can’t possibly affect > other ports, as opposed to patches that are motivated by a problem that > shows only on one port, but are changes to cross-platform code. Agreed; changed the summary to match what I did. 316838 2017-08-01 03:03:35 -0700 2017-08-01 09:42:21 -0700 Patch bug-174610-20170801120334.patch text/plain 3668 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMDU0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTEyYTBhNGUwZjkyNzU0NGU1NTNk NzU0ZTc0YjkwNzVhODBlYWIwNS4uYjc5ZTMyMjU2Njg2ZmQzM2NhODk0MmJmNTE1YjUyNDg5MzZm M2MyNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE3LTA4LTAxICBNczJnZXIgIDxNczJnZXJA aWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBMYXlvdXQgdGVzdCBmYXN0L2Zvcm1zL2NvbnRl bnQtd2l0aC1tYXJnaW5zLWluc2lkZS1idXR0b24uaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ2MTAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgYW4gZXhwbGljaXQgdGV4 dCBjb2xvciBmb3IgY29udGVudC13aXRoLW1hcmdpbnMtaW5zaWRlLWJ1dHRvbi5odG1sLgorCisg ICAgICAgIFRoaXMgbWFrZXMgdGhlIHRlc3QgcGFzcyBpbiB0aGUgR1RLIHBvcnQuCisKKyAgICAg ICAgSSBhbHNvIGNoYW5nZWQgdGhlIGZvcm1hdHRpbmcgb2YgdGhlIENTUyB0byBtYWtlIGl0IG1v cmUgcmVhZGFibGUuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2NvbnRlbnQtd2l0aC1tYXJnaW5z LWluc2lkZS1idXR0b24tZXhwZWN0ZWQuaHRtbDoKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2NvbnRl bnQtd2l0aC1tYXJnaW5zLWluc2lkZS1idXR0b24uaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n dGsvVGVzdEV4cGVjdGF0aW9uczoKKworMjAxNy0wOC0wMSAgTXMyZ2VyICA8TXMyZ2VyQGlnYWxp YS5jb20+CisKICAgICAgICAgUmVtb3ZlIG9ic29sZXRlIGV4cGVjdGF0aW9ucyBmb3Igc3ludGF4 LTAyMS54bWwuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04NjE0MgogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2NvbnRlbnQtd2l0 aC1tYXJnaW5zLWluc2lkZS1idXR0b24tZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvY29udGVudC13aXRoLW1hcmdpbnMtaW5zaWRlLWJ1dHRvbi1leHBlY3RlZC5odG1sCmlu ZGV4IDQ0NjIzZWM2MjYxNzA3MjUzNmI4MGFjMmI0YjMzMjdiZGFhYWFhNGMuLjgwY2ZjZjYxMzRm OTZjNDc0M2ZiZWZjYTE5MTQwMjkwY2JhNWI1ZDUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvY29udGVudC13aXRoLW1hcmdpbnMtaW5zaWRlLWJ1dHRvbi1leHBlY3RlZC5odG1s CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvY29udGVudC13aXRoLW1hcmdpbnMtaW5zaWRl LWJ1dHRvbi1leHBlY3RlZC5odG1sCkBAIC02LDcgKzYsMTYgQEAKICAgICBtYXJnaW4tYm90dG9t OiAxMDBweDsKICAgfQogICAKLSAgLm91dGVyIHsgdGV4dC1hbGlnbjpjZW50ZXI7IGZsb2F0OiBs ZWZ0OyBiYWNrZ3JvdW5kLWNvbG9yOiAjY2NjY2NjOyBib3JkZXI6MXB4IHNvbGlkIGJsYWNrOyBw YWRkaW5nOjA7IGZvbnQtZmFtaWx5OiBUaW1lczsgZm9udC1zaXplOjE2cHggfQorICAub3V0ZXIg eworICAgIGZsb2F0OiBsZWZ0OworICAgIGJhY2tncm91bmQtY29sb3I6ICNjY2NjY2M7CisgICAg Ym9yZGVyOiAxcHggc29saWQgYmxhY2s7CisgICAgcGFkZGluZzogMDsKKyAgICBmb250LWZhbWls eTogVGltZXM7CisgICAgZm9udC1zaXplOiAxNnB4OworICAgIGNvbG9yOiBibGFjazsKKyAgICB0 ZXh0LWFsaWduOiBjZW50ZXI7CisgIH0KIDwvc3R5bGU+CiAKLTxkaXYgY2xhc3M9Im91dGVyIj48 ZGl2IGNsYXNzPSJpbm5lciI+Q29udGVudDwvZGl2PjwvYnV0dG9uPgpcIE5vIG5ld2xpbmUgYXQg ZW5kIG9mIGZpbGUKKzxkaXYgY2xhc3M9Im91dGVyIj48ZGl2IGNsYXNzPSJpbm5lciI+Q29udGVu dDwvZGl2PjwvYnV0dG9uPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9jb250 ZW50LXdpdGgtbWFyZ2lucy1pbnNpZGUtYnV0dG9uLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL2NvbnRlbnQtd2l0aC1tYXJnaW5zLWluc2lkZS1idXR0b24uaHRtbAppbmRleCBkMmY2YWI0 ODNhMTU1YjBhMjgyMTQ0YTA3NGM1YzUzYTczYmU1YWNkLi5jZDkxMzJjNDk4ZjhhNDZiNDMyYTk1 ZDJkOTkyNzU3YjM0YTllNjczIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2Nv bnRlbnQtd2l0aC1tYXJnaW5zLWluc2lkZS1idXR0b24uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2Zvcm1zL2NvbnRlbnQtd2l0aC1tYXJnaW5zLWluc2lkZS1idXR0b24uaHRtbApAQCAtNiw3 ICs2LDE2IEBACiAgICAgbWFyZ2luLWJvdHRvbTogMTAwcHg7CiAgIH0KICAgCi0gIGJ1dHRvbiB7 IGZsb2F0OmxlZnQ7IG1hcmdpbjowOyBiYWNrZ3JvdW5kLWNvbG9yOiAjY2NjY2NjOyBib3JkZXI6 MXB4IHNvbGlkIGJsYWNrOyBwYWRkaW5nOjA7IGZvbnQtZmFtaWx5OiBUaW1lczsgZm9udC1zaXpl OjE2cHggfQorICBidXR0b24geworICAgIGZsb2F0OiBsZWZ0OworICAgIGJhY2tncm91bmQtY29s b3I6ICNjY2NjY2M7CisgICAgYm9yZGVyOiAxcHggc29saWQgYmxhY2s7CisgICAgcGFkZGluZzog MDsKKyAgICBmb250LWZhbWlseTogVGltZXM7CisgICAgZm9udC1zaXplOiAxNnB4OworICAgIGNv bG9yOiBibGFjazsKKyAgICBtYXJnaW46IDA7CisgIH0KIDwvc3R5bGU+CiAKLTxidXR0b24+PGRp dj5Db250ZW50PC9kaXY+PC9idXR0b24+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorPGJ1 dHRvbj48ZGl2PkNvbnRlbnQ8L2Rpdj48L2J1dHRvbj4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYmQyZmVkZGM5NWUxMTk0NGM3ZjQzNzFiN2MzZDgzZTE0 MzIwYmRlZS4uMjhlMTlmMmFhMWRlNTNmMGVkOThiNWJkZjg4ZDVlNWU2NzE5NjdmMCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM0MDksOCArMzQwOSw2 IEBAIHdlYmtpdC5vcmcvYi8xNzQ0NjEgaW5zcGVjdG9yL2NhbnZhcy9yZXF1ZXN0Q29udGVudC13 ZWJnbC5odG1sIFsgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xNzQ2MDkgYWNjZXNzaWJpbGl0 eS9wcmVzZW50YXRpb24tcm9sZS1pZnJhbWUuaHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3Jn L2IvMTc0NjEwIGZhc3QvZm9ybXMvY29udGVudC13aXRoLW1hcmdpbnMtaW5zaWRlLWJ1dHRvbi5o dG1sIFsgRmFpbHVyZSBdCi0KICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiAjIEVu ZCBvZiBub24tY3Jhc2hpbmcsIG5vbi1mbGFreSB0ZXN0cyBmYWlsaW5nCiAjLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLwo=