17458 2008-02-20 13:42:49 -0800 Bug in 3d-cube SunSpider test (also in Jetstream2) 2020-11-30 16:01:12 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 1 jresig mjs brendan gavin.sharp mjs oliver saam seth.gaurav oldest_to_newest 71299 0 jresig 2008-02-20 13:42:49 -0800 There's a minor bug in the test which allows variables to leak into the global scope. Please see the attached patch. 71301 1 19238 jresig 2008-02-20 13:43:31 -0800 Created attachment 19238 3d-cube.js patch 71468 2 19238 ap 2008-02-21 22:24:12 -0800 Comment on attachment 19238 3d-cube.js patch I assume this was meant for review; marking as such. 72531 3 19238 darin 2008-03-02 18:43:56 -0800 Comment on attachment 19238 3d-cube.js patch This change looks right to me. But Maciej should really be the one to review it. 100853 4 19238 eric 2008-12-01 12:28:15 -0800 Comment on attachment 19238 3d-cube.js patch This bug doesn't need to sit in the review queue. Maciej knows of the issue. Sitting in the review queue for the next 10 months isn't going to solve the issue. :) Maciej has noted reviewing this patch is blocked on other issues with sunspider distribution. 194602 5 mjs 2010-02-28 14:24:00 -0800 This bug doesn't seem to affect the correctness of the result. Saving for SunSpider 2.0. 1710074 6 mjs 2020-11-25 13:44:21 -0800 Saam, can you take a look at this? Worth fixing for the next JS2 update? 1710837 7 saam 2020-11-30 16:01:12 -0800 (In reply to Maciej Stachowiak from comment #6) > Saam, can you take a look at this? Worth fixing for the next JS2 update? I've noticed this before. And it's very possible we've done things to make this faster. It's not quite obvious to me what the purpose of that loop is in general, especially if we switch to using `new`, none of those objects will be pointed to by anything. A sufficiently smart compiler could omit those allocations. 19238 2008-02-20 13:43:31 -0800 2010-06-10 21:04:07 -0700 3d-cube.js patch 3d-cube.patch text/plain 464 jresig SW5kZXg6IHRlc3RzLzNkLWN1YmUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdGVzdHMvM2QtY3ViZS5qcwko cmV2aXNpb24gMzA0MjkpCisrKyB0ZXN0cy8zZC1jdWJlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0z MDksNyArMzA5LDcgQEAKICAgCiAgIC8vIGNyZWF0ZSBsaW5lIHBpeGVscwogICBRLk51bVB4ID0g OSAqIDIgKiBDdWJlU2l6ZTsKLSAgZm9yICh2YXIgaSA9IDA7IGkgPCBRLk51bVB4OyBpKyspIENy ZWF0ZVAoMCwwLDApOworICBmb3IgKHZhciBpID0gMDsgaSA8IFEuTnVtUHg7IGkrKykgbmV3IENy ZWF0ZVAoMCwwLDApOwogICAKICAgTVRyYW5zID0gVHJhbnNsYXRlKE1UcmFucywgT3JpZ2luLlZb MF0sIE9yaWdpbi5WWzFdLCBPcmlnaW4uVlsyXSk7CiAgIE1RdWJlID0gTU11bHRpKE1UcmFucywg TVF1YmUpOwo=