174564 2017-07-16 06:55:29 -0700 click event does not dispatch to parent when child target stops hit testing after mousedown 2017-07-17 12:14:17 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174565 1 graouts cdumez bfulgham cdumez commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1329375 0 315605 graouts 2017-07-16 06:55:29 -0700 Created attachment 315605 Testcase See the attached test case. It has a <div> with a child <div>, both the parent and the child have the same initial, overlapping bounds. The parent shows an alert when receiving a "click" event, the child shrinks itself to 25% of its size using a "transform: scale(25%)" style when the ":active" pseudo-class matches. If you click in the center of the parent, the "click" event is dispatched. If you click on the left, top, right or bottom of the parent, there is no "click" event dispatched, seemingly because the original event target, the child, is no longer hit-testing by the time the mouse pointer is released. Firefox behaves the same as WebKit, but Chrome dispatches the "click" event in all cases, which seems correct to me. 1329376 1 webkit-bug-importer 2017-07-16 06:55:51 -0700 <rdar://problem/33340234> 1329379 2 graouts 2017-07-16 07:00:11 -0700 This causes https://bugs.webkit.org/show_bug.cgi?id=174565. 1329383 3 graouts 2017-07-16 07:29:31 -0700 If/when this gets fixed, we should remove the workaround for https://bugs.webkit.org/show_bug.cgi?id=174565. 1329482 4 simon.fraser 2017-07-16 21:25:55 -0700 So the question is whether :active style is applied before or after the click? :active applies at mouseDown time, and click fires after mouseDown/mouseUp, so I think our behavior is correct. 1329585 5 cdumez 2017-07-17 09:59:09 -0700 In EventHandler::handleMouseReleaseEvent(const PlatformMouseEvent&), we end up with targetNodeForClickEvent() with a mousePressNode being the child and a mouseReleaseNode being the parent node. The logic inside targetNodeForClickEvent() returns nullptr in this case so we do not fire a click event. It sounds like we would want to fire the click event at the mouseReleaseNode instead? I'll look up the spec and check the blink code as well. 1329586 6 cdumez 2017-07-17 10:02:26 -0700 From https://w3c.github.io/uievents/: """ Each implementation will determine the appropriate hysteresis tolerance, but in general SHOULD fire click and dblclick events when the event target of the associated mousedown and mouseup events is the same element with no mouseout or mouseleave events intervening, and SHOULD fire click and dblclick events on the nearest common inclusive ancestor when the associated mousedown and mouseup event targets are different. """ So it sounds like we are supposed to fire the click event at the nearest common ancestor. In the test case, that would be the parent node. 1329608 7 315677 cdumez 2017-07-17 10:50:34 -0700 Created attachment 315677 Patch 1329657 8 315677 commit-queue 2017-07-17 12:14:15 -0700 Comment on attachment 315677 Patch Clearing flags on attachment: 315677 Committed r219568: <http://trac.webkit.org/changeset/219568> 1329658 9 commit-queue 2017-07-17 12:14:17 -0700 All reviewed patches have been landed. Closing bug. 315605 2017-07-16 06:55:29 -0700 2017-07-16 06:55:29 -0700 Testcase click-event.html text/html 433 graouts CjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CgogICAgZGl2IHsKICAgICAg ICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAgICAgdG9wOiAwOwogICAgICAgIGxlZnQ6IDA7CiAg ICAgICAgd2lkdGg6IDEwMCU7CiAgICAgICAgaGVpZ2h0OiAxMDAlOwogICAgfQogICAgCiAgICAu YnV0dG9uIHsKICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOwogICAgfQoKICAgIC5pY29u IHsKICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibGFjazsKICAgIH0KCiAgICAuYnV0dG9uOmFj dGl2ZSAuaWNvbiB7CiAgICAgICAgdHJhbnNmb3JtOiBzY2FsZSgwLjI1KTsKICAgIH0KICAgIAo8 L3N0eWxlPgo8ZGl2IGNsYXNzPSJidXR0b24iIG9uY2xpY2s9ImFsZXJ0KCdjbGlja2VkJykiPgog ICAgPGRpdiBjbGFzcz0iaWNvbiI+PC9kaXY+CjwvZGl2Pg== 315677 2017-07-17 10:50:34 -0700 2017-07-17 12:14:15 -0700 Patch bug-174564-20170717105120.patch text/plain 6492 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWM0MWNiMGNmY2Q3YWNj ODUzZmFhMTNkYjRhNTNkYWZlMzc1NGUzMy4uZDA1YTQzZjI2ZTJiOTZhZjcxOTg4NmFjOGUyZmI4 NjI5NzhlZjllNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA3LTE3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgY2xpY2sgZXZlbnQgZG9lcyBu b3QgZGlzcGF0Y2ggdG8gcGFyZW50IHdoZW4gY2hpbGQgdGFyZ2V0IHN0b3BzIGhpdCB0ZXN0aW5n IGFmdGVyIG1vdXNlZG93bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc0NTY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMzM0MDIzND4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBwZXIgWzFdLCBp ZiB0aGUgbW91c2UgZG93biBub2RlIGFuZCB0aGUgbW91c2UgcmVsZWFzZSBub2RlIGRpZmZlciwg dGhlbiB3ZSBhcmUgc3VwcG9zZWQgdG8KKyAgICAgICAgZmlyZSB0aGUgY2xpY2sgZXZlbnQgYXQg dGhlaXIgY29tbW9uIGFuY2VzdG9yLCBpZiBzdWNoIG5vZGUgZXhpc3RzLiBUaGlzIHBhdGNoIGlt cGxlbWVudHMgdGhpcworICAgICAgICBsb2dpYy4gVGhpcyBhbHNvIGFsaWducyBvdXIgYmVoYXZp b3Igd2l0aCBCbGluay4KKworICAgICAgICBbMV0gaHR0cHM6Ly93M2MuZ2l0aHViLmlvL3VpZXZl bnRzLyNldmVudHMtbW91c2VldmVudC1ldmVudC1vcmRlcgorCisgICAgICAgIFRlc3Q6IGZhc3Qv ZXZlbnRzL21vdXNlLWNsaWNrLWRpZmZlcmVudC1tb3VzZURvd24tbW91c2VVcC1ub2Rlcy5odG1s CisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0 YXJnZXROb2RlRm9yQ2xpY2tFdmVudCk6CisKIDIwMTctMDctMTcgIEtvbnN0YW50aW4gVG9rYXJl diAgPGFubnVsZW5AeWFuZGV4LnJ1PgogCiAgICAgICAgIFtDTWFrZV0gQ3JlYXRlIHRhcmdldHMg YmVmb3JlIFdFQktJVF9JTkNMVURFX0NPTkZJR19GSUxFU19JRl9FWElTVFMgaXMgY2FsbGVkCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggZTk3ODQyOTgwZDUxOTNjZGRmY2M2 M2JkMDY3ODk5NzRjOWE1NjdkMC4uNjE3YjMyNWEzMGNkNzdlODY1OGNmMjJjNWM0ZDE1Y2I5NjAy MjBmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtNzAsNiArNzAsNyBA QAogI2luY2x1ZGUgIlBsYXRmb3JtS2V5Ym9hcmRFdmVudC5oIgogI2luY2x1ZGUgIlBsYXRmb3Jt V2hlZWxFdmVudC5oIgogI2luY2x1ZGUgIlBsdWdpbkRvY3VtZW50LmgiCisjaW5jbHVkZSAiUmFu Z2UuaCIKICNpbmNsdWRlICJSZW5kZXJGcmFtZVNldC5oIgogI2luY2x1ZGUgIlJlbmRlckxheWVy LmgiCiAjaW5jbHVkZSAiUmVuZGVyTGlzdEJveC5oIgpAQCAtMTk5OSw2ICsyMDAwLDEyIEBAIHN0 YXRpYyBOb2RlKiB0YXJnZXROb2RlRm9yQ2xpY2tFdmVudChOb2RlKiBtb3VzZVByZXNzTm9kZSwg Tm9kZSogbW91c2VSZWxlYXNlTm9kCiAgICAgaWYgKG1vdXNlUHJlc3NOb2RlID09IG1vdXNlUmVs ZWFzZU5vZGUpCiAgICAgICAgIHJldHVybiBtb3VzZVJlbGVhc2VOb2RlOwogCisgICAgLy8gSWYg bW91c2VQcmVzc05vZGUgYW5kIG1vdXNlUmVsZWFzZU5vZGUgZGlmZmVyLCB3ZSBzaG91bGQgZmly ZSB0aGUgZXZlbnQgYXQgdGhlaXIgY29tbW9uIGFuY2VzdG9yIGlmIHRoZXJlIGlzIG9uZS4KKyAg ICBpZiAoJm1vdXNlUHJlc3NOb2RlLT5kb2N1bWVudCgpID09ICZtb3VzZVJlbGVhc2VOb2RlLT5k b2N1bWVudCgpKSB7CisgICAgICAgIGlmIChhdXRvKiBjb21tb25BbmNlc3RvciA9IFJhbmdlOjpj b21tb25BbmNlc3RvckNvbnRhaW5lcihtb3VzZVByZXNzTm9kZSwgbW91c2VSZWxlYXNlTm9kZSkp CisgICAgICAgICAgICByZXR1cm4gY29tbW9uQW5jZXN0b3I7CisgICAgfQorCiAgICAgRWxlbWVu dCogbW91c2VSZWxlYXNlU2hhZG93SG9zdCA9IG1vdXNlUmVsZWFzZU5vZGUtPnNoYWRvd0hvc3Qo KTsKICAgICBpZiAobW91c2VSZWxlYXNlU2hhZG93SG9zdCAmJiBtb3VzZVJlbGVhc2VTaGFkb3dI b3N0ID09IG1vdXNlUHJlc3NOb2RlLT5zaGFkb3dIb3N0KCkpIHsKICAgICAgICAgLy8gV2Ugd2Fu dCB0byBkaXNwYXRjaCB0aGUgY2xpY2sgdG8gdGhlIHNoYWRvdyB0cmVlIGhvc3QgZWxlbWVudCB0 byBnaXZlIGxpc3RlbmVycyB0aGUgaWxsdXNpb24gdGhhdCB0aGUKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlZDI5MmEwM2Fk MTZjNzYwNTgxNGQwNmI0YmRhNTIwMDc2NTAzZDVjLi5mYmJkNWZhMDc2MGI4MzM2YjExNDJkNTVh MDFjOGNlNGJmMzAxYWFhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDctMTcgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBjbGljayBldmVudCBkb2VzIG5v dCBkaXNwYXRjaCB0byBwYXJlbnQgd2hlbiBjaGlsZCB0YXJnZXQgc3RvcHMgaGl0IHRlc3Rpbmcg YWZ0ZXIgbW91c2Vkb3duCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzQ1NjQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMzMzQwMjM0PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBsYXlvdXQgdGVz dCBjb3ZlcmFnZS4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL21vdXNlLWNsaWNrLWRpZmZlcmVu dC1tb3VzZURvd24tbW91c2VVcC1ub2Rlcy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGZhc3QvZXZlbnRzL21vdXNlLWNsaWNrLWRpZmZlcmVudC1tb3VzZURvd24tbW91c2VVcC1ub2Rl cy5odG1sOiBBZGRlZC4KKwogMjAxNy0wNy0xNyAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBw bGUuY29tPgogCiAgICAgICAgIE1lZGlhIGNvbnRyb2xzIGRyYXcgYmVoaW5kIGNhcHRpb25zCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tb3VzZS1jbGljay1kaWZmZXJlbnQt bW91c2VEb3duLW1vdXNlVXAtbm9kZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9l dmVudHMvbW91c2UtY2xpY2stZGlmZmVyZW50LW1vdXNlRG93bi1tb3VzZVVwLW5vZGVzLWV4cGVj dGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi5lOTZjMTVhOTE3MTEwYzA0MjdmZTU5MjQ1NzA3NDAyZGZkNWIw YjQwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvbW91c2UtY2xp Y2stZGlmZmVyZW50LW1vdXNlRG93bi1tb3VzZVVwLW5vZGVzLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDExIEBACitUZXN0cyB0aGF0IHRoZSBjbGljayBldmVudCBpcyBmaXJlZCBhdCB0aGUgY29t bW9uIGFuY2VzdG9yIGlmIHRoZSBtb3VzZURvd24gLyBtb3VzZVVwIG5vZGVzIGRpZmZlci4KKwor T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgcGFyZW50R290Q2xpY2tFdmVudCBp cyB0cnVlCitQQVNTIGNoaWxkR290Q2xpY2tFdmVudCBpcyBmYWxzZQorUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvZXZlbnRzL21vdXNlLWNsaWNrLWRpZmZlcmVudC1tb3VzZURvd24tbW91c2VVcC1u b2Rlcy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvbW91c2UtY2xpY2stZGlmZmVyZW50 LW1vdXNlRG93bi1tb3VzZVVwLW5vZGVzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZWNjYmIxYjQwNTFhNzBl YjYzZjY1NDk2NGRkZjdjMzhkZjk5ZjU4OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvZXZlbnRzL21vdXNlLWNsaWNrLWRpZmZlcmVudC1tb3VzZURvd24tbW91c2VVcC1ub2Rl cy5odG1sCkBAIC0wLDAgKzEsNjEgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4K KzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c3R5 bGU+CisgICAgZGl2IHsKKyAgICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgICB0b3A6 IDA7CisgICAgICAgIGxlZnQ6IDA7CisgICAgICAgIHdpZHRoOiAxMDAlOworICAgICAgICBoZWln aHQ6IDEwMCU7CisgICAgfQorCisgICAgLmJ1dHRvbiB7CisgICAgICAgIGJhY2tncm91bmQtY29s b3I6IGJsdWU7CisgICAgfQorCisgICAgLmljb24geworICAgICAgICBiYWNrZ3JvdW5kLWNvbG9y OiBibGFjazsKKyAgICB9CisKKyAgICAuYnV0dG9uOmFjdGl2ZSAuaWNvbiB7CisgICAgICAgIHRy YW5zZm9ybTogc2NhbGUoMC4yNSk7CisgICAgfQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5Pgor PGRpdiBpZD0icGFyZW50RGl2IiBjbGFzcz0iYnV0dG9uIiBvbmNsaWNrPSJhbGVydCgnY2xpY2tl ZCcpIj4KKyAgICA8ZGl2IGlkPSJjaGlsZERpdiIgY2xhc3M9Imljb24iPjwvZGl2PgorPC9kaXY+ Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3RzIHRoYXQgdGhlIGNsaWNrIGV2ZW50IGlzIGZp cmVkIGF0IHRoZSBjb21tb24gYW5jZXN0b3IgaWYgdGhlIG1vdXNlRG93biAvIG1vdXNlVXAgbm9k ZXMgZGlmZmVyLiIpOworanNUZXN0SXNBc3luYyA9IHRydWU7CisKK3BhcmVudEdvdENsaWNrRXZl bnQgPSBmYWxzZTsKK2NoaWxkR290Q2xpY2tFdmVudCA9IGZhbHNlOworCitkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgicGFyZW50RGl2Iikub25jbGljayA9IGZ1bmN0aW9uKCkgeworICAgIHBhcmVu dEdvdENsaWNrRXZlbnQgPSB0cnVlOworfTsKKworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNo aWxkRGl2Iikub25jbGljayA9IGZ1bmN0aW9uKCkgeworICAgIGNoaWxkR290Q2xpY2tFdmVudCA9 IHRydWU7Cit9OworCitvbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICBpZiAod2luZG93LmV2ZW50 U2VuZGVyKSB7CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDEwLCAzMDApOworICAg ICAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICAgICAgZXZlbnRTZW5kZXIubW91c2VV cCgpOyAgICAKKyAgICB9CisKKyAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAgICAgICBz aG91bGRCZVRydWUoInBhcmVudEdvdENsaWNrRXZlbnQiKTsKKyAgICAgICAgc2hvdWxkQmVGYWxz ZSgiY2hpbGRHb3RDbGlja0V2ZW50Iik7CisgICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAgIH0s IDApOworfQorPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9pb3MvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2lvcy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDk3M2Q1ZWFlOTQwN2JmNzZkOTAzNzE1MjJkYjVk ZTNjMjFmMjkwMmQuLjZiZTdjNDA4YWM0ZGExZWNiMjAzNGQ0ODQ0ZDIxOTJkZDc4ZmJjNDIgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zCisrKyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zCkBAIC0zODcsNiArMzg3 LDcgQEAgZmFzdC9mb3Jtcy9yYW5nZS9kaXNhYmxlZC13aGlsZS1kcmFnZ2luZy5odG1sIFsgU2tp cCBdCiBmYXN0L2Zvcm1zL3JhbmdlL3JhbmdlLWRyYWctd2hlbi10b2dnbGVkLWRpc2FibGVkLmh0 bWwgWyBTa2lwIF0KIGZhc3QvbWVkaWEvdmlkZW8tZWxlbWVudC1pbi1kZXRhaWxzLWNvbGxhcHNl Lmh0bWwgWyBTa2lwIF0KIGZhc3QvZnJhbWVzL3VzZXItZ2VzdHVyZS10aW1lc3RhbXAtcHJvcGFn YXRpb24uaHRtbCBbIEZhaWx1cmUgXQorZmFzdC9ldmVudHMvbW91c2UtY2xpY2stZGlmZmVyZW50 LW1vdXNlRG93bi1tb3VzZVVwLW5vZGVzLmh0bWwgWyBTa2lwIF0KIAogIyBUaGUgZmlsZS13cmFw cGVyIHBhcnQgb2YgPGF0dGFjaG1lbnQ+IGlzIG5vdCB5ZXQgd29ya2luZyBvbiBpT1MKIGZhc3Qv YXR0YWNobWVudC9hdHRhY2htZW50LXR5cGUtYXR0cmlidXRlLmh0bWwgWyBTa2lwIF0K