174530 2017-07-14 14:46:57 -0700 Add performance.mark()s around Speedometer test steps 2017-07-18 16:22:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mattkot webkit-unassigned buildbot cdumez commit-queue rniwa oldest_to_newest 1329024 0 mattkot 2017-07-14 14:46:57 -0700 Add performance.mark()s around Speedometer test steps 1330021 1 315805 mattkot 2017-07-18 10:39:48 -0700 Created attachment 315805 Patch 1330035 2 315805 rniwa 2017-07-18 11:42:08 -0700 Comment on attachment 315805 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315805&action=review Thanks for the patch. > PerformanceTests/ChangeLog:8 > + https://bugs.webkit.org/show_bug.cgi?id=174530 This URL should appear right below the it title. > PerformanceTests/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). Followed by this line, and then the long description you have above. See other entries for the format. > PerformanceTests/Speedometer/resources/benchmark-runner.js:116 > + if (window.performance && window.performance.mark) { window.performance.mark(name); } Please put the call to mark in a separate line with an indentation but without curly braces to match the WebKit coding style. > PerformanceTests/Speedometer/resources/benchmark-runner.js:252 > + self._runTest(`${suite.name}.${test.name}`, suite, test.run, self._prepareReturnValue, function (syncTime, asyncTime) { I think it’s cleaner to pass in the test object, and construct the string in _runTrst function. 1330120 3 315838 mattkot 2017-07-18 14:26:01 -0700 Created attachment 315838 Patch 1330190 4 315838 commit-queue 2017-07-18 16:22:50 -0700 Comment on attachment 315838 Patch Clearing flags on attachment: 315838 Committed r219640: <http://trac.webkit.org/changeset/219640> 1330191 5 commit-queue 2017-07-18 16:22:51 -0700 All reviewed patches have been landed. Closing bug. 315805 2017-07-18 10:39:48 -0700 2017-07-18 14:26:00 -0700 Patch bug-174530-20170718103947.patch text/plain 3296 mattkot U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NjMwCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDI4Y2I5NzMxZjQ1 Y2I0MDA4Y2M5NDBlYmFlYjE0M2JiOTE2NWZkYWMuLjIyMDIxNTNmYTUyZjVmNGU2NzMyNTJiMTU5 MDhkOTk0OTUxODA4ZjkgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTctMDct MTQgIE1hdHQgS290c2VuYXMgIDxtYXR0a290QG1pY3Jvc29mdC5jb20+CisKKyAgICAgICAgQWRk IHBlcmZvcm1hbmNlLm1hcmsoKXMgYXJvdW5kIGVhY2ggdGVzdCBzdGVwCisKKyAgICAgICAgQWRk IGBwZXJmb3JtYW5jZS5tYXJrKClgIGFyb3VuZCBlYWNoIHRlc3Qgc3RlcCB0byBtYWtlIGFuYWx5 c2lzCisgICAgICAgIHNpbXBsZXIuIE5vdyBlYWNoIHRlc3Qgc3RlcCBjYW4gYmUgaW52ZXN0aWdh dGVkIHZpYSBkZXYgdG9vbHMsIEVUVywgZXRjLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ1MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNwZWVkb21ldGVyL3Jlc291cmNlcy9iZW5jaG1hcmst cnVubmVyLmpzOgorICAgICAgICAoQmVuY2htYXJrUnVubmVyLnByb3RvdHlwZS5fd3JpdGVNYXJr KToKKyAgICAgICAgKEJlbmNobWFya1J1bm5lci5wcm90b3R5cGUuX3J1blRlc3QpOgorICAgICAg ICAoQmVuY2htYXJrUnVubmVyLnByb3RvdHlwZS5fcnVuVGVzdEFuZFJlY29yZFJlc3VsdHMpOgor CiAyMDE3LTA2LTEwICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2ZXJ0ZWQgcjIxODA1NiBiZWNhdXNlIGl0IG1hZGUgdGhlIElERSByZWluZGV4IGNvbnN0YW50 bHkuCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy9i ZW5jaG1hcmstcnVubmVyLmpzIGIvUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9tZXRlci9yZXNvdXJj ZXMvYmVuY2htYXJrLXJ1bm5lci5qcwppbmRleCA1NWJkNTcwMzlkOTBjYmMwNjRkYmVhNTc4ZDM5 Njk5MDhmNzBkMzBlLi4xNTdiMDgwYjZmYmQwZDMyZTY4NWU3NGJmMWMxNGI0Y2I0MDMyOGM3IDEw MDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy9iZW5jaG1h cmstcnVubmVyLmpzCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2Vz L2JlbmNobWFyay1ydW5uZXIuanMKQEAgLTExMiwyMiArMTEyLDMxIEBAIEJlbmNobWFya1J1bm5l ci5wcm90b3R5cGUuX3dhaXRBbmRXYXJtVXAgPSBmdW5jdGlvbiAoKSB7CiAgICAgcmV0dXJuIHBy b21pc2U7CiB9CiAKK0JlbmNobWFya1J1bm5lci5wcm90b3R5cGUuX3dyaXRlTWFyayA9IGZ1bmN0 aW9uKG5hbWUpIHsKKyAgICBpZiAod2luZG93LnBlcmZvcm1hbmNlICYmIHdpbmRvdy5wZXJmb3Jt YW5jZS5tYXJrKSB7IHdpbmRvdy5wZXJmb3JtYW5jZS5tYXJrKG5hbWUpOyB9Cit9CisKIC8vIFRo aXMgZnVuY3Rpb24gb3VnaHQgYmUgYXMgc2ltcGxlIGFzIHBvc3NpYmxlLiBEb24ndCBldmVuIHVz ZSBTaW1wbGVQcm9taXNlLgotQmVuY2htYXJrUnVubmVyLnByb3RvdHlwZS5fcnVuVGVzdCA9IGZ1 bmN0aW9uKHN1aXRlLCB0ZXN0RnVuY3Rpb24sIHByZXBhcmVSZXR1cm5WYWx1ZSwgY2FsbGJhY2sp CitCZW5jaG1hcmtSdW5uZXIucHJvdG90eXBlLl9ydW5UZXN0ID0gZnVuY3Rpb24odGVzdExhYmVs LCBzdWl0ZSwgdGVzdEZ1bmN0aW9uLCBwcmVwYXJlUmV0dXJuVmFsdWUsIGNhbGxiYWNrKQogewor ICAgIHZhciBzZWxmID0gdGhpczsKICAgICB2YXIgbm93ID0gd2luZG93LnBlcmZvcm1hbmNlICYm IHdpbmRvdy5wZXJmb3JtYW5jZS5ub3cgPyBmdW5jdGlvbiAoKSB7IHJldHVybiB3aW5kb3cucGVy Zm9ybWFuY2Uubm93KCk7IH0gOiBEYXRlLm5vdzsKIAotICAgIHZhciBjb250ZW50V2luZG93ID0g dGhpcy5fZnJhbWUuY29udGVudFdpbmRvdzsKLSAgICB2YXIgY29udGVudERvY3VtZW50ID0gdGhp cy5fZnJhbWUuY29udGVudERvY3VtZW50OworICAgIHZhciBjb250ZW50V2luZG93ID0gc2VsZi5f ZnJhbWUuY29udGVudFdpbmRvdzsKKyAgICB2YXIgY29udGVudERvY3VtZW50ID0gc2VsZi5fZnJh bWUuY29udGVudERvY3VtZW50OwogCisgICAgc2VsZi5fd3JpdGVNYXJrKGAke3Rlc3RMYWJlbH0t c3RhcnRgKTsKICAgICB2YXIgc3RhcnRUaW1lID0gbm93KCk7CiAgICAgdGVzdEZ1bmN0aW9uKHBy ZXBhcmVSZXR1cm5WYWx1ZSwgY29udGVudFdpbmRvdywgY29udGVudERvY3VtZW50KTsKICAgICB2 YXIgZW5kVGltZSA9IG5vdygpOworICAgIHNlbGYuX3dyaXRlTWFyayhgJHt0ZXN0TGFiZWx9LXN5 bmMtZW5kYCk7CisKICAgICB2YXIgc3luY1RpbWUgPSBlbmRUaW1lIC0gc3RhcnRUaW1lOwogCiAg ICAgdmFyIHN0YXJ0VGltZSA9IG5vdygpOwogICAgIHNldFRpbWVvdXQoZnVuY3Rpb24gKCkgewog ICAgICAgICB2YXIgZW5kVGltZSA9IG5vdygpOworICAgICAgICBzZWxmLl93cml0ZU1hcmsoYCR7 dGVzdExhYmVsfS1hc3luYy1lbmRgKTsKICAgICAgICAgY2FsbGJhY2soc3luY1RpbWUsIGVuZFRp bWUgLSBzdGFydFRpbWUpOwogICAgIH0sIDApOwogfQpAQCAtMjQwLDcgKzI0OSw3IEBAIEJlbmNo bWFya1J1bm5lci5wcm90b3R5cGUuX3J1blRlc3RBbmRSZWNvcmRSZXN1bHRzID0gZnVuY3Rpb24g KHN0YXRlKSB7CiAKICAgICB2YXIgc2VsZiA9IHRoaXM7CiAgICAgc2V0VGltZW91dChmdW5jdGlv biAoKSB7Ci0gICAgICAgIHNlbGYuX3J1blRlc3Qoc3VpdGUsIHRlc3QucnVuLCBzZWxmLl9wcmVw YXJlUmV0dXJuVmFsdWUsIGZ1bmN0aW9uIChzeW5jVGltZSwgYXN5bmNUaW1lKSB7CisgICAgICAg IHNlbGYuX3J1blRlc3QoYCR7c3VpdGUubmFtZX0uJHt0ZXN0Lm5hbWV9YCwgc3VpdGUsIHRlc3Qu cnVuLCBzZWxmLl9wcmVwYXJlUmV0dXJuVmFsdWUsIGZ1bmN0aW9uIChzeW5jVGltZSwgYXN5bmNU aW1lKSB7CiAgICAgICAgICAgICB2YXIgc3VpdGVSZXN1bHRzID0gc2VsZi5fbWVhc3VyZWRWYWx1 ZXMudGVzdHNbc3VpdGUubmFtZV0gfHwge3Rlc3RzOnt9LCB0b3RhbDogMH07CiAgICAgICAgICAg ICB2YXIgdG90YWwgPSBzeW5jVGltZSArIGFzeW5jVGltZTsKICAgICAgICAgICAgIHNlbGYuX21l YXN1cmVkVmFsdWVzLnRlc3RzW3N1aXRlLm5hbWVdID0gc3VpdGVSZXN1bHRzOwo= 315838 2017-07-18 14:26:01 -0700 2017-07-18 16:22:50 -0700 Patch bug-174530-20170718142600.patch text/plain 3355 mattkot U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NjMwCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDI4Y2I5NzMxZjQ1 Y2I0MDA4Y2M5NDBlYmFlYjE0M2JiOTE2NWZkYWMuLjUwM2MxZTE5YjkzMGVjNWUyZjM0OTBhMjlh OWMzYzkxZGJlOTg3YTMgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMDct MTQgIE1hdHQgS290c2VuYXMgIDxtYXR0a290QG1pY3Jvc29mdC5jb20+CisKKyAgICAgICAgQWRk IHBlcmZvcm1hbmNlLm1hcmsoKXMgYXJvdW5kIGVhY2ggdGVzdCBzdGVwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ1MzAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYHBlcmZvcm1hbmNlLm1hcmso KWAgYXJvdW5kIGVhY2ggdGVzdCBzdGVwIHRvIG1ha2UgYW5hbHlzaXMKKyAgICAgICAgc2ltcGxl ci4gTm93IGVhY2ggdGVzdCBzdGVwIGNhbiBiZSBpbnZlc3RpZ2F0ZWQgdmlhIGRldiB0b29scywg RVRXLCBldGMuCisKKyAgICAgICAgKiBTcGVlZG9tZXRlci9yZXNvdXJjZXMvYmVuY2htYXJrLXJ1 bm5lci5qczoKKyAgICAgICAgKEJlbmNobWFya1J1bm5lci5wcm90b3R5cGUuX3dyaXRlTWFyayk6 CisgICAgICAgIChCZW5jaG1hcmtSdW5uZXIucHJvdG90eXBlLl9ydW5UZXN0KToKKyAgICAgICAg KEJlbmNobWFya1J1bm5lci5wcm90b3R5cGUuX3J1blRlc3RBbmRSZWNvcmRSZXN1bHRzKToKKwog MjAxNy0wNi0xMCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmVydGVkIHIyMTgwNTYgYmVjYXVzZSBpdCBtYWRlIHRoZSBJREUgcmVpbmRleCBjb25zdGFudGx5 LgpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9tZXRlci9yZXNvdXJjZXMvYmVu Y2htYXJrLXJ1bm5lci5qcyBiL1BlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2Vz L2JlbmNobWFyay1ydW5uZXIuanMKaW5kZXggNTViZDU3MDM5ZDkwY2JjMDY0ZGJlYTU3OGQzOTY5 OTA4ZjcwZDMwZS4uMjJmOTRmYjUxYzZjOTE2YWY5NTk4ZjZlNmJkYmI3YzA5YzRhNGQ5ZiAxMDA2 NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9tZXRlci9yZXNvdXJjZXMvYmVuY2htYXJr LXJ1bm5lci5qcworKysgYi9QZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy9i ZW5jaG1hcmstcnVubmVyLmpzCkBAIC0xMTIsMjIgKzExMiwzMiBAQCBCZW5jaG1hcmtSdW5uZXIu cHJvdG90eXBlLl93YWl0QW5kV2FybVVwID0gZnVuY3Rpb24gKCkgewogICAgIHJldHVybiBwcm9t aXNlOwogfQogCitCZW5jaG1hcmtSdW5uZXIucHJvdG90eXBlLl93cml0ZU1hcmsgPSBmdW5jdGlv bihuYW1lKSB7CisgICAgaWYgKHdpbmRvdy5wZXJmb3JtYW5jZSAmJiB3aW5kb3cucGVyZm9ybWFu Y2UubWFyaykKKyAgICAgICAgd2luZG93LnBlcmZvcm1hbmNlLm1hcmsobmFtZSk7Cit9CisKIC8v IFRoaXMgZnVuY3Rpb24gb3VnaHQgYmUgYXMgc2ltcGxlIGFzIHBvc3NpYmxlLiBEb24ndCBldmVu IHVzZSBTaW1wbGVQcm9taXNlLgotQmVuY2htYXJrUnVubmVyLnByb3RvdHlwZS5fcnVuVGVzdCA9 IGZ1bmN0aW9uKHN1aXRlLCB0ZXN0RnVuY3Rpb24sIHByZXBhcmVSZXR1cm5WYWx1ZSwgY2FsbGJh Y2spCitCZW5jaG1hcmtSdW5uZXIucHJvdG90eXBlLl9ydW5UZXN0ID0gZnVuY3Rpb24oc3VpdGUs IHRlc3QsIHByZXBhcmVSZXR1cm5WYWx1ZSwgY2FsbGJhY2spCiB7CisgICAgdmFyIHNlbGYgPSB0 aGlzOwogICAgIHZhciBub3cgPSB3aW5kb3cucGVyZm9ybWFuY2UgJiYgd2luZG93LnBlcmZvcm1h bmNlLm5vdyA/IGZ1bmN0aW9uICgpIHsgcmV0dXJuIHdpbmRvdy5wZXJmb3JtYW5jZS5ub3coKTsg fSA6IERhdGUubm93OwogCi0gICAgdmFyIGNvbnRlbnRXaW5kb3cgPSB0aGlzLl9mcmFtZS5jb250 ZW50V2luZG93OwotICAgIHZhciBjb250ZW50RG9jdW1lbnQgPSB0aGlzLl9mcmFtZS5jb250ZW50 RG9jdW1lbnQ7CisgICAgdmFyIGNvbnRlbnRXaW5kb3cgPSBzZWxmLl9mcmFtZS5jb250ZW50V2lu ZG93OworICAgIHZhciBjb250ZW50RG9jdW1lbnQgPSBzZWxmLl9mcmFtZS5jb250ZW50RG9jdW1l bnQ7CiAKKyAgICBzZWxmLl93cml0ZU1hcmsoYCR7c3VpdGUubmFtZX0uJHt0ZXN0Lm5hbWV9LXN0 YXJ0YCk7CiAgICAgdmFyIHN0YXJ0VGltZSA9IG5vdygpOwotICAgIHRlc3RGdW5jdGlvbihwcmVw YXJlUmV0dXJuVmFsdWUsIGNvbnRlbnRXaW5kb3csIGNvbnRlbnREb2N1bWVudCk7CisgICAgdGVz dC5ydW4ocHJlcGFyZVJldHVyblZhbHVlLCBjb250ZW50V2luZG93LCBjb250ZW50RG9jdW1lbnQp OwogICAgIHZhciBlbmRUaW1lID0gbm93KCk7CisgICAgc2VsZi5fd3JpdGVNYXJrKGAke3N1aXRl Lm5hbWV9LiR7dGVzdC5uYW1lfS1zeW5jLWVuZGApOworCiAgICAgdmFyIHN5bmNUaW1lID0gZW5k VGltZSAtIHN0YXJ0VGltZTsKIAogICAgIHZhciBzdGFydFRpbWUgPSBub3coKTsKICAgICBzZXRU aW1lb3V0KGZ1bmN0aW9uICgpIHsKICAgICAgICAgdmFyIGVuZFRpbWUgPSBub3coKTsKKyAgICAg ICAgc2VsZi5fd3JpdGVNYXJrKGAke3N1aXRlLm5hbWV9LiR7dGVzdC5uYW1lfS1hc3luYy1lbmRg KTsKICAgICAgICAgY2FsbGJhY2soc3luY1RpbWUsIGVuZFRpbWUgLSBzdGFydFRpbWUpOwogICAg IH0sIDApOwogfQpAQCAtMjQwLDcgKzI1MCw3IEBAIEJlbmNobWFya1J1bm5lci5wcm90b3R5cGUu X3J1blRlc3RBbmRSZWNvcmRSZXN1bHRzID0gZnVuY3Rpb24gKHN0YXRlKSB7CiAKICAgICB2YXIg c2VsZiA9IHRoaXM7CiAgICAgc2V0VGltZW91dChmdW5jdGlvbiAoKSB7Ci0gICAgICAgIHNlbGYu X3J1blRlc3Qoc3VpdGUsIHRlc3QucnVuLCBzZWxmLl9wcmVwYXJlUmV0dXJuVmFsdWUsIGZ1bmN0 aW9uIChzeW5jVGltZSwgYXN5bmNUaW1lKSB7CisgICAgICAgIHNlbGYuX3J1blRlc3Qoc3VpdGUs IHRlc3QsIHNlbGYuX3ByZXBhcmVSZXR1cm5WYWx1ZSwgZnVuY3Rpb24gKHN5bmNUaW1lLCBhc3lu Y1RpbWUpIHsKICAgICAgICAgICAgIHZhciBzdWl0ZVJlc3VsdHMgPSBzZWxmLl9tZWFzdXJlZFZh bHVlcy50ZXN0c1tzdWl0ZS5uYW1lXSB8fCB7dGVzdHM6e30sIHRvdGFsOiAwfTsKICAgICAgICAg ICAgIHZhciB0b3RhbCA9IHN5bmNUaW1lICsgYXN5bmNUaW1lOwogICAgICAgICAgICAgc2VsZi5f bWVhc3VyZWRWYWx1ZXMudGVzdHNbc3VpdGUubmFtZV0gPSBzdWl0ZVJlc3VsdHM7Cg==