174504 2017-07-14 09:10:29 -0700 Marking a directory as [ Pass ] or [ Failure ] or [ Crash ] should not override test-specific expectations 2017-08-28 09:05:42 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 1 jbedard webkit-unassigned jlewis3 lforschler webkit-bug-importer oldest_to_newest 1328786 0 jbedard 2017-07-14 09:10:29 -0700 Currently, when we mark an entire directory as something, we simply recursively mark every test in that directory as Pass/Failure/Crash/Skip. We should be smarter about this, particularly with 'Pass.' For example: TestExpectations: edit/mac [ Skip ] platform/wk2/TestExpectations: edit/mac/some-test.html [ Failure ] # XYZ is not implemented in WK2 platform/mac/TestExpectations: edit/mac [ Pass ] # Now edit/mac/some-test.html is marked as passing This results in 1) duplicated expectations, 2) bugs separated across expectation files and 3) it being difficult to garden tests since platforms frequently mark entire directories as [ Pass ] when those platforms support a feature which their more general parent platform does not. (ie: Mac generally may not support a given feature, but Sierra might). 1328788 1 webkit-bug-importer 2017-07-14 09:11:11 -0700 <rdar://problem/33317289> 1342841 2 jbedard 2017-08-28 09:05:42 -0700 I spoke with Ryan Haddad and Dan Bates about this proposal on 8/25. It seems that what I'm suggesting would not be an improvement over the current behavior. Closing this bug.