174498 2017-07-14 02:51:14 -0700 Web Automation: link and partial link queries don't work if the link contains formatting tags 2017-07-17 00:03:13 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174499 1 cgarcia webkit-unassigned bburg joepeck webkit-bug-importer oldest_to_newest 1328719 0 cgarcia 2017-07-14 02:51:14 -0700 So, for example, if we find links with text "Foo" and there's a link like <a href=""><bA>Foo</b></a> we fail with no such element error. This causes test test_Link_With_Formatting_Tags to fail. ========================================================================================== FAILURES ========================================================================================== _________________________________________________________________________ test_Link_With_Formatting_Tags[WebKitGTK] __________________________________________________________________________ driver = <selenium.webdriver.webkitgtk.webdriver.WebDriver (session="38543e9a-0de3-40ae-9cb8-af4e20f27c58")>, pages = <conftest.Pages object at 0x7fdba75e2490> def test_Link_With_Formatting_Tags(driver, pages): pages.load("simpleTest.html") elem = driver.find_element(By.ID, "links") > res = elem.find_element(By.PARTIAL_LINK_TEXT, "link with formatting tags") E NoSuchElementException: Message: ../selenium/webdriver/remote/errorhandler.py:193: NoSuchElementException I think we could simply use descendant-or-self::text() instead of just text() in the links xpath expressions. 1328720 1 315412 cgarcia 2017-07-14 02:54:00 -0700 Created attachment 315412 Patch 1328759 2 webkit-bug-importer 2017-07-14 08:29:10 -0700 <rdar://problem/33316682> 1328821 3 315412 bburg 2017-07-14 10:02:27 -0700 Comment on attachment 315412 Patch r=me This progresses safaridriver as well. 1329500 4 cgarcia 2017-07-17 00:03:13 -0700 Committed r219555: <http://trac.webkit.org/changeset/219555> 315412 2017-07-14 02:54:00 -0700 2017-07-14 10:02:27 -0700 Patch wk2-find-nodes-links-xpath.diff text/plain 1891 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYTUyZjhlZGUxMzYuLjg4MjJhZjQzNGMzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE4IEBACiAyMDE3LTA3LTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAorICAgICAgICBXZWIgQXV0b21hdGlvbjogbGluayBhbmQgcGFydGlhbCBsaW5rIHF1 ZXJpZXMgZG9uJ3Qgd29yayBpZiB0aGUgbGluayBjb250YWlucyBmb3JtYXR0aW5nIHRhZ3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDQ5OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvLCBmb3IgZXhh bXBsZSwgaWYgd2UgZmluZCBsaW5rcyB3aXRoIHRleHQgIkZvbyIgYW5kIHRoZXJlJ3MgYSBsaW5r IGxpa2UgPGEgaHJlZj0iIj48YkE+Rm9vPC9iPjwvYT4gd2UgZmFpbAorICAgICAgICB3aXRoIG5v IHN1Y2ggZWxlbWVudCBlcnJvci4gVGhpcyBjYXVzZXMgdGVzdCB0ZXN0X0xpbmtfV2l0aF9Gb3Jt YXR0aW5nX1RhZ3MgdG8gZmFpbC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BdXRvbWF0aW9uL2F0 b21zL0ZpbmROb2Rlcy5qczoKKyAgICAgICAgKHN3aXRjaCk6IFVzZSBkZXNjZW5kYW50LW9yLXNl bGY6OnRleHQoKSBpbnN0ZWFkIG9mIGp1c3QgdGV4dCgpIGluIHRoZSBsaW5rcyB4cGF0aCBleHBy ZXNzaW9ucy4KKworMjAxNy0wNy0xNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKICAgICAgICAgV2ViIEF1dG9tYXRpb246IEZpbmROb2RlcyBzaG91bGQgdGhy b3cgYW4gZXJyb3IgaW4gY2FzZSBvZiBpbnZhbGlkIHN0cmF0ZWd5CiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ0OTcKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi9hdG9tcy9GaW5kTm9kZXMuanMgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL2F0b21zL0ZpbmROb2Rlcy5qcwppbmRleCBi MGQyZWZkYmY0Ny4uNWUwNWNjMDM0ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0F1dG9tYXRpb24vYXRvbXMvRmluZE5vZGVzLmpzCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0F1dG9tYXRpb24vYXRvbXMvRmluZE5vZGVzLmpzCkBAIC0zNywxMSArMzcsMTEgQEAg ZnVuY3Rpb24oc3RyYXRlZ3ksIGFuY2VzdG9yRWxlbWVudCwgcXVlcnksIGZpcnN0UmVzdWx0T25s eSwgdGltZW91dER1cmF0aW9uLCBjYWwKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSAibGluayB0 ZXh0IjoKICAgICAgICAgc3RyYXRlZ3kgPSAieHBhdGgiOwotICAgICAgICBxdWVyeSA9ICIuLy9h W0BocmVmXVt0ZXh0KCkgPSBcIiIgKyBlc2NhcGUocXVlcnkpICsgIlwiXSI7CisgICAgICAgIHF1 ZXJ5ID0gIi4vL2FbQGhyZWZdW2Rlc2NlbmRhbnQtb3Itc2VsZjo6dGV4dCgpID0gXCIiICsgZXNj YXBlKHF1ZXJ5KSArICJcIl0iOwogICAgICAgICBicmVhazsKICAgICBjYXNlICJwYXJ0aWFsIGxp bmsgdGV4dCI6CiAgICAgICAgIHN0cmF0ZWd5ID0gInhwYXRoIjsKLSAgICAgICAgcXVlcnkgPSAi Li8vYVtAaHJlZl1bY29udGFpbnModGV4dCgpLCBcIiIgKyBlc2NhcGUocXVlcnkpICsgIlwiKV0i OworICAgICAgICBxdWVyeSA9ICIuLy9hW0BocmVmXVtjb250YWlucyhkZXNjZW5kYW50LW9yLXNl bGY6OnRleHQoKSwgXCIiICsgZXNjYXBlKHF1ZXJ5KSArICJcIildIjsKICAgICAgICAgYnJlYWs7 CiAgICAgfQogCg==