174495 2017-07-13 23:26:48 -0700 [WTF] Use std::unique_ptr for StackTrace 2017-07-16 08:25:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki achristensen benjamin buildbot cdumez cmarcelo commit-queue darin dbates keith_miller mark.lam msaboff saam ticaiolima oldest_to_newest 1328691 0 ysuzuki 2017-07-13 23:26:48 -0700 [WTF] Use std::unique_ptr for StackTrace 1328692 1 315405 ysuzuki 2017-07-13 23:30:38 -0700 Created attachment 315405 Patch 1328778 2 315405 commit-queue 2017-07-14 09:03:51 -0700 Comment on attachment 315405 Patch Clearing flags on attachment: 315405 Committed r219506: <http://trac.webkit.org/changeset/219506> 1328779 3 commit-queue 2017-07-14 09:03:52 -0700 All reviewed patches have been landed. Closing bug. 1328814 4 mark.lam 2017-07-14 09:42:09 -0700 Caio had brought up this issue before, and I told him at the time that I original chose to have captureStackTrace() return a raw pointer instead of a std::unique_ptr for a reason. I looked and found the discussion I was thinking of: https://bugs.webkit.org/show_bug.cgi?id=169454#c7. Michael had suggested using RefPtr which I think is not needed. A std::unique_ptr is indeed the right solution. The only reason that captureStackTrace() didn't return a std::unique_ptr instead of a raw pointer was because I didn't think to do so at the time and was writing bad C++ code. Thanks for the fix. 1328822 5 315405 saam 2017-07-14 10:03:40 -0700 Comment on attachment 315405 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315405&action=review > Source/WTF/wtf/StackTrace.cpp:69 > + std::unique_ptr<StackTrace> trace(new (NotNull, fastMalloc(sizeToAllocate)) StackTrace()); How does the fastMalloc memory here get freed when the unique_ptr’s destructor is run? Maybe I’m missing something? 1328824 6 315405 mark.lam 2017-07-14 10:07:32 -0700 Comment on attachment 315405 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315405&action=review >> Source/WTF/wtf/StackTrace.cpp:69 >> + std::unique_ptr<StackTrace> trace(new (NotNull, fastMalloc(sizeToAllocate)) StackTrace()); > > How does the fastMalloc memory here get freed when the unique_ptr’s destructor is run? Maybe I’m missing something? Because class StackTrace is WTF_MAKE_FAST_ALLOCATED. 1328826 7 mark.lam 2017-07-14 10:08:48 -0700 (In reply to Mark Lam from comment #6) > Comment on attachment 315405 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315405&action=review > > >> Source/WTF/wtf/StackTrace.cpp:69 > >> + std::unique_ptr<StackTrace> trace(new (NotNull, fastMalloc(sizeToAllocate)) StackTrace()); > > > > How does the fastMalloc memory here get freed when the unique_ptr’s destructor is run? Maybe I’m missing something? > > Because class StackTrace is WTF_MAKE_FAST_ALLOCATED. In case you missed it, the purpose of the explicit call to fastMalloc() is not to choose fastMalloc vs system malloc, but to customize the allocation size. 1329176 8 ticaiolima 2017-07-15 07:39:10 -0700 (In reply to Mark Lam from comment #4) > Caio had brought up this issue before, and I told him at the time that I > original chose to have captureStackTrace() return a raw pointer instead of a > std::unique_ptr for a reason. > > I looked and found the discussion I was thinking of: > https://bugs.webkit.org/show_bug.cgi?id=169454#c7. Michael had suggested > using RefPtr which I think is not needed. A std::unique_ptr is indeed the > right solution. The only reason that captureStackTrace() didn't return a > std::unique_ptr instead of a raw pointer was because I didn't think to do so > at the time and was writing bad C++ code. > > Thanks for the fix. It was Yusuke's suggestion BTW. 1329204 9 315405 darin 2017-07-15 09:58:51 -0700 Comment on attachment 315405 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315405&action=review > Source/WTF/ChangeLog:12 > + And we also move WTFGetBackTrace from Assertions.cpp to > + StackTrace.cpp to consolidate stack trace related operations > + into StackTrace.cpp. OK, but it’s not great that this function is declared in Assertions.h but defined in StackTrace.cpp. 1329385 10 ysuzuki 2017-07-16 07:39:22 -0700 (In reply to Darin Adler from comment #9) > Comment on attachment 315405 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315405&action=review > > > Source/WTF/ChangeLog:12 > > + And we also move WTFGetBackTrace from Assertions.cpp to > > + StackTrace.cpp to consolidate stack trace related operations > > + into StackTrace.cpp. > > OK, but it’s not great that this function is declared in Assertions.h but > defined in StackTrace.cpp. Let's remove WTFGetBacktrace and WTFPrintBacktrace! And move these functionalities to StackTrace. 1329388 11 ysuzuki 2017-07-16 08:25:37 -0700 (In reply to Yusuke Suzuki from comment #10) > (In reply to Darin Adler from comment #9) > > Comment on attachment 315405 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=315405&action=review > > > > > Source/WTF/ChangeLog:12 > > > + And we also move WTFGetBackTrace from Assertions.cpp to > > > + StackTrace.cpp to consolidate stack trace related operations > > > + into StackTrace.cpp. > > > > OK, but it’s not great that this function is declared in Assertions.h but > > defined in StackTrace.cpp. > > Let's remove WTFGetBacktrace and WTFPrintBacktrace! > And move these functionalities to StackTrace. https://bugs.webkit.org/show_bug.cgi?id=174566 315405 2017-07-13 23:30:38 -0700 2017-07-14 09:03:51 -0700 Patch bug-174495-20170714153037.patch text/plain 6359 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 OTFlNDlmNzZlNTUyZmVhMzRiMjJjODJiZWIyYTUwYWU2MTEwYmM1Li43NThmZDliYmM4YmUzNjY5 YWQyNDM0ZTU4ZGNiYmEzZjdhMWVkMGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNy0wNy0xMyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbV1RGXSBVc2Ugc3RkOjp1bmlxdWVfcHRyIGZvciBTdGFja1RyYWNl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ0OTUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRp bWUvRXhjZXB0aW9uU2NvcGUuY3BwOgorICAgICAgICAoSlNDOjpFeGNlcHRpb25TY29wZTo6dW5l eHBlY3RlZEV4Y2VwdGlvbk1lc3NhZ2UpOgorICAgICAgICAqIHJ1bnRpbWUvVk0uY3BwOgorICAg ICAgICAoSlNDOjpWTTo6dGhyb3dFeGNlcHRpb24pOgorCiAyMDE3LTA3LTEzICBNaWNoYWVsIENh dGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBGaXggY29tcGlsZXIg d2FybmluZ3Mgd2hlbiBidWlsZGluZyB3aXRoIEdDQyA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDg2ODY3MDM0MTY3MjI3MzJk OTc4MjU0MjkxNzllMWZkYzVkMmI0MzQuLmYyNDZmYmYyM2I2NWVlMjAzNjRiNWMxZjFkOWQ3NmFh YTlhNmYxYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X VEYvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQgQEAKIDIwMTctMDctMTMgIFl1c3VrZSBTdXp1a2kg IDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKKyAgICAgICAgW1dURl0gVXNlIHN0ZDo6dW5pcXVl X3B0ciBmb3IgU3RhY2tUcmFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc0NDk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW5zdGVhZCBvZiByZXR1cm5pbmcgcG9pbnRlciB0byBoZWFwIGFsbG9jYXRl ZCBTdGFja1RyYWNlLAorICAgICAgICB3ZSBzaG91bGQgcmV0dXJuIHN0ZDo6dW5pcXVlX3B0cjxT dGFja1RyYWNlPi4KKyAgICAgICAgQW5kIHdlIGFsc28gbW92ZSBXVEZHZXRCYWNrVHJhY2UgZnJv bSBBc3NlcnRpb25zLmNwcCB0bworICAgICAgICBTdGFja1RyYWNlLmNwcCB0byBjb25zb2xpZGF0 ZSBzdGFjayB0cmFjZSByZWxhdGVkIG9wZXJhdGlvbnMKKyAgICAgICAgaW50byBTdGFja1RyYWNl LmNwcC4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmNwcDoKKyAgICAgICAgKiB3dGYvU3Rh Y2tUcmFjZS5jcHA6CisgICAgICAgIChXVEZHZXRCYWNrdHJhY2UpOgorICAgICAgICAoV1RGOjpT dGFja1RyYWNlOjpjYXB0dXJlU3RhY2tUcmFjZSk6CisgICAgICAgICogd3RmL1N0YWNrVHJhY2Uu aDoKKworMjAxNy0wNy0xMyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4K KwogICAgICAgICBVbnJldmlld2VkLCBhbm5vdGF0ZSBpbmxpbmUgZm9yIG9wZXJhdG9yPT0vIT0g Zm9yIEZhc3RBbGxvY2F0b3IKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3NDM2NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9FeGNlcHRpb25TY29wZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9F eGNlcHRpb25TY29wZS5jcHAKaW5kZXggOTU0NGM2NGNiNmYwZjZjZmUwMjFlYTI4MTk4MDJiNTU3 OGYxNmIxZC4uNjkwYmMxMjI5ZjIxNDBhMDhkYmE3N2I3ZTU1YmEyYzIxZjhjMjdiZiAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhjZXB0aW9uU2NvcGUuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvblNjb3BlLmNwcApAQCAt NTYsNyArNTYsNyBAQCBDU3RyaW5nIEV4Y2VwdGlvblNjb3BlOjp1bmV4cGVjdGVkRXhjZXB0aW9u TWVzc2FnZSgpCiAgICAgU3RyaW5nUHJpbnRTdHJlYW0gb3V0OwogCiAgICAgb3V0LnByaW50bG4o IlVuZXhwZWN0ZWQgZXhjZXB0aW9uIG9ic2VydmVkIG9uIHRocmVhZCAiLCBjdXJyZW50VGhyZWFk KCksICIgYXQ6Iik7Ci0gICAgYXV0byBjdXJyZW50U3RhY2sgPSBzdGQ6OnVuaXF1ZV9wdHI8U3Rh Y2tUcmFjZT4oU3RhY2tUcmFjZTo6Y2FwdHVyZVN0YWNrVHJhY2UoT3B0aW9uczo6dW5leHBlY3Rl ZEV4Y2VwdGlvblN0YWNrVHJhY2VMaW1pdCgpLCAxKSk7CisgICAgYXV0byBjdXJyZW50U3RhY2sg PSBTdGFja1RyYWNlOjpjYXB0dXJlU3RhY2tUcmFjZShPcHRpb25zOjp1bmV4cGVjdGVkRXhjZXB0 aW9uU3RhY2tUcmFjZUxpbWl0KCksIDEpOwogICAgIGN1cnJlbnRTdGFjay0+ZHVtcChvdXQsICIg ICAgIik7CiAKICAgICBpZiAoIW1fdm0ubmF0aXZlU3RhY2tUcmFjZU9mTGFzdFRocm93KCkpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAKaW5kZXggNDg3MjdhNjYyZWU5NjU2YWJjYTg1 YzA1YzM1NmE2Zjk0NjQyNWQzZS4uZmUzOTU2ZDA0M2Y3NDQ0ZDdhYWIzMTgzOTNiODAwYjUyMmQ5 ZTE2MyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcApAQCAtNjAwLDcgKzYwMCw3 IEBAIHZvaWQgVk06OnRocm93RXhjZXB0aW9uKEV4ZWNTdGF0ZSogZXhlYywgRXhjZXB0aW9uKiBl eGNlcHRpb24pCiAgICAgc2V0RXhjZXB0aW9uKGV4Y2VwdGlvbik7CiAKICNpZiBFTkFCTEUoRVhD RVBUSU9OX1NDT1BFX1ZFUklGSUNBVElPTikKLSAgICBtX25hdGl2ZVN0YWNrVHJhY2VPZkxhc3RU aHJvdyA9IHN0ZDo6dW5pcXVlX3B0cjxTdGFja1RyYWNlPihTdGFja1RyYWNlOjpjYXB0dXJlU3Rh Y2tUcmFjZShPcHRpb25zOjp1bmV4cGVjdGVkRXhjZXB0aW9uU3RhY2tUcmFjZUxpbWl0KCkpKTsK KyAgICBtX25hdGl2ZVN0YWNrVHJhY2VPZkxhc3RUaHJvdyA9IFN0YWNrVHJhY2U6OmNhcHR1cmVT dGFja1RyYWNlKE9wdGlvbnM6OnVuZXhwZWN0ZWRFeGNlcHRpb25TdGFja1RyYWNlTGltaXQoKSk7 CiAgICAgbV90aHJvd2luZ1RocmVhZCA9IGN1cnJlbnRUaHJlYWQoKTsKICNlbmRpZgogfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9B c3NlcnRpb25zLmNwcAppbmRleCBhNzAzMjVkOTA4NjRiMjIwYzljMzRmYjZmMTBiNjMyNjcwNGZj OTBmLi44NmFlNTQ1MDYxZjgwODZjOTZmMWViMGM3NTU2YmJjYzMwNTY3YzE5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3Nl cnRpb25zLmNwcApAQCAtNzQsMTAgKzc0LDYgQEAKICNpbmNsdWRlIDx1bmlzdGQuaD4KICNlbmRp ZgogCi0jaWYgSEFWRShCQUNLVFJBQ0UpCi0jaW5jbHVkZSA8ZXhlY2luZm8uaD4KLSNlbmRpZgot CiBleHRlcm4gIkMiIHsKIAogc3RhdGljIHZvaWQgbG9nVG9TdGRlcnIoY29uc3QgY2hhciogYnVm ZmVyKQpAQCAtMjQ3LDE3ICsyNDMsNiBAQCBjbGFzcyBDcmFzaExvZ1ByaW50U3RyZWFtIDogcHVi bGljIFByaW50U3RyZWFtIHsKICAgICB9CiB9OwogCi12b2lkIFdURkdldEJhY2t0cmFjZSh2b2lk Kiogc3RhY2ssIGludCogc2l6ZSkKLXsKLSNpZiBIQVZFKEJBQ0tUUkFDRSkKLSAgICAqc2l6ZSA9 IGJhY2t0cmFjZShzdGFjaywgKnNpemUpOwotI2VsaWYgT1MoV0lORE9XUykKLSAgICAqc2l6ZSA9 IFJ0bENhcHR1cmVTdGFja0JhY2tUcmFjZSgwLCAqc2l6ZSwgc3RhY2ssIDApOwotI2Vsc2UKLSAg ICAqc2l6ZSA9IDA7Ci0jZW5kaWYKLX0KLQogdm9pZCBXVEZSZXBvcnRCYWNrdHJhY2UoKQogewog ICAgIHN0YXRpYyBjb25zdCBpbnQgZnJhbWVzVG9TaG93ID0gMzE7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9TdGFja1RyYWNlLmNwcCBiL1NvdXJjZS9XVEYvd3RmL1N0YWNrVHJhY2UuY3Bw CmluZGV4IGNlN2MzZWJkN2U3MzAwMWJhZTUwMGYxNWRjMzhkMGU3YzcxZmRmNTQuLjYyYmRiYmQ4 YjQyOGI0NTQ0ZTYyNGE5ZmE2ZWI0ODBjZjRlOWY0MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL1N0YWNrVHJhY2UuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL1N0YWNrVHJhY2UuY3BwCkBA IC0zMCw3ICszMCw3IEBACiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3 dGYvUHJpbnRTdHJlYW0uaD4KIAotI2lmIEhBVkUoQkFDS1RSQUNFX1NZTUJPTFMpCisjaWYgSEFW RShCQUNLVFJBQ0VfU1lNQk9MUykgfHwgSEFWRShCQUNLVFJBQ0UpCiAjaW5jbHVkZSA8ZXhlY2lu Zm8uaD4KICNlbmRpZgogCkBAIC0zOSw2ICszOSwyMSBAQAogI2luY2x1ZGUgPGRsZmNuLmg+CiAj ZW5kaWYKIAorI2lmIE9TKFdJTkRPV1MpCisjaW5jbHVkZSA8d2luZG93cy5oPgorI2VuZGlmCisK K3ZvaWQgV1RGR2V0QmFja3RyYWNlKHZvaWQqKiBzdGFjaywgaW50KiBzaXplKQoreworI2lmIEhB VkUoQkFDS1RSQUNFKQorICAgICpzaXplID0gYmFja3RyYWNlKHN0YWNrLCAqc2l6ZSk7CisjZWxp ZiBPUyhXSU5ET1dTKQorICAgICpzaXplID0gUnRsQ2FwdHVyZVN0YWNrQmFja1RyYWNlKDAsICpz aXplLCBzdGFjaywgMCk7CisjZWxzZQorICAgICpzaXplID0gMDsKKyNlbmRpZgorfQorCiBuYW1l c3BhY2UgV1RGIHsKIAogQUxXQVlTX0lOTElORSBzaXplX3QgU3RhY2tUcmFjZTo6aW5zdGFuY2VT aXplKGludCBjYXBhY2l0eSkKQEAgLTQ3LDExICs2MiwxMSBAQCBBTFdBWVNfSU5MSU5FIHNpemVf dCBTdGFja1RyYWNlOjppbnN0YW5jZVNpemUoaW50IGNhcGFjaXR5KQogICAgIHJldHVybiBzaXpl b2YoU3RhY2tUcmFjZSkgKyAoY2FwYWNpdHkgLSAxKSAqIHNpemVvZih2b2lkKik7CiB9CiAKLVN0 YWNrVHJhY2UqIFN0YWNrVHJhY2U6OmNhcHR1cmVTdGFja1RyYWNlKGludCBtYXhGcmFtZXMsIGlu dCBmcmFtZXNUb1NraXApCitzdGQ6OnVuaXF1ZV9wdHI8U3RhY2tUcmFjZT4gU3RhY2tUcmFjZTo6 Y2FwdHVyZVN0YWNrVHJhY2UoaW50IG1heEZyYW1lcywgaW50IGZyYW1lc1RvU2tpcCkKIHsKICAg ICBtYXhGcmFtZXMgPSBzdGQ6Om1heCgxLCBtYXhGcmFtZXMpOwogICAgIHNpemVfdCBzaXplVG9B bGxvY2F0ZSA9IGluc3RhbmNlU2l6ZShtYXhGcmFtZXMpOwotICAgIFN0YWNrVHJhY2UqIHRyYWNl ID0gbmV3IChOb3ROdWxsLCBmYXN0TWFsbG9jKHNpemVUb0FsbG9jYXRlKSkgU3RhY2tUcmFjZSgp OworICAgIHN0ZDo6dW5pcXVlX3B0cjxTdGFja1RyYWNlPiB0cmFjZShuZXcgKE5vdE51bGwsIGZh c3RNYWxsb2Moc2l6ZVRvQWxsb2NhdGUpKSBTdGFja1RyYWNlKCkpOwogCiAgICAgLy8gU2tpcCAy IGFkZGl0aW9uYWwgZnJhbWVzIGkuZS4gU3RhY2tUcmFjZTo6Y2FwdHVyZVN0YWNrVHJhY2UgYW5k IFdURkdldEJhY2t0cmFjZS4KICAgICBmcmFtZXNUb1NraXAgKz0gMjsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL1N0YWNrVHJhY2UuaCBiL1NvdXJjZS9XVEYvd3RmL1N0YWNrVHJhY2UuaApp bmRleCBhZjZhOTYxZjk1ZjZhNzE1ZTZiNWEwMTkxYzJjNjRmOGY4ZTI1NWU1Li40MzJhNzc5MWIz MDNjOTliNTBmNDFiZWI4ZjFmNzY5Y2ZiMWMwMTI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9TdGFja1RyYWNlLmgKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tUcmFjZS5oCkBAIC0zNiw3 ICszNiw3IEBAIGNsYXNzIFByaW50U3RyZWFtOwogY2xhc3MgU3RhY2tUcmFjZSB7CiAgICAgV1RG X01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6Ci0gICAgV1RGX0VYUE9SVF9QUklWQVRFIHN0 YXRpYyBTdGFja1RyYWNlKiBjYXB0dXJlU3RhY2tUcmFjZShpbnQgbWF4RnJhbWVzLCBpbnQgZnJh bWVzVG9Ta2lwID0gMCk7CisgICAgV1RGX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBzdGQ6OnVuaXF1 ZV9wdHI8U3RhY2tUcmFjZT4gY2FwdHVyZVN0YWNrVHJhY2UoaW50IG1heEZyYW1lcywgaW50IGZy YW1lc1RvU2tpcCA9IDApOwogCiAgICAgLy8gQm9ycm93ZWQgc3RhY2sgdHJhY2UuCiAgICAgU3Rh Y2tUcmFjZSh2b2lkKiogc3RhY2ssIGludCBzaXplKQo=