174493 2017-07-13 22:14:46 -0700 [WinCairo] error 'm_compositorTexture': undeclared identifier since Bug 174345 2017-07-14 08:58:52 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 174345 1 fujii fujii achristensen bfulgham buildbot commit-queue dino graouts kondapallykalyan noam pvollan oldest_to_newest 1328673 0 fujii 2017-07-13 22:14:46 -0700 [WinCairo] error 'm_compositorTexture': undeclared identifier since Bug 174345 https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/4338 > [111/547] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\graphics\opengl\GraphicsContext3DOpenGLES.cpp.obj > FAILED: Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp.obj > (snip) > C:\WebKit-BuildSlave\win-cairo-release\build\Source\ThirdParty\ANGLE\include\GLES2/gl2ext.h(1611): warning C4005: 'GL_COLOR_ATTACHMENT0_EXT': macro redefinition > c:\webkit-buildslave\win-cairo-release\build\source\webcore\platform\graphics\OpenGLESShims.h(48): note: see previous definition of 'GL_COLOR_ATTACHMENT0_EXT' > ..\..\Source\WebCore\platform\graphics\opengl\GraphicsContext3DOpenGLES.cpp(113): error C2065: 'm_compositorTexture': undeclared identifier > ..\..\Source\WebCore\platform\graphics\opengl\GraphicsContext3DOpenGLES.cpp(114): error C2065: 'm_compositorTexture': undeclared identifier 1328687 1 315404 fujii 2017-07-13 23:07:12 -0700 Created attachment 315404 Patch 1328775 2 315404 commit-queue 2017-07-14 08:58:51 -0700 Comment on attachment 315404 Patch Clearing flags on attachment: 315404 Committed r219505: <http://trac.webkit.org/changeset/219505> 1328776 3 commit-queue 2017-07-14 08:58:52 -0700 All reviewed patches have been landed. Closing bug. 315404 2017-07-13 23:07:12 -0700 2017-07-14 08:58:51 -0700 Patch bug-174493-20170714150711.patch text/plain 3960 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzk4Y2NhZmM4OWQ3MTZk NzhhMmZkOWI1Y2VhNTI3MjA4ZWVlM2UxMC4uMzExNmUwNjI5ZjkwYTk4ZGVkMDk2MjIyNTI0ZTU4 NmE5YTVjOTNiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA3LTEzICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWly b10gZXJyb3IgJ21fY29tcG9zaXRvclRleHR1cmUnOiB1bmRlY2xhcmVkIGlkZW50aWZpZXIgc2lu Y2UgQnVnIDE3NDM0NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTc0NDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ29tcGlsYXRpb24gZXJyb3JzIGFyZSByZXBvcnRlZCBieSB0aGUgY29kZSB1c2luZyBh IG1lbWJlcgorICAgICAgICBtX2NvbXBvc2l0b3JUZXh0dXJlIG9mIEdyYXBoaWNzQ29udGV4dDNE IHdoaWNoIGV4aXN0cyBvbmx5IGlmCisgICAgICAgIFVTRShDT09SRElOQVRFRF9HUkFQSElDU19U SFJFQURFRCkuIFdpbkNhaXJvIHBvcnQgZG9lc24ndCB1c2UgaXQuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjpHcmFwaGljc0NvbnRleHQzRCk6CisgICAgICAg IFVzZSBtX2NvbXBvc2l0b3JUZXh0dXJlIG9ubHkgaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNT X1RIUkVBREVEKS4KKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjp+R3JhcGhp Y3NDb250ZXh0M0QpOiBEaXR0by4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wv R3JhcGhpY3NDb250ZXh0M0RPcGVuR0xFUy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHQzRDo6cmVzaGFwZUZCT3MpOgorICAgICAgICBEaXR0by4gRml4IHRoZSB3cm9uZyBp bmRlbnRhdGlvbiBsZXZlbC4KKwogMjAxNy0wNy0xMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0 YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgRml4IGNvbXBpbGVyIHdhcm5pbmdzIHdoZW4g YnVpbGRpbmcgd2l0aCBHQ0MgNwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0M0RDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcAppbmRl eCA4OWExMjJjNjc2ODRjZDU2ZGVlYzkxOWU4YTE1YjhhY2M4YWQ0ZDlmLi4wNzQyYWZhYjFkNjc5 ZThhODc2MjRmYjA1NzhlODFkMWJhZGQyMGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENh aXJvLmNwcApAQCAtOTAsNyArOTAsOSBAQCBHcmFwaGljc0NvbnRleHQzRDo6R3JhcGhpY3NDb250 ZXh0M0QoR3JhcGhpY3NDb250ZXh0M0RBdHRyaWJ1dGVzIGF0dHJpYnV0ZXMsIEhvcwogICAgICwg bV9jdXJyZW50SGVpZ2h0KDApCiAgICAgLCBtX2F0dHJzKGF0dHJpYnV0ZXMpCiAgICAgLCBtX3Rl eHR1cmUoMCkKKyNpZiBVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1NfVEhSRUFERUQpCiAgICAgLCBt X2NvbXBvc2l0b3JUZXh0dXJlKDApCisjZW5kaWYKICAgICAsIG1fZmJvKDApCiAjaWYgVVNFKENP T1JESU5BVEVEX0dSQVBISUNTX1RIUkVBREVEKQogICAgICwgbV9pbnRlcm1lZGlhdGVUZXh0dXJl KDApCkBAIC0yMzMsOCArMjM1LDEwIEBAIEdyYXBoaWNzQ29udGV4dDNEOjp+R3JhcGhpY3NDb250 ZXh0M0QoKQogICAgIG1ha2VDb250ZXh0Q3VycmVudCgpOwogICAgIGlmIChtX3RleHR1cmUpCiAg ICAgICAgIDo6Z2xEZWxldGVUZXh0dXJlcygxLCAmbV90ZXh0dXJlKTsKKyNpZiBVU0UoQ09PUkRJ TkFURURfR1JBUEhJQ1NfVEhSRUFERUQpCiAgICAgaWYgKG1fY29tcG9zaXRvclRleHR1cmUpCiAg ICAgICAgIDo6Z2xEZWxldGVUZXh0dXJlcygxLCAmbV9jb21wb3NpdG9yVGV4dHVyZSk7CisjZW5k aWYKIAogICAgIGlmIChtX2F0dHJzLmFudGlhbGlhcykgewogICAgICAgICA6OmdsRGVsZXRlUmVu ZGVyYnVmZmVycygxLCAmbV9tdWx0aXNhbXBsZUNvbG9yQnVmZmVyKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9w ZW5HTEVTLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFw aGljc0NvbnRleHQzRE9wZW5HTEVTLmNwcAppbmRleCA0ODMxNGZkZTcwMmEyMzFmODU2MjI2MWZl NmUzMzcwMDNmYjEyMmIwLi5hMTBiNmQ5OTkzNjkyMmUzMmY3NDlhMDBkNGU4NjgwMDE5ZmQ3MDVm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3Jh cGhpY3NDb250ZXh0M0RPcGVuR0xFUy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMRVMuY3BwCkBAIC0xMTAsMTYg KzExMCwxNiBAQCBib29sIEdyYXBoaWNzQ29udGV4dDNEOjpyZXNoYXBlRkJPcyhjb25zdCBJbnRT aXplJiBzaXplKQogICAgIDo6Z2xUZXhJbWFnZTJEKEdMX1RFWFRVUkVfMkQsIDAsIG1faW50ZXJu YWxDb2xvckZvcm1hdCwgd2lkdGgsIGhlaWdodCwgMCwgY29sb3JGb3JtYXQsIHBpeGVsRGF0YVR5 cGUsIDApOwogICAgIDo6Z2xGcmFtZWJ1ZmZlclRleHR1cmUyRChHTF9GUkFNRUJVRkZFUiwgR0xf Q09MT1JfQVRUQUNITUVOVDAsIEdMX1RFWFRVUkVfMkQsIG1fdGV4dHVyZSwgMCk7CiAKKyNpZiBV U0UoQ09PUkRJTkFURURfR1JBUEhJQ1NfVEhSRUFERUQpCiAgICAgaWYgKG1fY29tcG9zaXRvclRl eHR1cmUpIHsKICAgICAgICAgOjpnbEJpbmRUZXh0dXJlKEdMX1RFWFRVUkVfMkQsIG1fY29tcG9z aXRvclRleHR1cmUpOwogICAgICAgICA6OmdsVGV4SW1hZ2UyRChHTF9URVhUVVJFXzJELCAwLCBt X2ludGVybmFsQ29sb3JGb3JtYXQsIHdpZHRoLCBoZWlnaHQsIDAsIGNvbG9yRm9ybWF0LCBHTF9V TlNJR05FRF9CWVRFLCAwKTsKICAgICAgICAgOjpnbEJpbmRUZXh0dXJlKEdMX1RFWFRVUkVfMkQs IDApOwogICAgIH0KIAotI2lmIFVTRShDT09SRElOQVRFRF9HUkFQSElDU19USFJFQURFRCkKLSAg ICAgICAgOjpnbEJpbmRUZXh0dXJlKEdMX1RFWFRVUkVfMkQsIG1faW50ZXJtZWRpYXRlVGV4dHVy ZSk7Ci0gICAgICAgIDo6Z2xUZXhJbWFnZTJEKEdMX1RFWFRVUkVfMkQsIDAsIG1faW50ZXJuYWxD b2xvckZvcm1hdCwgd2lkdGgsIGhlaWdodCwgMCwgY29sb3JGb3JtYXQsIEdMX1VOU0lHTkVEX0JZ VEUsIDApOwotICAgICAgICA6OmdsQmluZFRleHR1cmUoR0xfVEVYVFVSRV8yRCwgMCk7CisgICAg OjpnbEJpbmRUZXh0dXJlKEdMX1RFWFRVUkVfMkQsIG1faW50ZXJtZWRpYXRlVGV4dHVyZSk7Cisg ICAgOjpnbFRleEltYWdlMkQoR0xfVEVYVFVSRV8yRCwgMCwgbV9pbnRlcm5hbENvbG9yRm9ybWF0 LCB3aWR0aCwgaGVpZ2h0LCAwLCBjb2xvckZvcm1hdCwgR0xfVU5TSUdORURfQllURSwgMCk7Cisg ICAgOjpnbEJpbmRUZXh0dXJlKEdMX1RFWFRVUkVfMkQsIDApOwogI2VuZGlmCiAKICAgICBFeHRl bnNpb25zM0RPcGVuR0xFUyYgZXh0ZW5zaW9ucyA9IHN0YXRpY19jYXN0PEV4dGVuc2lvbnMzRE9w ZW5HTEVTJj4oZ2V0RXh0ZW5zaW9ucygpKTsK