17445 2008-02-20 03:16:44 -0800 [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed" 2008-02-21 11:45:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED http://www.gentoo.org/proj/en/qa/asneeded.xml P2 Normal --- 1 mike.auty webkit-unassigned alp oldest_to_newest 71193 0 mike.auty 2008-02-20 03:16:44 -0800 The GNUmakefile.am files make use of the LDFLAGS variable to include library additions such as -ljpeg etc. Unfortunately, if these inclusions aren't made in LIBADD/LDADD variables, then they are mis-ordered during the linking. The as-needed flag discards libraries whose functions have not been needed by earlier libraries, which therefore makes the ordering important. I'll be attaching a patch directly after this, built against a recent nightly build. This could potentially affect other build systems/OSes, but I've only been able to confirm that the patch fixes the build issues on linux. 71194 1 19224 mike.auty 2008-02-20 03:21:57 -0800 Created attachment 19224 webkitgtk-30267-as-needed.patch This moves all -l library inclusion statements from LDFLAGS variables to LIBADD/LDADD variables. It applies cleanly against r30267. If you require newer versions or any further information, please just ask. 5:) 71403 2 19224 alp 2008-02-21 11:43:55 -0800 Comment on attachment 19224 webkitgtk-30267-as-needed.patch r=me Sorry about the delay. I'll clean up a few whitespace mistakes in GNUmakefile.am and write a ChangeLog entry for you this time, but in future please look into doing these in your patches. Thanks 71404 3 alp 2008-02-21 11:45:16 -0800 Landed in r30459. I also took out an unneeded -ljpeg from the GtkLauncher flags. 19224 2008-02-20 03:21:57 -0800 2008-02-21 11:43:55 -0800 webkitgtk-30267-as-needed.patch webkitgtk-30267-as-needed.patch text/plain 2077 mike.auty ZGlmZiAtLWdpdCBhL0dOVW1ha2VmaWxlLmFtIGIvR05VbWFrZWZpbGUuYW0KaW5kZXggYWQ1ZTFm OC4uOWFlZTFmMiAxMDA2NDQKLS0tIGEvR05VbWFrZWZpbGUuYW0KKysrIGIvR05VbWFrZWZpbGUu YW0KQEAgLTEwMiw3ICsxMDIsNyBAQCBsaWJKYXZhU2NyaXB0Q29yZV9sYV9TT1VSQ0VTID0gXAog CSQoamF2YXNjcmlwdGNvcmVfYnVpbHRfc291cmNlcykgXAogCSQoamF2YXNjcmlwdGNvcmVfc291 cmNlcykKIAotbGliSmF2YVNjcmlwdENvcmVfbGFfTERGTEFHUyA9ICQoSUNVX0xJQlMpIC1scHRo cmVhZAorbGliSmF2YVNjcmlwdENvcmVfbGFfTElCQUREID0gJChJQ1VfTElCUykgLWxwdGhyZWFk CiAKIGxpYkphdmFTY3JpcHRDb3JlX2xhX0NYWEZMQUdTID0gJChnbG9iYWxfY3h4ZmxhZ3MpICQo Z2xvYmFsX2NmbGFncykgLWZzdHJpY3QtYWxpYXNpbmcKIApAQCAtMTI2LDcgKzEyNiw3IEBAIHdl YmtpdGd0a19oX2FwaSA6PQogd2Via2l0Z3RrX2hlYWRlcnMgOj0KIHdlYmtpdGd0a19zb3VyY2Vz IDo9CiB3ZWJraXRndGtfY3BwZmxhZ3MgOj0KLXdlYmtpdGd0a19sZGZsYWdzIDo9Cit3ZWJraXRn dGtfbGliYWRkIDo9CiB3ZWJraXRndGtfYnVpbHRfc291cmNlcyA6PQogd2Via2l0Z3RrX2J1aWx0 X25vc291cmNlcyA6PQogd2Via2l0Z3RrX2NsZWFuZmlsZXMgOj0KQEAgLTE3NiwyMCArMTc2LDIw IEBAIGxpYldlYktpdEd0a19sYV9DUFBGTEFHUyA9IFwKIAkkKHdlYmtpdGd0a19jcHBmbGFncykg XAogCSQoSUNVX0NQUEZMQUdTKQogCi1saWJXZWJLaXRHdGtfbGFfTElCQUREID0gbGliSmF2YVNj cmlwdENvcmUubGEKLQotbGliV2ViS2l0R3RrX2xhX0xERkxBR1MgPSBcCi0JJCh3ZWJraXRndGtf bGRmbGFncykgXAorbGliV2ViS2l0R3RrX2xhX0xJQkFERCA9IGxpYkphdmFTY3JpcHRDb3JlLmxh IFwKKwkkKHdlYmtpdGd0a19saWJhZGQpIFwKIAkkKERFUEVOREVOQ0lFU19MSUJTKSBcCiAJJChM SUJDVVJMX0xJQlMpIFwKLQkkKElDVV9MSUJTKSBcCi0JJChTUUxJVEUzX0xJQlMpIFwKLQkkKEdT VFJFQU1FUl9MSUJTKSBcCi0JJChMSUJYU0xUX0xJQlMpIFwKKyAgICAgICAgJChJQ1VfTElCUykg XAorICAgICAgICAkKFNRTElURTNfTElCUykgXAorICAgICAgICAkKEdTVFJFQU1FUl9MSUJTKSBc CisgICAgICAgICQoTElCWFNMVF9MSUJTKSBcCisgICAgICAgICQoSElMRE9OX0xJQlMpIFwKKyAg ICAgICAgLWxwdGhyZWFkIFwKKyAgICAgICAgLWxqcGVnCisKK2xpYldlYktpdEd0a19sYV9MREZM QUdTID0gXAogCSQoQ09WRVJBR0VfTERGTEFHUykgXAotCSQoSElMRE9OX0xJQlMpIFwKLQktbHB0 aHJlYWQgXAotCS1sanBlZyBcCiAJLXZlcnNpb24taW5mbyBATElCV0VCS0lUR1RLX1ZFUlNJT05A CiAKICMKQEAgLTIzNyw3ICsyMzcsNyBAQCBnbG9iYWxfY3BwZmxhZ3MgKz0gXAogZW5kaWYKIAog aWYgRU5BQkxFX1ZJREVPCi13ZWJraXRndGtfbGRmbGFncyArPSAtbGdzdGludGVyZmFjZXMtMC4x MCAtbGdzdHZpZGVvLTAuMTAKK3dlYmtpdGd0a19saWJhZGQgKz0gLWxnc3RpbnRlcmZhY2VzLTAu MTAgLWxnc3R2aWRlby0wLjEwCiBlbmRpZgogCiAjCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9H TlVtYWtlZmlsZS5hbSBiL1dlYktpdFRvb2xzL0dOVW1ha2VmaWxlLmFtCmluZGV4IGU0MmEwNjQu LjI1NWY5ZTMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0dOVW1ha2VmaWxlLmFtCisrKyBiL1dl YktpdFRvb2xzL0dOVW1ha2VmaWxlLmFtCkBAIC0xNiwxMCArMTYsMTEgQEAgUHJvZ3JhbXNfR3Rr TGF1bmNoZXJfQ0ZMQUdTID0gXAogCiBQcm9ncmFtc19HdGtMYXVuY2hlcl9MREFERCA9IFwKIAkk KERFUEVOREVOQ0lFU19MSUJTKSBcCisJLWxqcGVnIFwKIAlsaWJKYXZhU2NyaXB0Q29yZS5sYSBc CiAJbGliV2ViS2l0R3RrLmxhCiAKLVByb2dyYW1zX0d0a0xhdW5jaGVyX0xERkxBR1MgPSAtbGpw ZWcgLXJwYXRoICQoQ1VSRElSKS8ubGlicworUHJvZ3JhbXNfR3RrTGF1bmNoZXJfTERGTEFHUyA9 IC1ycGF0aCAkKENVUkRJUikvLmxpYnMKIAogIyBEdW1wUmVuZGVyVHJlZQogUHJvZ3JhbXNfRHVt cFJlbmRlclRyZWVfQ1BQRkxBR1MgPSBcCg==