174424 2017-07-12 09:05:41 -0700 bmalloc: Failure to build when the compiler specifically targets ARMv8-A / defines __ARM_ARCH_8A__ 2017-07-12 11:43:41 -0700 1 1 1 Unclassified WebKit bmalloc Other Other Linux RESOLVED FIXED P2 Normal --- 1 aperez aperez commit-queue fpizlo ggaren mcatanzaro mitz msaboff thorton oldest_to_newest 1328070 0 aperez 2017-07-12 09:05:41 -0700 The following error prevents builds from succeeding when a compiler specifically targets ARMv8-A (instead of generic ARMv8): In file included from /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/BAssert.h:28:0, from /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/BumpAllocator.h:29, from /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/Allocator.h:29, from /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/Allocator.cpp:26: /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/BPlatform.h:84:45: warning: "BARM_ARCH_VERSION" is not defined [-Wundef] #define BARM_ARCH_AT_LEAST(N) (BCPU(ARM) && BARM_ARCH_VERSION >= N) ^ /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/BPlatform.h:180:9: note: in expansion of macro ‘BARM_ARCH_AT_LEAST’ # elif BARM_ARCH_AT_LEAST(4) ^~~~~~~~~~~~~~~~~~ /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/BPlatform.h:184:6: error: #error "Not supported ARM architecture" # error "Not supported ARM architecture" ^~~~~ The compiler is GCC 6.4.0, and it's defining __ARM_ARCH_8A__, which is not checked by BPlatform.h (it checks for __ARM_ARCH_8__ instead). Compiler output: % ./output/host/bin/arm-buildroot-linux-gnueabihf-g++ -E -dM -x c++ -std=c++1y /dev/null|grep ARM_ARCH_8 #define __ARM_ARCH_8A__ 1 % ./output/host/bin/arm-buildroot-linux-gnueabihf-g++ -dumpversion 6.4.0 I'm submitting a patch for this soon. 1328071 1 315248 aperez 2017-07-12 09:08:35 -0700 Created attachment 315248 Patch 1328136 2 315248 mcatanzaro 2017-07-12 11:15:06 -0700 Comment on attachment 315248 Patch Hm, shame there's so much code duplication here between Platform.h and BPlatform.h.... 1328150 3 315248 commit-queue 2017-07-12 11:43:40 -0700 Comment on attachment 315248 Patch Clearing flags on attachment: 315248 Committed r219416: <http://trac.webkit.org/changeset/219416> 1328151 4 commit-queue 2017-07-12 11:43:41 -0700 All reviewed patches have been landed. Closing bug. 315248 2017-07-12 09:08:35 -0700 2017-07-12 11:43:40 -0700 Patch bug-174424-20170712190834.patch text/plain 1222 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggYzcwOGZkMjA1NGVkNDc1 Y2UwZGEyNjI2NzEyZjg3ZDM0ZjYwYjVjNS4uNDJiNzA2ZTA4MjEzMWFjNWU2NzU5YTM2YWZmY2Mx OGNmYTM2OGFmOSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA3LTEyICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgYm1hbGxv YzogRmFpbHVyZSB0byBidWlsZCB3aGVuIHRoZSBjb21waWxlciBzcGVjaWZpY2FsbHkgdGFyZ2V0 cyBBUk12OC1BIC8gZGVmaW5lcyBfX0FSTV9BUkNIXzhBX18KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDQyNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYm1hbGxvYy9CUGxhdGZvcm0uaDogQWxzbyBj aGVjayBmb3IgX19BUkNIX0FSTV84QV9fIHRvIGRldGVjdCBBUk12OC4KKwogMjAxNy0wNy0wNSAg RGFld29vbmcgSmFuZyAgPGRhZXdvb25nLmphbmdAbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBy ZWludGVycHJldF9jYXN0IGRvZXMgbm90IGV2YWx1YXRlIHRvIGNvbnN0ZXhwcgpkaWZmIC0tZ2l0 IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CUGxhdGZvcm0uaCBiL1NvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvQlBsYXRmb3JtLmgKaW5kZXggNDViYmMyNDlmNTkxOThlYWFmYWVlMzA4YjU0ZTc4ZTAw MmU0OGMyZC4uNTk3Zjc4MTlkMTgxNzhhMTdkOTJhZGM0NWVjZWNlNDExOWVmOGFkZCAxMDA2NDQK LS0tIGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvYm1h bGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oCkBAIC0xMjMsNyArMTIzLDggQEAKIHx8IGRlZmluZWQo X19BUk1fQVJDSF83U19fKQogI2RlZmluZSBCQVJNX0FSQ0hfVkVSU0lPTiA3CiAKLSNlbGlmIGRl ZmluZWQoX19BUk1fQVJDSF84X18pCisjZWxpZiBkZWZpbmVkKF9fQVJNX0FSQ0hfOF9fKSBcCit8 fCBkZWZpbmVkKF9fQVJNX0FSQ0hfOEFfXykKICNkZWZpbmUgQkFSTV9BUkNIX1ZFUlNJT04gOAog CiAvKiBNU1ZDIHNldHMgX01fQVJNICovCg==