174383 2017-07-11 13:33:19 -0700 RealtimeOutgoingAudioSource should not push more audio data if the WebRTC thread is not able to process it 2017-07-11 17:25:43 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1327686 0 youennf 2017-07-11 13:33:19 -0700 On slow devices, the audio capture thread, which is high priority, may push more audio data than what the WebRTC thread can process. In that case, messages are queued in the WebRTC thread queue and it may end up blocking the main thread or increase memory too much. We should stop pushing data when the buffered amount is large. 1327719 1 315160 youennf 2017-07-11 13:50:34 -0700 Created attachment 315160 Patch 1327720 2 webkit-bug-importer 2017-07-11 13:51:20 -0700 <rdar://problem/33245519> 1327862 3 315160 commit-queue 2017-07-11 17:25:42 -0700 Comment on attachment 315160 Patch Clearing flags on attachment: 315160 Committed r219377: <http://trac.webkit.org/changeset/219377> 1327863 4 commit-queue 2017-07-11 17:25:43 -0700 All reviewed patches have been landed. Closing bug. 315160 2017-07-11 13:50:34 -0700 2017-07-11 17:25:42 -0700 Patch bug-174383-20170711135034.patch text/plain 5094 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjA2MTY1YzJmMWM0ZGUz MWJiMTQ1MzIzMGI2OWYyZGU5OGFhMjIwNi4uZTJjMmYyNGRiZjdhYzRmZTYxZTVlZjk3NTU3ODlh MTFhNzAwYTA3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA3LTExICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWFsdGltZU91dGdvaW5n QXVkaW9Tb3VyY2Ugc2hvdWxkIG5vdCBwdXNoIG1vcmUgYXVkaW8gZGF0YSBpZiB0aGUgV2ViUlRD IHRocmVhZCBpcyBub3QgYWJsZSB0byBwcm9jZXNzIGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQzODMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgc3VwcG9ydCB0byBjaGVj ayBmb3IgcGVuZGluZy1wcm9jZXNzaW5nIGF1ZGlvIGRhdGEuCisgICAgICAgIElmIHRoZSBhbW91 bnQgb2YgYXVkaW8gZGF0YSBpcyBiaWdnZXIgdGhhbiBhIGhpZ2ggd2F0ZXIgbWFyayBvZiAwLjUg c2Vjb25kcywKKyAgICAgICAgd2Ugc3RvcCBwdXNoaW5nIG5ldyBhdWRpbyBkYXRhIHVudGlsIGJ1 ZmZlcmVkIGF1ZGlvIGRhdGEgaXMgbG93ZXIgdGhhbiBhIGxvdyB3YXRlciBtYXJrIG9mIDAuMSBz ZWNvbmRzLgorICAgICAgICBQYXRjaCBpcyB0ZXN0ZWQgYnkgYWRkaW5nIGJyZWFrcG9pbnRzIHRv IHRyaWdnZXIgdGhlIGhpZ2ggd2F0ZXIgbWFyaywgdmVyaWZ5aW5nIHRoYXQgbG93IHdhdGVyIG1h cmsgaXMgdHJpZ2dlcmVkCisgICAgICAgIGFuZCByZWNlaXZpbmcgYXVkaW8gaXMgZmluZSBvbiB0 aGUgb3RoZXIgY29ubmVjdGlvbiBlbmRwb2ludC4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlh c3RyZWFtL21hYy9SZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlOjppc1JlYWNoaW5nQnVmZmVyZWRBdWRp b0RhdGFIaWdoTGltaXQpOgorICAgICAgICAoV2ViQ29yZTo6UmVhbHRpbWVPdXRnb2luZ0F1ZGlv U291cmNlOjppc1JlYWNoaW5nQnVmZmVyZWRBdWRpb0RhdGFMb3dMaW1pdCk6CisgICAgICAgIChX ZWJDb3JlOjpSZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2U6OmF1ZGlvU2FtcGxlc0F2YWlsYWJs ZSk6CisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lT3V0Z29pbmdB dWRpb1NvdXJjZS5oOgorCiAyMDE3LTA3LTExICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAg PGNsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFNwaW4gYnV0dG9ucyBvbiBpbnB1 dCB0eXBlIG51bWJlciBhcHBlYXIgb3ZlciB0aGUgdmFsdWUgaXRzZWxmIGZvciBzbWFsbCB3aWR0 aHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9S ZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZS5jcHAKaW5kZXggY2Fh YzQ3YjIzODdjZGVjOTVjNTI5MzY0ZDhmNjliM2MyZTkwNzQxNi4uZTcyZTE1YzJkZTM2NDQ1Yjhj NzZkZDY3N2Y4MDEyY2ZmZmNjMGQ3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lT3V0Z29pbmdB dWRpb1NvdXJjZS5jcHAKQEAgLTg4LDYgKzg4LDI0IEBAIHZvaWQgUmVhbHRpbWVPdXRnb2luZ0F1 ZGlvU291cmNlOjpzb3VyY2VFbmFibGVkQ2hhbmdlZCgpCiAgICAgbV9zYW1wbGVDb252ZXJ0ZXIt PnNldE11dGVkKG1fbXV0ZWQgfHwgIW1fZW5hYmxlZCk7CiB9CiAKK2Jvb2wgUmVhbHRpbWVPdXRn b2luZ0F1ZGlvU291cmNlOjppc1JlYWNoaW5nQnVmZmVyZWRBdWRpb0RhdGFIaWdoTGltaXQoKQor eworICAgIGF1dG8gd3JpdHRlbkF1ZGlvRHVyYXRpb24gPSBtX3dyaXRlQ291bnQgLyBtX2lucHV0 U3RyZWFtRGVzY3JpcHRpb24uc2FtcGxlUmF0ZSgpOworICAgIGF1dG8gcmVhZEF1ZGlvRHVyYXRp b24gPSBtX3JlYWRDb3VudCAvIG1fb3V0cHV0U3RyZWFtRGVzY3JpcHRpb24uc2FtcGxlUmF0ZSgp OworCisgICAgQVNTRVJUKHdyaXR0ZW5BdWRpb0R1cmF0aW9uID49IHJlYWRBdWRpb0R1cmF0aW9u KTsKKyAgICByZXR1cm4gd3JpdHRlbkF1ZGlvRHVyYXRpb24gPiByZWFkQXVkaW9EdXJhdGlvbiAr IDAuNTsKK30KKworYm9vbCBSZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2U6OmlzUmVhY2hpbmdC dWZmZXJlZEF1ZGlvRGF0YUxvd0xpbWl0KCkKK3sKKyAgICBhdXRvIHdyaXR0ZW5BdWRpb0R1cmF0 aW9uID0gbV93cml0ZUNvdW50IC8gbV9pbnB1dFN0cmVhbURlc2NyaXB0aW9uLnNhbXBsZVJhdGUo KTsKKyAgICBhdXRvIHJlYWRBdWRpb0R1cmF0aW9uID0gbV9yZWFkQ291bnQgLyBtX291dHB1dFN0 cmVhbURlc2NyaXB0aW9uLnNhbXBsZVJhdGUoKTsKKworICAgIEFTU0VSVCh3cml0dGVuQXVkaW9E dXJhdGlvbiA+PSByZWFkQXVkaW9EdXJhdGlvbik7CisgICAgcmV0dXJuIHdyaXR0ZW5BdWRpb0R1 cmF0aW9uIDwgcmVhZEF1ZGlvRHVyYXRpb24gKyAwLjE7Cit9CisKIHZvaWQgUmVhbHRpbWVPdXRn b2luZ0F1ZGlvU291cmNlOjphdWRpb1NhbXBsZXNBdmFpbGFibGUoY29uc3QgTWVkaWFUaW1lJiwg Y29uc3QgUGxhdGZvcm1BdWRpb0RhdGEmIGF1ZGlvRGF0YSwgY29uc3QgQXVkaW9TdHJlYW1EZXNj cmlwdGlvbiYgc3RyZWFtRGVzY3JpcHRpb24sIHNpemVfdCBzYW1wbGVDb3VudCkKIHsKICAgICBp ZiAobV9pbnB1dFN0cmVhbURlc2NyaXB0aW9uICE9IHN0cmVhbURlc2NyaXB0aW9uKSB7CkBAIC05 OSw3ICsxMTcsMTcgQEAgdm9pZCBSZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2U6OmF1ZGlvU2Ft cGxlc0F2YWlsYWJsZShjb25zdCBNZWRpYVRpbWUmLCBjb25zdAogICAgICAgICBzdGF0dXMgPSBt X3NhbXBsZUNvbnZlcnRlci0+c2V0T3V0cHV0Rm9ybWF0KG1fb3V0cHV0U3RyZWFtRGVzY3JpcHRp b24uc3RyZWFtRGVzY3JpcHRpb24oKSk7CiAgICAgICAgIEFTU0VSVCghc3RhdHVzKTsKICAgICB9 Ci0gICAgCisKKyAgICAvLyBMZXQncyBza2lwIHB1c2hpbmcgc2FtcGxlcyBpZiB3ZSBhcmUgdG9v IHNsb3cgcHVsbGluZyB0aGVtLgorICAgIGlmIChtX3NraXBwaW5nQXVkaW9EYXRhKSB7CisgICAg ICAgIGlmICghaXNSZWFjaGluZ0J1ZmZlcmVkQXVkaW9EYXRhTG93TGltaXQoKSkKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgbV9za2lwcGluZ0F1ZGlvRGF0YSA9IGZhbHNlOworICAgIH0g ZWxzZSBpZiAoaXNSZWFjaGluZ0J1ZmZlcmVkQXVkaW9EYXRhSGlnaExpbWl0KCkpIHsKKyAgICAg ICAgbV9za2lwcGluZ0F1ZGlvRGF0YSA9IHRydWU7CisgICAgICAgIHJldHVybjsKKyAgICB9CisK ICAgICAvLyBJZiB3ZSBjaGFuZ2UgdGhlIGF1ZGlvIHRyYWNrIG9yIGl0cyBzYW1wbGUgcmF0ZSBj aGFuZ2VzLCB0aGUgdGltZXN0YW1wIGJhc2VkIG9uIG1fd3JpdGVDb3VudCBtYXkgYmUgd3Jvbmcu CiAgICAgLy8gRklYTUU6IFdlIHNob3VsZCB1cGRhdGUgbV93cml0ZUNvdW50IHRvIGJlIHZhbGlk IGFjY29yZGluZyB0aGUgbmV3IHNhbXBsZVJhdGUuCiAgICAgbV9zYW1wbGVDb252ZXJ0ZXItPnB1 c2hTYW1wbGVzKE1lZGlhVGltZShtX3dyaXRlQ291bnQsIHN0YXRpY19jYXN0PHVpbnQzMl90Piht X2lucHV0U3RyZWFtRGVzY3JpcHRpb24uc2FtcGxlUmF0ZSgpKSksIGF1ZGlvRGF0YSwgc2FtcGxl Q291bnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v bWFjL1JlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZS5oCmluZGV4IDc3 ZjU5NDE1NGMxN2YwZmRiN2MxMDYxMDI1NDg3ODM4YTM2ZDQwYjYuLmIzNDFmZmM3ZTljM2NlZWE0 Nzk2ZWE4ZWRiMzY0MGM2NTdiZWQ0ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21lZGlhc3RyZWFtL21hYy9SZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2UuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ0F1 ZGlvU291cmNlLmgKQEAgLTcwLDYgKzcwLDkgQEAgcHJpdmF0ZToKICAgICB2b2lkIHNvdXJjZUVu YWJsZWRDaGFuZ2VkKCk7CiAgICAgdm9pZCBhdWRpb1NhbXBsZXNBdmFpbGFibGUoY29uc3QgTWVk aWFUaW1lJiwgY29uc3QgUGxhdGZvcm1BdWRpb0RhdGEmLCBjb25zdCBBdWRpb1N0cmVhbURlc2Ny aXB0aW9uJiwgc2l6ZV90KTsKIAorICAgIGJvb2wgaXNSZWFjaGluZ0J1ZmZlcmVkQXVkaW9EYXRh SGlnaExpbWl0KCk7CisgICAgYm9vbCBpc1JlYWNoaW5nQnVmZmVyZWRBdWRpb0RhdGFMb3dMaW1p dCgpOworCiAgICAgLy8gTWVkaWFTdHJlYW1UcmFja1ByaXZhdGU6Ok9ic2VydmVyIEFQSQogICAg IHZvaWQgdHJhY2tNdXRlZENoYW5nZWQoTWVkaWFTdHJlYW1UcmFja1ByaXZhdGUmKSBmaW5hbCB7 IHNvdXJjZU11dGVkQ2hhbmdlZCgpOyB9CiAgICAgdm9pZCB0cmFja0VuYWJsZWRDaGFuZ2VkKE1l ZGlhU3RyZWFtVHJhY2tQcml2YXRlJikgZmluYWwgeyBzb3VyY2VFbmFibGVkQ2hhbmdlZCgpOyB9 CkBAIC05Miw2ICs5NSw3IEBAIHByaXZhdGU6CiAgICAgdWludDY0X3QgbV93cml0ZUNvdW50IHsg MCB9OwogICAgIGJvb2wgbV9tdXRlZCB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2VuYWJsZWQgeyB0 cnVlIH07CisgICAgYm9vbCBtX3NraXBwaW5nQXVkaW9EYXRhIHsgZmFsc2UgfTsKIH07CiAKIH0g Ly8gbmFtZXNwYWNlIFdlYkNvcmUK