174382 2017-07-11 13:30:04 -0700 [WebCrypto] CryptoKeyECMac::Custom OpenSSL tag is actually tagged type [1] 2017-07-11 16:11:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan bfulgham commit-queue jiewen_tan webkit-bug-importer oldest_to_newest 1327684 0 jiewen_tan 2017-07-11 13:30:04 -0700 In CryptoKeyECMac, we wrongly treat tagged type [1] as OpenSSL custom named curve tag. We should correct it. 1327685 1 webkit-bug-importer 2017-07-11 13:30:57 -0700 <rdar://problem/33244871> 1327694 2 315155 jiewen_tan 2017-07-11 13:40:02 -0700 Created attachment 315155 Patch 1327706 3 315155 bfulgham 2017-07-11 13:45:02 -0700 Comment on attachment 315155 Patch r=me, assuming the bots are happy. 1327707 4 bfulgham 2017-07-11 13:45:32 -0700 (In reply to Jiewen Tan from comment #0) > In CryptoKeyECMac, we wrongly treat tagged type [1] as OpenSSL custom named > curve tag. We should correct it. So this appears to just bring our implementation in line with the spec, instead of using a custom named type internally? Seems reasonable. 1327726 5 jiewen_tan 2017-07-11 13:57:29 -0700 (In reply to Brent Fulgham from comment #4) > (In reply to Jiewen Tan from comment #0) > > In CryptoKeyECMac, we wrongly treat tagged type [1] as OpenSSL custom named > > curve tag. We should correct it. > > So this appears to just bring our implementation in line with the spec, > instead of using a custom named type internally? Seems reasonable. Kind of. Before I didn't realize what those parts of binaries mean. Therefore, I thought it could be some custom types. But then I realized that those are tagged types. 1327813 6 315155 commit-queue 2017-07-11 16:11:44 -0700 Comment on attachment 315155 Patch Clearing flags on attachment: 315155 Committed r219371: <http://trac.webkit.org/changeset/219371> 1327814 7 commit-queue 2017-07-11 16:11:46 -0700 All reviewed patches have been landed. Closing bug. 315155 2017-07-11 13:40:02 -0700 2017-07-11 16:11:44 -0700 Patch bug-174382-20170711134006.patch text/plain 4763 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjBlZmU3N2ExMWFhZGQx NmRhNzk3ZjMzMGE4NjFmNjJjMTQ2NWNmOC4uZDZiMjFhM2I1ZjdhZTcyMDg5ODRhNjI0MjRlZmM3 ZTg5ZmEyZjEzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA3LTExICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkNyeXB0b10gQ3J5 cHRvS2V5RUNNYWM6OkN1c3RvbSBPcGVuU1NMIHRhZyBpcyBhY3R1YWxseSB0YWdnZWQgdHlwZSBb MV0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDM4 MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzMyNDQ4NzE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gY2hhbmdlIG9mIGJlaGF2aW91ci4KKwor ICAgICAgICAqIGNyeXB0by9tYWMvQ3J5cHRvS2V5RUNNYWMuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Q3J5cHRvS2V5RUM6OnBsYXRmb3JtSW1wb3J0UGtjczgpOgorICAgICAgICAoV2ViQ29yZTo6 Q3J5cHRvS2V5RUM6OnBsYXRmb3JtRXhwb3J0UGtjczgpOgorICAgICAgICBSZXBsYWNlIEN1c3Rv bUVDUGFyYW1ldGVycyB3aXRoIFRhZ2dlZFR5cGUxIGFjY29yZGluZyB0byBYLjY5MCgwOC8yMDE1 KSBzZWN0aW9uIDguMTQ6CisgICAgICAgIGh0dHBzOi8vd3d3Lml0dS5pbnQvcmVjL1QtUkVDLVgu NjkwLTIwMTUwOC1JL2VuCisgICAgICAgIGFuZCBSRkMgNTkxNSBBcHBlbmRpeCBBOgorICAgICAg ICBodHRwOi8vd3d3LmlldGYub3JnL3JmYy9yZmM1OTE1LnR4dC4KKwogMjAxNy0wNy0xMCAgQnJh ZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW51cCBsaWZldGlt ZSBpc3N1ZXMgb2YgVW5pcXVlSURCRGF0YWJhc2UgYW5kIElEQkJhY2tpbmdTdG9yZS4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2NyeXB0by9tYWMvQ3J5cHRvS2V5RUNNYWMuY3BwIGIvU291 cmNlL1dlYkNvcmUvY3J5cHRvL21hYy9DcnlwdG9LZXlFQ01hYy5jcHAKaW5kZXggNWJmMzFmZDAx ODE1OTRhZWU5YTc1YWFlMTA3Yjk2YWVhMzExM2NmNS4uYjdhZDRiMWQ4MWRmMzA0MWFmNmNmMmJk NTZiNTUxMTliNTJhOGI2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3J5cHRvL21hYy9D cnlwdG9LZXlFQ01hYy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3J5cHRvL21hYy9DcnlwdG9L ZXlFQ01hYy5jcHAKQEAgLTQ0LDEwICs0NCw4IEBAIHN0YXRpYyBjb25zdGV4cHIgdW5zaWduZWQg Y2hhciBTZWNwMjU2cjFbXSA9IHsweDA2LCAweDA4LCAweDJhLCAweDg2LCAweDQ4LCAweGNlCiBz dGF0aWMgY29uc3RleHByIHVuc2lnbmVkIGNoYXIgU2VjcDM4NHIxW10gPSB7MHgwNiwgMHgwNSwg MHgyYiwgMHg4MSwgMHgwNCwgMHgwMCwgMHgyMn07CiAvLyBWZXJzaW9uIDEuIFBlciBodHRwczov L3Rvb2xzLmlldGYub3JnL2h0bWwvcmZjNTkxNSNzZWN0aW9uLTMKIHN0YXRpYyBjb25zdCB1bnNp Z25lZCBjaGFyIFByaXZhdGVLZXlWZXJzaW9uW10gPSB7MHgwMiwgMHgwMSwgMHgwMX07Ci0vLyBD dXN0b20gT3BlblNTTCBFQ1BhcmFtZXRlcnMgVGFncwotc3RhdGljIGNvbnN0IHNpemVfdCBDdXN0 b21UYWdTaXplID0gMjsKLXN0YXRpYyBjb25zdGV4cHIgdW5zaWduZWQgY2hhciBFY1AyNTZbXSA9 IHsweGExLCAweDQ0fTsKLXN0YXRpYyBjb25zdGV4cHIgdW5zaWduZWQgY2hhciBFY1AzODRbXSA9 IHsweGExLCAweDY0fTsKKy8vIFRhZ2dlZCB0eXBlIFsxXQorc3RhdGljIGNvbnN0IHVuc2lnbmVk IGNoYXIgVGFnZ2VkVHlwZTEgPSAweGExOwogCiAvLyBQZXIgU2VjdGlvbiAyLjMuNCBvZiBodHRw Oi8vd3d3LnNlY2cub3JnL3NlYzEtdjIucGRmCiAvLyBXZSBvbmx5IHN1cHBvcnQgdW5jb21wcmVz c2VkIHBvaW50IGZvcm1hdC4KQEAgLTMxOSw3ICszMTcsMTAgQEAgUmVmUHRyPENyeXB0b0tleUVD PiBDcnlwdG9LZXlFQzo6cGxhdGZvcm1JbXBvcnRQa2NzOChDcnlwdG9BbGdvcml0aG1JZGVudGlm aWVyIGkKICAgICBpZiAoa2V5RGF0YS5zaXplKCkgPCBpbmRleCArIGdldEtleVNpemVGcm9tTmFt ZWRDdXJ2ZShjdXJ2ZSkgLyA4KQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICBzaXplX3Qg cHJpdmF0ZUtleVBvcyA9IGluZGV4OwotICAgIGluZGV4ICs9IGdldEtleVNpemVGcm9tTmFtZWRD dXJ2ZShjdXJ2ZSkgLyA4ICsgQ3VzdG9tVGFnU2l6ZSArIDE7IC8vIFJlYWQgcHJpdmF0ZUtleSwg Q3VzdG9tRUNQYXJhbWV0ZXJzLCBCSVQgU1RSSU5HCisgICAgaW5kZXggKz0gZ2V0S2V5U2l6ZUZy b21OYW1lZEN1cnZlKGN1cnZlKSAvIDggKyAxOyAvLyBSZWFkIHByaXZhdGVLZXksIFRhZ2dlZFR5 cGUxCisgICAgaWYgKGtleURhdGEuc2l6ZSgpIDwgaW5kZXggKyAxKQorICAgICAgICByZXR1cm4g bnVsbHB0cjsKKyAgICBpbmRleCArPSBieXRlc1VzZWRUb0VuY29kZWRMZW5ndGgoa2V5RGF0YVtp bmRleF0pICsgMTsgLy8gUmVhZCBsZW5ndGgsIEJJVCBTVFJJTkcKICAgICBpZiAoa2V5RGF0YS5z aXplKCkgPCBpbmRleCArIDEpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIGluZGV4ICs9 IGJ5dGVzVXNlZFRvRW5jb2RlZExlbmd0aChrZXlEYXRhW2luZGV4XSkgKyAxOyAvLyBSZWFkIGxl bmd0aCwgSW5pdGlhbE9jdGV0CkBAIC0zNTAsMTkgKzM1MSwxMyBAQCBWZWN0b3I8dWludDhfdD4g Q3J5cHRvS2V5RUM6OnBsYXRmb3JtRXhwb3J0UGtjczgoKSBjb25zdAogICAgIC8vIDxyZGFyOi8v cHJvYmxlbS8zMDk4NzYyOD4KICAgICBjb25zdCB1aW50OF90KiBvaWQ7CiAgICAgc2l6ZV90IG9p ZFNpemUgPSBnZXRPSUQobmFtZWRDdXJ2ZSgpLCBvaWQpOwotICAgIGNvbnN0IHVpbnQ4X3QqIGN1 c3RvbVRhZzsKLSAgICBzd2l0Y2ggKG5hbWVkQ3VydmUoKSkgewotICAgIGNhc2UgTmFtZWRDdXJ2 ZTo6UDI1NjoKLSAgICAgICAgY3VzdG9tVGFnID0gRWNQMjU2OwotICAgICAgICBicmVhazsKLSAg ICBjYXNlIE5hbWVkQ3VydmU6OlAzODQ6Ci0gICAgICAgIGN1c3RvbVRhZyA9IEVjUDM4NDsKLSAg ICB9CiAKICAgICAvLyBJbml0aWFsT2N0ZXQgKyAwNCArIFggKyBZCiAgICAgc2l6ZV90IHB1Ymxp Y0tleVNpemUgPSBrZXlTaXplSW5CeXRlcyAqIDIgKyAyOwotICAgIC8vIFZFUlNJT04gKyBPQ1RF VCBTVFJJTkcgKyBsZW5ndGgoMSkgKyBwcml2YXRlIGtleSArIEN1c3RvbUVDUGFyYW1ldGVycygy KSArIEJJVCBTVFJJTkcgKyBsZW5ndGgoPykgKyBwdWJsaWNLZXlTaXplCi0gICAgc2l6ZV90IGVj UHJpdmF0ZUtleVNpemUgPSBzaXplb2YoVmVyc2lvbikgKyBrZXlTaXplSW5CeXRlcyArIEN1c3Rv bVRhZ1NpemUgKyBieXRlc05lZWRlZEZvckVuY29kZWRMZW5ndGgocHVibGljS2V5U2l6ZSkgKyBw dWJsaWNLZXlTaXplICsgMzsKKyAgICAvLyBCSVQgU1RSSU5HICsgbGVuZ3RoKD8pICsgcHVibGlj S2V5U2l6ZQorICAgIHNpemVfdCB0YWdnZWRUeXBlU2l6ZSA9IGJ5dGVzTmVlZGVkRm9yRW5jb2Rl ZExlbmd0aChwdWJsaWNLZXlTaXplKSArIHB1YmxpY0tleVNpemUgKyAxOworICAgIC8vIFZFUlNJ T04gKyBPQ1RFVCBTVFJJTkcgKyBsZW5ndGgoMSkgKyBwcml2YXRlIGtleSArIFRhZ2dlZFR5cGUx KDEpICsgbGVuZ3RoKD8pICsgQklUIFNUUklORyArIGxlbmd0aCg/KSArIHB1YmxpY0tleVNpemUK KyAgICBzaXplX3QgZWNQcml2YXRlS2V5U2l6ZSA9IHNpemVvZihWZXJzaW9uKSArIGtleVNpemVJ bkJ5dGVzICsgYnl0ZXNOZWVkZWRGb3JFbmNvZGVkTGVuZ3RoKHRhZ2dlZFR5cGVTaXplKSArIGJ5 dGVzTmVlZGVkRm9yRW5jb2RlZExlbmd0aChwdWJsaWNLZXlTaXplKSArIHB1YmxpY0tleVNpemUg KyA0OwogICAgIC8vIFNFUVVFTkNFICsgbGVuZ3RoKD8pICsgZWNQcml2YXRlS2V5U2l6ZQogICAg IHNpemVfdCBwcml2YXRlS2V5U2l6ZSA9IGJ5dGVzTmVlZGVkRm9yRW5jb2RlZExlbmd0aChlY1By aXZhdGVLZXlTaXplKSArIGVjUHJpdmF0ZUtleVNpemUgKyAxOwogICAgIC8vIFZFUlNJT04gKyBT RVFVRU5DRSArIGxlbmd0aCgxKSArIE9JRCBpZC1lY1B1YmxpY0tleSArIE9JRCBzZWNwMjU2cjEv T0lEIHNlY3AzODRyMSArIE9DVEVUIFNUUklORyArIGxlbmd0aCg/KSArIHByaXZhdGVLZXlTaXpl CkBAIC0zODUsNyArMzgwLDggQEAgVmVjdG9yPHVpbnQ4X3Q+IENyeXB0b0tleUVDOjpwbGF0Zm9y bUV4cG9ydFBrY3M4KCkgY29uc3QKICAgICByZXN1bHQuYXBwZW5kKE9jdGV0U3RyaW5nTWFyayk7 CiAgICAgYWRkRW5jb2RlZEFTTjFMZW5ndGgocmVzdWx0LCBrZXlTaXplSW5CeXRlcyk7CiAgICAg cmVzdWx0LmFwcGVuZChrZXlCeXRlcy5kYXRhKCkgKyBwdWJsaWNLZXlTaXplIC0gMSwga2V5U2l6 ZUluQnl0ZXMpOwotICAgIHJlc3VsdC5hcHBlbmQoY3VzdG9tVGFnLCBDdXN0b21UYWdTaXplKTsK KyAgICByZXN1bHQuYXBwZW5kKFRhZ2dlZFR5cGUxKTsKKyAgICBhZGRFbmNvZGVkQVNOMUxlbmd0 aChyZXN1bHQsIHRhZ2dlZFR5cGVTaXplKTsKICAgICByZXN1bHQuYXBwZW5kKEJpdFN0cmluZ01h cmspOwogICAgIGFkZEVuY29kZWRBU04xTGVuZ3RoKHJlc3VsdCwgcHVibGljS2V5U2l6ZSk7CiAg ICAgcmVzdWx0LmFwcGVuZChJbml0aWFsT2N0ZXQpOwo=