174377 2017-07-11 11:35:38 -0700 [WebRTC] Hanging under LibWebRTCMediaEndpoint::getStats 2017-07-11 13:46:29 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson joepeck oldest_to_newest 1327620 0 youennf 2017-07-11 11:35:38 -0700 getStats for logging is done in the main thread. It then does a synchronous call to the signaling thread. In case the signaling thread is busy, the main thread will be blocked. It might be better to post a task instead to the signaling thread so as not to block main thread. 1327625 1 315140 youennf 2017-07-11 11:43:29 -0700 Created attachment 315140 Patch 1327626 2 youennf 2017-07-11 11:43:54 -0700 rdar://problem/32515212 1327627 3 youennf 2017-07-11 11:44:52 -0700 We could contemplate to do that for all calls but getStats is the one that will usually happen most often during the calls where there might be bottleneck issues 1327708 4 315140 commit-queue 2017-07-11 13:46:28 -0700 Comment on attachment 315140 Patch Clearing flags on attachment: 315140 Committed r219359: <http://trac.webkit.org/changeset/219359> 1327709 5 commit-queue 2017-07-11 13:46:29 -0700 All reviewed patches have been landed. Closing bug. 315140 2017-07-11 11:43:29 -0700 2017-07-11 13:46:28 -0700 Patch bug-174377-20170711114329.patch text/plain 3762 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjMxN2JkZDQ3M2NjZDc4 YWRjZDBjY2Y3MzFiZGIzYzcyMTVkNTU3NC4uYmM4NTM1NzcwMzRjYWUwNjU0ZjgyNjQ3MWMwOTQy ZDQ2NGNlZTQ4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA3LTExICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViUlRDXSBIYW5naW5n IHVuZGVyIExpYldlYlJUQ01lZGlhRW5kcG9pbnQ6OmdldFN0YXRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQzNzcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisg ICAgICAgIE1vdmluZyBjYWxscyB0byBsaWJ3ZWJydGMgZ2V0U3RhdHMgaW4gdGhlIHNpZ25hbGxp bmcgdGhyZWFkIHNpbmNlIGRvaW5nIGl0IGluIHRoZSBtYWluIHRocmVhZAorICAgICAgICB3b3Vs ZCBibG9jayB0aGUgbWFpbiB0aHJlYWQgdW50aWwgdGhlIHNpZ25hbGxpbmcgdGhyZWFkIGlzIHJl YWR5IHRvIGhhbmRsZSBnZXRTdGF0cy4KKyAgICAgICAgUmVkdWNpbmcgc3RhdCBsb2dnaW5nIHNp bmNlIHRoaXMgbWF5IGJlIHRvbyBtdWNoIGZvciBzb21lIGRldmljZXMuCisKKyAgICAgICAgKiBN b2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkxpYldlYlJUQ01lZGlhRW5kcG9pbnQ6OmdldFN0YXRzKToKKyAg ICAgICAgKFdlYkNvcmU6OkxpYldlYlJUQ01lZGlhRW5kcG9pbnQ6OmdhdGhlclN0YXRzRm9yTG9n Z2luZyk6CisgICAgICAgIChXZWJDb3JlOjpMaWJXZWJSVENNZWRpYUVuZHBvaW50OjpPblN0YXRz RGVsaXZlcmVkKToKKyAgICAgICAgKFdlYkNvcmU6OkxpYldlYlJUQ01lZGlhRW5kcG9pbnQ6OnN0 YXJ0TG9nZ2luZ1N0YXRzKToKKwogMjAxNy0wNy0xMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CiAKICAgICAgICAgV2Ugc2hvdWxkIGRvIElDRSBjYW5kaWRhdGUgZmlsdGVyaW5n IGF0IHRoZSBEb2N1bWVudCBsZXZlbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDTWVkaWFFbmRwb2ludC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVu ZHBvaW50LmNwcAppbmRleCBjYzAwNmFhMjNjYzJmY2MxNzgzZDRmZWEyNTI4YzA0NTVkYTZlYjA0 Li43ZmI1ZDUwMzViYjRjY2U5ZWUwZDFlYjNiNzU5OTQ5ODEyMzE2MDVjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRp YUVuZHBvaW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xp YndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50LmNwcApAQCAtMjcwLDkgKzI3MCwxMSBAQCB2 b2lkIExpYldlYlJUQ01lZGlhRW5kcG9pbnQ6OmRvQ3JlYXRlQW5zd2VyKCkKIAogdm9pZCBMaWJX ZWJSVENNZWRpYUVuZHBvaW50OjpnZXRTdGF0cyhNZWRpYVN0cmVhbVRyYWNrKiB0cmFjaywgY29u c3QgRGVmZXJyZWRQcm9taXNlJiBwcm9taXNlKQogewotICAgIFVOVVNFRF9QQVJBTSh0cmFjayk7 Ci0gICAgVU5VU0VEX1BBUkFNKHByb21pc2UpOwotICAgIG1fYmFja2VuZC0+R2V0U3RhdHMoU3Rh dHNDb2xsZWN0b3I6OmNyZWF0ZSgqdGhpcywgcHJvbWlzZSwgdHJhY2spLmdldCgpKTsKKyAgICBh dXRvIGNvbGxlY3RvciA9IFN0YXRzQ29sbGVjdG9yOjpjcmVhdGUoKnRoaXMsIHByb21pc2UsIHRy YWNrKTsKKyAgICBMaWJXZWJSVENQcm92aWRlcjo6Y2FsbE9uV2ViUlRDU2lnbmFsaW5nVGhyZWFk KFtwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGNvbGxlY3RvciA9IFdURk1vdmUoY29s bGVjdG9yKV0geworICAgICAgICBpZiAocHJvdGVjdGVkVGhpcy0+bV9iYWNrZW5kKQorICAgICAg ICAgICAgcHJvdGVjdGVkVGhpcy0+bV9iYWNrZW5kLT5HZXRTdGF0cyhjb2xsZWN0b3IuZ2V0KCkp OworICAgIH0pOwogfQogCiBMaWJXZWJSVENNZWRpYUVuZHBvaW50OjpTdGF0c0NvbGxlY3Rvcjo6 U3RhdHNDb2xsZWN0b3IoUmVmPExpYldlYlJUQ01lZGlhRW5kcG9pbnQ+JiYgZW5kcG9pbnQsIGNv bnN0IERlZmVycmVkUHJvbWlzZSYgcHJvbWlzZSwgTWVkaWFTdHJlYW1UcmFjayogdHJhY2spCkBA IC0xMDQwLDE4ICsxMDQyLDE5IEBAIFJUQ1J0cFBhcmFtZXRlcnMgTGliV2ViUlRDTWVkaWFFbmRw b2ludDo6Z2V0UlRDUnRwU2VuZGVyUGFyYW1ldGVycyhSVENSdHBTZW5kZXImCiAKIHZvaWQgTGli V2ViUlRDTWVkaWFFbmRwb2ludDo6Z2F0aGVyU3RhdHNGb3JMb2dnaW5nKCkKIHsKLSAgICBBU1NF UlQobV9iYWNrZW5kKTsKLSAgICBpZiAobV9iYWNrZW5kKQotICAgICAgICBtX2JhY2tlbmQtPkdl dFN0YXRzKHRoaXMpOworICAgIExpYldlYlJUQ1Byb3ZpZGVyOjpjYWxsT25XZWJSVENTaWduYWxp bmdUaHJlYWQoW3Byb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKV0geworICAgICAgICBpZiAo cHJvdGVjdGVkVGhpcy0+bV9iYWNrZW5kKQorICAgICAgICAgICAgcHJvdGVjdGVkVGhpcy0+bV9i YWNrZW5kLT5HZXRTdGF0cyhwcm90ZWN0ZWRUaGlzLnB0cigpKTsKKyAgICB9KTsKIH0KIAogdm9p ZCBMaWJXZWJSVENNZWRpYUVuZHBvaW50OjpPblN0YXRzRGVsaXZlcmVkKGNvbnN0IHJ0Yzo6c2Nv cGVkX3JlZnB0cjxjb25zdCB3ZWJydGM6OlJUQ1N0YXRzUmVwb3J0PiYgcmVwb3J0KQogewogICAg IGlmICghbV9zdGF0c1RpbWVzdGFtcCkKICAgICAgICAgbV9zdGF0c1RpbWVzdGFtcCA9IHJlcG9y dC0+dGltZXN0YW1wX3VzKCk7Ci0gICAgZWxzZSBpZiAobV9zdGF0c0xvZ1RpbWVyLnJlcGVhdElu dGVydmFsKCkgPT0gMV9zICYmIChyZXBvcnQtPnRpbWVzdGFtcF91cygpIC0gbV9zdGF0c1RpbWVz dGFtcCkgPiAzMDAwMDAwMCkgeworICAgIGVsc2UgaWYgKG1fc3RhdHNMb2dUaW1lci5yZXBlYXRJ bnRlcnZhbCgpID09IDJfcyAmJiAocmVwb3J0LT50aW1lc3RhbXBfdXMoKSAtIG1fc3RhdHNUaW1l c3RhbXApID4gMTUwMDAwMDApIHsKICAgICAgICAgY2FsbE9uTWFpblRocmVhZChbcHJvdGVjdGVk VGhpcyA9IG1ha2VSZWYoKnRoaXMpXSB7Ci0gICAgICAgICAgICBwcm90ZWN0ZWRUaGlzLT5tX3N0 YXRzTG9nVGltZXIuYXVnbWVudFJlcGVhdEludGVydmFsKDRfcyk7CisgICAgICAgICAgICBwcm90 ZWN0ZWRUaGlzLT5tX3N0YXRzTG9nVGltZXIuYXVnbWVudFJlcGVhdEludGVydmFsKDlfcyk7CiAg ICAgICAgIH0pOwogICAgIH0KIApAQCAtMTA3Miw3ICsxMDc1LDcgQEAgdm9pZCBMaWJXZWJSVENN ZWRpYUVuZHBvaW50OjpzdGFydExvZ2dpbmdTdGF0cygpCiAjaWYgIVJFTEVBU0VfTE9HX0RJU0FC TEVECiAgICAgaWYgKG1fc3RhdHNMb2dUaW1lci5pc0FjdGl2ZSgpKQogICAgICAgICBtX3N0YXRz TG9nVGltZXIuc3RvcCgpOwotICAgIG1fc3RhdHNMb2dUaW1lci5zdGFydFJlcGVhdGluZygxX3Mp OworICAgIG1fc3RhdHNMb2dUaW1lci5zdGFydFJlcGVhdGluZygyX3MpOwogI2VuZGlmCiB9CiAK