174333 2017-07-10 16:54:22 -0700 Adjust unpartitioned cookie time-to-live to 48 hours 2017-07-13 15:16:51 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=174402 InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham cdumez ggaren mjs webkit-bug-importer oldest_to_newest 1327262 0 bfulgham 2017-07-10 16:54:22 -0700 Adjust unpartitioned cookie time-to-live from 24 to 48 hours to reduce website compatibility impact. 1327264 1 bfulgham 2017-07-10 16:54:44 -0700 <rdar://problem/33164423> 1327271 2 315047 bfulgham 2017-07-10 16:56:26 -0700 Created attachment 315047 Patch 1327768 3 315047 cdumez 2017-07-11 15:11:29 -0700 Comment on attachment 315047 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315047&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:445 > + store->setTimeToLiveCookiePartitionFree(48_h); This is only used for testing. You need to update WebResourceLoadStatisticsStore::m_timeToLiveCookiePartitionFree's default value otherwise it won't do what you want. 1327776 4 315047 cdumez 2017-07-11 15:25:43 -0700 Comment on attachment 315047 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315047&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:443 > // FIXME: These needs to match the default data member values in ResourceLoadStatistics, which is fragile. I'll fix this to make it less error prone. 1327830 5 cdumez 2017-07-11 16:28:42 -0700 (In reply to Chris Dumez from comment #4) > Comment on attachment 315047 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315047&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:443 > > // FIXME: These needs to match the default data member values in ResourceLoadStatistics, which is fragile. > > I'll fix this to make it less error prone. Doing this via https://bugs.webkit.org/show_bug.cgi?id=174402. 1328574 6 bfulgham 2017-07-13 15:16:51 -0700 We decided not to make this change. 315047 2017-07-10 16:56:26 -0700 2017-07-11 15:11:29 -0700 Patch bug-174333-20170710165625.patch text/plain 2831 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxOTMxNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA3LTEwICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFkanVzdCB1bnBhcnRpdGlv bmVkIGNvb2tpZSB0aW1lLXRvLWxpdmUgdG8gNDggaG91cnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDMzMworICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzMxNjQ0MjM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFTdG9yZS5tbToKKyAgICAg ICAgKC1bV0tXZWJzaXRlRGF0YVN0b3JlIF9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzUmVzZXRUb0Nv bnNpc3RlbnRTdGF0ZV0pOiBTd2l0Y2gKKyAgICAgICAgZGVmYXVsdCB0byA0OCBob3Vycy4KKyAg ICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlQ29j b2EubW06CisgICAgICAgIChXZWJLaXQ6OldlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6 cmVnaXN0ZXJVc2VyRGVmYXVsdHNJZk5lZWRlZCk6IFNldAorICAgICAgICB1cHBlciBsaW1pdCB0 byA0OCBob3Vycy4KKwogMjAxNy0wNy0xMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIFtpT1NdIF9kaWRDb21taXRMYXllclRyZWUgc2hvdWxkIGF2b2lkIGNhbGxp bmcgW3Njcm9sbFZpZXcgc2V0Wm9vbVNjYWxlXSB1bm5lY2Vzc2FyaWx5CkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFTdG9yZS5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFT dG9yZS5tbQkocmV2aXNpb24gMjE5MzEyKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1dlYnNpdGVEYXRhU3RvcmUubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ0Miw3ICs0 NDIsNyBAQCAtICh2b2lkKV9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzUmVzZXRUb0NvCiAKICAgICAv LyBGSVhNRTogVGhlc2UgbmVlZHMgdG8gbWF0Y2ggdGhlIGRlZmF1bHQgZGF0YSBtZW1iZXIgdmFs dWVzIGluIFJlc291cmNlTG9hZFN0YXRpc3RpY3MsIHdoaWNoIGlzIGZyYWdpbGUuCiAgICAgc3Rv cmUtPnNldFRpbWVUb0xpdmVVc2VySW50ZXJhY3Rpb24oc3RkOjpudWxsb3B0KTsKLSAgICBzdG9y ZS0+c2V0VGltZVRvTGl2ZUNvb2tpZVBhcnRpdGlvbkZyZWUoMjRfaCk7CisgICAgc3RvcmUtPnNl dFRpbWVUb0xpdmVDb29raWVQYXJ0aXRpb25GcmVlKDQ4X2gpOwogICAgIHN0b3JlLT5zZXRNaW5p bXVtVGltZUJldHdlZW5EYXRhUmVjb3Jkc1JlbW92YWwoMV9oKTsKICAgICBzdG9yZS0+c2V0R3Jh bmRmYXRoZXJpbmdUaW1lKDFfaCk7CiAgICAgc3RvcmUtPnNldE5vdGlmeVBhZ2VzV2hlbkRhdGFS ZWNvcmRzV2VyZVNjYW5uZWQoZmFsc2UpOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0NvY29hL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZUNvY29hLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0 aWNzU3RvcmVDb2NvYS5tbQkocmV2aXNpb24gMjE5MzEyKQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0NvY29hL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZUNvY29hLm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC01Miw3ICs1Miw3IEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGlj c1N0b3JlOjpyZWcKICAgICAgICAgICAgIHNldFRpbWVUb0xpdmVVc2VySW50ZXJhY3Rpb24oU2Vj b25kcyB7IHRpbWVUb0xpdmVVc2VySW50ZXJhY3Rpb24gfSk7CiAKICAgICAgICAgZG91YmxlIHRp bWVUb0xpdmVDb29raWVQYXJ0aXRpb25GcmVlID0gW1tOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVz ZXJEZWZhdWx0c10gZG91YmxlRm9yS2V5OiBXZWJQcmVmZXJlbmNlc0tleTo6cmVzb3VyY2VMb2Fk U3RhdGlzdGljc1RpbWVUb0xpdmVDb29raWVQYXJ0aXRpb25GcmVlS2V5KCldOwotICAgICAgICBp ZiAodGltZVRvTGl2ZUNvb2tpZVBhcnRpdGlvbkZyZWUgPiAwICYmIHRpbWVUb0xpdmVDb29raWVQ YXJ0aXRpb25GcmVlIDw9IGRheUluU2Vjb25kcykKKyAgICAgICAgaWYgKHRpbWVUb0xpdmVDb29r aWVQYXJ0aXRpb25GcmVlID4gMCAmJiB0aW1lVG9MaXZlQ29va2llUGFydGl0aW9uRnJlZSA8PSAy ICogZGF5SW5TZWNvbmRzKQogICAgICAgICAgICAgc2V0VGltZVRvTGl2ZUNvb2tpZVBhcnRpdGlv bkZyZWUoU2Vjb25kcyB7IHRpbWVUb0xpdmVDb29raWVQYXJ0aXRpb25GcmVlIH0pOwogCiAgICAg ICAgIGRvdWJsZSBncmFuZGZhdGhlcmluZ1RpbWUgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJk VXNlckRlZmF1bHRzXSBkb3VibGVGb3JLZXk6IFdlYlByZWZlcmVuY2VzS2V5OjpyZXNvdXJjZUxv YWRTdGF0aXN0aWNzR3JhbmRmYXRoZXJpbmdUaW1lS2V5KCldOwo=