17433 2008-02-18 21:01:16 -0800 getComputedStyle() -> clip returns empty string 2008-08-19 16:49:43 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 CLOSED FIXED InRadar P2 Normal --- 1 xk1t webkit-unassigned bdakin mrowe oldest_to_newest 71111 0 xk1t 2008-02-18 21:01:16 -0800 getComputedStyle(el,'').getPropertyValue('clip') returns empty string. Should return a clip value, e.g "rect(10px, 10px, 0px, 0px)" 71113 1 19205 xk1t 2008-02-18 21:59:32 -0800 Created attachment 19205 testcase showing problem 80604 2 21195 rwlbuis 2008-05-16 00:01:24 -0700 Created attachment 21195 First attempt So now we give a better CSSPrimitiveValue for the computed value of 'clip'. What is not completely clear to me is how to treat 'auto'. Right now it returns rect(0px, 0px, 0px, 0px), I would have expected something with at least a width and height, also no clipping can be seen. However if I specify rect(0px, 0px, 0px, 0px) explicitly, there is clipping. I don't see how a distinction is made between these two cases, and whether it is relevant for the computed value. Opera also returns what we return for auto, FF3 just returns 'auto'. Cheers, Rob. 80605 3 21195 hyatt 2008-05-16 00:03:13 -0700 Comment on attachment 21195 First attempt r=me 80644 4 rwlbuis 2008-05-16 12:15:55 -0700 Landed in r33513. 81108 5 harrison 2008-05-21 11:52:52 -0700 btw this also rdar://5875146 86070 6 xk1t 2008-07-16 10:42:36 -0700 (In reply to comment #2) > Created an attachment (id=21195) [edit] > First attempt > > So now we give a better CSSPrimitiveValue for the computed value of 'clip'. > What is not completely clear to me is how to treat 'auto'. "rect(0, " + el.offsetWidth +", " + el.offsetHeight +", " + "0)" > Right now it returns > rect(0px, 0px, 0px, 0px), That's worse than returning an empty string. Before the "fix", if computedStyle.clip was the empty string, it was logical to assume that the value couldn't be read. Now it's impossible to tell what the actual computed value is where as b. Is the element really clipped, or is this the result of a bug 17433's "fix"? > I would have expected something with at least a width > and height, also no clipping can be seen. Of course. > However if I specify rect(0px, 0px, > 0px, 0px) explicitly, there is clipping. That seems to violate transivity. > I don't see how a distinction is made > between these two cases, and whether it is relevant for the computed value. > Opera also returns what we return for auto, FF3 just returns 'auto'. returning 'auto' is wrong. That is not the CSS 2.1 computed value for clip. The computed value for clip is defined by css 2.1: http://www.w3.org/TR/CSS21/visufx.html#clipping | Computed value: For rectangle values, a rectangle | consisting of four computed lengths; otherwise, as specified Returning all zeros, or "rect(0px, 0px, 0px, 0px)", is obviously inaccurate and intransitive, as you noticed. If the computedStyle.clip is all zeros, and is used to set el.style.clip, it will result in the element being clipped. Obviously, the error is in the computedStyle.clip incorrectly returning all zeros. This can be demonstrated by an example:- <!DOCTYPE HTML> <html lang="en"> <head> <title>Clip Test</title> </head> <body> <div style="position: absolute" id="el" >will be clipped?</div> <script> var el = document.getElementById('el'), // Since readStyle.clip returns empty string in current Webkit, // use a "mock" object. readStyle = {clip: "rect(0px, 0px, 0px, 0px)"}; //readStyle = getComputedStyle(el,''), style = el.style; alert(style.clip = readStyle.clip); alert("getPropertyCSSValue('clip'): " +getComputedStyle(el,'').getPropertyCSSValue('clip')); </script> </body> </html> To solve the problem, return a correct length. This is as simple as:- "rect(0, " + el.offsetWidth +", " + el.offsetHeight +", " + "0)" We can also see that 'getPropertyCSSValue' does not return a Rect for clip but returns null instead. (Method getPropertyCSSValue should also return the correct computed lengths (not all zeros).) There is a need for a determination between "absolute" value and "computed" value in the DOM Style specs. > > Rob. > 86150 7 xk1t 2008-07-16 22:33:36 -0700 The value should be comma separated. I would recommend that the assertion for the unit test you make not have a hardcoded value for "rect(5px 24px 1px 12px)". http://www.w3.org/TR/CSS21/visufx.html#clipping | Authors should separate offset values with commas. User agents must | support separation with commas, but may also support separation without | commas, because a previous revision of this specification was ambiguous in | this respect. Don't return space-separated values. Return a rect() string with comma-separated values, as the CSS2.1 specification recommends. 87036 8 mrowe 2008-07-26 22:31:33 -0700 Garrett, could you please file a new bug report about the problems you have observed in the current implementation? 87056 9 xk1t 2008-07-26 23:15:48 -0700 The current implementation that I have, of Safari 3, on Mac, clip returns an empty string. That is this bug, and it is described in comment 0. 87057 10 mrowe 2008-07-26 23:19:29 -0700 A patch was landed in r33513 to address getComputedStyle returning an empty string. You then reopened this bug report due to issues in the new results. You should file a new bug report about those issues and this bug report should be closed. 87058 11 xk1t 2008-07-26 23:20:18 -0700 Then I will have to download a nightly build. 88863 12 xk1t 2008-08-19 16:23:11 -0700 Created Bug 20454 This bug is not FIXED. Perhaps its best marked WONTFIX? 88865 13 mrowe 2008-08-19 16:27:21 -0700 It will be marked as FIXED as it no longer returns an empty string, which was the originally reported issue. If we had decided to keep it returning an empty string then WONTFIX would be an appropriate resolution. The issues in the return value will be tracked via the new bug report. Thanks for filing it! 88868 14 xk1t 2008-08-19 16:45:03 -0700 not really fixed. Just created a new bug. 88869 15 xk1t 2008-08-19 16:45:58 -0700 WONTFIX, (only because I didn't find a more appropriate option) 88870 16 mrowe 2008-08-19 16:48:13 -0700 As I mentioned, WONTFIX is not appropriate here. 88871 17 mrowe 2008-08-19 16:49:43 -0700 Fixes to bugs occasionally introduce new bugs. That does not mean that we have no intent to fix the original issue, nor that the original issue is unfixed. When new bugs are introduced, they are tracked separately. You've already filed the new bug report, so I see no need for you to keep fiddling with the status of this bug report. 19205 2008-02-18 21:59:32 -0800 2008-02-18 21:59:32 -0800 testcase showing problem clipWebkit.html text/html 706 xk1t IDwhRE9DVFlQRSBodG1sIFBVQkxJQyAiLS8vVzNDLy9EVEQgWEhUTUwgMS4xLy9FTiINCiAgICAg ICAgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMTEvRFREL3hodG1sMTEuZHRkIj4NCjxodG1s IHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIiB4bWw6bGFuZz0iZW4iPg0KPGhl YWQ+DQoJPG1ldGEgaHR0cC1lcXVpdj0iY29udGVudC10eXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7 IGNoYXJzZXQ9aXNvLTg4NTktMSIgLz4NCiAgICA8dGl0bGU+Y2xpcDwvdGl0bGU+DQo8c3R5bGU+ DQpkaXYgew0KICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsgDQogICAgd2lkdGg6IDIwZW07DQogICAg aGVpZ2h0OiAxLjVlbTsNCn0NCg0KPC9zdHlsZT4NCg0KPC9oZWFkPg0KPGJvZHk+DQoNCjxoMT5j bGlwPC9oMT4NCjxkaXYgc3R5bGU9ImNsaXA6IHJlY3QoMCAyMmVtIDNlbSAwKTtwb3NpdGlvbjph YnNvbHV0ZTtiYWNrZ3JvdW5kOiByZWQ7IGJvcmRlcjogMXB4IHNvbGlkIHBpbms7IiA+DQogICAg PGJ1dHRvbiBzdHlsZT0id2hpdGUtc3BhY2U6cHJlIg0KICAgICAgICBvbmNsaWNrPSJldmFsKHRo aXMudGV4dENvbnRlbnQpIj5hbGVydCggDQogICAgICAgIGdldENvbXB1dGVkU3R5bGUodGhpcy5w YXJlbnROb2RlLCcnKS5nZXRQcm9wZXJ0eVZhbHVlKCdjbGlwJykgDQopPC9idXR0b24+DQo8L2Rp dj4NCg0KPC9ib2R5Pg0KPC9odG1sPg== 21195 2008-05-16 00:01:24 -0700 2008-05-16 00:03:13 -0700 First attempt 17433.diff text/plain 4063 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMzUxMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDgtMDUtMTUgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQzMworICAgICAgICBnZXRDb21wdXRlZFN0 eWxlKCkgLT4gY2xpcCByZXR1cm5zIGVtcHR5IHN0cmluZworCisgICAgICAgIE1ha2UgZ2V0Q29t cHV0ZWRTdHlsZSByZXR1cm4gYSBzaGFwZSB2YWx1ZSBmb3IgY2xpcAorICAgICAgICBpZiBpdCBp cyBzZXQuCisKKyAgICAgICAgVGVzdHM6IGZhc3QvY3NzL2dldFByb3BlcnR5VmFsdWUtY2xpcC5o dG1sCisKKyAgICAgICAgKiBjc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6Z2V0UHJvcGVydHlD U1NWYWx1ZSk6CisKIDIwMDgtMDUtMTUgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2 aWVycy5jb20+CiAKICAgICAgICAgd3ggYnVpbGQgZml4LiBBZGQgcmVuZGVyaW5nL3N0eWxlIHRv IGluY2x1ZGVzIGRpci4KSW5kZXg6IFdlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJh dGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xh cmF0aW9uLmNwcAkocmV2aXNpb24gMzM1MTIpCisrKyBXZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0 eWxlRGVjbGFyYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDAwLDYgKzEwMDAsMTggQEAg UGFzc1JlZlB0cjxDU1NWYWx1ZT4gQ1NTQ29tcHV0ZWRTdHlsZURlYwogICAgICAgICAgICAgcmV0 dXJuIGdldEJvcmRlclJhZGl1c0Nvcm5lclZhbHVlKHN0eWxlLT5ib3JkZXJUb3BMZWZ0UmFkaXVz KCkpOwogICAgICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyVG9wUmlnaHRSYWRpdXM6 CiAgICAgICAgICAgICByZXR1cm4gZ2V0Qm9yZGVyUmFkaXVzQ29ybmVyVmFsdWUoc3R5bGUtPmJv cmRlclRvcFJpZ2h0UmFkaXVzKCkpOworICAgICAgICBjYXNlIENTU1Byb3BlcnR5Q2xpcDoKKyAg ICAgICAgeworICAgICAgICAgICAgaWYgKHN0eWxlLT5oYXNDbGlwKCkpIHsKKyAgICAgICAgICAg ICAgICBSZWN0KiByZWN0ID0gbmV3IFJlY3QoKTsKKyAgICAgICAgICAgICAgICByZWN0LT5zZXRU b3AobmV3IENTU1ByaW1pdGl2ZVZhbHVlKHN0eWxlLT5jbGlwKCkudG9wLnZhbHVlKCksIENTU1By aW1pdGl2ZVZhbHVlOjpDU1NfUFgpKTsKKyAgICAgICAgICAgICAgICByZWN0LT5zZXRSaWdodChu ZXcgQ1NTUHJpbWl0aXZlVmFsdWUoc3R5bGUtPmNsaXAoKS5yaWdodC52YWx1ZSgpLCBDU1NQcmlt aXRpdmVWYWx1ZTo6Q1NTX1BYKSk7CisgICAgICAgICAgICAgICAgcmVjdC0+c2V0Qm90dG9tKG5l dyBDU1NQcmltaXRpdmVWYWx1ZShzdHlsZS0+Y2xpcCgpLmJvdHRvbS52YWx1ZSgpLCBDU1NQcmlt aXRpdmVWYWx1ZTo6Q1NTX1BYKSk7CisgICAgICAgICAgICAgICAgcmVjdC0+c2V0TGVmdChuZXcg Q1NTUHJpbWl0aXZlVmFsdWUoc3R5bGUtPmNsaXAoKS5sZWZ0LnZhbHVlKCksIENTU1ByaW1pdGl2 ZVZhbHVlOjpDU1NfUFgpKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gbmV3IENTU1ByaW1pdGl2 ZVZhbHVlKHJlY3QpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgcmV0dXJuIDA7CisgICAg ICAgIH0KICAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eUJhY2tncm91bmQ6CiAgICAgICAgIGNhc2Ug Q1NTUHJvcGVydHlCb3JkZXI6CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlCb3JkZXJCb3R0b206 CkBAIC0xMDA5LDcgKzEwMjEsNiBAQCBQYXNzUmVmUHRyPENTU1ZhbHVlPiBDU1NDb21wdXRlZFN0 eWxlRGVjCiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlCb3JkZXJTdHlsZToKICAgICAgICAgY2Fz ZSBDU1NQcm9wZXJ0eUJvcmRlclRvcDoKICAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eUJvcmRlcldp ZHRoOgotICAgICAgICBjYXNlIENTU1Byb3BlcnR5Q2xpcDoKICAgICAgICAgY2FzZSBDU1NQcm9w ZXJ0eUNvbnRlbnQ6CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlDb3VudGVySW5jcmVtZW50Ogog ICAgICAgICBjYXNlIENTU1Byb3BlcnR5Q291bnRlclJlc2V0OgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9jc3MvZ2V0UHJvcGVydHlWYWx1ZS1jbGlwLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9nZXRQcm9wZXJ0eVZhbHVlLWNsaXAtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jc3MvZ2V0UHJvcGVydHlWYWx1ZS1j bGlwLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorUEFTU0VECkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9nZXRQcm9wZXJ0eVZhbHVlLWNsaXAuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9nZXRQcm9wZXJ0eVZhbHVlLWNsaXAuaHRtbAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY3NzL2dldFByb3BlcnR5VmFsdWUtY2xp cC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDM1IEBACis8IURPQ1RZUEUgSFRNTCBQVUJM SUMgIi0vL1czQy8vRFREIEhUTUwgNC4wLy9FTiI+Cis8aHRtbCBsYW5nPSJlbiI+CisgPGhlYWQ+ CisgIDx0aXRsZT5jbGlwIGNvbXB1dGVkIHN0eWxlPC90aXRsZT4KKyA8c3R5bGUgdHlwZT0idGV4 dC9jc3MiPgorICAgZGl2IHsgaGVpZ2h0OiA1ZW07IHdpZHRoOiAxMGVtOyBmb250LXNpemU6MTJw eCB9CisgIDwvc3R5bGU+CisgIDxzY3JpcHQ+CisgICAgZnVuY3Rpb24gbG9nKG1lc3NhZ2UpIHsK KyAgICAgIHZhciBjb25zb2xlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKTsK KyAgICAgIGNvbnNvbGUuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobWVzc2Fn ZSArICJcbiIpKTsKKyAgICB9CisgICAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIAorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQXNUZXh0KCk7CisgICAgICB2YXIgZGl2ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImNsaXAiKTsKKyAgICAgIGlmIChnZXRDb21wdXRlZFN0eWxlKGRpdiwnJykuZ2V0UHJvcGVydHlW YWx1ZSgiY2xpcCIpICE9ICJyZWN0KDVweCAyNHB4IDFweCAxMnB4KSIpIHsKKyAgICAgICAgICBs b2coIkZBSUxFRCIpOworICAgICAgICAgIHJldHVybjsKKyAgICAgIH0KKyAgICAgIGRpdiA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJjbGlwMiIpOworICAgICAgaWYgKGdldENvbXB1dGVkU3R5 bGUoZGl2LCcnKS5nZXRQcm9wZXJ0eVZhbHVlKCJjbGlwIikgIT0gInJlY3QoMHB4IDBweCAwcHgg MHB4KSIpIHsKKyAgICAgICAgICBsb2coIkZBSUxFRCIpOworICAgICAgICAgIHJldHVybjsKKyAg ICAgIH0KKyAgICAgIGxvZygiUEFTU0VEIik7CisgICAgfQorICA8L3NjcmlwdD4KKyA8L2hlYWQ+ CisgPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorICA8ZGl2IGlkPSJjbGlwIiBzdHlsZT0iY2xp cDogcmVjdCg1cHgsIDJlbSwgMXB4LCAxZW0pIiA+PC9kaXY+CisgIDxkaXYgaWQ9ImNsaXAyIiBz dHlsZT0iY2xpcDogYXV0byIgPjwvZGl2PgorICA8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKyA8 L2JvZHk+Cis8L2h0bWw+Cg==