174315 2017-07-10 11:06:36 -0700 check-webkit-style: cpp linter incorrectly treats colon appearing in a string argument as the start of the initializer list 2022-03-01 03:14:17 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 mattbaker mattbaker buildbot glenn lforschler webkit-bug-importer oldest_to_newest 1327068 0 mattbaker 2017-07-10 11:06:36 -0700 check-webkit-style's cpp linter incorrectly treats colon appearing in a string argument as the start of the initializer list, and emits an error if whitespace rules aren't followed. For example, running check-webkit-style on the following: MyClass::MyClass() : m_foo("foo:bar") { } Will output: ERROR: Missing spaces around : [whitespace/init] [4] Note: The problem is with the cpp linter regex, see Tools/Scripts/webkitpy/style/checkers/cpp.py:2043: # match the start of initialization list if search(r'^(?P<indentation>\s*)((explicit\s+)?[^(\s|\?)]+\([^\?]*\)\s?\:|^(\s|\?)*\:)([^\:]|\Z)[^;]*$', line): if search(r'[^:]\:[^\:\s]+', line): error(line_number, 'whitespace/init', 4, 'Missing spaces around :') ... 1327069 1 webkit-bug-importer 2017-07-10 11:06:57 -0700 <rdar://problem/33216486> 1327293 2 315052 mattbaker 2017-07-10 17:24:51 -0700 Created attachment 315052 Patch 1327302 3 315052 mattbaker 2017-07-10 17:50:29 -0700 Comment on attachment 315052 Patch r- for now. Need to improve on this (using elided over raw_lines feels risky), and add a test case to Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py. 315052 2017-07-10 17:24:51 -0700 2022-03-01 03:14:17 -0800 Patch bug-174315-20170710172450.patch text/plain 2223 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MzE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWZkYzU1MTcwZWMwMWU1NTFhMTBiM2Y4YjE3MmRkMWEz MmM2NDRkYy4uZTdjMjk2N2RkOGY2NjAyODQ0Mjk1OWViNDg2MTk4Y2U4YWE2Y2ZiNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE3LTA3LTEwICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KKworICAg ICAgICBjaGVjay13ZWJraXQtc3R5bGU6IGNwcCBsaW50ZXIgaW5jb3JyZWN0bHkgdHJlYXRzIGNv bG9uIGFwcGVhcmluZyBpbiBhIHN0cmluZyBhcmd1bWVudCBhcyB0aGUgc3RhcnQgb2YgdGhlIGlu aXRpYWxpemVyIGxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3NDMxNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzMyMTY0ODY+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3BlcmF0ZSBvbiBlbGlk ZWQgbGluZXMgKGNvbW1lbnRzIGFuZCBzdHJpbmdzIHJlbW92ZWQpIHdoZW4gY2hlY2tpbmcKKyAg ICAgICAgdGhlIHN0eWxlIG9mIHRoZSBtZW1iZXIgaW5pdGlhbGl6YXRpb24gbGlzdC4gVGhpcyBw cmV2ZW50cyBhIGNvbG9uIGFwcGVhcmluZworICAgICAgICBpbiBhIHN0cmluZyBmcm9tIGJlaW5n IG1pc3Rha2VuIGZvciB0aGUgYmVnaW5uaW5nIG9mIHRoZSBsaXN0LgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19tZW1i ZXJfaW5pdGlhbGl6YXRpb25fbGlzdCk6CisKIDIwMTctMDctMDMgIEJyaWFuIEJ1cmcgIDxiYnVy Z0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIFJlcGxheTogcmVtb3ZlIHNvbWUgdW51c2VkIGNv ZGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXgg NTc0MjQzNTM1NmI2ZDAwYTIyZTVhNzQ4YWI1NzI0Y2NmYjJlNGE1NS4uNmYyYTI1NjExYWJiYjZl ZWVlYmYzMmFmNjIzZDA5NGU1ZWEwYWQxNCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTIwMjcsOCArMjAyNyw4IEBAIGRlZiBjaGVja19tZW1i ZXJfaW5pdGlhbGl6YXRpb25fbGlzdChjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKToK ICAgICAgIGVycm9yOiBUaGUgZnVuY3Rpb24gdG8gY2FsbCB3aXRoIGFueSBlcnJvcnMgZm91bmQu CiAgICAgIiIiCiAKLSAgICByYXcgPSBjbGVhbl9saW5lcy5yYXdfbGluZXMKLSAgICBsaW5lID0g cmF3W2xpbmVfbnVtYmVyXQorICAgIGVsaWRlZCA9IGNsZWFuX2xpbmVzLmVsaWRlZAorICAgIGxp bmUgPSBlbGlkZWRbbGluZV9udW1iZXJdCiAKICAgICBpZiBzZWFyY2gocidcYihbQS1aYS16MC05 X10qXylcKFwxXCknLCBsaW5lKToKICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICdydW50aW1l L2luaXQnLCA0LApAQCAtMjA2NCw5ICsyMDY0LDkgQEAgZGVmIGNoZWNrX21lbWJlcl9pbml0aWFs aXphdGlvbl9saXN0KGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICAgICAg ICAgICAgICAgICAgICAgJ0NvbW1hIHNob3VsZCBiZSBhdCB0aGUgYmVnaW5uaW5nIG9mIHRoZSBs aW5lIGluIGEgbWVtYmVyIGluaXRpYWxpemF0aW9uIGxpc3QuJykKIAogICAgICAgICAgICAgIyBU byBhdm9pZCBpbmZpbml0ZSBsb29wLCBpZiBjYW4ndCBmaW5kIHRoZSBlbmQgb2YgbWVtYmVyIGlu aXRpYWxpemF0aW9uIGxpc3QKLSAgICAgICAgICAgIGlmIGxpbmVfbnVtYmVyIDwgbGVuKHJhdykg LSAxOgorICAgICAgICAgICAgaWYgbGluZV9udW1iZXIgPCBsZW4oZWxpZGVkKSAtIDE6CiAgICAg ICAgICAgICAgICAgbGluZV9udW1iZXIgPSBsaW5lX251bWJlciArIDEKLSAgICAgICAgICAgICAg ICBsaW5lID0gcmF3W2xpbmVfbnVtYmVyXQorICAgICAgICAgICAgICAgIGxpbmUgPSBlbGlkZWRb bGluZV9udW1iZXJdCiAgICAgICAgICAgICBlbHNlOgogICAgICAgICAgICAgICAgIGJyZWFrCiAK