174314 2017-07-10 10:37:50 -0700 RTCPeerConnection's close method should update signalingState 2018-03-12 14:16:40 -0700 1 1 1 Unclassified WebKit WebRTC Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mroberts youennf commit-queue eric.carlson jonlee webkit-bug-importer youennf oldest_to_newest 1327055 0 mroberts 2017-07-10 10:37:50 -0700 Run the following code: (async () => { console.log('1. Constructing an RTCPeerConnection') const pc = new RTCPeerConnection() const signalingStateChangeEvent = new Promise(resolve => pc.onsignalingstatechange = resolve) console.log('2. Closing the RTCPeerConnection') pc.close() if (pc.signalingState !== 'closed') { console.error(`Expected the RTCPeerConnection's signaling state to be "closed", not "${pc.signalingState}"`) } console.log('3. Awaiting a "signalingstatechange" event') await signalingStateChangeEvent console.log('Success!') })() Expected output (Chrome, Firefox): 1. Constructing an RTCPeerConnection 2. Closing the RTCPeerConnection 3. Awaiting a "signalingstatechange" event Success! Actual output (Safari): 1. Constructing an RTCPeerConnection 2. Closing the RTCPeerConnection Expected the RTCPeerConnection's signaling state to be "closed", not "stable" 3. Awaiting a "signalingstatechange" event In the actual output, "Success!" never prints because `signalingStateChangeEvent` never resolves. I guess the behavior around this was only recently specified here? https://github.com/w3c/webrtc-pc/pull/1371 1327065 1 mroberts 2017-07-10 11:01:35 -0700 RTCPeerConnection's `close` method should also update `iceConnectionState`. Perhaps this issue could be tracked here, too, instead of a separate ticket. Run the following code: (async () => { console.log('1. Constructing an RTCPeerConnection') const pc = new RTCPeerConnection() const iceConnectionStateChangeEvent = new Promise(resolve => pc.oniceconnectionstatechange = resolve) console.log('2. Closing the RTCPeerConnection') pc.close() if (pc.iceConnectionState !== 'closed') { console.error(`Expected the RTCPeerConnection's ICE connection state to be "closed", not "${pc.iceConnectionState}"`) } console.log('3. Awaiting a "iceconnectionstatechange" event') await iceConnectionStateChangeEvent console.log('Success!') })() Expected output (Firefox): 1. Constructing an RTCPeerConnection 2. Closing the RTCPeerConnection Expected the RTCPeerConnection's ICE connection state to be "closed", not "new" 3. Awaiting a "iceconnectionstatechange" event Success! Actual output (Safari): 1. Constructing an RTCPeerConnection 2. Closing the RTCPeerConnection Expected the RTCPeerConnection's ICE connection state to be "closed", not "new" 3. Awaiting a "iceconnectionstatechange" event In the actual output, "Success!" never prints because `iceConnectionStateChangeEvent` never resolves. This behavior seems specified in the Step 4 of `close` and the description of "closed" in RTCIceConnectionState: * http://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-close * http://w3c.github.io/webrtc-pc/#rtciceconnectionstate-enum (Note: In Chrome, the error prints, too, I guess because `iceConnectionState` isn't updated synchronously?) 1328122 2 webkit-bug-importer 2017-07-12 10:40:53 -0700 <rdar://problem/33267977> 1405781 3 youennf 2018-03-12 10:49:58 -0700 Thanks Mark, it is true we are missing the closed state. I will add it. Looking at the spec, it does not seem to mandate firing an event though. Maybe this is my reading of the spec. 1405782 4 youennf 2018-03-12 10:50:16 -0700 Testing further, you are right that Chrome and Firefox are firing this event. 1405785 5 335605 youennf 2018-03-12 10:52:07 -0700 Created attachment 335605 Patch 1405789 6 youennf 2018-03-12 10:57:51 -0700 Filed https://github.com/w3c/webrtc-pc/issues/1799 for clarification about the event part of the bug. 1405898 7 335605 commit-queue 2018-03-12 14:16:39 -0700 Comment on attachment 335605 Patch Clearing flags on attachment: 335605 Committed r229548: <https://trac.webkit.org/changeset/229548> 1405899 8 commit-queue 2018-03-12 14:16:40 -0700 All reviewed patches have been landed. Closing bug. 335605 2018-03-12 10:52:07 -0700 2018-03-12 14:16:39 -0700 Patch bug-174314-20180312105207.patch text/plain 4620 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQwZjE0YjczMDM0ZmI0 MzVmMjU2NzVhYjkwNjA3OTUzZjViNjJjZi4uYzMyYmJhZjllNWZjMTY3ZmIzNTZjZTcwODgyNDA3 NDk4MjYxZDcyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTAzLTEyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSVENQZWVyQ29ubmVjdGlv bidzIGNsb3NlIG1ldGhvZCBzaG91bGQgdXBkYXRlIHNpZ25hbGluZ1N0YXRlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQzMTQKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzMzMjY3OTc3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgcmViYXNlZCB0ZXN0LgorICAgICAgICBBZGQgY2xv c2VkIGFzIHNpZ25hbGluZ1N0YXRlIGVudW0gdmFsdWUuCisgICAgICAgIFNldCBwZWVyIGNvbm5l Y3Rpb24gc2lnbmFsaW5nIHN0YXRlIHRvIGNsb3NlZCBvbmNlIGNsb3NlIGlzIGNhbGxlZC4KKwor ICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UlRDUGVlckNvbm5lY3Rpb246OmRvQ2xvc2UpOgorICAgICAgICAqIE1v ZHVsZXMvbWVkaWFzdHJlYW0vUlRDU2lnbmFsaW5nU3RhdGUuaWRsOgorICAgICAgICAqIHBsYXRm b3JtL21lZGlhc3RyZWFtL1JUQ1NpZ25hbGluZ1N0YXRlLmg6CisKIDIwMTgtMDMtMTAgIE1lZ2Fu IEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYSBxdWVy eSBmb3IgZGVmYXVsdCBhcHBlYXJhbmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwCmluZGV4IGY4MGZiODQ4OTA1 NDc3N2VhNDk4MDcxZTAyZmNlZTdjMDg1ZjdhNDAuLjlmM2ExNzRkNjkzMmQyZGY0MTcwMDE1ZTBh NjdiYjZiZDZjY2JhYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz dHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwCkBAIC0zOTQsNiArMzk0LDcgQEAgYm9v bCBSVENQZWVyQ29ubmVjdGlvbjo6ZG9DbG9zZSgpCiAKICAgICBtX2Nvbm5lY3Rpb25TdGF0ZSA9 IFJUQ1BlZXJDb25uZWN0aW9uU3RhdGU6OkNsb3NlZDsKICAgICBtX2ljZUNvbm5lY3Rpb25TdGF0 ZSA9IFJUQ0ljZUNvbm5lY3Rpb25TdGF0ZTo6Q2xvc2VkOworICAgIG1fc2lnbmFsaW5nU3RhdGUg PSBSVENTaWduYWxpbmdTdGF0ZTo6Q2xvc2VkOwogCiAgICAgZm9yIChhdXRvJiB0cmFuc2NlaXZl ciA6IG1fdHJhbnNjZWl2ZXJTZXQtPmxpc3QoKSkgewogICAgICAgICB0cmFuc2NlaXZlci0+c3Rv cCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENT aWduYWxpbmdTdGF0ZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JU Q1NpZ25hbGluZ1N0YXRlLmlkbAppbmRleCAyMjJiY2Y5OTA2ZTliZjI3N2M4OTM0MmQ2NWZjNmJk YWE5NTIzZjNkLi5jNzlmNDk5NWE0NjA5Njc3YzI2NDc4MmZiMDZiN2E3MGY1ODdiN2M4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1NpZ25hbGluZ1N0 YXRlLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1NpZ25h bGluZ1N0YXRlLmlkbApAQCAtMzEsNSArMzEsNiBAQAogICAgICJoYXZlLWxvY2FsLW9mZmVyIiwK ICAgICAiaGF2ZS1yZW1vdGUtb2ZmZXIiLAogICAgICJoYXZlLWxvY2FsLXByYW5zd2VyIiwKLSAg ICAiaGF2ZS1yZW1vdGUtcHJhbnN3ZXIiCisgICAgImhhdmUtcmVtb3RlLXByYW5zd2VyIiwKKyAg ICAiY2xvc2VkIgogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlh c3RyZWFtL1JUQ1NpZ25hbGluZ1N0YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRp YXN0cmVhbS9SVENTaWduYWxpbmdTdGF0ZS5oCmluZGV4IDQ5NDk3N2RmYTFkODgxNmExYTYwZjQ4 YWFlYzBjNDc5ODQxMzg0ZjEuLjQ0NjVlZTFiYjFiZjNjZDIwYzFmYTUyZGQ1ZmM3MzYyODdjOTNj ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JUQ1Np Z25hbGluZ1N0YXRlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v UlRDU2lnbmFsaW5nU3RhdGUuaApAQCAtMzQsNiArMzQsNyBAQCBlbnVtIGNsYXNzIFJUQ1NpZ25h bGluZ1N0YXRlIHsKICAgICBIYXZlUmVtb3RlT2ZmZXIsCiAgICAgSGF2ZUxvY2FsUHJhbnN3ZXIs CiAgICAgSGF2ZVJlbW90ZVByYW5zd2VyLAorICAgIENsb3NlZCwKIH07CiAKIFN0cmluZyBjb252 ZXJ0RW51bWVyYXRpb25Ub1N0cmluZyhSVENTaWduYWxpbmdTdGF0ZSk7IC8vIGluIEpTQ1JUQ1Np Z25hbGluZ1N0YXRlLmNwcApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggZDQ2OTli OTYwYzkyMTVmYTA4OWNlMWZhYzlkNTQzNWY5NGMxOGI5OC4uN2Y2ZmM3ODJkMmJlZWUzOWRmYTE4 MThlYTEyNGFmNTJhMjgyNzEzYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTgtMDMtMTIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgorCisgICAgICAgIFJUQ1BlZXJDb25uZWN0aW9uJ3MgY2xvc2UgbWV0aG9kIHNob3VsZCB1cGRh dGUgc2lnbmFsaW5nU3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3NDMxNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzMyNjc5Nzc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWItcGxhdGZv cm0tdGVzdHMvd2VicnRjL1JUQ1BlZXJDb25uZWN0aW9uLWNyZWF0ZURhdGFDaGFubmVsLWV4cGVj dGVkLnR4dDoKKwogMjAxOC0wMy0wMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+ CiAKICAgICAgICAgTG9hZHMgZm9yIGEgRG9jdW1lbnQgY29udHJvbGxlZCBieSBhIFNlcnZpY2Ug V29ya2VyIHNob3VsZCBub3QgdXNlIEFwcENhY2hlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYnJ0Yy9SVENQZWVyQ29ubmVjdGlvbi1j cmVhdGVEYXRhQ2hhbm5lbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL3dlYnJ0Yy9SVENQZWVyQ29ubmVjdGlvbi1jcmVhdGVEYXRhQ2hh bm5lbC1leHBlY3RlZC50eHQKaW5kZXggMDRlNTI4YjNjZmZiMDQ1MzZjOGJiZjZiZjIwOWJlZWM4 Njc2NGEwNi4uMmFmMWNlOGIxNjBlZDZjZjc5OTY3M2U0MzA3NTE2MDEzNTdhMGI0OCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWJydGMv UlRDUGVlckNvbm5lY3Rpb24tY3JlYXRlRGF0YUNoYW5uZWwtZXhwZWN0ZWQudHh0CisrKyBiL0xh eW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2VicnRjL1JUQ1BlZXJD b25uZWN0aW9uLWNyZWF0ZURhdGFDaGFubmVsLWV4cGVjdGVkLnR4dApAQCAtMSw2ICsxLDYgQEAK IAogUEFTUyBjcmVhdGVEYXRhQ2hhbm5lbCB3aXRoIG5vIGFyZ3VtZW50IHNob3VsZCB0aHJvdyBU eXBlRXJyb3IgCi1GQUlMIGNyZWF0ZURhdGFDaGFubmVsIHdpdGggY2xvc2VkIGNvbm5lY3Rpb24g c2hvdWxkIHRocm93IEludmFsaWRTdGF0ZUVycm9yIGFzc2VydF9lcXVhbHM6IHNpZ25hbGluZyBz dGF0ZSBleHBlY3RlZCAiY2xvc2VkIiBidXQgZ290ICJzdGFibGUiCitQQVNTIGNyZWF0ZURhdGFD aGFubmVsIHdpdGggY2xvc2VkIGNvbm5lY3Rpb24gc2hvdWxkIHRocm93IEludmFsaWRTdGF0ZUVy cm9yIAogRkFJTCBjcmVhdGVEYXRhQ2hhbm5lbCBhdHRyaWJ1dGUgZGVmYXVsdCB2YWx1ZXMgYXNz ZXJ0X2VxdWFsczogZXhwZWN0ZWQgKHN0cmluZykgImxvdyIgYnV0IGdvdCAodW5kZWZpbmVkKSB1 bmRlZmluZWQKIEZBSUwgY3JlYXRlRGF0YUNoYW5uZWwgd2l0aCBwcm92aWRlZCBwYXJhbWV0ZXJz IHNob3VsZCBpbml0aWFsaXplIGF0dHJpYnV0ZXMgdG8gcHJvdmlkZWQgdmFsdWVzIFR5cGUgZXJy b3IKIFBBU1MgY3JlYXRlRGF0YUNoYW5uZWwgd2l0aCBsYWJlbCAiZm9vIiBzaG91bGQgc3VjY2Vl ZCAK