174304 2017-07-09 18:54:37 -0700 A/B testing results page show results for the top-level tests instead of the one being analyzed 2017-07-10 20:45:03 -0700 1 1 1 Unclassified WebKit Perf Dashboard Safari Technology Preview Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez dewei_zhu kling koivisto rniwa slewis oldest_to_newest 1326914 0 rniwa 2017-07-09 18:54:37 -0700 After the perf try bots support was added, the results shown right above the revision table always show the results for the top-level tests instead of the one being biesected. e.g. If we're bisecting MotionMark's Images subtest, we'd like to see how A/B compares in Images subtest, not the overall MotionMark's score, which may or may not show the actual regression / progression due to the noise from other tests. What's even more confusing is the fact the stacking graph charts DO show the progression/regression amount based on the subtest. 1326915 1 314959 rniwa 2017-07-09 19:04:20 -0700 Created attachment 314959 Fixes the bug 1326950 2 314959 koivisto 2017-07-10 01:18:21 -0700 Comment on attachment 314959 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=314959&action=review > Websites/perf.webkit.org/public/v3/models/analysis-results.js:23 > + for (let metric of test.metrics()) { const? 1327351 3 314959 rniwa 2017-07-10 20:45:01 -0700 Comment on attachment 314959 Fixes the bug Clearing flags on attachment: 314959 Committed r219321: <http://trac.webkit.org/changeset/219321> 1327352 4 rniwa 2017-07-10 20:45:03 -0700 All reviewed patches have been landed. Closing bug. 314959 2017-07-09 19:04:20 -0700 2017-07-10 20:45:01 -0700 Fixes the bug bug-174304-20170709190427.patch text/plain 5909 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MjgzCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBkN2Y4MjBhOGZlMzYwYjI4NDg5MDFhOTM2ZGNkZTllZjkwNTFiYjM5Li5mNTk4MjVkMDFl NTRlNzY5MmY3ODc4OGJjNjNkYjdmMzM4MjhiMWM1IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwzMiBAQAorMjAxNy0wNy0wOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KKworICAgICAgICBBL0IgdGVzdGluZyByZXN1bHRzIHBhZ2Ugc2hvdyByZXN1 bHRzIGZvciB0aGUgdG9wLWxldmVsIHRlc3RzIGluc3RlYWQgb2YgdGhlIG9uZSBiZWluZyBhbmFs eXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0 MzA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hl biBhIHNwZWNpZmljIHN1YnRlc3QgaXMgYW5hbHl6ZWQgKGUuZy4gSW1hZ2VzIHN1YnRlc3Qgb2Yg TW90aW9uTWFyayksIHRoZW4gVGVzdEdyb3VwUmVzdWx0c1ZpZXdlcgorICAgICAgICBzaG91bGQg ZXhwYW5kIGFuZCBoaWdobGlnaHQgdGhhdCBzcGVjaWZpYyBzdWJ0ZXN0IGluc3RlYWQgb2Ygc2lt cGx5IHNob3dpbmcgdGhlIHRvcC1sZXZlbCB0ZXN0J3Mgc2NvcmUuCisgICAgICAgIFRoaXMgaXMg ZXNwZWNpYWxseSBtaXNsZWFkaW5nIHNpbmNlIEFuYWx5c2lzUmVzdWx0c1ZpZXdlciAoc3RhY2tp bmcgYmFycyBmb3IgZWFjaCB0ZXN0IGdyb3VwKSB1c2VzCisgICAgICAgIHRoZSBzY29yZSBvZiB0 aGUgc3BlY2lmaWMgc3VidGVzdCBiZWluZyBhbmFseXplZC4KKworICAgICAgICBGaXhlZCB0aGUg YnVnIGJ5IHBhc3NpbmcgaW4gdGhlIG1ldHJpYyBhc3NvY2lhdGVkIHdpdGggdGhlIGFuYWx5c2lz IHRhc2sgZnJvbSBBbmFseXNpc1Rhc2tQYWdlIHRvCisgICAgICAgIFRlc3RHcm91cFJlc3VsdHNW aWV3ZXIgdmlhIEFuYWx5c2lzVGFza1Rlc3RHcm91cFBhbmUuIEFsc28gbWFkZSBUZXN0R3JvdXBS ZXN1bHRzVmlld2VyLnNldEFuYWx5c2lzUmVzdWx0cworICAgICAgICBhdXRvLWV4cGFuZCB0aGUg dGVzdHMgdGhhdCBhcmUgYW5jZXN0b3JzIG9mIHRoZSBzcGVjaWZpZWQgbWV0cmljLiBXaXRob3V0 IHRoYXQsIHRoZSB0ZXN0IHdvbid0IGJlIHNob3duCisgICAgICAgIHRvIHRoZSB1c2VyIHVudGls IHRoZSBhbmNlc3RvciB0ZXN0cyBhcmUgZXhwYW5kZWQgYnkgdGhlIHVzZXIuCisKKyAgICAgICAg QWxzbyBmaXhlZCB0aGUgYnVnIHRoYXQgd2Ugd2VyZSBhbHdheXMgbGlzdGluZyBzdWItdGVzdHMg cmVnYXJkbGVzcyBvZiB3aGV0aGVyIHRoZXkgaGF2ZSByZXN1bHRzIG9yIG5vdC4KKyAgICAgICAg U2luY2UgdGVzdHMgdGVuZCB0byBjaGFuZ2Ugb3ZlciB0aW1lLCB3ZSBzaG91bGRuJ3Qgc2hvdyBh IHRlc3QgaWYgaXQgZG9lc24ndCBoYXZlIGFueSByZXN1bHRzIGFzc29jaWF0ZWQuCisKKyAgICAg ICAgKiBwdWJsaWMvdjMvY29tcG9uZW50cy90ZXN0LWdyb3VwLXJlc3VsdHMtdmlld2VyLmpzOgor ICAgICAgICAoVGVzdEdyb3VwUmVzdWx0c1ZpZXdlci5wcm90b3R5cGUuc2V0QW5hbHlzaXNSZXN1 bHRzKTogRXhwYW5kIHRoZSBhbmNlc3RvciB0ZXN0cyBvZiB0aGUgbWV0cmljLgorICAgICAgICAo VGVzdEdyb3VwUmVzdWx0c1ZpZXdlci5wcm90b3R5cGUuX2J1aWxkUm93c0ZvclRlc3QpOiBFeGl0 IGVhcmx5IGlmIHRoaXMgdGVzdCBkb2Vzbid0IGhhdmUgYW55IHJlc3VsdHMuCisgICAgICAgICog cHVibGljL3YzL21vZGVscy9hbmFseXNpcy1yZXN1bHRzLmpzOgorICAgICAgICAoQW5hbHlzaXNS ZXN1bHRzLnByb3RvdHlwZS5jb250YWluc1Rlc3QpOiBBZGRlZC4KKyAgICAgICAgKiBwdWJsaWMv djMvcGFnZXMvYW5hbHlzaXMtdGFzay1wYWdlLmpzOgorICAgICAgICAoQW5hbHlzaXNUYXNrVGVz dEdyb3VwUGFuZS5wcm90b3R5cGUuc2V0QW5hbHlzaXNSZXN1bHRzKTogVGFrZXMgYSBtZXRyaWMg dG8gcGFzcyBpdCB0byB0aGUgcmVzdWx0cyB2aWV3ZXIuCisgICAgICAgIChBbmFseXNpc1Rhc2tQ YWdlLnByb3RvdHlwZS5fYXNzaWduVGVzdFJlc3VsdHNJZlBvc3NpYmxlKToKKwogMjAxNy0wNy0w NiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBTYWZhcmkgMTAu MSBmYWlscyB0byB1cGxvYWQgYSBwYXRjaCBvbiBwZXJmIHRyeSBib3RzIHBhZ2UKZGlmZiAtLWdp dCBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy90ZXN0LWdy b3VwLXJlc3VsdHMtdmlld2VyLmpzIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92 My9jb21wb25lbnRzL3Rlc3QtZ3JvdXAtcmVzdWx0cy12aWV3ZXIuanMKaW5kZXggMTBiZTBmMjk1 MTAwMGU0OGY2Njg2NzJlMDllYmVmYWQwOGQzZGFmYS4uMGQ5N2RiODEyMmIyNGYyZWM2ZWFiM2M3 MWRkZWI4ZjNhZGEwYjlmNyAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1 YmxpYy92My9jb21wb25lbnRzL3Rlc3QtZ3JvdXAtcmVzdWx0cy12aWV3ZXIuanMKKysrIGIvV2Vi c2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9jb21wb25lbnRzL3Rlc3QtZ3JvdXAtcmVz dWx0cy12aWV3ZXIuanMKQEAgLTI0LDYgKzI0LDEyIEBAIGNsYXNzIFRlc3RHcm91cFJlc3VsdHNW aWV3ZXIgZXh0ZW5kcyBDb21wb25lbnRCYXNlIHsKICAgICB7CiAgICAgICAgIHRoaXMuX2FuYWx5 c2lzUmVzdWx0cyA9IGFuYWx5c2lzUmVzdWx0czsKICAgICAgICAgdGhpcy5fY3VycmVudE1ldHJp YyA9IG1ldHJpYzsKKyAgICAgICAgaWYgKG1ldHJpYykgeworICAgICAgICAgICAgY29uc3QgcGF0 aCA9IG1ldHJpYy50ZXN0KCkucGF0aCgpOworICAgICAgICAgICAgZm9yIChsZXQgaSA9IHBhdGgu bGVuZ3RoIC0gMjsgaSA+PSAwOyBpLS0pCisgICAgICAgICAgICAgICAgdGhpcy5fZXhwYW5kZWRU ZXN0cy5hZGQocGF0aFtpXSk7CisgICAgICAgIH0KKwogICAgICAgICB0aGlzLmVucXVldWVUb1Jl bmRlcigpOwogICAgIH0KIApAQCAtNTgsNiArNjQsOSBAQCBjbGFzcyBUZXN0R3JvdXBSZXN1bHRz Vmlld2VyIGV4dGVuZHMgQ29tcG9uZW50QmFzZSB7CiAKICAgICBfYnVpbGRSb3dzRm9yVGVzdCh0 ZXN0R3JvdXAsIGV4cGFuZGVkVGVzdHMsIHRlc3QsIHNoYXJlZFBhdGgsIG1heERlcHRoLCBkZXB0 aCkKICAgICB7CisgICAgICAgIGlmICghdGhpcy5fYW5hbHlzaXNSZXN1bHRzLmNvbnRhaW5zVGVz dCh0ZXN0KSkKKyAgICAgICAgICAgIHJldHVybiBbXTsKKwogICAgICAgICBjb25zdCBlbGVtZW50 ID0gQ29tcG9uZW50QmFzZS5jcmVhdGVFbGVtZW50OwogICAgICAgICBjb25zdCByb3dzID0gZWxl bWVudCgndGJvZHknLCB0ZXN0Lm1ldHJpY3MoKS5tYXAoKG1ldHJpYykgPT4gdGhpcy5fYnVpbGRS b3dGb3JNZXRyaWModGVzdEdyb3VwLCBtZXRyaWMsIHNoYXJlZFBhdGgsIG1heERlcHRoLCBkZXB0 aCkpKTsKIApkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9t b2RlbHMvYW5hbHlzaXMtcmVzdWx0cy5qcyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJs aWMvdjMvbW9kZWxzL2FuYWx5c2lzLXJlc3VsdHMuanMKaW5kZXggMGJiMTY1Y2UwNGFiMDdjN2Y1 YjU0MjFjZmY4NmIxM2IyMTMxZjcyOC4uYmMzOTVhZjFjNDQ5ZjA1Y2Y0ZWY2NTYxNmIyNzIxZjll Y2I1MzJkMCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9t b2RlbHMvYW5hbHlzaXMtcmVzdWx0cy5qcworKysgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcv cHVibGljL3YzL21vZGVscy9hbmFseXNpcy1yZXN1bHRzLmpzCkBAIC0xNyw2ICsxNywxNiBAQCBj bGFzcyBBbmFseXNpc1Jlc3VsdHMgewogCiAgICAgaGlnaGVzdFRlc3RzKCkgeyByZXR1cm4gdGhp cy5fbGF6aWx5Q29tcHV0ZWRIaWdoZXN0VGVzdHMuZXZhbHVhdGUodGhpcy5fbWV0cmljSWRzKTsg fQogCisgICAgY29udGFpbnNUZXN0KHRlc3QpCisgICAgeworICAgICAgICBjb25zb2xlLmFzc2Vy dCh0ZXN0IGluc3RhbmNlb2YgVGVzdCk7CisgICAgICAgIGZvciAobGV0IG1ldHJpYyBvZiB0ZXN0 Lm1ldHJpY3MoKSkgeworICAgICAgICAgICAgaWYgKG1ldHJpYy5pZCgpIGluIHRoaXMuX21ldHJp Y1RvQnVpbGRNYXApCisgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIH0KKyAg ICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKwogICAgIF9jb21wdXRlSGlnaGVzdFRlc3RzKG1l dHJpY0lkcykKICAgICB7CiAgICAgICAgIGNvbnN0IHRlc3RzSW5SZXN1bHRzID0gbmV3IFNldCht ZXRyaWNJZHMubWFwKChtZXRyaWNJZCkgPT4gTWV0cmljLmZpbmRCeUlkKG1ldHJpY0lkKS50ZXN0 KCkpKTsKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvcGFn ZXMvYW5hbHlzaXMtdGFzay1wYWdlLmpzIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92My9wYWdlcy9hbmFseXNpcy10YXNrLXBhZ2UuanMKaW5kZXggM2RjNDM1OGI2MTc4NDg1OTcw ZDE3NzA4MjI3NmM1YWQ2NzI2M2JkNi4uMGE2YTAyZWZhNjdiNGYxMDEzMWVhMjA5ZjdiMmE1ZGZj ZGVlNTRlZiAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9w YWdlcy9hbmFseXNpcy10YXNrLXBhZ2UuanMKKysrIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3Jn L3B1YmxpYy92My9wYWdlcy9hbmFseXNpcy10YXNrLXBhZ2UuanMKQEAgLTI4MCwxMCArMjgwLDEw IEBAIGNsYXNzIEFuYWx5c2lzVGFza1Rlc3RHcm91cFBhbmUgZXh0ZW5kcyBDb21wb25lbnRCYXNl IHsKICAgICAgICAgdGhpcy5lbnF1ZXVlVG9SZW5kZXIoKTsKICAgICB9CiAKLSAgICBzZXRBbmFs eXNpc1Jlc3VsdHMoYW5hbHlzaXNSZXN1bHRzKQorICAgIHNldEFuYWx5c2lzUmVzdWx0cyhhbmFs eXNpc1Jlc3VsdHMsIG1ldHJpYykKICAgICB7CiAgICAgICAgIHRoaXMucGFydCgncmV2aXNpb24t dGFibGUnKS5zZXRBbmFseXNpc1Jlc3VsdHMoYW5hbHlzaXNSZXN1bHRzKTsKLSAgICAgICAgdGhp cy5wYXJ0KCdyZXN1bHRzLXZpZXdlcicpLnNldEFuYWx5c2lzUmVzdWx0cyhhbmFseXNpc1Jlc3Vs dHMsIG51bGwpOworICAgICAgICB0aGlzLnBhcnQoJ3Jlc3VsdHMtdmlld2VyJykuc2V0QW5hbHlz aXNSZXN1bHRzKGFuYWx5c2lzUmVzdWx0cywgbWV0cmljKTsKICAgICAgICAgdGhpcy5lbnF1ZXVl VG9SZW5kZXIoKTsKICAgICB9CiAKQEAgLTYxMyw4ICs2MTMsOCBAQCBjbGFzcyBBbmFseXNpc1Rh c2tQYWdlIGV4dGVuZHMgUGFnZVdpdGhIZWFkaW5nIHsKICAgICAgICAgaWYgKCF0aGlzLl90YXNr IHx8ICF0aGlzLl90ZXN0R3JvdXBzIHx8ICF0aGlzLl9hbmFseXNpc1Jlc3VsdHMpCiAgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICAgICAgdGhpcy5wYXJ0KCdncm91cC1wYW5lJykuc2V0 QW5hbHlzaXNSZXN1bHRzKHRoaXMuX2FuYWx5c2lzUmVzdWx0cyk7CiAgICAgICAgIGxldCBtZXRy aWMgPSB0aGlzLl9tZXRyaWM7CisgICAgICAgIHRoaXMucGFydCgnZ3JvdXAtcGFuZScpLnNldEFu YWx5c2lzUmVzdWx0cyh0aGlzLl9hbmFseXNpc1Jlc3VsdHMsIG1ldHJpYyk7CiAgICAgICAgIGlm IChtZXRyaWMpIHsKICAgICAgICAgICAgIGNvbnN0IHZpZXcgPSB0aGlzLl9hbmFseXNpc1Jlc3Vs dHMudmlld0Zvck1ldHJpYyhtZXRyaWMpOwogICAgICAgICAgICAgdGhpcy5wYXJ0KCdyZXN1bHRz LXBhbmUnKS5zZXRBbmFseXNpc1Jlc3VsdHNWaWV3KHZpZXcpOwo=