174302 2017-07-09 15:00:09 -0700 REGRESSION(r210226): Keyboard-focused element not preserved when navigating back through page cache, causing multiple elements to have focus 2017-07-10 10:03:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Local Build Unspecified Unspecified RESOLVED FIXED data:text/html,<a%20href="about:blank#1">1</a><a%20href="about:blank#2">2</a><a%20href="about:blank#3">3</a> InRadar, Regression P1 Normal --- 1 mitz kling buildbot cdumez commit-queue dbates esprehn+autocc kangil.han kling koivisto simon.fraser webkit-bug-importer oldest_to_newest 1326899 0 mitz 2017-07-09 15:00:09 -0700 To reproduce: 1. Navigate to the URL. 2. Press Option-Tab three times to focus the 3 link 3. Press Return to navigate 4. Navigate back 5. Notice that the 3 link still looks focused, but pressing Return doesn’t navigate to it 6. Press Option-Tab twice 7. Notice that the 1 link, then the 2 link become focused, but the 3 link also looks focused 8. Press Return to navigate, then navigate back 9. Notice that the 2 link and the 3 link still look focused This is a regression from shipping Safari. 1326901 1 webkit-bug-importer 2017-07-09 15:00:52 -0700 <rdar://problem/33204273> 1326953 2 kling 2017-07-10 02:16:17 -0700 Regressed with https://trac.webkit.org/r210226 1326962 3 kling 2017-07-10 04:03:29 -0700 I think I see the problem here. Document::destroyRenderTree() is clearing the various DOM pointers to "user action elements", including the currently focused element. This feels like a red patch, just need to write a test case. Thanks mitz for the really great bug report! 1326992 4 314977 kling 2017-07-10 07:14:10 -0700 Created attachment 314977 Patch 1327050 5 314977 commit-queue 2017-07-10 10:03:18 -0700 Comment on attachment 314977 Patch Clearing flags on attachment: 314977 Committed r219296: <http://trac.webkit.org/changeset/219296> 1327051 6 commit-queue 2017-07-10 10:03:20 -0700 All reviewed patches have been landed. Closing bug. 314977 2017-07-10 07:14:10 -0700 2017-07-10 10:03:18 -0700 Patch bug-174302.diff text/plain 4394 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxNTBjN2U2M2MxNy4uMWRkNjRlOWMxZDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxNy0wNy0xMCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTihyMjEwMjI2KTogS2V5Ym9hcmQtZm9jdXNlZCBlbGVtZW50IG5vdCBwcmVzZXJ2 ZWQgd2hlbiBuYXZpZ2F0aW5nIGJhY2sgdGhyb3VnaCBwYWdlIGNhY2hlLCBjYXVzaW5nIG11bHRp cGxlIGVsZW1lbnRzIHRvIGhhdmUgZm9jdXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NDMwMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzMyMDQy NzM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBm YXN0L2hpc3RvcnkvcGFnZS1jYWNoZS1lbGVtZW50LXN0YXRlLWZvY3VzZWQtZXhwZWN0ZWQuaHRt bDogQWRkZWQuCisgICAgICAgICogZmFzdC9oaXN0b3J5L3BhZ2UtY2FjaGUtZWxlbWVudC1zdGF0 ZS1mb2N1c2VkLmh0bWw6IEFkZGVkLgorCiAyMDE3LTA3LTA4ICBKb2huIFdpbGFuZGVyICA8d2ls YW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlc291cmNlIExvYWQgU3RhdGlzdGljczogVXNl ciBpbnRlcmFjdGlvbiBzaG91bGQgYWx3YXlzIGdvIHRvIHRvcCBkb2N1bWVudApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L3BhZ2UtY2FjaGUtZWxlbWVudC1zdGF0ZS1mb2N1 c2VkLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2hpc3RvcnkvcGFnZS1jYWNoZS1l bGVtZW50LXN0YXRlLWZvY3VzZWQtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMC4uNDRjNDM3MDdiOTQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2hpc3RvcnkvcGFnZS1jYWNoZS1lbGVtZW50LXN0YXRlLWZvY3VzZWQtZXhwZWN0 ZWQuaHRtbApAQCAtMCwwICsxLDIwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+ Cis8c3R5bGU+CisgICAgYTpmb2N1cyB7CisgICAgICAgIGJhY2tncm91bmQ6IHllbGxvdzsKKyAg ICB9Cis8L3N0eWxlPgorPHNjcmlwdD4KKyAgICBmdW5jdGlvbiBydW5UZXN0KCkgeworICAgICAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYTMiKS5mb2N1cygpOworICAgIH0KKzwvc2NyaXB0 PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSdydW5UZXN0KCk7Jz4KKzxhIGlkPSJhMSIgaHJlZj0i IyI+MTwvYT4KKzxhIGlkPSJhMiIgaHJlZj0iIyI+MjwvYT4KKzxhIGlkPSJhMyIgaHJlZj0iIyI+ MzwvYT4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaGlz dG9yeS9wYWdlLWNhY2hlLWVsZW1lbnQtc3RhdGUtZm9jdXNlZC5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9oaXN0b3J5L3BhZ2UtY2FjaGUtZWxlbWVudC1zdGF0ZS1mb2N1c2VkLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmE0MGU5MzRmNzRhCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L3BhZ2UtY2FjaGUtZWxlbWVudC1zdGF0 ZS1mb2N1c2VkLmh0bWwKQEAgLTAsMCArMSwzNyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4K KzxoZWFkPgorPHN0eWxlPgorICAgIGE6Zm9jdXMgeworICAgICAgICBiYWNrZ3JvdW5kOiB5ZWxs b3c7CisgICAgfQorPC9zdHlsZT4KKzxzY3JpcHQ+CisgICAgZnVuY3Rpb24gcnVuVGVzdCgpIHsK KyAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAgICAgICB0ZXN0UnVubmVy Lm92ZXJyaWRlUHJlZmVyZW5jZSgiV2ViS2l0VXNlc1BhZ2VDYWNoZVByZWZlcmVuY2VLZXkiLCAx KTsKKyAgICAgICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgICAgICB9CisK KyAgICAgICAgd2luZG93Lm9ucGFnZXNob3cgPSBmdW5jdGlvbihlKSB7CisgICAgICAgICAgICBp ZiAoZS5wZXJzaXN0ZWQpIHsKKyAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgiYTMiKS5mb2N1cygpOworICAgICAgICAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikK KyAgICAgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgICAgICAg ICB9IGVsc2UgeworICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJhMiIp LmZvY3VzKCk7CisgICAgICAgICAgICB9CisgICAgICAgIH07CisKKyAgICAgICAgc2V0VGltZW91 dChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHdpbmRvdy5sb2NhdGlvbi5ocmVmID0gImRhdGE6 dGV4dC9odG1sLDxib2R5IG9ubG9hZD0naGlzdG9yeS5iYWNrKCknPjwvYm9keT4iOworICAgICAg ICB9LCAwKTsKKyAgICB9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0ncnVuVGVz dCgpOyc+Cis8YSBpZD0iYTEiIGhyZWY9IiMiPjE8L2E+Cis8YSBpZD0iYTIiIGhyZWY9IiMiPjI8 L2E+Cis8YSBpZD0iYTMiIGhyZWY9IiMiPjM8L2E+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggMmVjZDE2MjBkZjMuLjkyMjk3MTQ0NWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTctMDctMTAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjIxMDIyNik6IEtleWJvYXJkLWZvY3VzZWQgZWxlbWVudCBub3QgcHJl c2VydmVkIHdoZW4gbmF2aWdhdGluZyBiYWNrIHRocm91Z2ggcGFnZSBjYWNoZSwgY2F1c2luZyBt dWx0aXBsZSBlbGVtZW50cyB0byBoYXZlIGZvY3VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQzMDIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMz MjA0MjczPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IERvbid0IGNsZWFyIHRoZSBhY3RpdmUvaG92ZXJlZC9mb2N1c2VkIGVsZW1lbnRzIHdoZW4gZGVz dHJveWluZyB0aGUgcmVuZGVyIHRyZWUsCisgICAgICAgIHNpbmNlIHdlIG1pZ2h0IG5lZWQgdG8g cmVjb25zdHJ1Y3QgaXQgbGF0ZXIsIGFuZCB3b3VsZCBsaWtlIHRvIHJlbWVtYmVyIHdoaWNoCisg ICAgICAgIGVsZW1lbnRzIHRob3NlIHdlcmUuCisKKyAgICAgICAgT25seSB0aGUgZm9jdXNlZCBz dGF0ZSBhY3R1YWxseSBzdHVjayB3aGVuIGdvaW5nIGluIGFuZCBvdXQgb2YgdGhlIHBhZ2UgY2Fj aGUsCisgICAgICAgIGJ1dCB0aGlzIHBhdGNoIHJlbW92ZXMgYWxsIHRoZSBlbGVtZW50IHBvaW50 ZXIgY2xlYXJpbmcgZm9yIGNvbnNpc3RlbmN5LgorCisgICAgICAgIFRlc3Q6IGZhc3QvaGlzdG9y eS9wYWdlLWNhY2hlLWVsZW1lbnQtc3RhdGUtZm9jdXNlZC5odG1sCisKKyAgICAgICAgKiBkb20v RG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmRlc3Ryb3lSZW5kZXJU cmVlKToKKwogMjAxNy0wNy0wOCAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXNvdXJjZSBMb2FkIFN0YXRpc3RpY3M6IFVzZXIgaW50ZXJhY3Rpb24gc2hv dWxkIGFsd2F5cyBnbyB0byB0b3AgZG9jdW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4 IDZiN2JlNDIzNTgzLi5kOTQ2NmI0MDk5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC0y MjUzLDExICsyMjUzLDYgQEAgdm9pZCBEb2N1bWVudDo6ZGVzdHJveVJlbmRlclRyZWUoKQogICAg ICAgICBzZXRGdWxsU2NyZWVuUmVuZGVyZXIobnVsbHB0cik7CiAjZW5kaWYKIAotICAgIG1faG92 ZXJlZEVsZW1lbnQgPSBudWxscHRyOwotICAgIG1fZm9jdXNlZEVsZW1lbnQgPSBudWxscHRyOwot ICAgIG1fYWN0aXZlRWxlbWVudCA9IG51bGxwdHI7Ci0gICAgbV9mb2N1c05hdmlnYXRpb25TdGFy dGluZ05vZGUgPSBudWxscHRyOwotCiAgICAgaWYgKG1fZG9jdW1lbnRFbGVtZW50KQogICAgICAg ICBSZW5kZXJUcmVlVXBkYXRlcjo6dGVhckRvd25SZW5kZXJlcnMoKm1fZG9jdW1lbnRFbGVtZW50 KTsKIAo=