<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>174299</bug_id>
          
          <creation_ts>2017-07-09 12:35:49 -0700</creation_ts>
          <short_desc>[Xcode] ICU headers aren’t treated as system headers after r219155</short_desc>
          <delta_ts>2017-07-09 13:19:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=116407</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>mitz</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>buildbot</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1326882</commentid>
    <comment_count>0</comment_count>
    <who name="">mitz</who>
    <bug_when>2017-07-09 12:35:49 -0700</bug_when>
    <thetext>&lt;https://trac.webkit.org/changeset/219155/webkit/trunk/Source/JavaScriptCore&gt; made it so that the ICU headers were no longer treated as system headers, and tried to compensate by suppressing the documentation warning around each #include of an ICU header that triggered the warning. Instead, we can keep treating the headers as system headers.

Patch forthcoming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1326883</commentid>
    <comment_count>1</comment_count>
      <attachid>314951</attachid>
    <who name="">mitz</who>
    <bug_when>2017-07-09 12:37:57 -0700</bug_when>
    <thetext>Created attachment 314951
Treat ICU headers as system headers</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1326884</commentid>
    <comment_count>2</comment_count>
    <who name="">mitz</who>
    <bug_when>2017-07-09 13:19:58 -0700</bug_when>
    <thetext>Fixed in &lt;https://trac.webkit.org/r219282&gt;.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>314951</attachid>
            <date>2017-07-09 12:37:57 -0700</date>
            <delta_ts>2017-07-09 13:18:29 -0700</delta_ts>
            <desc>Treat ICU headers as system headers</desc>
            <filename>file_174299.txt</filename>
            <type>text/plain</type>
            <size>4301</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTkyODEpDQorKysgU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwx
OCBAQA0KKzIwMTctMDctMDkgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4NCisNCisg
ICAgICAgIFtYY29kZV0gSUNVIGhlYWRlcnMgYXJlbuKAmXQgdHJlYXRlZCBhcyBzeXN0ZW0gaGVh
ZGVycyBhZnRlciByMjE5MTU1DQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTc0Mjk5DQorDQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4NCisNCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNjb25maWc6
IFBhc3MgLS1zeXN0ZW0taGVhZGVyLXByZWZpeD11bmljb2RlLyB0byB0aGUgQyBhbmQNCisgICAg
ICAgICAgQysrIGNvbXBpbGVycy4NCisNCisqIHJ1bnRpbWUvSW50bENvbGxhdG9yLmNwcDogUmVt
b3ZlZCBkb2N1bWVudGF0aW9uIHdhcm5pbmcgc3VwcHJlc3Npb24uDQorICAgICAgICAqIHJ1bnRp
bWUvSW50bERhdGVUaW1lRm9ybWF0LmNwcDogRGl0dG8uDQorICAgICAgICAqIHJ1bnRpbWUvSlNH
bG9iYWxPYmplY3QuY3BwOiBEaXR0by4NCisgICAgICAgICogcnVudGltZS9TdHJpbmdQcm90b3R5
cGUuY3BwOiBEaXR0by4NCisNCiAyMDE3LTA3LTA5ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50
ZWFAZ21haWwuY29tPg0KIA0KICAgICAgICAgW0pTQ10gVXNlIGZhc3RNYWxsb2MgLyBmYXN0RnJl
ZSBmb3IgU1RMIGNvbnRhaW5lcnMNCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmln
dXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNjb25maWcNCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNjb25maWcJKHJl
dmlzaW9uIDIxOTI4MSkNCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMv
SmF2YVNjcmlwdENvcmUueGNjb25maWcJKHdvcmtpbmcgY29weSkNCkBAIC00Nyw2ICs0Nyw4IEBA
IFNFQ1RPUkRFUl9GTEFHU19Qcm9kdWN0aW9uW3Nkaz1tYWNvc3gqXSANCiANCiBHQ0NfUFJFRklY
X0hFQURFUiA9IEphdmFTY3JpcHRDb3JlUHJlZml4Lmg7DQogR0NDX1NZTUJPTFNfUFJJVkFURV9F
WFRFUk4gPSBZRVM7DQorT1RIRVJfQ0ZMQUdTID0gJChpbmhlcml0ZWQpIC0tc3lzdGVtLWhlYWRl
ci1wcmVmaXg9dW5pY29kZS87DQorT1RIRVJfQ1BMVVNQTFVTRkxBR1MgPSAkKGluaGVyaXRlZCkg
LS1zeXN0ZW0taGVhZGVyLXByZWZpeD11bmljb2RlLzsNCiBIRUFERVJfU0VBUkNIX1BBVEhTID0g
IiR7QlVJTFRfUFJPRFVDVFNfRElSfS9EZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZSIgJChI
RUFERVJfU0VBUkNIX1BBVEhTKTsNCiBJTkZPUExJU1RfRklMRSA9IEluZm8ucGxpc3Q7DQogSU5T
VEFMTF9QQVRIID0gJChKQVZBU0NSSVBUQ09SRV9GUkFNRVdPUktTX0RJUik7DQpJbmRleDogU291
cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bENvbGxhdG9yLmNwcA0KPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K
LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxDb2xsYXRvci5jcHAJKHJldmlz
aW9uIDIxOTI4MSkNCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRsQ29sbGF0
b3IuY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtMzksMTQgKzM5LDcgQEANCiAjaW5jbHVkZSAiT2Jq
ZWN0Q29uc3RydWN0b3IuaCINCiAjaW5jbHVkZSAiU2xvdFZpc2l0b3JJbmxpbmVzLmgiDQogI2lu
Y2x1ZGUgIlN0cnVjdHVyZUlubGluZXMuaCINCi0jaWYgQ09NUElMRVIoQ0xBTkcpDQotI3ByYWdt
YSBjbGFuZyBkaWFnbm9zdGljIHB1c2gNCi0jcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgaWdub3Jl
ZCAiLVdkb2N1bWVudGF0aW9uIg0KLSNlbmRpZg0KICNpbmNsdWRlIDx1bmljb2RlL3Vjb2wuaD4N
Ci0jaWYgQ09NUElMRVIoQ0xBTkcpDQotI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHBvcA0KLSNl
bmRpZg0KICNpbmNsdWRlIDx3dGYvdW5pY29kZS9Db2xsYXRvci5oPg0KIA0KIG5hbWVzcGFjZSBK
U0Mgew0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxEYXRlVGltZUZv
cm1hdC5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0NCi0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9J
bnRsRGF0ZVRpbWVGb3JtYXQuY3BwCShyZXZpc2lvbiAyMTkyODEpDQorKysgU291cmNlL0phdmFT
Y3JpcHRDb3JlL3J1bnRpbWUvSW50bERhdGVUaW1lRm9ybWF0LmNwcAkod29ya2luZyBjb3B5KQ0K
QEAgLTM3LDE0ICszNyw3IEBADQogI2luY2x1ZGUgIkpTQ0lubGluZXMuaCINCiAjaW5jbHVkZSAi
T2JqZWN0Q29uc3RydWN0b3IuaCINCiAjaW5jbHVkZSA8dW5pY29kZS91Y2FsLmg+DQotI2lmIENP
TVBJTEVSKENMQU5HKQ0KLSNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwdXNoDQotI3ByYWdtYSBj
bGFuZyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XZG9jdW1lbnRhdGlvbiINCi0jZW5kaWYNCiAjaW5j
bHVkZSA8dW5pY29kZS91ZGF0cGcuaD4NCi0jaWYgQ09NUElMRVIoQ0xBTkcpDQotI3ByYWdtYSBj
bGFuZyBkaWFnbm9zdGljIHBvcA0KLSNlbmRpZg0KICNpbmNsdWRlIDx1bmljb2RlL3VlbnVtLmg+
DQogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4NCiANCkluZGV4OiBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHANCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0t
LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHAJKHJldmlz
aW9uIDIxOTI4MSkNCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9i
amVjdC5jcHAJKHdvcmtpbmcgY29weSkNCkBAIC0xNjksMTQgKzE2OSw3IEBADQogDQogI2lmIEVO
QUJMRShJTlRMKQ0KICNpbmNsdWRlICJJbnRsT2JqZWN0LmgiDQotI2lmIENPTVBJTEVSKENMQU5H
KQ0KLSNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwdXNoDQotI3ByYWdtYSBjbGFuZyBkaWFnbm9z
dGljIGlnbm9yZWQgIi1XZG9jdW1lbnRhdGlvbiINCi0jZW5kaWYNCiAjaW5jbHVkZSA8dW5pY29k
ZS91Y29sLmg+DQotI2lmIENPTVBJTEVSKENMQU5HKQ0KLSNwcmFnbWEgY2xhbmcgZGlhZ25vc3Rp
YyBwb3ANCi0jZW5kaWYNCiAjaW5jbHVkZSA8dW5pY29kZS91ZGF0Lmg+DQogI2luY2x1ZGUgPHVu
aWNvZGUvdW51bS5oPg0KICNlbmRpZiAvLyBFTkFCTEUoSU5UTCkNCkluZGV4OiBTb3VyY2UvSmF2
YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwDQo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0g
U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAkocmV2aXNp
b24gMjE5MjgxKQ0KKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3Rv
dHlwZS5jcHAJKHdvcmtpbmcgY29weSkNCkBAIC00NiwxNCArNDYsNyBAQA0KICNpbmNsdWRlICJT
dXBlclNhbXBsZXIuaCINCiAjaW5jbHVkZSA8YWxnb3JpdGhtPg0KICNpbmNsdWRlIDx1bmljb2Rl
L3Vjb25maWcuaD4NCi0jaWYgQ09NUElMRVIoQ0xBTkcpDQotI3ByYWdtYSBjbGFuZyBkaWFnbm9z
dGljIHB1c2gNCi0jcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgaWdub3JlZCAiLVdkb2N1bWVudGF0
aW9uIg0KLSNlbmRpZg0KICNpbmNsdWRlIDx1bmljb2RlL3Vub3JtLmg+DQotI2lmIENPTVBJTEVS
KENMQU5HKQ0KLSNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3ANCi0jZW5kaWYNCiAjaW5jbHVk
ZSA8dW5pY29kZS91c3RyaW5nLmg+DQogI2luY2x1ZGUgPHd0Zi9BU0NJSUNUeXBlLmg+DQogI2lu
Y2x1ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+DQo=
</data>
<flag name="review"
          id="335805"
          type_id="1"
          status="+"
          setter="sam"
    />
          </attachment>
      

    </bug>

</bugzilla>