174274 2017-07-07 13:56:53 -0700 Web Inspector: REGRESSION(r217258): WebSocket resource tree elements don't show the connection status 2017-07-07 14:33:30 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 hi hi bburg commit-queue inspector-bugzilla-changes oldest_to_newest 1326606 0 hi 2017-07-07 13:56:53 -0700 This was caused by using the wrong variable when registering the folderized settings for WebSocketResource. 1326608 1 314873 hi 2017-07-07 14:02:49 -0700 Created attachment 314873 Patch 1326613 2 314873 bburg 2017-07-07 14:05:15 -0700 Comment on attachment 314873 Patch r=me 1326638 3 314873 commit-queue 2017-07-07 14:33:29 -0700 Comment on attachment 314873 Patch Clearing flags on attachment: 314873 Committed r219269: <http://trac.webkit.org/changeset/219269> 1326639 4 commit-queue 2017-07-07 14:33:30 -0700 All reviewed patches have been landed. Closing bug. 314873 2017-07-07 14:02:49 -0700 2017-07-07 14:33:29 -0700 Patch bug-174274-20170707140248.patch text/plain 4958 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNmNmY2YjUwNGE3YTc5ODU5Njg2NmRkZTA3Nzlm NjVlNTFmNzFiOTIuLjhmYmQ2ZmI0ZGU5ZTIzZGQzNWU5ZWVmODFmOGJiZDMwOWEyODEzM2MgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA3LTA3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyMTcyNTgpOiBXZWJTb2NrZXQgcmVzb3VyY2UgdHJlZSBlbGVtZW50cyBkb24n dCBzaG93IHRoZSBjb25uZWN0aW9uIHN0YXR1cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0Mjc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0ZyYW1lVHJlZUVsZW1l bnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRnJhbWVUcmVlRWxlbWVudCk6CisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVRyZWVFbGVtZW50LmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlJlc291cmNlVHJlZUVsZW1lbnQucHJvdG90eXBlLnBvcHVsYXRlQ29udGV4 dE1lbnUpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvV2ViU29ja2V0UmVzb3VyY2VU cmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5XZWJTb2NrZXRSZXNvdXJjZVRy ZWVFbGVtZW50LnByb3RvdHlwZS5wb3B1bGF0ZUNvbnRleHRNZW51KToKKyAgICAgICAgTW92ZSAi TG9nIFdlYlNvY2tldCIgY29udGV4dCBtZW51IGl0ZW0gdG8gV2ViU29ja2V0UmVzb3VyY2VUcmVl RWxlbWVudC4KKwogMjAxNy0wNy0wNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSGlnaGxpZ2h0IG1hdGNoaW5nIGNhbnZhcyBlbGVt ZW50IHdoZW4gaG92ZXJpbmcgY29udGV4dHMgaW4gdGhlIFJlc291cmNlcyB0YWIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZyYW1lVHJlZUVs ZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9GcmFt ZVRyZWVFbGVtZW50LmpzCmluZGV4IDg5MmM1ZWYxYjZlZWVmNzIyMzZiMjVlNWU5Y2NlYWEyNjQ0 MDdiZDguLjEyODg1ZTQ2MTM1NWY3ZjM1MTMzNTVhYTc1ZTlkNTlhMDEzNThmMTEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZyYW1lVHJlZUVs ZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv RnJhbWVUcmVlRWxlbWVudC5qcwpAQCAtNjksNyArNjksNyBAQCBXZWJJbnNwZWN0b3IuRnJhbWVU cmVlRWxlbWVudCA9IGNsYXNzIEZyYW1lVHJlZUVsZW1lbnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3Iu UmVzbwogICAgICAgICAgICAgaWYgKHZhbHVlID09PSBXZWJJbnNwZWN0b3IuUmVzb3VyY2UuVHlw ZS5XZWJTb2NrZXQpCiAgICAgICAgICAgICAgICAgdHJlZUVsZW1lbnRDb25zdHJ1Y3RvciA9IFdl Ykluc3BlY3Rvci5XZWJTb2NrZXRSZXNvdXJjZVRyZWVFbGVtZW50OwogCi0gICAgICAgICAgICB0 aGlzLnJlZ2lzdGVyRm9sZGVyaXplU2V0dGluZ3Moa2V5LCBmb2xkZXJOYW1lLCB0aGlzLl9mcmFt ZS5yZXNvdXJjZUNvbGxlY3Rpb25Gb3JUeXBlKHZhbHVlKSwgZm9yd2FyZGluZ0NvbnN0cnVjdG9y KTsKKyAgICAgICAgICAgIHRoaXMucmVnaXN0ZXJGb2xkZXJpemVTZXR0aW5ncyhrZXksIGZvbGRl ck5hbWUsIHRoaXMuX2ZyYW1lLnJlc291cmNlQ29sbGVjdGlvbkZvclR5cGUodmFsdWUpLCB0cmVl RWxlbWVudENvbnN0cnVjdG9yKTsKICAgICAgICAgfQogCiAgICAgICAgIHRoaXMudXBkYXRlUGFy ZW50U3RhdHVzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9SZXNvdXJjZVRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VUcmVlRWxlbWVudC5qcwppbmRleCAwY2Y4MDE3 ZmI0ZWViNDAyODAwYTU0ODc0OTRlMWIxYjYxOWUwNmVlLi41MGQ0MTA4ZWVmNTkyMGI1NTcxMjM3 MTkyYzgwYzJlYWJjN2Y3Y2IzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlVHJlZUVsZW1lbnQuanMKQEAg LTE2MSwyMSArMTYxLDYgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlVHJlZUVsZW1lbnQgPSBjbGFz cyBSZXNvdXJjZVRyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVjdG8KIAogICAgIHBvcHVsYXRl Q29udGV4dE1lbnUoY29udGV4dE1lbnUsIGV2ZW50KQogICAgIHsKLSAgICAgICAgaWYgKHRoaXMu X3Jlc291cmNlLnR5cGUgPT09IFdlYkluc3BlY3Rvci5SZXNvdXJjZS5UeXBlLldlYlNvY2tldCkg ewotICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJp bmcoIkxvZyBXZWJTb2NrZXQiKSwgKCkgPT4gewotICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rv ci5SZW1vdGVPYmplY3QucmVzb2x2ZVdlYlNvY2tldCh0aGlzLl9yZXNvdXJjZSwgV2ViSW5zcGVj dG9yLlJ1bnRpbWVNYW5hZ2VyLkNvbnNvbGVPYmplY3RHcm91cCwgKHJlbW90ZU9iamVjdCkgPT4g ewotICAgICAgICAgICAgICAgICAgICBpZiAoIXJlbW90ZU9iamVjdCkKLSAgICAgICAgICAgICAg ICAgICAgICAgIHJldHVybjsKLQotICAgICAgICAgICAgICAgICAgICBjb25zdCB0ZXh0ID0gV2Vi SW5zcGVjdG9yLlVJU3RyaW5nKCJTZWxlY3RlZCBXZWJTb2NrZXQiKTsKLSAgICAgICAgICAgICAg ICAgICAgY29uc3QgYWRkU3BlY2lhbFVzZXJMb2dDbGFzcyA9IHRydWU7Ci0gICAgICAgICAgICAg ICAgICAgIFdlYkluc3BlY3Rvci5jb25zb2xlTG9nVmlld0NvbnRyb2xsZXIuYXBwZW5kSW1tZWRp YXRlRXhlY3V0aW9uV2l0aFJlc3VsdCh0ZXh0LCByZW1vdGVPYmplY3QsIGFkZFNwZWNpYWxVc2Vy TG9nQ2xhc3MpOwotICAgICAgICAgICAgICAgIH0pOwotICAgICAgICAgICAgfSk7Ci0KLSAgICAg ICAgICAgIGNvbnRleHRNZW51LmFwcGVuZFNlcGFyYXRvcigpOwotICAgICAgICB9Ci0KICAgICAg ICAgV2ViSW5zcGVjdG9yLmFwcGVuZENvbnRleHRNZW51SXRlbXNGb3JTb3VyY2VDb2RlKGNvbnRl eHRNZW51LCB0aGlzLl9yZXNvdXJjZSk7CiAKICAgICAgICAgc3VwZXIucG9wdWxhdGVDb250ZXh0 TWVudShjb250ZXh0TWVudSwgZXZlbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvV2ViU29ja2V0UmVzb3VyY2VUcmVlRWxlbWVudC5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1dlYlNvY2tldFJlc291 cmNlVHJlZUVsZW1lbnQuanMKaW5kZXggNjgxNjE1MWNjYzJiZTcwNTI0ZDE3MjcwMGVjNGRiNGNj NzUwZGJiOC4uMGY1YWEwNTU0YzU1MmY0MzU5YTc1Nzk5YjcwZGFjNGZlNjcyYjUzMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvV2ViU29ja2V0 UmVzb3VyY2VUcmVlRWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9XZWJTb2NrZXRSZXNvdXJjZVRyZWVFbGVtZW50LmpzCkBAIC00Myw2ICs0 MywyNCBAQCBXZWJJbnNwZWN0b3IuV2ViU29ja2V0UmVzb3VyY2VUcmVlRWxlbWVudCA9IGNsYXNz IFdlYlNvY2tldFJlc291cmNlVHJlZUVsZW1lbnQgZQogICAgICAgICB0aGlzLnJlc291cmNlLnJl bW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLldlYlNvY2tldFJlc291cmNlLkV2ZW50LlJl YWR5U3RhdGVDaGFuZ2VkLCB0aGlzLl91cGRhdGVDb25uZWN0aW9uU3RhdHVzLCB0aGlzKTsKICAg ICB9CiAKKyAgICBwb3B1bGF0ZUNvbnRleHRNZW51KGNvbnRleHRNZW51LCBldmVudCkKKyAgICB7 CisgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJM b2cgV2ViU29ja2V0IiksICgpID0+IHsKKyAgICAgICAgICAgIFdlYkluc3BlY3Rvci5SZW1vdGVP YmplY3QucmVzb2x2ZVdlYlNvY2tldCh0aGlzLl9yZXNvdXJjZSwgV2ViSW5zcGVjdG9yLlJ1bnRp bWVNYW5hZ2VyLkNvbnNvbGVPYmplY3RHcm91cCwgKHJlbW90ZU9iamVjdCkgPT4geworICAgICAg ICAgICAgICAgIGlmICghcmVtb3RlT2JqZWN0KQorICAgICAgICAgICAgICAgICAgICByZXR1cm47 CisKKyAgICAgICAgICAgICAgICBjb25zdCB0ZXh0ID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJT ZWxlY3RlZCBXZWJTb2NrZXQiKTsKKyAgICAgICAgICAgICAgICBjb25zdCBhZGRTcGVjaWFsVXNl ckxvZ0NsYXNzID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICBXZWJJbnNwZWN0b3IuY29uc29sZUxv Z1ZpZXdDb250cm9sbGVyLmFwcGVuZEltbWVkaWF0ZUV4ZWN1dGlvbldpdGhSZXN1bHQodGV4dCwg cmVtb3RlT2JqZWN0LCBhZGRTcGVjaWFsVXNlckxvZ0NsYXNzKTsKKyAgICAgICAgICAgIH0pOwor ICAgICAgICB9KTsKKworICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRTZXBhcmF0b3IoKTsKKwor ICAgICAgICBzdXBlci5wb3B1bGF0ZUNvbnRleHRNZW51KGNvbnRleHRNZW51LCBldmVudCk7Cisg ICAgfQorCiAgICAgLy8gUHJpdmF0ZQogCiAgICAgX3VwZGF0ZUNvbm5lY3Rpb25TdGF0dXMoKQo=