174260 2017-07-07 10:12:08 -0700 REGRESSION(r219194): [GStreamer] http/tests/media/video-redirect.html is failing 2017-07-10 03:13:52 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner bugs-noreply cgarcia clopez commit-queue mcatanzaro oldest_to_newest 1326510 0 cturner 2017-07-07 10:12:08 -0700 This was some fallout from r219194. The reason was not omitting an extra place we needed to convert URL's to using our internal protocol schema. These workarounds can go away once the upstream bug to be able to set ranks per-element get in. 1326549 1 314861 cturner 2017-07-07 12:35:25 -0700 Created attachment 314861 Patch 1326906 2 314861 clopez 2017-07-09 17:35:47 -0700 Comment on attachment 314861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314861&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:229 > - m_url = URL(URL(), cleanURLString); > + URL cleanURL = URL(URL(), cleanURLString); > + convertToInternalProtocol(cleanURL); > > - if (m_url.protocolIsInHTTPFamily()) > - m_url.setProtocol("webkit+" + url.protocol()); > + m_url = cleanURL; Why using an extra variable cleanURL and not simply doing ... m_url = URL(URL(), cleanURLString); convertToInternalProtocol(m_url); ?? 1326951 3 314969 cturner 2017-07-10 01:45:18 -0700 Created attachment 314969 Patch 1326959 4 314969 commit-queue 2017-07-10 03:13:50 -0700 Comment on attachment 314969 Patch Clearing flags on attachment: 314969 Committed r219288: <http://trac.webkit.org/changeset/219288> 1326960 5 commit-queue 2017-07-10 03:13:52 -0700 All reviewed patches have been landed. Closing bug. 314861 2017-07-07 12:35:25 -0700 2017-07-10 01:45:15 -0700 Patch bug-174260-20170707203523.patch text/plain 2910 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEyMGNjZjBlNjRjMzA5 MDIxZDA5Y2VjMGYwOTE0ZGIyNmM2ODY4ZC4uYjhiOTQ2NGYyMzc5Zjc2OWYyMzA5YmFkYzBjZTU0 ZDIzODcwZjY3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA3LTA3ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBodHRwL3Rl c3RzL21lZGlhL3ZpZGVvLXJlZGlyZWN0Lmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MjYwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHdlJ3JlIHRlc3Rpbmcg bmV3IFVSTHMgd2l0aGluIHRoZSBzYW1lIHNlY3VyaXR5IG9yaWdpbi4KKworICAgICAgICBDb3Zl cmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3Jl Ojpjb252ZXJ0VG9JbnRlcm5hbFByb3RvY29sKTogRmFjdG9yIG91dCBzZXR0aW5nIG91cgorICAg ICAgICBpbnRlcm5hbCBVUkwgc2NoZW1hLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyOjpzZXRQbGF5YmluVVJMKTogVXNlIHRoZQorICAgICAgICByZWZhY3Rv cmVkIGhlbHBlci4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l cjo6bG9hZE5leHRMb2NhdGlvbik6IFVzZQorICAgICAgICByZWZhY3RvcmVkIGhlbHBlciB0byBl bnN1cmUgYm90aCBVUkxzIGhhdmUgdGhlIHNhbWUgb3JpZ2luLgorCiAyMDE3LTA1LTI0ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTVkddIExl YWsgaW4gU1ZHQW5pbWF0ZWRMaXN0UHJvcGVydHlUZWFyT2ZmCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IGM4ZDY2ZDc3MmI5OTQxMzk0MjRl ZmNjMThhNDU3OTNmY2M3ZmQzMmUuLmUxNzQxODU0MDU1Mzg2YjgxNDFiY2UwNzhlNWY0Y2FiMjg0 OTU1ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIu Y3BwCkBAIC0yMTAsNiArMjEwLDEyIEBAIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6fk1l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcigpCiAgICAgfQogfQogCitzdGF0aWMgdm9pZCBjb252 ZXJ0VG9JbnRlcm5hbFByb3RvY29sKFVSTCYgdXJsKQoreworICAgIGlmICh1cmwucHJvdG9jb2xJ c0luSFRUUEZhbWlseSgpKQorICAgICAgICB1cmwuc2V0UHJvdG9jb2woIndlYmtpdCsiICsgdXJs LnByb3RvY29sKCkpOworfQorCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6c2V0 UGxheWJpblVSTChjb25zdCBVUkwmIHVybCkKIHsKICAgICAvLyBDbGVhbiBvdXQgZXZlcnl0aGlu ZyBhZnRlciBmaWxlOi8vIHVybCBwYXRoLgpAQCAtMjE3LDEwICsyMjMsMTAgQEAgdm9pZCBNZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnNldFBsYXliaW5VUkwoY29uc3QgVVJMJiB1cmwpCiAg ICAgaWYgKHVybC5pc0xvY2FsRmlsZSgpKQogICAgICAgICBjbGVhblVSTFN0cmluZyA9IGNsZWFu VVJMU3RyaW5nLnN1YnN0cmluZygwLCB1cmwucGF0aEVuZCgpKTsKIAotICAgIG1fdXJsID0gVVJM KFVSTCgpLCBjbGVhblVSTFN0cmluZyk7CisgICAgVVJMIGNsZWFuVVJMID0gVVJMKFVSTCgpLCBj bGVhblVSTFN0cmluZyk7CisgICAgY29udmVydFRvSW50ZXJuYWxQcm90b2NvbChjbGVhblVSTCk7 CiAKLSAgICBpZiAobV91cmwucHJvdG9jb2xJc0luSFRUUEZhbWlseSgpKQotICAgICAgICBtX3Vy bC5zZXRQcm90b2NvbCgid2Via2l0KyIgKyB1cmwucHJvdG9jb2woKSk7CisgICAgbV91cmwgPSBj bGVhblVSTDsKIAogICAgIEdTVF9JTkZPKCJMb2FkICVzIiwgbV91cmwuc3RyaW5nKCkudXRmOCgp LmRhdGEoKSk7CiAgICAgZ19vYmplY3Rfc2V0KG1fcGlwZWxpbmUuZ2V0KCksICJ1cmkiLCBtX3Vy bC5zdHJpbmcoKS51dGY4KCkuZGF0YSgpLCBudWxscHRyKTsKQEAgLTE2NjgsNiArMTY3NCw3IEBA IGJvb2wgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpsb2FkTmV4dExvY2F0aW9uKCkKICAg ICAgICAgLy8gYXBwZW5kIHRoZSB2YWx1ZSBvZiBuZXctbG9jYXRpb24gdG8gaXQuCiAgICAgICAg IFVSTCBiYXNlVXJsID0gZ3N0X3VyaV9pc192YWxpZChuZXdMb2NhdGlvbikgPyBVUkwoKSA6IG1f dXJsOwogICAgICAgICBVUkwgbmV3VXJsID0gVVJMKGJhc2VVcmwsIG5ld0xvY2F0aW9uKTsKKyAg ICAgICAgY29udmVydFRvSW50ZXJuYWxQcm90b2NvbChuZXdVcmwpOwogCiAgICAgICAgIFJlZlB0 cjxTZWN1cml0eU9yaWdpbj4gc2VjdXJpdHlPcmlnaW4gPSBTZWN1cml0eU9yaWdpbjo6Y3JlYXRl KG1fdXJsKTsKICAgICAgICAgaWYgKHNlY3VyaXR5T3JpZ2luLT5jYW5SZXF1ZXN0KG5ld1VybCkp IHsK 314969 2017-07-10 01:45:18 -0700 2017-07-10 03:13:50 -0700 Patch bug-174260-20170710094517.patch text/plain 2806 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEyMGNjZjBlNjRjMzA5 MDIxZDA5Y2VjMGYwOTE0ZGIyNmM2ODY4ZC4uYjhiOTQ2NGYyMzc5Zjc2OWYyMzA5YmFkYzBjZTU0 ZDIzODcwZjY3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA3LTA3ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBodHRwL3Rl c3RzL21lZGlhL3ZpZGVvLXJlZGlyZWN0Lmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MjYwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHdlJ3JlIHRlc3Rpbmcg bmV3IFVSTHMgd2l0aGluIHRoZSBzYW1lIHNlY3VyaXR5IG9yaWdpbi4KKworICAgICAgICBDb3Zl cmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3Jl Ojpjb252ZXJ0VG9JbnRlcm5hbFByb3RvY29sKTogRmFjdG9yIG91dCBzZXR0aW5nIG91cgorICAg ICAgICBpbnRlcm5hbCBVUkwgc2NoZW1hLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyOjpzZXRQbGF5YmluVVJMKTogVXNlIHRoZQorICAgICAgICByZWZhY3Rv cmVkIGhlbHBlci4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l cjo6bG9hZE5leHRMb2NhdGlvbik6IFVzZQorICAgICAgICByZWZhY3RvcmVkIGhlbHBlciB0byBl bnN1cmUgYm90aCBVUkxzIGhhdmUgdGhlIHNhbWUgb3JpZ2luLgorCiAyMDE3LTA1LTI0ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTVkddIExl YWsgaW4gU1ZHQW5pbWF0ZWRMaXN0UHJvcGVydHlUZWFyT2ZmCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IGM4ZDY2ZDc3MmI5OTQxMzk0MjRl ZmNjMThhNDU3OTNmY2M3ZmQzMmUuLjdjM2ZkZDM0ODM2MWU0YzU2MWI3ODY4ODllZmI0MWMxZjc4 Nzg0MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIu Y3BwCkBAIC0yMTAsNiArMjEwLDEyIEBAIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6fk1l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcigpCiAgICAgfQogfQogCitzdGF0aWMgdm9pZCBjb252 ZXJ0VG9JbnRlcm5hbFByb3RvY29sKFVSTCYgdXJsKQoreworICAgIGlmICh1cmwucHJvdG9jb2xJ c0luSFRUUEZhbWlseSgpKQorICAgICAgICB1cmwuc2V0UHJvdG9jb2woIndlYmtpdCsiICsgdXJs LnByb3RvY29sKCkpOworfQorCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6c2V0 UGxheWJpblVSTChjb25zdCBVUkwmIHVybCkKIHsKICAgICAvLyBDbGVhbiBvdXQgZXZlcnl0aGlu ZyBhZnRlciBmaWxlOi8vIHVybCBwYXRoLgpAQCAtMjE4LDkgKzIyNCw3IEBAIHZvaWQgTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpzZXRQbGF5YmluVVJMKGNvbnN0IFVSTCYgdXJsKQogICAg ICAgICBjbGVhblVSTFN0cmluZyA9IGNsZWFuVVJMU3RyaW5nLnN1YnN0cmluZygwLCB1cmwucGF0 aEVuZCgpKTsKIAogICAgIG1fdXJsID0gVVJMKFVSTCgpLCBjbGVhblVSTFN0cmluZyk7Ci0KLSAg ICBpZiAobV91cmwucHJvdG9jb2xJc0luSFRUUEZhbWlseSgpKQotICAgICAgICBtX3VybC5zZXRQ cm90b2NvbCgid2Via2l0KyIgKyB1cmwucHJvdG9jb2woKSk7CisgICAgY29udmVydFRvSW50ZXJu YWxQcm90b2NvbChtX3VybCk7CiAKICAgICBHU1RfSU5GTygiTG9hZCAlcyIsIG1fdXJsLnN0cmlu ZygpLnV0ZjgoKS5kYXRhKCkpOwogICAgIGdfb2JqZWN0X3NldChtX3BpcGVsaW5lLmdldCgpLCAi dXJpIiwgbV91cmwuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSwgbnVsbHB0cik7CkBAIC0xNjY4LDYg KzE2NzIsNyBAQCBib29sIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6bG9hZE5leHRMb2Nh dGlvbigpCiAgICAgICAgIC8vIGFwcGVuZCB0aGUgdmFsdWUgb2YgbmV3LWxvY2F0aW9uIHRvIGl0 LgogICAgICAgICBVUkwgYmFzZVVybCA9IGdzdF91cmlfaXNfdmFsaWQobmV3TG9jYXRpb24pID8g VVJMKCkgOiBtX3VybDsKICAgICAgICAgVVJMIG5ld1VybCA9IFVSTChiYXNlVXJsLCBuZXdMb2Nh dGlvbik7CisgICAgICAgIGNvbnZlcnRUb0ludGVybmFsUHJvdG9jb2wobmV3VXJsKTsKIAogICAg ICAgICBSZWZQdHI8U2VjdXJpdHlPcmlnaW4+IHNlY3VyaXR5T3JpZ2luID0gU2VjdXJpdHlPcmln aW46OmNyZWF0ZShtX3VybCk7CiAgICAgICAgIGlmIChzZWN1cml0eU9yaWdpbi0+Y2FuUmVxdWVz dChuZXdVcmwpKSB7Cg==