174254 2017-07-07 07:12:55 -0700 [GTK] Media test gardening after r219253 2017-07-12 09:14:36 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner commit-queue lforschler mcatanzaro oldest_to_newest 1326480 0 cturner 2017-07-07 07:12:55 -0700 Patch to follow... 1326584 1 314870 cturner 2017-07-07 13:23:56 -0700 Created attachment 314870 Patch 1327770 2 314870 mcatanzaro 2017-07-11 15:15:59 -0700 Comment on attachment 314870 Patch It'd be advisable to use the WebKitGTK+ or WPE components instead of Tools/Tests, or CC bugs-noreply@webkitgtk.org, so that we see it in a timely manner! I only check for other patches about once a month or so... just happened to do that now. 1327772 3 314870 mcatanzaro 2017-07-11 15:20:21 -0700 Comment on attachment 314870 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314870&action=review > LayoutTests/platform/gtk/TestExpectations:154 > +media/video-does-not-loop.html [ WontFix Timeout Crash ] Hm, I'm concerned about this one. In many cases, it's totally expected that a test can never pass on or platform, or expected that the test will hang forever due to use of unsupported JavaScript. But it should never crash. We should never have crash expectations without a bug, because crashes are never acceptable behavior. I see there are a couple other tests with crash expectations but no bugs right below this. That's not good. If you have time, it would be great to file bug reports and add the bugs to the test expectations. > LayoutTests/platform/gtk/TestExpectations:-3228 > -webkit.org/b/163530 media/video-restricted-no-preload-metadata.html [ Failure ] So we should close bug #163530 now, right? It is the only test marked against this bug. 1327774 4 mcatanzaro 2017-07-11 15:21:09 -0700 I reset my commit-queue so you can edit this before landing. 1327960 5 315216 cturner 2017-07-12 02:04:37 -0700 Created attachment 315216 Patch I will leave the crash expectation off because I won't have time to update the expectations for a while, I also noticed video-fast-seek started crashing again, so I'm going to leave it as well. I will close #163530 once this lands 1327961 6 cturner 2017-07-12 02:05:25 -0700 (Ah, I see you closed it already, thanks :)) 1328051 7 315216 mcatanzaro 2017-07-12 08:15:03 -0700 Comment on attachment 315216 Patch OK! 1328073 8 315216 commit-queue 2017-07-12 09:14:35 -0700 Comment on attachment 315216 Patch Clearing flags on attachment: 315216 Committed r219399: <http://trac.webkit.org/changeset/219399> 1328074 9 commit-queue 2017-07-12 09:14:36 -0700 All reviewed patches have been landed. Closing bug. 314870 2017-07-07 13:23:56 -0700 2017-07-12 02:04:32 -0700 Patch bug-174254-20170707212355.patch text/plain 3801 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MjU5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDgxYTY1N2U4NjI3NDc2YTVmYTAy MTc1OTNjMTk2OWViNjUwNTNlMy4uOGQwNjY1OGFhYTJkZGJmZGYxMDhhNWMyYzM0NTFmN2Q3MWQ4 NTgyMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA3LTA3ICBDaGFybGllIFR1cm5lciAg PGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBVbnJldmlld2VkIHRlc3QgZ2Fy ZGVuaW5nLgorICAgICAgICB2aWRlby1kb2VzLW5vdC1sb29wIGFsc28gY3Jhc2hlcyBvY2Nhc3Np b25hbGx5LgorCisgICAgICAgIHZpZGVvLWNvb2tpZSB3YXMgZml4ZWQgYnkgcjIxOTI1Mi4KKwor ICAgICAgICBtZWRpYS92aWRlby1iYWNrZ3JvdW5kLXRhYi1wbGF5YmFjay5odG1sIGlzIGZsYWt5 LgorCisgICAgICAgIG1lZGlhL3ZpZGVvLWZhc3Qtc2Vlay5odG1sIGhhcyBiZWVuIGNvbnNpc3Rl bnRseSBwYXNzaW5nLiBJdCBkaWQgY3Jhc2gKKyAgICAgICAgb2NjYXNzaW9uYWxseSwgYnV0IHRo ZSBleHBlY3RhdGlvbiBzaG91bGQgYmUgcGFzcywgYW5kIGlmL3doZW4gaXQgY3Jhc2hlcworICAg ICAgICBhZ2FpbiwgY2FuIGludmVzdGlnYXRlLgorCisgICAgICAgIG1lZGlhL3ZpZGVvLXJlc3Ry aWN0ZWQtbm8tcHJlbG9hZC1tZXRhZGF0YS5odG1sIGJlZW4gcGFzc2luZyBjb25zaXN0ZW50bHkK KyAgICAgICAgc2luY2UgcjIxNDMzOQorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl Y3RhdGlvbnM6CisKIDIwMTctMDctMDcgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bp Z2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLCBmaXggV0syIGV4cGVj dGF0aW9ucyBhZnRlciBteSBwcmV2aW91cyBjb21taXQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNDdlMWEzMGQwYzAxOTBlY2Q4NGU2NGM3NzdmMmFlMWNj ZGE3ZGNiNy4uNjg5N2U2YWIzOTYwMDRhYzQyNzNhMDg4ZTBiNTJiYjA1YjViZGVjMiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE1MSw3ICsxNTEsNyBA QCBzdmcvd2ViYXJjaGl2ZSBbIFdvbnRGaXggXQogc3ZnL2N1c3RvbS9pbWFnZS13aXRoLXByZWZp eC1pbi13ZWJhcmNoaXZlLnN2ZyBbIFdvbnRGaXggXQogCiAjIFRoaXMgdGVzdCBpcyBzcGVjaWZp YyB0byBRdWlja1RpbWUgbWVkaWEgZW5naW5lLgotbWVkaWEvdmlkZW8tZG9lcy1ub3QtbG9vcC5o dG1sIFsgV29udEZpeCBUaW1lb3V0IF0KK21lZGlhL3ZpZGVvLWRvZXMtbm90LWxvb3AuaHRtbCBb IFdvbnRGaXggVGltZW91dCBDcmFzaCBdCiAKICMgUmVxdWlyZXMgbWVkaWEgZW5naW5lIGNsb3Nl ZCBjYXB0aW9uIHN1cHBvcnQuCiBtZWRpYS9tZWRpYS1jYXB0aW9ucy5odG1sIFsgV29udEZpeCBU aW1lb3V0IEZhaWx1cmUgQ3Jhc2ggXQpAQCAtMTEzNiw3ICsxMTM2LDYgQEAgd2Via2l0Lm9yZy9i LzE1NDM5MCBbIFJlbGVhc2UgXSBodHRwL3Rlc3RzL21lZGlhL2hscy9obHMtYXVkaW8tdHJhY2tz LWxvY2FsZS1zZWwKIHdlYmtpdC5vcmcvYi8xNTQzOTAgWyBSZWxlYXNlIF0gaHR0cC90ZXN0cy9t ZWRpYS9obHMvaGxzLXZpZGVvLXJlc2l6ZS5odG1sIFsgVGltZW91dCBGYWlsdXJlIF0KIHdlYmtp dC5vcmcvYi8xNTQzOTAgWyBSZWxlYXNlIF0gaHR0cC90ZXN0cy9tZWRpYS9obHMvaGxzLWF1ZGlv LXRyYWNrcy5odG1sIFsgVGltZW91dCBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNTQzOTAgWyBS ZWxlYXNlIF0gaHR0cC90ZXN0cy9tZWRpYS9obHMvaGxzLWF1ZGlvLXRyYWNrcy1oYXMtYXVkaW8u aHRtbCBbIFRpbWVvdXQgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTU0MzkwIFsgUmVsZWFzZSBd IGh0dHAvdGVzdHMvbWVkaWEvaGxzL3ZpZGVvLWNvb2tpZS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJr aXQub3JnL2IvMTU0MzkwIGh0dHAvdGVzdHMvc2VjdXJpdHkvbG9jYWwtdmlkZW8tc291cmNlLWZy b20tcmVtb3RlLmh0bWwgWyBUaW1lb3V0IFBhc3MgXQogCiB3ZWJraXQub3JnL2IvMTU1NTA1IGh0 dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L3VzZXJBZ2VudFNoYWRvd0RP TS9hbGxvdy1hdWRpby5odG1sIFsgU2tpcCBdCkBAIC0yODk3LDcgKzI4OTYsNiBAQCB3ZWJraXQu b3JnL2IvMTMzODAzIGVkaXRpbmcvaW5wdXQvc2Nyb2xsLXZpZXdwb3J0LXBhZ2UtdXAtZG93bi5o dG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTMzODAzIGVkaXRpbmcvdW5kby91bmRvLWRl bGV0ZVdvcmQuaHRtbCBbIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMTM0OTc2IG1lZGlhL21l ZGlhLWNvbnRyb2xzLWludmFsaWQtdXJsLmh0bWwgWyBGYWlsdXJlIFRpbWVvdXQgXQotd2Via2l0 Lm9yZy9iLzEzNDk3NiBtZWRpYS92aWRlby1mYXN0LXNlZWsuaHRtbCBbIEZhaWx1cmUgXQogCiB3 ZWJraXQub3JnL2IvMTM0OTc5IG1lZGlhL3RyYWNrL3RyYWNrLWN1ZS1tdXRhYmxlLXRleHQuaHRt bCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzEzNDk3OSBtZWRpYS90cmFjay90cmFjay1jdWUt bm90aGluZy10by1yZW5kZXIuaHRtbCBbIEZhaWx1cmUgXQpAQCAtMzIyMSwxMSArMzIxOSwxMCBA QCB3ZWJraXQub3JnL2IvMTYzNTEyIG1lZGlhL21lZGlhLWNvbnRyb2xzLWFjY2Vzc2liaWxpdHku aHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE2MzUyMSBtZWRpYS90YWItZm9jdXMtaW5z aWRlLW1lZGlhLWVsZW1lbnRzLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNjM1MjMg bWVkaWEvdHJhY2svdHJhY2stbWFudWFsLW1vZGUuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9y Zy9iLzE2MzUyNCBtZWRpYS90cmFjay92aWRlby10cmFjay1hbHRlcm5hdGUtZ3JvdXBzLmh0bWwg WyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xNjM1MjUgbWVkaWEvdmlkZW8tYmFja2dyb3VuZC10 YWItcGxheWJhY2suaHRtbCBbIEZhaWx1cmUgXQord2Via2l0Lm9yZy9iLzE2MzUyNSBtZWRpYS92 aWRlby1iYWNrZ3JvdW5kLXRhYi1wbGF5YmFjay5odG1sIFsgRmFpbHVyZSBQYXNzIENyYXNoIFRp bWVvdXQgXQogd2Via2l0Lm9yZy9iLzE2MzUyNiBtZWRpYS92aWRlby1jb250cm9scy1kcm9wLWFu ZC1yZXN0b3JlLXRpbWVsaW5lLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNjM1Mjcg bWVkaWEvdmlkZW8tY29udHJvbHMtc2hvdy1vbi1rYi1vci1heC1ldmVudC5odG1sIFsgRmFpbHVy ZSBdCiB3ZWJraXQub3JnL2IvMTYzNTI5IG1lZGlhL3ZpZGVvLXBsYXliYWNrLXJlc3RyaWN0aW9u LXBsYXktYmVmb3JlLWxvYWQuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE2MzUzMCBt ZWRpYS92aWRlby1yZXN0cmljdGVkLW5vLXByZWxvYWQtbWV0YWRhdGEuaHRtbCBbIEZhaWx1cmUg XQogd2Via2l0Lm9yZy9iLzE2MzUzMSBtZWRpYS92aWRlby12b2x1bWUtc2xpZGVyLWRyYWcuaHRt bCBbIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMTYzODIzIG1lZGlhL2F1ZGlvLXBsYXliYWNr LXJlc3RyaWN0aW9uLWF1dG9wbGF5Lmh0bWwgWyBGYWlsdXJlIF0K 315216 2017-07-12 02:04:37 -0700 2017-07-12 09:14:35 -0700 Patch bug-174254-20170712110435.patch text/plain 2735 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5Mzg1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmJiZGM3MzFlMjczZTliYTUwOGIx NWE0MDljOWE0NzhkNmQ0MzFhOC4uZDRkNGViZmYwZjBhNmIzNjQzMmRmNjVhMjU3M2UzZTUwYjkz NzQ1MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA3LTEyICBDaGFybGllIFR1cm5lciAg PGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBNZWRpYSB0ZXN0IGdhcmRlbmlu ZyBhZnRlciByMjE5MjUzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzQyNTQKKworICAgICAgICBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLgorCisg ICAgICAgIHZpZGVvLWNvb2tpZSB3YXMgZml4ZWQgYnkgcjIxOTI1Mi4KKyAgICAgICAgbWVkaWEv dmlkZW8tcmVzdHJpY3RlZC1uby1wcmVsb2FkLW1ldGFkYXRhLmh0bWwgYmVlbiBwYXNzaW5nIGNv bnNpc3RlbnRseS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOgor CiAyMDE3LTA3LTExICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIxOTMzMik6IFtHVEtdIDkgbmV3IGZhaWx1cmVz IG9uIGZhc3QvZm9ybXMgc3BpbmJ1dHRvbiByZWxhdGVkIHRlc3RzLgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBhOTViMjk3NThjZmFmOWMyY2I0YTI3ZDg4 NWU5YzMyZDg2MzE2YzhkLi4zMTIwMDEwODAzNDc3NTJhNWY4MDg4MzMwYzcyNDU0NDc0NTlhMjg0 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTEzNSw3 ICsxMTM1LDYgQEAgd2Via2l0Lm9yZy9iLzE1NDM5MCBbIFJlbGVhc2UgXSBodHRwL3Rlc3RzL21l ZGlhL2hscy9obHMtYXVkaW8tdHJhY2tzLWxvY2FsZS1zZWwKIHdlYmtpdC5vcmcvYi8xNTQzOTAg WyBSZWxlYXNlIF0gaHR0cC90ZXN0cy9tZWRpYS9obHMvaGxzLXZpZGVvLXJlc2l6ZS5odG1sIFsg VGltZW91dCBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNTQzOTAgWyBSZWxlYXNlIF0gaHR0cC90 ZXN0cy9tZWRpYS9obHMvaGxzLWF1ZGlvLXRyYWNrcy5odG1sIFsgVGltZW91dCBGYWlsdXJlIF0K IHdlYmtpdC5vcmcvYi8xNTQzOTAgWyBSZWxlYXNlIF0gaHR0cC90ZXN0cy9tZWRpYS9obHMvaGxz LWF1ZGlvLXRyYWNrcy1oYXMtYXVkaW8uaHRtbCBbIFRpbWVvdXQgRmFpbHVyZSBdCi13ZWJraXQu b3JnL2IvMTU0MzkwIFsgUmVsZWFzZSBdIGh0dHAvdGVzdHMvbWVkaWEvaGxzL3ZpZGVvLWNvb2tp ZS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTU0MzkwIGh0dHAvdGVzdHMvc2VjdXJp dHkvbG9jYWwtdmlkZW8tc291cmNlLWZyb20tcmVtb3RlLmh0bWwgWyBUaW1lb3V0IFBhc3MgXQog CiB3ZWJraXQub3JnL2IvMTU1NTA1IGh0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5 UG9saWN5L3VzZXJBZ2VudFNoYWRvd0RPTS9hbGxvdy1hdWRpby5odG1sIFsgU2tpcCBdCkBAIC0z MjM1LDExICszMjM0LDEwIEBAIHdlYmtpdC5vcmcvYi8xNjM1MTIgbWVkaWEvbWVkaWEtY29udHJv bHMtYWNjZXNzaWJpbGl0eS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTYzNTIxIG1l ZGlhL3RhYi1mb2N1cy1pbnNpZGUtbWVkaWEtZWxlbWVudHMuaHRtbCBbIEZhaWx1cmUgXQogd2Vi a2l0Lm9yZy9iLzE2MzUyMyBtZWRpYS90cmFjay90cmFjay1tYW51YWwtbW9kZS5odG1sIFsgRmFp bHVyZSBdCiB3ZWJraXQub3JnL2IvMTYzNTI0IG1lZGlhL3RyYWNrL3ZpZGVvLXRyYWNrLWFsdGVy bmF0ZS1ncm91cHMuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE2MzUyNSBtZWRpYS92 aWRlby1iYWNrZ3JvdW5kLXRhYi1wbGF5YmFjay5odG1sIFsgRmFpbHVyZSBdCit3ZWJraXQub3Jn L2IvMTYzNTI1IG1lZGlhL3ZpZGVvLWJhY2tncm91bmQtdGFiLXBsYXliYWNrLmh0bWwgWyBGYWls dXJlIFBhc3MgQ3Jhc2ggVGltZW91dCBdCiB3ZWJraXQub3JnL2IvMTYzNTI2IG1lZGlhL3ZpZGVv LWNvbnRyb2xzLWRyb3AtYW5kLXJlc3RvcmUtdGltZWxpbmUuaHRtbCBbIEZhaWx1cmUgXQogd2Vi a2l0Lm9yZy9iLzE2MzUyNyBtZWRpYS92aWRlby1jb250cm9scy1zaG93LW9uLWtiLW9yLWF4LWV2 ZW50Lmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNjM1MjkgbWVkaWEvdmlkZW8tcGxh eWJhY2stcmVzdHJpY3Rpb24tcGxheS1iZWZvcmUtbG9hZC5odG1sIFsgRmFpbHVyZSBdCi13ZWJr aXQub3JnL2IvMTYzNTMwIG1lZGlhL3ZpZGVvLXJlc3RyaWN0ZWQtbm8tcHJlbG9hZC1tZXRhZGF0 YS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTYzNTMxIG1lZGlhL3ZpZGVvLXZvbHVt ZS1zbGlkZXItZHJhZy5odG1sIFsgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xNjM4MjMgbWVk aWEvYXVkaW8tcGxheWJhY2stcmVzdHJpY3Rpb24tYXV0b3BsYXkuaHRtbCBbIEZhaWx1cmUgXQo=