174236 2017-07-06 20:44:07 -0700 Web Inspector: Clean up some unnecessary constructors 2017-07-07 10:20:36 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bburg commit-queue hi inspector-bugzilla-changes joepeck oldest_to_newest 1326347 0 joepeck 2017-07-06 20:44:07 -0700 Some constructors are equivalent to the default. Some constructors take unnecessary parameters. 1326349 1 314805 joepeck 2017-07-06 20:44:53 -0700 Created attachment 314805 [PATCH] Proposed Fix 1326508 2 314805 bburg 2017-07-07 09:53:29 -0700 Comment on attachment 314805 [PATCH] Proposed Fix rs=me 1326511 3 314805 commit-queue 2017-07-07 10:20:35 -0700 Comment on attachment 314805 [PATCH] Proposed Fix Clearing flags on attachment: 314805 Committed r219259: <http://trac.webkit.org/changeset/219259> 1326512 4 commit-queue 2017-07-07 10:20:36 -0700 All reviewed patches have been landed. Closing bug. 314805 2017-07-06 20:44:53 -0700 2017-07-07 10:20:35 -0700 [PATCH] Proposed Fix constructor-cleanup-1.patch text/plain 4771 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRlMDMwZjcxMDFjLi4zZDhjYzcwZDA0NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMDctMDYgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBDbGVhbiB1cCBzb21lIHVubmVjZXNzYXJ5IGNvbnN0cnVjdG9ycworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MjM2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xs ZXJzL0NvZGVNaXJyb3JCZXppZXJFZGl0aW5nQ29udHJvbGxlci5qczoKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JDb2xvckVkaXRpbmdDb250cm9sbGVyLmpz OgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvckdyYWRpZW50 RWRpdGluZ0NvbnRyb2xsZXIuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9EaXZp ZGVyTmF2aWdhdGlvbkl0ZW0uanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9GbGV4 aWJsZVNwYWNlTmF2aWdhdGlvbkl0ZW0uanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9JZGxlVHJlZUVsZW1lbnQuanM6CisKIDIwMTctMDctMDUgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgYW5vdGhlciBQ cm90b2NvbCBWZXJzaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yQmV6aWVyRWRpdGluZ0NvbnRyb2xsZXIuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWly cm9yQmV6aWVyRWRpdGluZ0NvbnRyb2xsZXIuanMKaW5kZXggZTc5ZGE5N2Y5YzguLjcxNzk4OWQ1 MTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9Db2RlTWlycm9yQmV6aWVyRWRpdGluZ0NvbnRyb2xsZXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvckJlemll ckVkaXRpbmdDb250cm9sbGVyLmpzCkBAIC0yNSwxMSArMjUsNiBAQAogCiBXZWJJbnNwZWN0b3Iu Q29kZU1pcnJvckJlemllckVkaXRpbmdDb250cm9sbGVyID0gY2xhc3MgQ29kZU1pcnJvckJlemll ckVkaXRpbmdDb250cm9sbGVyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JFZGl0aW5n Q29udHJvbGxlcgogewotICAgIGNvbnN0cnVjdG9yKGNvZGVNaXJyb3IsIG1hcmtlcikKLSAgICB7 Ci0gICAgICAgIHN1cGVyKGNvZGVNaXJyb3IsIG1hcmtlcik7Ci0gICAgfQotCiAgICAgLy8gUHVi bGljCiAKICAgICBnZXQgaW5pdGlhbFZhbHVlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JDb2xvckVkaXRpbmdD b250cm9sbGVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJv bGxlcnMvQ29kZU1pcnJvckNvbG9yRWRpdGluZ0NvbnRyb2xsZXIuanMKaW5kZXggYjQ1ODQ2ZmQ1 MjYuLjM4NDhjNDYzZDMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yQ29sb3JFZGl0aW5nQ29udHJvbGxlci5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2Rl TWlycm9yQ29sb3JFZGl0aW5nQ29udHJvbGxlci5qcwpAQCAtMjUsMTEgKzI1LDYgQEAKIAogV2Vi SW5zcGVjdG9yLkNvZGVNaXJyb3JDb2xvckVkaXRpbmdDb250cm9sbGVyID0gY2xhc3MgQ29kZU1p cnJvckNvbG9yRWRpdGluZ0NvbnRyb2xsZXIgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuQ29kZU1pcnJv ckVkaXRpbmdDb250cm9sbGVyCiB7Ci0gICAgY29uc3RydWN0b3IoY29kZU1pcnJvciwgbWFya2Vy KQotICAgIHsKLSAgICAgICAgc3VwZXIoY29kZU1pcnJvciwgbWFya2VyKTsKLSAgICB9Ci0KICAg ICAvLyBQdWJsaWMKIAogICAgIGdldCBpbml0aWFsVmFsdWUoKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvckdyYWRp ZW50RWRpdGluZ0NvbnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yR3JhZGllbnRFZGl0aW5nQ29udHJvbGxlci5qcwpp bmRleCA3ZmYzOGUwZTdhMi4uMWY5ZWZkN2QyNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JHcmFkaWVudEVkaXRp bmdDb250cm9sbGVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JHcmFkaWVudEVkaXRpbmdDb250cm9sbGVyLmpzCkBAIC0y NSwxMSArMjUsNiBAQAogCiBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvckdyYWRpZW50RWRpdGluZ0Nv bnRyb2xsZXIgPSBjbGFzcyBDb2RlTWlycm9yR3JhZGllbnRFZGl0aW5nQ29udHJvbGxlciBleHRl bmRzIFdlYkluc3BlY3Rvci5Db2RlTWlycm9yRWRpdGluZ0NvbnRyb2xsZXIKIHsKLSAgICBjb25z dHJ1Y3Rvcihjb2RlTWlycm9yLCBtYXJrZXIpCi0gICAgewotICAgICAgICBzdXBlcihjb2RlTWly cm9yLCBtYXJrZXIpOwotICAgIH0KLQogICAgIC8vIFB1YmxpYwogCiAgICAgZ2V0IGluaXRpYWxW YWx1ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9EaXZpZGVyTmF2aWdhdGlvbkl0ZW0uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9EaXZpZGVyTmF2aWdhdGlvbkl0ZW0uanMKaW5kZXggOTEwYzA0NDhh MTIuLmViOWU5NmEwNWEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9EaXZpZGVyTmF2aWdhdGlvbkl0ZW0uanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGl2aWRlck5hdmlnYXRpb25JdGVtLmpzCkBA IC0yNSwxMSArMjUsNiBAQAogCiBXZWJJbnNwZWN0b3IuRGl2aWRlck5hdmlnYXRpb25JdGVtID0g Y2xhc3MgRGl2aWRlck5hdmlnYXRpb25JdGVtIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk5hdmlnYXRp b25JdGVtCiB7Ci0gICAgY29uc3RydWN0b3IoaWRlbnRpZmllcikKLSAgICB7Ci0gICAgICAgIHN1 cGVyKGlkZW50aWZpZXIpOwotICAgIH0KLQogICAgIC8vIFByb3RlY3RlZAogCiAgICAgZ2V0IGFk ZGl0aW9uYWxDbGFzc05hbWVzKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0ZsZXhpYmxlU3BhY2VOYXZpZ2F0aW9uSXRlbS5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZsZXhpYmxlU3BhY2VOYXZpZ2F0 aW9uSXRlbS5qcwppbmRleCA4NWM5ZjA5NzE3Zi4uZWNjMDJkMTcyOWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZsZXhpYmxlU3BhY2VOYXZp Z2F0aW9uSXRlbS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9GbGV4aWJsZVNwYWNlTmF2aWdhdGlvbkl0ZW0uanMKQEAgLTI1LDExICsyNSw2IEBACiAK IFdlYkluc3BlY3Rvci5GbGV4aWJsZVNwYWNlTmF2aWdhdGlvbkl0ZW0gPSBjbGFzcyBGbGV4aWJs ZVNwYWNlTmF2aWdhdGlvbkl0ZW0gZXh0ZW5kcyBXZWJJbnNwZWN0b3IuTmF2aWdhdGlvbkl0ZW0K IHsKLSAgICBjb25zdHJ1Y3RvcihpZGVudGlmaWVyKQotICAgIHsKLSAgICAgICAgc3VwZXIoaWRl bnRpZmllcik7Ci0gICAgfQotCiAgICAgLy8gUHJvdGVjdGVkCiAKICAgICBnZXQgYWRkaXRpb25h bENsYXNzTmFtZXMoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvSWRsZVRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvSWRsZVRyZWVFbGVtZW50LmpzCmluZGV4IGI1NDUyYjYwNGZhLi44 MjhiYWRmZThhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvSWRsZVRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0lkbGVUcmVlRWxlbWVudC5qcwpAQCAtMjUsNyArMjUsNyBAQAog CiBXZWJJbnNwZWN0b3IuSWRsZVRyZWVFbGVtZW50ID0gY2xhc3MgSWRsZVRyZWVFbGVtZW50IGV4 dGVuZHMgV2ViSW5zcGVjdG9yLkdlbmVyYWxUcmVlRWxlbWVudAogewotICAgIGNvbnN0cnVjdG9y KHRhcmdldCkKKyAgICBjb25zdHJ1Y3RvcigpCiAgICAgewogICAgICAgICBzdXBlcigiaWRsZSIs IFdlYkluc3BlY3Rvci5VSVN0cmluZygiSWRsZSIpKTsKICAgICB9Cg==