174228 2017-07-06 16:28:25 -0700 [Cocoa] CTParagraphStyle leak under WebCore::LinkImageLayout::LinkImageLayout 2017-07-06 17:00:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue dino joepeck kling thorton oldest_to_newest 1326245 0 joepeck 2017-07-06 16:28:25 -0700 Summary: Checking for leaks I came across a CTParagraphStyle Leak: Leak: 0x6180002dbc10 size=112 zone: DefaultMallocZone_0x10a316000 CTParagraphStyle CFType CoreText Call stack: [thread 0x7fff5a805340]: | start | main | NSApplicationMain | -[NSApplication run] | -[NSApplication(NSEvent) sendEvent:] | -[NSWindow(NSEventRouting) sendEvent:] | -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] | -[WebHTMLView mouseDragged:] | WebCore::EventHandler::mouseDragged(NSEvent*, NSEvent*) | WebCore::EventHandler::handleMouseMoveEvent(WebCore::PlatformMouseEvent const&, WebCore::HitTestResult*, bool) | WebCore::EventHandler::handleMouseDraggedEvent(WebCore::MouseEventWithHitTestResults const&, WebCore::CheckDragHysteresis) | WebCore::EventHandler::handleDrag(WebCore::MouseEventWithHitTestResults const&, WebCore::CheckDragHysteresis) | WebCore::DragController::startDrag(WebCore::Frame&, WebCore::DragState const&, WebCore::DragOperation, WebCore::PlatformMouseEvent const&, WebCore::IntPoint const&) | WebCore::createDragImageForLink(WebCore::Element&, WebCore::URL&, WTF::String const&, WebCore::TextIndicatorData&, WebCore::FontRenderingMode, float) | WebCore::LinkImageLayout::LinkImageLayout(WebCore::URL&, WTF::String const&) | WebCore::LinkImageLayout::LinkImageLayout(WebCore::URL&, WTF::String const&)::$_0::operator()(NSString*, NSColor*, NSFont*, long, CTLineBreakMode) const | CTParagraphStyleCreate | _CFRuntimeCreateInstance Should be adopting the Create into a RetainPtr: RetainPtr<CTParagraphStyleRef> paragraphStyle = CTParagraphStyleCreate(paragraphStyleSettings, 1); 1326248 1 314775 joepeck 2017-07-06 16:30:48 -0700 Created attachment 314775 [PATCH] Proposed Fix 1326258 2 314775 commit-queue 2017-07-06 17:00:33 -0700 Comment on attachment 314775 [PATCH] Proposed Fix Clearing flags on attachment: 314775 Committed r219226: <http://trac.webkit.org/changeset/219226> 1326259 3 commit-queue 2017-07-06 17:00:34 -0700 All reviewed patches have been landed. Closing bug. 314775 2017-07-06 16:30:48 -0700 2017-07-06 17:00:33 -0700 [PATCH] Proposed Fix adopt-1.patch text/plain 1467 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwMzA1NWM0YzkxOC4uZGVkN2ZhNmU2YzcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNy0wNy0wNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFtDb2NvYV0gQ1RQYXJhZ3JhcGhTdHlsZSBsZWFrIHVuZGVyIFdlYkNv cmU6OkxpbmtJbWFnZUxheW91dDo6TGlua0ltYWdlTGF5b3V0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQyMjgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9EcmFnSW1hZ2VNYWMu bW06CisgICAgICAgIChXZWJDb3JlOjpMaW5rSW1hZ2VMYXlvdXQ6OkxpbmtJbWFnZUxheW91dCk6 CisKIDIwMTctMDctMDUgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgQW5vdGhlciBidWlsZCBmaXgsIGZvciBNYWMuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tYWMvRHJhZ0ltYWdlTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL0RyYWdJbWFnZU1hYy5tbQppbmRleCA0ZDQ0N2ZkYjAxMS4uOTg5M2UyYTZlMmIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9EcmFnSW1hZ2VNYWMubW0K KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0RyYWdJbWFnZU1hYy5tbQpAQCAtMjI2 LDcgKzIyNiw3IEBAIExpbmtJbWFnZUxheW91dDo6TGlua0ltYWdlTGF5b3V0KFVSTCYgdXJsLCBj b25zdCBTdHJpbmcmIHRpdGxlU3RyaW5nKQogICAgICAgICBwYXJhZ3JhcGhTdHlsZVNldHRpbmdz WzBdLnNwZWMgPSBrQ1RQYXJhZ3JhcGhTdHlsZVNwZWNpZmllckxpbmVCcmVha01vZGU7CiAgICAg ICAgIHBhcmFncmFwaFN0eWxlU2V0dGluZ3NbMF0udmFsdWVTaXplID0gc2l6ZW9mKENUTGluZUJy ZWFrTW9kZSk7CiAgICAgICAgIHBhcmFncmFwaFN0eWxlU2V0dGluZ3NbMF0udmFsdWUgPSAmbGlu ZUJyZWFrTW9kZTsKLSAgICAgICAgUmV0YWluUHRyPENUUGFyYWdyYXBoU3R5bGVSZWY+IHBhcmFn cmFwaFN0eWxlID0gQ1RQYXJhZ3JhcGhTdHlsZUNyZWF0ZShwYXJhZ3JhcGhTdHlsZVNldHRpbmdz LCAxKTsKKyAgICAgICAgUmV0YWluUHRyPENUUGFyYWdyYXBoU3R5bGVSZWY+IHBhcmFncmFwaFN0 eWxlID0gYWRvcHRDRihDVFBhcmFncmFwaFN0eWxlQ3JlYXRlKHBhcmFncmFwaFN0eWxlU2V0dGlu Z3MsIDEpKTsKIAogICAgICAgICBOU0RpY3Rpb25hcnkgKnRleHRBdHRyaWJ1dGVzID0gQHsKICAg ICAgICAgICAgIChpZClrQ1RGb250QXR0cmlidXRlTmFtZTogZm9udCwK