174222 2017-07-06 15:41:35 -0700 [GStreamer] Live twitch.tv videos do not play 2017-07-10 09:44:35 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner bugs-noreply commit-queue mcatanzaro oldest_to_newest 1326217 0 cturner 2017-07-06 15:41:35 -0700 Not investigated yet, but apparently we're missing a plugin to play whatever twitch.tv is serving in its live streams. 1326465 1 cturner 2017-07-07 06:13:53 -0700 This was an upstream in bug in typefind, it was incorrectly deducing the type of Twitch HLS streams as text/uri-list. It's fixed by e68c071bf01c1b4b796c48a87b511005e8c0c9f6 typefind: Switch to normal mode before have-type I recommend we update our GStreamer dependency. Conservatively can go to 1.10.5, since there's nothing (apart from the fix above) adventurous, $ git log --pretty=oneline 1.10.4...1.10.5 2bec169793cddeaad35a1e50a0e7d5f1d7946a58 Release 1.10.5 4eb8908fa9589d7ff555c44798f19fa65711acc2 Update .po files 37a9b02391e468226498f26ae8922cea68bb6e22 message: Don't pass a NULL debug string to g_utf8_validate() e68c071bf01c1b4b796c48a87b511005e8c0c9f6 typefind: Switch to normal mode before have-type f727d67d5300b85fae405d371dd171b6528eb9ed meson: update version 9c80d89d74244658675ef281b3ceceb32ae1fd66 meson: Fix build with latest upstream git 1326496 2 mcatanzaro 2017-07-07 08:57:09 -0700 (In reply to Charlie Turner from comment #1) > This was an upstream in bug in typefind, it was incorrectly deducing the > type of Twitch HLS streams as text/uri-list. It's fixed by > > e68c071bf01c1b4b796c48a87b511005e8c0c9f6 typefind: Switch to normal mode > before have-type > > I recommend we update our GStreamer dependency. Conservatively can go to > 1.10.5, since there's nothing (apart from the fix above) adventurous, OK. Do you want to prepare a patch for the WPE and GTK JHBuild modulesets? 1326498 3 cturner 2017-07-07 09:06:35 -0700 Yep, I am working on that. I will do another test run once I'm finished to make sure there's no regressions. 1327001 4 cturner 2017-07-10 07:57:55 -0700 This is looking alright to be, current patch review (no changes needed) <patch file="gstreamer-0001-protection-added-function-to-filter-system-ids.patch" strip="1"/> bda8440 in version 1.12.0 - still needed <patch file="gst-plugins-good-0003-rtpbin-receive-bundle-support.patch" strip="1"/> dcd3ce9 in version 1.11.0 - still needed <patch file="gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch" strip="1"/> not committed upstream - still needed. There's some noise on stderr related to things like OpenWebRTC and MediaStream, neither of which has complete implementation, so I don't know whether to make this block the otherwise good upgrade. 1327007 5 cturner 2017-07-10 08:29:58 -0700 WPE has for some reason lagged behind the previous GStreamer version bumps. I'm not setup yet to adequately test upgrades on WPE, but when I am I will look at upgrading it also. 1327008 6 314982 cturner 2017-07-10 08:33:34 -0700 Created attachment 314982 Patch 1327010 7 314982 mcatanzaro 2017-07-10 08:42:20 -0700 Comment on attachment 314982 Patch Of course, it'd be even better to upgrade to 1.12, so we can test against the software our users are actually running. But that would probably require rebaselining more layout tests. 1327023 8 314982 commit-queue 2017-07-10 09:10:22 -0700 Comment on attachment 314982 Patch Clearing flags on attachment: 314982 Committed r219292: <http://trac.webkit.org/changeset/219292> 1327024 9 commit-queue 2017-07-10 09:10:23 -0700 All reviewed patches have been landed. Closing bug. 1327046 10 mcatanzaro 2017-07-10 09:44:35 -0700 Oops, for future reference, we should have done the JHBuild moduleset update in a separate bug report. 314982 2017-07-10 08:33:34 -0700 2017-07-10 09:10:22 -0700 Patch bug-174222-20170710163332.patch text/plain 4442 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5Mjg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjk3ZmYzMGFjMWQxMmM5ZGM1YzBjYTQ2Y2I3NDI5YWU5 MDE4YTJiNS4uYmRiOGUzYzA0MWIwYWJmYjI3M2IwYWIxNjQ3MWU2YWY0ODhlY2JiOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE3LTA3LTEwICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbR1N0cmVhbWVyXSBMaXZlIHR3aXRjaC50diB2aWRlb3MgZG8gbm90IHBsYXkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDIyMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZ3JhZGUgR1N0 cmVhbWVyIHRvIDEuMTAuNS4gSXQgY29udGFpbnMgYSBjaGFuZ2UgdG8gdHlwZWZpbmQgdGhhdAor ICAgICAgICBmaXhlcyB2aWRlb3Mgbm90IHBsYXlpbmcgb24gdHdpdGNoLnR2LgorCisgICAgICAg ICogZ3RrL2poYnVpbGQubW9kdWxlczoKKwogMjAxNy0wNy0wOSAgWmFuIERvYmVyc2VrICA8emRv YmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgQWRkIFdlYkdMMiBjb25maWd1cmF0aW9uIG9w dGlvbiB0byBidWlsZC13ZWJraXQKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVs ZXMgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCmluZGV4IDcwZjJkNmNhODkxMTQ4NGE0ZWVk NGYyYTk5M2VmMDMxMjFiYWQ0ZWIuLjNiOTVhMGMzN2Y2MWJjNjRmNjViNDhmMzAwOWNmZGE3OGQ0 MDg1NTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMv Z3RrL2poYnVpbGQubW9kdWxlcwpAQCAtMzE3LDkgKzMxNyw5IEBACiAgICAgPGRlcGVuZGVuY2ll cz4KICAgICAgIDxkZXAgcGFja2FnZT0ib3JjIi8+CiAgICAgPC9kZXBlbmRlbmNpZXM+Ci0gICAg PGJyYW5jaCBtb2R1bGU9ImdzdHJlYW1lci9nc3RyZWFtZXItJHt2ZXJzaW9ufS50YXIueHoiIHZl cnNpb249IjEuMTAuNCIKKyAgICA8YnJhbmNoIG1vZHVsZT0iZ3N0cmVhbWVyL2dzdHJlYW1lci0k e3ZlcnNpb259LnRhci54eiIgdmVyc2lvbj0iMS4xMC41IgogICAgICAgICAgICAgcmVwbz0iZ3N0 cmVhbWVyIgotICAgICAgICAgICAgaGFzaD0ic2hhMjU2OjUwYzJmNWFmNTBhNmNjNmMwYTNmM2Vk NDNiZGQ4YjVlMmJmZjAwYmFjZmI3NjZkNGJlMTM5ZWMwNmQ4YjUyMTgiPgorICAgICAgICAgICAg aGFzaD0ic2hhMjU2OmJjMDYyNDM2MDA4MTdmNjM3MDI5ZGEyOWQwODlkNTkwOGQxZDI2NjU0MmY2 OGJmNjYyNmExMGM1ZjA1ZjFmMWQiPgogICAgICAgPHBhdGNoIGZpbGU9ImdzdHJlYW1lci0wMDAx LXByb3RlY3Rpb24tYWRkZWQtZnVuY3Rpb24tdG8tZmlsdGVyLXN5c3RlbS1pZHMucGF0Y2giIHN0 cmlwPSIxIi8+CiAgICAgPC9icmFuY2g+CiAgIDwvYXV0b3Rvb2xzPgpAQCAtMzMzLDkgKzMzMyw5 IEBACiAgICAgPGRlcGVuZGVuY2llcz4KICAgICAgIDxkZXAgcGFja2FnZT0iZ3N0cmVhbWVyIi8+ CiAgICAgPC9kZXBlbmRlbmNpZXM+Ci0gICAgPGJyYW5jaCBtb2R1bGU9ImdzdC1wbHVnaW5zLWJh c2UvZ3N0LXBsdWdpbnMtYmFzZS0ke3ZlcnNpb259LnRhci54eiIgdmVyc2lvbj0iMS4xMC40Igor ICAgIDxicmFuY2ggbW9kdWxlPSJnc3QtcGx1Z2lucy1iYXNlL2dzdC1wbHVnaW5zLWJhc2UtJHt2 ZXJzaW9ufS50YXIueHoiIHZlcnNpb249IjEuMTAuNSIKICAgICAgICAgICAgIHJlcG89ImdzdHJl YW1lciIKLSAgICAgICAgICAgIGhhc2g9InNoYTI1NjpmNmQyNDViNmIzZDRjYjczM2Y4MWViYjAy MTA3NGM1MjVlY2U4M2RiMGMxMGU5MzI3OTRiMzM5YjhkOTM1ZWI3Ii8+CisgICAgICAgICAgICBo YXNoPSJzaGEyNTY6MWM0MDFhNzliZDFlNDUyMWM2ZWYxYjY2NTc5YmRkZWRkOTEzNmUxNjRlNTQ3 OTJhYWI0YmZjZjM0ODViZjlhNyIvPgogICA8L2F1dG90b29scz4KIAogICA8YXV0b3Rvb2xzIGlk PSJnc3QtcGx1Z2lucy1nb29kIiBhdXRvZ2VuLXNoPSJjb25maWd1cmUiIGF1dG9nZW5hcmdzPSIt LWRpc2FibGUtZXhhbXBsZXMgLS1kaXNhYmxlLWd0ay1kb2MiPgpAQCAtMzQ3LDkgKzM0Nyw5IEBA CiAgICAgICA8ZGVwIHBhY2thZ2U9ImxpYnZweCIvPgogICAgIDwvZGVwZW5kZW5jaWVzPgogCi0g ICAgPGJyYW5jaCBtb2R1bGU9ImdzdC1wbHVnaW5zLWdvb2QvZ3N0LXBsdWdpbnMtZ29vZC0ke3Zl cnNpb259LnRhci54eiIgdmVyc2lvbj0iMS4xMC40IgorICAgIDxicmFuY2ggbW9kdWxlPSJnc3Qt cGx1Z2lucy1nb29kL2dzdC1wbHVnaW5zLWdvb2QtJHt2ZXJzaW9ufS50YXIueHoiIHZlcnNpb249 IjEuMTAuNSIKICAgICAgICAgICAgIHJlcG89ImdzdHJlYW1lciIKLSAgICAgICAgICAgIGhhc2g9 InNoYTI1Njo4YTg2YzYxNDM0YThjNDQ2NjUzNjViZDBiMzU1N2EwNDA5MzdkMWY0NGJmNjljYWVl NGU5ZWE4MTZjZTc0ZDdlIj4KKyAgICAgICAgICAgIGhhc2g9InNoYTI1NjpiZTA1M2Y2ZWQ3MTZl ZWI1MTdjZWMxNDhjZWM2MzdjZGNlNTcxYzZlMDRkNWMyMTQwOWUyODc2ZmI3NmM3NjM5Ij4KICAg ICAgIDxwYXRjaCBmaWxlPSJnc3QtcGx1Z2lucy1nb29kLTAwMDMtcnRwYmluLXJlY2VpdmUtYnVu ZGxlLXN1cHBvcnQucGF0Y2giIHN0cmlwPSIxIi8+CiAgICAgICA8cGF0Y2ggZmlsZT0iZ3N0LXBs dWdpbnMtZ29vZC0wMDA0LXF0ZGVtdXgtYWRkLWNvbnRleHQtZm9yLWEtcHJlZmVycmVkLXByb3Rl Y3Rpb24ucGF0Y2giIHN0cmlwPSIxIi8+CiAgICAgPC9icmFuY2g+CkBAIC0zNjMsMTggKzM2Mywx OCBAQAogICAgICAgPGRlcCBwYWNrYWdlPSJnc3QtcGx1Z2lucy1iYXNlIi8+CiAgICAgICA8ZGVw IHBhY2thZ2U9Im9wZW5oMjY0Ii8+CiAgICAgPC9kZXBlbmRlbmNpZXM+Ci0gICAgPGJyYW5jaCBt b2R1bGU9ImdzdC1wbHVnaW5zLWJhZC9nc3QtcGx1Z2lucy1iYWQtJHt2ZXJzaW9ufS50YXIueHoi IHZlcnNpb249IjEuMTAuNCIKKyAgICA8YnJhbmNoIG1vZHVsZT0iZ3N0LXBsdWdpbnMtYmFkL2dz dC1wbHVnaW5zLWJhZC0ke3ZlcnNpb259LnRhci54eiIgdmVyc2lvbj0iMS4xMC41IgogICAgICAg ICAgICAgcmVwbz0iZ3N0cmVhbWVyIgotICAgICAgICAgICAgaGFzaD0ic2hhMjU2OjIzZGRhZTUw NmIzYTIyM2I5NDg2OWEwZDNlZWEzZTlhMTJlODQ3Zjk0ZDJkMGUwYjk3MTAyY2UxM2VjZDY5NjYi Lz4KKyAgICAgICAgICAgIGhhc2g9InNoYTI1NjpjNTgwNjA0MGJiODNiNDNiZTg2Y2U1OTJlNmEx OWM1ZDgzZDc3NzZmN2Q5ZjQzNGViNGI5MTFjNGVmZmYzNTczIi8+CiAgIDwvYXV0b3Rvb2xzPgog CiAgIDxhdXRvdG9vbHMgaWQ9ImdzdC1saWJhdiIgYXV0b2dlbi1zaD0iY29uZmlndXJlIiBhdXRv Z2VuYXJncz0iLS13aXRoLWxpYmF2LWV4dHJhLWNvbmZpZ3VyZT0nLS1kaXNhYmxlLXlhc20nIC0t ZGlzYWJsZS1ndGstZG9jIj4KICAgICA8ZGVwZW5kZW5jaWVzPgogICAgICAgPGRlcCBwYWNrYWdl PSJnc3QtcGx1Z2lucy1iYXNlIi8+CiAgICAgPC9kZXBlbmRlbmNpZXM+Ci0gICAgPGJyYW5jaCBt b2R1bGU9ImdzdC1saWJhdi9nc3QtbGliYXYtJHt2ZXJzaW9ufS50YXIueHoiIHZlcnNpb249IjEu MTAuNCIKKyAgICA8YnJhbmNoIG1vZHVsZT0iZ3N0LWxpYmF2L2dzdC1saWJhdi0ke3ZlcnNpb259 LnRhci54eiIgdmVyc2lvbj0iMS4xMC41IgogICAgICAgICAgICAgcmVwbz0iZ3N0cmVhbWVyIgot ICAgICAgICAgICAgaGFzaD0ic2hhMjU2OjZjYTBmZWNhNzVlM2Q0ODMxNWUwN2YyMGVjMzdjZjYy NjBlZDFlOWRkZTU4ZGYzNTVmZWJkNTAxNjI0NjI2OGIiLz4KKyAgICAgICAgICAgIGhhc2g9InNo YTI1NjplNGQyZjMxNWY0NzhkNDcyODFmYmZkZmJkNTkwYTYzZDIzNzA0Y2EzNzkxMWQ3MTQyZDU5 OTI2MTZmNGIyOGQzIi8+CiAgIDwvYXV0b3Rvb2xzPgogCiAgIDxhdXRvdG9vbHMgaWQ9InhzZXJ2 ZXIiIGF1dG9nZW5hcmdzPSItLWRpc2FibGUteGluZXJhbWEgLS1lbmFibGUtZ2x4IC0tZW5hYmxl LWNvbXBvc2l0ZSAtLWRpc2FibGUteG9yZyAtLWRpc2FibGUtZG14IC0tZGlzYWJsZS14bmVzdCAt LWRpc2FibGUteHF1YXJ0eiAtLWRpc2FibGUteHdpbiAtLWRpc2FibGUteGVwaHlyIC0tZGlzYWJs ZS14ZmFrZSAtLWRpc2FibGUteGZiZGV2IC0tZGlzYWJsZS1pbnN0YWxsLXNldHVpZCAtLWRpc2Fi bGUtdW5pdC10ZXN0cyAtLWRpc2FibGUtcHJlc2VudCAtLWVuYWJsZS11bml4LXRyYW5zcG9ydCAt LWVuYWJsZS10Y3AtdHJhbnNwb3J0IC0tZGlzYWJsZS1sb2NhbC10cmFuc3BvcnQgLS13aXRoLXhr Yi1wYXRoPS91c3Ivc2hhcmUvWDExL3hrYiAtLXdpdGgteGtiLW91dHB1dD0vdmFyL2xpYi94a2Ig LS13aXRoLXhrYi1iaW4tZGlyZWN0b3J5PS91c3IvYmluIC0td2l0aG91dC1kdHJhY2UiPgo=