174209 2017-07-06 10:19:33 -0700 Web Inspector: Highlight matching canvas element when hovering contexts in the Resources tab 2017-07-07 14:43:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 138941 174279 1 hi hi commit-queue inspector-bugzilla-changes joepeck oldest_to_newest 1326089 0 hi 2017-07-06 10:19:33 -0700 This would be useful for quickly finding the right canvas to inspect. 1326095 1 314734 hi 2017-07-06 10:25:26 -0700 Created attachment 314734 Patch 1326098 2 314734 joepeck 2017-07-06 10:53:23 -0700 Comment on attachment 314734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314734&action=review r=me > Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:43 > + this.element.addEventListener("mouseover", this._handleMouseover.bind(this)); > + this.element.addEventListener("mouseout", this._handleMouseout.bind(this)); Seems we have more occurrences of "handleMouseOver" than "handleMouseover". Same with `MouseOut`. 1326151 3 314749 hi 2017-07-06 13:13:14 -0700 Created attachment 314749 Patch 1326168 4 314749 commit-queue 2017-07-06 13:51:23 -0700 Comment on attachment 314749 Patch Clearing flags on attachment: 314749 Committed r219214: <http://trac.webkit.org/changeset/219214> 1326169 5 commit-queue 2017-07-06 13:51:24 -0700 All reviewed patches have been landed. Closing bug. 314734 2017-07-06 10:25:26 -0700 2017-07-06 13:13:14 -0700 Patch bug-174209-20170706102520.patch text/plain 2268 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE4NWQzNGVmN2UwODVhNmI5NmIzOTQ3NDJmZWRl ZDdiMTI2YWNiODguLjhiZTE5NjM4ZGRiMDBhYWY5YmQ3M2RlOTAyMmJkNWExZGQxMDU2M2UgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA3LTA2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBI aWdobGlnaHQgbWF0Y2hpbmcgY2FudmFzIGVsZW1lbnQgd2hlbiBob3ZlcmluZyBjb250ZXh0cyBp biB0aGUgUmVzb3VyY2VzIHRhYgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc0MjA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1RyZWVFbGVtZW50LmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkNhbnZhc1RyZWVFbGVtZW50LnByb3RvdHlwZS5vbmF0dGFj aCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ2FudmFzVHJlZUVsZW1lbnQucHJvdG90eXBlLl9o YW5kbGVNb3VzZW92ZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNhbnZhc1RyZWVFbGVtZW50 LnByb3RvdHlwZS5faGFuZGxlTW91c2VvdXQpOgorCiAyMDE3LTA3LTA1ICBEZXZpbiBSb3Vzc28g IDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBbGxvdyB1c2Vy cyB0byBsb2cgYW55IHRyYWNrZWQgY2FudmFzIGNvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1RyZWVFbGVtZW50LmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzVHJlZUVsZW1l bnQuanMKaW5kZXggNDNiM2NhNmI5ZjJhZDhkNDBkYmFiODhjNmM3OTQwMzgyYWNhNWZkMS4uYjdl MTIxMzc3M2RjMTFhMDMwOTVlYjJhZjliZDI1NGJkM2RhYjk3OCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzVHJlZUVsZW1lbnQuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzVHJl ZUVsZW1lbnQuanMKQEAgLTM1LDYgKzM1LDE0IEBAIFdlYkluc3BlY3Rvci5DYW52YXNUcmVlRWxl bWVudCA9IGNsYXNzIENhbnZhc1RyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVjdG9yLkdlCiAK ICAgICAvLyBQcm90ZWN0ZWQKIAorICAgIG9uYXR0YWNoKCkKKyAgICB7CisgICAgICAgIHN1cGVy Lm9uYXR0YWNoKCk7CisKKyAgICAgICAgdGhpcy5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1v dXNlb3ZlciIsIHRoaXMuX2hhbmRsZU1vdXNlb3Zlci5iaW5kKHRoaXMpKTsKKyAgICAgICAgdGhp cy5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlb3V0IiwgdGhpcy5faGFuZGxlTW91c2Vv dXQuYmluZCh0aGlzKSk7CisgICAgfQorCiAgICAgcG9wdWxhdGVDb250ZXh0TWVudShjb250ZXh0 TWVudSwgZXZlbnQpCiAgICAgewogICAgICAgICBzdXBlci5wb3B1bGF0ZUNvbnRleHRNZW51KGNv bnRleHRNZW51LCBldmVudCk7CkBAIC01Miw0ICs2MCwyMSBAQCBXZWJJbnNwZWN0b3IuQ2FudmFz VHJlZUVsZW1lbnQgPSBjbGFzcyBDYW52YXNUcmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3BlY3Rv ci5HZQogCiAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZFNlcGFyYXRvcigpOwogICAgIH0KKwor ICAgIC8vIFByaXZhdGUKKworICAgIF9oYW5kbGVNb3VzZW92ZXIoZXZlbnQpCisgICAgeworICAg ICAgICB0aGlzLnJlcHJlc2VudGVkT2JqZWN0LnJlcXVlc3ROb2RlKChub2RlKSA9PiB7CisgICAg ICAgICAgICBpZiAoIW5vZGUgfHwgIW5vZGUub3duZXJEb2N1bWVudCkKKyAgICAgICAgICAgICAg ICByZXR1cm47CisKKyAgICAgICAgICAgIFdlYkluc3BlY3Rvci5kb21UcmVlTWFuYWdlci5oaWdo bGlnaHRET01Ob2RlKG5vZGUuaWQsICJhbGwiKTsKKyAgICAgICAgfSk7CisgICAgfQorCisgICAg X2hhbmRsZU1vdXNlb3V0KGV2ZW50KQorICAgIHsKKyAgICAgICAgV2ViSW5zcGVjdG9yLmRvbVRy ZWVNYW5hZ2VyLmhpZGVET01Ob2RlSGlnaGxpZ2h0KCk7CisgICAgfQogfTsK 314749 2017-07-06 13:13:14 -0700 2017-07-06 13:51:23 -0700 Patch 174209.diff text/plain 2153 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE4NWQzNGVmN2UwLi4wOWMwODY3NDlhMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDctMDYgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEhp Z2hsaWdodCBtYXRjaGluZyBjYW52YXMgZWxlbWVudCB3aGVuIGhvdmVyaW5nIGNvbnRleHRzIGlu IHRoZSBSZXNvdXJjZXMgdGFiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzQyMDkKKworICAgICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jhcm8u CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1RyZWVFbGVtZW50LmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkNhbnZhc1RyZWVFbGVtZW50LnByb3RvdHlwZS5vbmF0dGFj aCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ2FudmFzVHJlZUVsZW1lbnQucHJvdG90eXBlLl9o YW5kbGVNb3VzZU92ZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNhbnZhc1RyZWVFbGVtZW50 LnByb3RvdHlwZS5faGFuZGxlTW91c2VPdXQpOgorCiAyMDE3LTA3LTA1ICBEZXZpbiBSb3Vzc28g IDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBbGxvdyB1c2Vy cyB0byBsb2cgYW55IHRyYWNrZWQgY2FudmFzIGNvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1RyZWVFbGVtZW50LmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzVHJlZUVsZW1l bnQuanMKaW5kZXggNDNiM2NhNmI5ZjIuLjAwZjMwODZjYTJlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNUcmVlRWxlbWVudC5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNUcmVl RWxlbWVudC5qcwpAQCAtMzUsNiArMzUsMTQgQEAgV2ViSW5zcGVjdG9yLkNhbnZhc1RyZWVFbGVt ZW50ID0gY2xhc3MgQ2FudmFzVHJlZUVsZW1lbnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuR2UKIAog ICAgIC8vIFByb3RlY3RlZAogCisgICAgb25hdHRhY2goKQorICAgIHsKKyAgICAgICAgc3VwZXIu b25hdHRhY2goKTsKKworICAgICAgICB0aGlzLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91 c2VvdmVyIiwgdGhpcy5faGFuZGxlTW91c2VPdmVyLmJpbmQodGhpcykpOworICAgICAgICB0aGlz LmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2VvdXQiLCB0aGlzLl9oYW5kbGVNb3VzZU91 dC5iaW5kKHRoaXMpKTsKKyAgICB9CisKICAgICBwb3B1bGF0ZUNvbnRleHRNZW51KGNvbnRleHRN ZW51LCBldmVudCkKICAgICB7CiAgICAgICAgIHN1cGVyLnBvcHVsYXRlQ29udGV4dE1lbnUoY29u dGV4dE1lbnUsIGV2ZW50KTsKQEAgLTUyLDQgKzYwLDIxIEBAIFdlYkluc3BlY3Rvci5DYW52YXNU cmVlRWxlbWVudCA9IGNsYXNzIENhbnZhc1RyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVjdG9y LkdlCiAKICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kU2VwYXJhdG9yKCk7CiAgICAgfQorCisg ICAgLy8gUHJpdmF0ZQorCisgICAgX2hhbmRsZU1vdXNlT3ZlcihldmVudCkKKyAgICB7CisgICAg ICAgIHRoaXMucmVwcmVzZW50ZWRPYmplY3QucmVxdWVzdE5vZGUoKG5vZGUpID0+IHsKKyAgICAg ICAgICAgIGlmICghbm9kZSB8fCAhbm9kZS5vd25lckRvY3VtZW50KQorICAgICAgICAgICAgICAg IHJldHVybjsKKworICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmRvbVRyZWVNYW5hZ2VyLmhpZ2hs aWdodERPTU5vZGUobm9kZS5pZCwgImFsbCIpOworICAgICAgICB9KTsKKyAgICB9CisKKyAgICBf aGFuZGxlTW91c2VPdXQoZXZlbnQpCisgICAgeworICAgICAgICBXZWJJbnNwZWN0b3IuZG9tVHJl ZU1hbmFnZXIuaGlkZURPTU5vZGVIaWdobGlnaHQoKTsKKyAgICB9CiB9Owo=