174200 2017-07-06 03:39:15 -0700 setupgitclone.py needs to be updated in order to work with Perl 5.26.0+ 2017-07-06 09:41:25 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya webkit-unassigned annulen bjonesbe buildbot commit-queue glenn lforschler mcatanzaro rniwa oldest_to_newest 1325997 0 aboya 2017-07-06 03:39:15 -0700 Perl 5.26.0 introduces an important backwards incompatible change: the current working directory is no longer part of `@INC` by default. http://blogs.perl.org/users/sawyer_x/2017/05/perl-5260-is-now-available.html This makes invocations like this fail: perl -e "use VCSUtils; ..." In order to work with new versions of Perl, the current working directory must be added to the include path before running the `use` instruction, e.g: perl -e "use lib '.'; use VCSUtils; ..." setupgitclone.py has two of these invocations. 1326029 1 314722 aboya 2017-07-06 07:57:51 -0700 Created attachment 314722 Patch 1326031 2 314722 mcatanzaro 2017-07-06 08:09:45 -0700 Comment on attachment 314722 Patch There's always the risk this will break all our bots, but it looks fine. Remember to set cq? to request commit in the future. 1326036 3 314722 commit-queue 2017-07-06 08:37:46 -0700 Comment on attachment 314722 Patch Clearing flags on attachment: 314722 Committed r219197: <http://trac.webkit.org/changeset/219197> 1326037 4 commit-queue 2017-07-06 08:37:48 -0700 All reviewed patches have been landed. Closing bug. 1326052 5 annulen 2017-07-06 09:24:42 -0700 FWIW, I would use "-I." argument 1326063 6 aboya 2017-07-06 09:41:25 -0700 +1 to using -I. 314722 2017-07-06 07:57:51 -0700 2017-07-06 08:37:46 -0700 Patch bug-174200-20170706165749.patch text/plain 1991 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTk0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWMzMzZiZGExYjM3N2M3NGZjMWZmMjdjOGEyMDJkMTRh MDViZTI4Ni4uMDZmZjhiY2JmZDE0OTVkZjc5ZmQ2NWZlMTUyODZhODA3MGFkYTE3ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE3LTA3LTA2ICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4K KworICAgICAgICBBZGQgQ1dEIHRvIFBlcmwgbGlicmFyeSBwYXRoIChubyBsb25nZXIgdGhlIGRl ZmF1bHQgc2luY2UgNS4yNi4wKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc0MjAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2V0dXBnaXRjbG9u ZS5weToKKyAgICAgICAgKFNldHVwR2l0Q2xvbmUuX2dldF91c2VybmFtZV9hbmRfZW1haWwpOgor CiAyMDE3LTA3LTA2ICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KICAgICAg ICAgW0dTdHJlYW1lcl0gdmlkLm1lIHZpZGVvcyBkbyBub3QgcGxheQogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyMjQwCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2V0dXBnaXRjbG9uZS5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9zZXR1cGdpdGNsb25lLnB5CmluZGV4IDQ2 NTY0ZTZjNDA4YTcwM2FlZmY0OTFhNDkyZGFhZTFkYjZhOWMwYWEuLjI1OGRmMDBkMWZkNTQ1ZTQ3 MzVmZDI1ZWRmNzIyNmMzNGY3NzNkYmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9jb21tYW5kcy9zZXR1cGdpdGNsb25lLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9jb21tYW5kcy9zZXR1cGdpdGNsb25lLnB5CkBAIC04MSwxMSArODEsMTEgQEAg Y2xhc3MgU2V0dXBHaXRDbG9uZShDb21tYW5kKToKICAgICAgICAgICAgIG9yaWdpbmFsX3BhdGgg PSB0b29sLmZpbGVzeXN0ZW0uYWJzcGF0aCgiLiIpCiAKICAgICAgICAgICAgIHRvb2wuZmlsZXN5 c3RlbS5jaGRpcigiVG9vbHMvU2NyaXB0cy8iKQotICAgICAgICAgICAgdXNlcm5hbWUgPSB0b29s LmV4ZWN1dGl2ZS5ydW5fYW5kX3Rocm93X2lmX2ZhaWwoWyJwZXJsIiwgIi1lIiwgInVzZSBWQ1NV dGlsczsgcHJpbnQgU1RET1VUIGNoYW5nZUxvZ05hbWUoKTsiXSwgcXVpZXQ9VHJ1ZSkKKyAgICAg ICAgICAgIHVzZXJuYW1lID0gdG9vbC5leGVjdXRpdmUucnVuX2FuZF90aHJvd19pZl9mYWlsKFsi cGVybCIsICItZSIsICJ1c2UgbGliICcuJzsgdXNlIFZDU1V0aWxzOyBwcmludCBTVERPVVQgY2hh bmdlTG9nTmFtZSgpOyJdLCBxdWlldD1UcnVlKQogICAgICAgICAgICAgaWYgbm90IHVzZXJuYW1l OgogICAgICAgICAgICAgICAgIHVzZXJuYW1lID0gdG9vbC51c2VyLnByb21wdCgiWW91ciBuYW1l OiIpCiAKLSAgICAgICAgICAgIGVtYWlsID0gdG9vbC5leGVjdXRpdmUucnVuX2FuZF90aHJvd19p Zl9mYWlsKFsicGVybCIsICItZSIsICJ1c2UgVkNTVXRpbHM7IHByaW50IFNURE9VVCBjaGFuZ2VM b2dFbWFpbEFkZHJlc3MoKTsiXSwgcXVpZXQ9VHJ1ZSkKKyAgICAgICAgICAgIGVtYWlsID0gdG9v bC5leGVjdXRpdmUucnVuX2FuZF90aHJvd19pZl9mYWlsKFsicGVybCIsICItZSIsICJ1c2UgbGli ICcuJzsgdXNlIFZDU1V0aWxzOyBwcmludCBTVERPVVQgY2hhbmdlTG9nRW1haWxBZGRyZXNzKCk7 Il0sIHF1aWV0PVRydWUpCiAgICAgICAgICAgICBpZiBub3QgZW1haWw6CiAgICAgICAgICAgICAg ICAgZW1haWwgPSB0b29sLnVzZXIucHJvbXB0KCJZb3VyIGVtYWlsIGFkZHJlc3M6IikKIAo=