174190 2017-07-05 19:26:28 -0700 Add logging to first attempt to use the WebIconDatabase class 2017-07-06 09:31:39 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 beidson beidson achristensen aestes cdumez commit-queue thorton oldest_to_newest 1325882 0 beidson 2017-07-05 19:26:28 -0700 Add logging to any attempts to use WebIconDatabase It was never API, is no longer used for icon loading, and will be going away altogether in a future release. Least we can do now is add a warning log statement. 1325886 1 beidson 2017-07-05 19:28:27 -0700 "Add logging to first attempt to use the WebIconDatabase class" 1325895 2 314683 beidson 2017-07-05 19:32:34 -0700 Created attachment 314683 Patch 1326056 3 314683 commit-queue 2017-07-06 09:31:37 -0700 Comment on attachment 314683 Patch Clearing flags on attachment: 314683 Committed r219200: <http://trac.webkit.org/changeset/219200> 1326057 4 commit-queue 2017-07-06 09:31:39 -0700 All reviewed patches have been landed. Closing bug. 314683 2017-07-05 19:32:34 -0700 2017-07-06 09:31:37 -0700 Patch bug-174190-20170705193239.patch text/plain 2752 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZDQyNDIwYWIx NjY5OGRjZjFkODA0Mzg0YmM5MmNkZmU4YmQ5YTNiNC4uOWIxMzRjMDE2YjY2OTlkZWE1ZDc4MTQ4 MzEzZTQ2M2JiNTU1YjBlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE3 LTA3LTA1ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAorICAgICAgICBBZGQg bG9nZ2luZyB0byBmaXJzdCBhdHRlbXB0IHRvIHVzZSB0aGUgV2ViSWNvbkRhdGFiYXNlIGNsYXNz LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MTkw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaXNj L1dlYkljb25EYXRhYmFzZS5tbToKKyAgICAgICAgKCtbV2ViSWNvbkRhdGFiYXNlIHNoYXJlZElj b25EYXRhYmFzZV0pOiBPbiBmaXJzdCBjYWxsLCBsb2cgYSB3YXJuaW5nIG9mIHRoZSBibGVhayBm dXR1cmUgb2YgdGhpcyBub24tQVBJLgorICAgICAgICAqIE1pc2MvV2ViS2l0VmVyc2lvbkNoZWNr cy5oOgorCisyMDE3LTA3LTA1ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKwog ICAgICAgICBBbGxvdyBuYXZpZ2F0aW9ucyBpbiBzdWJmcmFtZXMgdG8gZ2V0IGEgU2hvdWxkT3Bl bkV4dGVybmFsVVJMc1BvbGljeSBvZiAiU2hvdWxkQWxsb3ciLgogICAgICAgICA8cmRhcjovL3By b2JsZW0vMjI0ODU1ODk+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTc0MTc4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViSWNvbkRh dGFiYXNlLm1tIGIvU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJJY29uRGF0YWJhc2UubW0KaW5k ZXggODYyZGI0ODIwM2UxNDE0ZTcwOWYzMDZjYjVmMTYyMzExNzU3OTA4Yi4uYjJkNzhlMGQwNjhi NmE3ZTZiNTNkMjIzNzE0NTdmODY1MGYyYzY3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9t YWMvTWlzYy9XZWJJY29uRGF0YWJhc2UubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvTWlzYy9X ZWJJY29uRGF0YWJhc2UubW0KQEAgLTM0LDYgKzM0LDcgQEAKICNpbXBvcnQgIldlYkljb25EYXRh YmFzZURlbGVnYXRlLmgiCiAjaW1wb3J0ICJXZWJLaXRMb2dnaW5nLmgiCiAjaW1wb3J0ICJXZWJL aXROU1N0cmluZ0V4dHJhcy5oIgorI2ltcG9ydCAiV2ViS2l0VmVyc2lvbkNoZWNrcy5oIgogI2lt cG9ydCAiV2ViTlNGaWxlTWFuYWdlckV4dHJhcy5oIgogI2ltcG9ydCAiV2ViTlNVUkxFeHRyYXMu aCIKICNpbXBvcnQgIldlYlByZWZlcmVuY2VzUHJpdmF0ZS5oIgpAQCAtOTcsOSArOTgsMTUgQEAg KyAodm9pZClpbml0aWFsaXplCiAKICsgKFdlYkljb25EYXRhYmFzZSAqKXNoYXJlZEljb25EYXRh YmFzZQogewotICAgIHN0YXRpYyBXZWJJY29uRGF0YWJhc2UgKmRhdGFiYXNlID0gbmlsOwotICAg IGlmICghZGF0YWJhc2UpCisgICAgc3RhdGljIFdlYkljb25EYXRhYmFzZSAqZGF0YWJhc2U7Cisg ICAgc3RhdGljIGRpc3BhdGNoX29uY2VfdCBvbmNlOworICAgIGRpc3BhdGNoX29uY2UoJm9uY2Us IF4geworICAgICAgICBpZiAobGlua2VkT25PckFmdGVyKFNES1ZlcnNpb246OkZpcnN0V2l0aFdl Ykljb25EYXRhYmFzZVdhcm5pbmcpKQorICAgICAgICAgICAgTlNMb2coQCIrW1dlYkljb25EYXRh YmFzZSBzaGFyZWRJY29uRGF0YWJhc2VdIGlzIG5vdCBBUEkgYW5kIHNob3VsZCBub3QgYmUgdXNl ZC4gV2ViSWNvbkRhdGFiYXNlIG5vIGxvbmdlciBoYW5kbGVzIGljb24gbG9hZGluZyBhbmQgaXQg d2lsbCBiZSByZW1vdmVkIGluIGEgZnV0dXJlIHJlbGVhc2UuIik7CisKICAgICAgICAgZGF0YWJh c2UgPSBbW1dlYkljb25EYXRhYmFzZSBhbGxvY10gaW5pdF07CisgICAgfSk7CisKICAgICByZXR1 cm4gZGF0YWJhc2U7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2Vi S2l0VmVyc2lvbkNoZWNrcy5oIGIvU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJLaXRWZXJzaW9u Q2hlY2tzLmgKaW5kZXggMDAzMmNhOTJkYTZlMDkwZjc4Mjk4NTZjNDhkZDQzYjA1NmJhZDdmMC4u Y2FkNjdlNmMyZGViNzZmNmExZGI3OWU5YzcwN2QzNGM4MWVmZjIzYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJLaXRWZXJzaW9uQ2hlY2tzLmgKKysrIGIvU291cmNlL1dl YktpdC9tYWMvTWlzYy9XZWJLaXRWZXJzaW9uQ2hlY2tzLmgKQEAgLTg0LDcgKzg0LDggQEAgZW51 bSBjbGFzcyBTREtWZXJzaW9uIDogdWludDMyX3QgewogI2lmIFBMQVRGT1JNKElPUykKICAgICBG aXJzdFRvRXhjbHVkZUxvY2FsU3RvcmFnZUZyb21CYWNrdXAgPSBEWUxEX0lPU19WRVJTSU9OXzEx XzAsCiAjZWxzZQotICAgIEZpcnN0V2l0aERyb3BUb05hdmlnYXRlRGlzYWxsb3dlZEJ5RGVmYXVs dCA9IERZTERfTUFDT1NYX1ZFUlNJT05fMTBfMTMKKyAgICBGaXJzdFdpdGhEcm9wVG9OYXZpZ2F0 ZURpc2FsbG93ZWRCeURlZmF1bHQgPSBEWUxEX01BQ09TWF9WRVJTSU9OXzEwXzEzLAorICAgIEZp cnN0V2l0aFdlYkljb25EYXRhYmFzZVdhcm5pbmcgPSBEWUxEX01BQ09TWF9WRVJTSU9OXzEwXzEz LAogI2VuZGlmCiB9OwogCg==