174185 2017-07-05 16:24:03 -0700 Crashing with information should have an abort reason 2017-07-05 17:05:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller benjamin buildbot cdumez cmarcelo commit-queue dbates mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1325814 0 keith_miller 2017-07-05 16:24:03 -0700 Crashing with information should have an abort reason 1325815 1 314664 keith_miller 2017-07-05 16:27:20 -0700 Created attachment 314664 Patch 1325816 2 314664 saam 2017-07-05 16:29:26 -0700 Comment on attachment 314664 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314664&action=review > Source/JavaScriptCore/dfg/DFGGraph.cpp:-1455 > - WTFReportBacktrace(); Why get rid of this? 1325823 3 314664 keith_miller 2017-07-05 16:37:16 -0700 Comment on attachment 314664 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314664&action=review >> Source/JavaScriptCore/dfg/DFGGraph.cpp:-1455 >> - WTFReportBacktrace(); > > Why get rid of this? The CRASH macro already does this. 1325824 4 webkit-bug-importer 2017-07-05 16:37:59 -0700 <rdar://problem/33146457> 1325840 5 314664 commit-queue 2017-07-05 17:05:40 -0700 Comment on attachment 314664 Patch Clearing flags on attachment: 314664 Committed r219172: <http://trac.webkit.org/changeset/219172> 1325841 6 commit-queue 2017-07-05 17:05:42 -0700 All reviewed patches have been landed. Closing bug. 314664 2017-07-05 16:27:20 -0700 2017-07-05 17:05:40 -0700 Patch bug-174185-20170705162719.patch text/plain 5613 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw Mjc3ZjM2MDk3Yzg3ZWEzMWMyMTVhODlkMDBhMzc4YTJhOWRkYzM1Li42ZjllNjVlYTRlZWM0Njhj MzE4OGYzNmI4N2ZlNDM1MDI0NDQ4MDBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNy0wNy0wNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBDcmFzaGluZyB3aXRoIGluZm9ybWF0aW9uIHNob3VsZCBoYXZlIGFu IGFib3J0IHJlYXNvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTc0MTg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGNyYXNoIGluZm9ybWF0aW9uIGZvciB0aGUgYWJzdHJhY3QgaW50ZXJwcmV0ZXIg YW5kIGFkZCBhbiBlbnVtCisgICAgICAgIHZhbHVlIGZvciBvYmplY3QgYWxsb2NhdGlvbiBzaW5r aW5nLgorCisgICAgICAgICogYXNzZW1ibGVyL0Fib3J0UmVhc29uLmg6CisgICAgICAgICogZGZn L0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkRGRzo6QWJz dHJhY3RJbnRlcnByZXRlcjxBYnN0cmFjdFN0YXRlVHlwZT46OnZlcmlmeUVkZ2UpOgorICAgICAg ICAqIGRmZy9ERkdHcmFwaC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6bG9nREZHQXNzZXJ0aW9u RmFpbHVyZSk6CisgICAgICAgICogZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2Uu Y3BwOgorCiAyMDE3LTA3LTA1ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWJBc3NlbWJseTogaW1wbGVtZW50IG5hbWUgc2VjdGlvbidzIG1vZHVsZSBuYW1l LCBza2lwIHVua25vd24gc2VjdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9n IGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggMmRlNGY4YjQ1NmQ2ZDZlYzMwYzY4M2FiY2Q1 NTgyMzEwZDk0Y2NlNy4uNDU1NDJkZDJlNGFhMTEzOGM4NzY5YWYxODhkZjcwYzFhM2QyNmZlNyAx MDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wNy0wNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWls bGVyQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaGluZyB3aXRoIGluZm9ybWF0aW9uIHNob3Vs ZCBoYXZlIGFuIGFib3J0IHJlYXNvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc0MTg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4IGFuIGlmZGVmIHRvIGFjdHVhbGx5IHdvcmsgd2l0aCBYODZfNjQu IEl0IHR1cm5zIG91dCBYNjRfNjQgaXMKKyAgICAgICAgbm90IGFuIGFyY2hpdGVjdHVyZS4uLiBX aG9vcHMuCisKKyAgICAgICAgKiB3dGYvQXNzZXJ0aW9ucy5jcHA6CisKIDIwMTctMDctMDQgIFl1 c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW1dURl0gTWFr ZSBkb3VibGUtY29udmVyc2lvbidzIGNhY2hlIGRhdGEgY29uc3RhbnQgYW5kIGRyb3AgZG91Ymxl X2NvbnZlcnNpb246OmluaXRpYWxpemUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9BYm9ydFJlYXNvbi5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9BYm9ydFJlYXNvbi5oCmluZGV4IDMyYWUwODY3YTU4MGIzYTVkZTM3NDA4N2ZjYTNiNDhl YTY5Zjc0ZmQuLjRiN2U3NjZhMDQ1OTViNmZjNjFlNzU4OTRlNzI4N2ZmODE4NGVlYzggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQWJvcnRSZWFzb24uaAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fib3J0UmVhc29uLmgKQEAgLTc2LDQg Kzc2LDEyIEBAIGVudW0gQWJvcnRSZWFzb24gewogICAgIFlBUlJOb0lucHV0Q29uc3VtZWQgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgPSAzNDAsCiB9OwogCisvLyBUaGlzIGVudW0gaXMg Zm9yIENSQVNIX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT05fQU5EX0lORk8gc28gd2UgY2FuIGVh c2lseSBpZGVudGlmeSB3aGljaCBhc3NlcnRpb24KKy8vIHdlIGFyZSBsb29raW5nIGF0IGV2ZW4g aWYgdGhlIGNhbGxzIHRvIGNyYXNoIGdldCBjb2FsZXNlZC4gVGhlIHNhbWUgbnVtYmVyaW5nIHJ1 bGVzIGFib3ZlIGZvcgorLy8gQWJvcnRSZWFzb24gYXBwbHkgaGVyZS4KK2VudW0gQ29tcGlsZXJB Ym9ydFJlYXNvbiB7CisgICAgQWJzdHJhY3RJbnRlcnByZXRlckludmFsaWRUeXBlICAgICAgICAg ICAgICAgID0gIDEwLAorICAgIE9iamVjdEFsbG9jYXRpb25TaW5raW5nQXNzZXJ0aW9uRmFpbHVy ZSAgICAgICA9IDEwMCwKK307CisKIH0gLy8gbmFtZXNwYWNlIEpTQwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdEludGVycHJldGVySW5saW5lcy5oIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdEludGVycHJldGVySW5saW5lcy5o CmluZGV4IGM3M2EyNzhlZmZkOWNhNDcwMjU4MTAwZmFhNGE2ZTY5ODIyMzBlOTguLmI4YjFmMzg0 Njc1OTBjNGU2MTQ3ODU4YzQxNTY2MDVkZmZiMjhkN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmgKQEAg LTEzMSw3ICsxMzEsNyBAQCB2b2lkIEFic3RyYWN0SW50ZXJwcmV0ZXI8QWJzdHJhY3RTdGF0ZVR5 cGU+Ojp2ZXJpZnlFZGdlKE5vZGUqIG5vZGUsIEVkZ2UgZWRnZSkKICAgICBpZiAoIShmb3JOb2Rl KGVkZ2UpLm1fdHlwZSAmIH50eXBlRmlsdGVyRm9yKGVkZ2UudXNlS2luZCgpKSkpCiAgICAgICAg IHJldHVybjsKICAgICAKLSAgICBERkdfQ1JBU0gobV9ncmFwaCwgbm9kZSwgdG9DU3RyaW5nKCJF ZGdlIHZlcmlmaWNhdGlvbiBlcnJvcjogIiwgbm9kZSwgIi0+IiwgZWRnZSwgIiB3YXMgZXhwZWN0 ZWQgdG8gaGF2ZSB0eXBlICIsIFNwZWN1bGF0aW9uRHVtcCh0eXBlRmlsdGVyRm9yKGVkZ2UudXNl S2luZCgpKSksICIgYnV0IGhhcyB0eXBlICIsIFNwZWN1bGF0aW9uRHVtcChmb3JOb2RlKGVkZ2Up Lm1fdHlwZSksICIgKCIsIGZvck5vZGUoZWRnZSkubV90eXBlLCAiKSIpLmRhdGEoKSk7CisgICAg REZHX0NSQVNIKG1fZ3JhcGgsIG5vZGUsIHRvQ1N0cmluZygiRWRnZSB2ZXJpZmljYXRpb24gZXJy b3I6ICIsIG5vZGUsICItPiIsIGVkZ2UsICIgd2FzIGV4cGVjdGVkIHRvIGhhdmUgdHlwZSAiLCBT cGVjdWxhdGlvbkR1bXAodHlwZUZpbHRlckZvcihlZGdlLnVzZUtpbmQoKSkpLCAiIGJ1dCBoYXMg dHlwZSAiLCBTcGVjdWxhdGlvbkR1bXAoZm9yTm9kZShlZGdlKS5tX3R5cGUpLCAiICgiLCBmb3JO b2RlKGVkZ2UpLm1fdHlwZSwgIikiKS5kYXRhKCksIEFic3RyYWN0SW50ZXJwcmV0ZXJJbnZhbGlk VHlwZSwgbm9kZS0+b3AoKSwgZWRnZS0+b3AoKSwgZWRnZS51c2VLaW5kKCksIGZvck5vZGUoZWRn ZSkubV90eXBlKTsKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgQWJzdHJhY3RTdGF0ZVR5cGU+CmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3BwCmluZGV4IDk0MjRlNTk0N2RhNmQ4YTFl MDdkNDFiNmMxN2YyMjQ3YWM2YzY1ZDUuLmRiMDZiMDE2OTcxYWJkNTg2ZmM5MTFlZmM2ZGMxNmI5 YzY5MjU0OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGgu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3BwCkBAIC0xNDUy LDcgKzE0NTIsNiBAQCBzdGF0aWMgdm9pZCBsb2dERkdBc3NlcnRpb25GYWlsdXJlKAogICAgIGRh dGFMb2coIlxuIik7CiAgICAgZGF0YUxvZygiREZHIEFTU0VSVElPTiBGQUlMRUQ6ICIsIGFzc2Vy dGlvbiwgIlxuIik7CiAgICAgZGF0YUxvZyhmaWxlLCAiKCIsIGxpbmUsICIpIDogIiwgZnVuY3Rp b24sICJcbiIpOwotICAgIFdURlJlcG9ydEJhY2t0cmFjZSgpOwogfQogCiB2b2lkIEdyYXBoOjps b2dBc3NlcnRpb25GYWlsdXJlKApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHAKaW5kZXggY2U4NjJk ZmJlMjQxMDg3YzRjN2UwYzA5ZDgxOTlmZDllNTg4YmNiOS4uYTY3NmIyZmJmNDk3N2IxMjAwMWMw YjVmM2UzZjM5NGZlNTViZmM5MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwCkBAIC01MCw3 ICs1MCw3IEBAIG5hbWVzcGFjZSB7CiAKIE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0ggTkVWRVJfSU5M SU5FIHZvaWQgY3Jhc2goY29uc3QgY2hhciosIGludCBsaW5lLCBpbnQpCiB7Ci0gICAgQ1JBU0hf V0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTl9BTkRfSU5GTyhsaW5lKTsKKyAgICBDUkFTSF9XSVRI X1NFQ1VSSVRZX0lNUExJQ0FUSU9OX0FORF9JTkZPKE9iamVjdEFsbG9jYXRpb25TaW5raW5nQXNz ZXJ0aW9uRmFpbHVyZSwgbGluZSk7CiB9CiAKICN1bmRlZiBSRUxFQVNFX0FTU0VSVApkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3Nl cnRpb25zLmNwcAppbmRleCA4ZTEwNGNiODkyNTEzZjBkMGE3NWRjNDViZjA0YzE0ZTI2MGUwZDQ4 Li5hNzAzMjVkOTA4NjRiMjIwYzljMzRmYjZmMTBiNjMyNjcwNGZjOTBmIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRp b25zLmNwcApAQCAtNTU5LDcgKzU1OSw3IEBAIHZvaWQgV1RGSW5pdGlhbGl6ZUxvZ0NoYW5uZWxT dGF0ZXNGcm9tU3RyaW5nKFdURkxvZ0NoYW5uZWwqIGNoYW5uZWxzW10sIHNpemVfdCBjCiAKIH0g Ly8gZXh0ZXJuICJDIgogCi0jaWYgT1MoREFSV0lOKSAmJiAoQ1BVKFg2NF82NCkgfHwgQ1BVKEFS TTY0KSkKKyNpZiBPUyhEQVJXSU4pICYmIChDUFUoWDg2XzY0KSB8fCBDUFUoQVJNNjQpKQogI2lm IENQVShYODZfNjQpCiAjZGVmaW5lIFNUVUZGX1JFR0lTVEVSX0ZPUl9DUkFTSChyZWcsIGluZm8p IF9fYXNtX18gdm9sYXRpbGUgKCJtb3ZxICUwLCAlJSIgcmVnIDogOiAiciIgKHN0YXRpY19jYXN0 PHVpbnQ2NF90PihpbmZvKSkgOiByZWcpCiAK