17418 2008-02-17 17:29:33 -0800 REGRESSION: Assertion failure dragging image (JSLock::lockCount() > 0) 2008-02-18 10:15:49 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED Regression P1 Normal --- 1 dev+webkit ap oldest_to_newest 70992 0 dev+webkit 2008-02-17 17:29:33 -0800 Dragging an image in ToT on Windows fails the following ASSERT in UString::Rep::createCopying: JSLock::lockCount() > 0 <http://trac.webkit.org/projects/webkit/browser/trunk/JavaScriptCore/kjs/ustring.cpp#L175> > WebKit.dll!KJS::UString::Rep::createCopying(const KJS::UChar * d=0x03f2a4e0, int l=77) Line 175 + 0x25 bytes C++ WebKit.dll!KJS::UString::UString(const KJS::UChar * c=0x03f2a4e0, int length=77) Line 442 + 0x11 bytes C++ WebKit.dll!WebCore::String::operator KJS::UString() Line 644 + 0x28 bytes C++ WebKit.dll!WebCore::KURL::operator KJS::UString() Line 140 + 0x23 bytes C++ WebKit.dll!WebCore::ClipboardWin::declareAndWriteDragImage(WebCore::Element * element=0x029b03f8, const WebCore::KURL & url={...}, const WebCore::String & title={...}, WebCore::Frame * frame=0x01e1b4f0) Line 677 + 0x34 bytes C++ WebKit.dll!WebCore::prepareClipboardForImageDrag(WebCore::Frame * src=0x01e1b4f0, WebCore::Clipboard * clipboard=0x0269c410, WebCore::Element * node=0x029b03f8, const WebCore::KURL & linkURL={...}, const WebCore::KURL & imageURL={...}, const WebCore::String & label={...}) Line 558 + 0x42 bytes C++ WebKit.dll!WebCore::DragController::startDrag(WebCore::Frame * src=0x01e1b4f0, WebCore::Clipboard * clipboard=0x0269c410, WebCore::DragOperation srcOp=DragOperationNone, const WebCore::PlatformMouseEvent & dragEvent={...}, const WebCore::IntPoint & dragOrigin={...}, bool isDHTMLDrag=false) Line 635 + 0x2f bytes C++ WebKit.dll!WebCore::EventHandler::handleDrag(const WebCore::MouseEventWithHitTestResults & event={...}) Line 1755 + 0x44 bytes C++ WebKit.dll!WebCore::EventHandler::handleMouseDraggedEvent(const WebCore::MouseEventWithHitTestResults & event={...}) Line 353 + 0xc bytes C++ WebKit.dll!WebCore::EventHandler::handleMouseMoveEvent(const WebCore::PlatformMouseEvent & mouseEvent={...}, WebCore::HitTestResult * hoveredNode=0x0012f7a4) Line 1034 + 0xc bytes C++ WebKit.dll!WebCore::EventHandler::mouseMoved(const WebCore::PlatformMouseEvent & event={...}) Line 938 + 0x10 bytes C++ WebKit.dll!WebView::handleMouseEvent(unsigned int message=512, unsigned int wParam=1, long lParam=11534604) Line 1216 + 0x1d bytes C++ WebKit.dll!WebViewWndProc(HWND__ * hWnd=0x00050112, unsigned int message=512, unsigned int wParam=1, long lParam=11534604) Line 1634 + 0x14 bytes C++ user32.dll!7e418724() [Frames below may be incorrect and/or missing, no symbols loaded for user32.dll] 71022 1 19185 ap 2008-02-18 01:51:06 -0800 Created attachment 19185 proposed fix (untested) As usual, my Windows build is far from completion, but this should fix the issue. I'm curious why KURL has such a preference for UString. 71051 2 19185 darin 2008-02-18 09:30:25 -0800 Comment on attachment 19185 proposed fix (untested) r=me The implicit conversion from KURL to UString is a bad idea. I suggest we either remove it or if we decide it's too valuable to remove, add an implicit conversion to String. 71054 3 ap 2008-02-18 10:15:49 -0800 Committed revision 30369. 19185 2008-02-18 01:51:06 -0800 2008-02-18 09:30:25 -0800 proposed fix (untested) 17418r1_patch.txt text/plain 1271 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMDM2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDItMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDE4CisgICAgICAgIFJF R1JFU1NJT046IEFzc2VydGlvbiBmYWlsdXJlIGRyYWdnaW5nIGltYWdlIChKU0xvY2s6OmxvY2tD b3VudCgpID4gMCkKKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9DbGlwYm9hcmRXaW4uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q2xpcGJvYXJkV2luOjpkZWNsYXJlQW5kV3JpdGVEcmFnSW1hZ2Up OiBFeHBsaWNpdGx5IGNvbnZlcnQgZnJvbSBLVVJMIHRvIFN0cmluZywKKyAgICAgICAgYXMgYW4g aW1wbGljaXQgY29udmVyc2lvbiB1c2VzIFVTdHJpbmcgYW5kIHRodXMgbmVlZHMgYSBKU0xvY2su CisKIDIwMDgtMDItMTcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBS b2xsIG91dCByMzAzNjAuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3dpbi9DbGlwYm9hcmRXaW4u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vd2luL0NsaXBib2FyZFdpbi5jcHAJ KHJldmlzaW9uIDMwMzY4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xpcGJvYXJkV2luLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNjc0LDcgKzY3NCw3IEBAIHZvaWQgQ2xpcGJvYXJkV2luOjpk ZWNsYXJlQW5kV3JpdGVEcmFnSW0KICAgICBpZiAoaW1hZ2VVUkwuaXNFbXB0eSgpKSAKICAgICAg ICAgcmV0dXJuOwogCi0gICAgU3RyaW5nIGZ1bGxVUkwgPSBmcmFtZS0+ZG9jdW1lbnQoKS0+Y29t cGxldGVVUkwocGFyc2VVUkwoaW1hZ2VVUkwpKTsKKyAgICBTdHJpbmcgZnVsbFVSTCA9IGZyYW1l LT5kb2N1bWVudCgpLT5jb21wbGV0ZVVSTChwYXJzZVVSTChpbWFnZVVSTCkpLnN0cmluZygpOwog ICAgIGlmIChmdWxsVVJMLmlzRW1wdHkoKSkgCiAgICAgICAgIHJldHVybjsKICAgICBTVEdNRURJ VU0gbWVkaXVtID0gezB9Owo=