174175 2017-07-05 14:16:58 -0700 Make WebKit's public headers on Mac and iOS C++ module safe 2017-07-05 16:40:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. Safari Technology Preview Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa achristensen beidson ggaren mitz oldest_to_newest 1325771 0 rniwa 2017-07-05 14:16:58 -0700 Make our public headers module safe. 1325793 1 314658 rniwa 2017-07-05 15:16:14 -0700 Created attachment 314658 Fixes the header files 1325794 2 314658 achristensen 2017-07-05 15:18:53 -0700 Comment on attachment 314658 Fixes the header files View in context: https://bugs.webkit.org/attachment.cgi?id=314658&action=review r=me with this change. > Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleList.h:27 > +#import <objc/NSObject.h> Should this be Foundation/NSObject.h? > Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleListStore.h:27 > +#import <objc/NSObject.h> ditto 1325802 3 314658 mitz 2017-07-05 15:46:31 -0700 Comment on attachment 314658 Fixes the header files View in context: https://bugs.webkit.org/attachment.cgi?id=314658&action=review >> Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleList.h:27 >> +#import <objc/NSObject.h> > > Should this be Foundation/NSObject.h? Everywhere else in the modern API we import the Foundation umbrella header, and we do so after the #if WK_API_ENABLED test. Is there a reason to do things differently here? >> Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleListStore.h:27 >> +#import <objc/NSObject.h> > > ditto Same here. 1325819 4 rniwa 2017-07-05 16:31:57 -0700 (In reply to mitz from comment #3) > Comment on attachment 314658 [details] > Fixes the header files > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314658&action=review > > >> Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleList.h:27 > >> +#import <objc/NSObject.h> > > > > Should this be Foundation/NSObject.h? > > Everywhere else in the modern API we import the Foundation umbrella header, > and we do so after the #if WK_API_ENABLED test. Is there a reason to do > things differently here? > > >> Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleListStore.h:27 > >> +#import <objc/NSObject.h> > > > > ditto > > Same here. Fixed to include Foundation/Foundation.h inside WK_API_ENABLED instead. 1325826 5 rniwa 2017-07-05 16:40:28 -0700 Committed r219165: <http://trac.webkit.org/changeset/219165> 314658 2017-07-05 15:16:14 -0700 2017-07-05 15:18:53 -0700 Fixes the header files bug-174175-20170705151614.patch text/plain 4761 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxOTE1MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA3LTA1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIE1ha2UgV2ViS2l0J3MgcHVibGlj IGhlYWRlcnMgb24gTWFjIGFuZCBpT1MgQysrIG1vZHVsZSBzYWZlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQxNzUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCB0aGUgaGVhZGVyIGZpbGVzLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0NvbnRlbnRSdWxlTGlzdC5oOgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tDb250ZW50UnVsZUxpc3RTdG9yZS5oOgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlLmg6CisKIDIwMTctMDctMDUg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIERvIG5vdCBwYXNz IEFQSTo6RnJhbWVJbmZvIGZvciBzb3VyY2UgZnJhbWUgb3IgY2xlYXIgb3V0IHBhZ2Ugb2YgdGFy Z2V0IGZyYW1lIG9uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL Q29udGVudFJ1bGVMaXN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS0NvbnRlbnRSdWxlTGlzdC5oCShyZXZpc2lvbiAyMTkxNTEpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLQ29udGVudFJ1bGVMaXN0LmgJKHdvcmtp bmcgY29weSkKQEAgLTI0LDYgKzI0LDcgQEAKICAqLwogCiAjaW1wb3J0IDxXZWJLaXQvV0tGb3Vu ZGF0aW9uLmg+CisjaW1wb3J0IDxvYmpjL05TT2JqZWN0Lmg+CiAKICNpZiBXS19BUElfRU5BQkxF RAogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLQ29udGVudFJ1 bGVMaXN0U3RvcmUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLQ29udGVudFJ1bGVMaXN0U3RvcmUuaAkocmV2aXNpb24gMjE5MTUxKQorKysgU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0NvbnRlbnRSdWxlTGlzdFN0b3JlLmgJ KHdvcmtpbmcgY29weSkKQEAgLTI0LDkgKzI0LDEzIEBACiAgKi8KIAogI2ltcG9ydCA8V2ViS2l0 L1dLRm91bmRhdGlvbi5oPgorI2ltcG9ydCA8b2JqYy9OU09iamVjdC5oPgogCiAjaWYgV0tfQVBJ X0VOQUJMRUQKIAorQGNsYXNzIE5TVVJMOworQGNsYXNzIE5TRXJyb3I7CitAY2xhc3MgTlNBcnJh eTsKIEBjbGFzcyBXS0NvbnRlbnRSdWxlTGlzdDsKIAogV0tfQ0xBU1NfQVZBSUxBQkxFKG1hY29z eChXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZS5oCShyZXZpc2lvbiAyMTkxNTEp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZS5oCSh3 b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiw3IEBAIE5TX0FTU1VNRV9OT05OVUxMX0JFR0lOCiBA Y2xhc3MgV0tOYXZpZ2F0aW9uQWN0aW9uOwogQGNsYXNzIFdLT3BlblBhbmVsUGFyYW1ldGVyczsK IEBjbGFzcyBXS1ByZXZpZXdFbGVtZW50SW5mbzsKK0BjbGFzcyBXS1dlYlZpZXc7CiBAY2xhc3Mg V0tXZWJWaWV3Q29uZmlndXJhdGlvbjsKIEBjbGFzcyBXS1dpbmRvd0ZlYXR1cmVzOwogCkluZGV4 OiBTb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9tYWMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTkxNTkpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxNy0wNy0wNSAgUnlv c3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAgICBNYWtlIFdlYktpdCdzIHB1 YmxpYyBoZWFkZXJzIG9uIE1hYyBhbmQgaU9TIEMrKyBtb2R1bGUgc2FmZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MTc1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgdGhlIGhlYWRlciBmaWxl cy4KKworICAgICAgICAqIE1pc2MvV2ViRG93bmxvYWQuaDoKKyAgICAgICAgKiBNaXNjL1dlYktp dEVycm9ycy5oOgorICAgICAgICAqIFBsdWdpbnMvV2ViUGx1Z2luQ29udGFpbmVyLmg6CisgICAg ICAgICogV2ViVmlldy9XZWJSZXNvdXJjZUxvYWREZWxlZ2F0ZS5oOgorCiAyMDE3LTA3LTAzICBN eWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3Zl IGNvcHkgb2YgSUNVIGhlYWRlcnMgZnJvbSBXZWJLaXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFj L01pc2MvV2ViRG93bmxvYWQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9NaXNj L1dlYkRvd25sb2FkLmgJKHJldmlzaW9uIDIxOTE1MSkKKysrIFNvdXJjZS9XZWJLaXQvbWFjL01p c2MvV2ViRG93bmxvYWQuaAkod29ya2luZyBjb3B5KQpAQCAtNDIsNiArNDIsNyBAQCBAaW50ZXJm YWNlIE5TVVJMRG93bmxvYWQgOiBOU09iamVjdAogI2ltcG9ydCA8V2ViS2l0TGVnYWN5L1dBS0Fw cEtpdFN0dWJzLmg+CiAjZW5kaWYKIAorQGNsYXNzIE5TV2luZG93OwogQGNsYXNzIFdlYkRvd25s b2FkSW50ZXJuYWw7CiAKIC8qIQpJbmRleDogU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJLaXRF cnJvcnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYktpdEVycm9y cy5oCShyZXZpc2lvbiAyMTkxNTEpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYktpdEVy cm9ycy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw2ICsyNiw4IEBACiAgKiBUSElTIFNPRlRXQVJF LCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICov CiAKK0BjbGFzcyBOU1N0cmluZzsKKwogZXh0ZXJuIE5TU3RyaW5nICpXZWJLaXRFcnJvckRvbWFp bjsKIAogZXh0ZXJuIE5TU3RyaW5nICogY29uc3QgV2ViS2l0RXJyb3JNSU1FVHlwZUtleTsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1BsdWdpbnMvV2ViUGx1Z2luQ29udGFpbmVyLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250YWluZXIuaAko cmV2aXNpb24gMjE5MTUxKQorKysgU291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5D b250YWluZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzAsNiArMzAsNyBAQAogCiAjaWYgIVRBUkdF VF9PU19JUEhPTkUKICNpbXBvcnQgPEFwcEtpdC9BcHBLaXQuaD4KK0BjbGFzcyBXZWJGcmFtZTsK ICNlbmRpZgogCiAvKiEKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUmVzb3Vy Y2VMb2FkRGVsZWdhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3 L1dlYlJlc291cmNlTG9hZERlbGVnYXRlLmgJKHJldmlzaW9uIDIxOTE1MSkKKysrIFNvdXJjZS9X ZWJLaXQvbWFjL1dlYlZpZXcvV2ViUmVzb3VyY2VMb2FkRGVsZWdhdGUuaAkod29ya2luZyBjb3B5 KQpAQCAtMjYsMTIgKzI2LDE3IEBACiAgKiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQg T0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKKyNpbXBvcnQgPEZvdW5k YXRpb24vTlNPYmpDUnVudGltZS5oPgorCiBAY2xhc3MgV2ViVmlldzsKIEBjbGFzcyBXZWJEYXRh U291cmNlOworQGNsYXNzIE5TRXJyb3I7CiBAY2xhc3MgTlNVUkxBdXRoZW50aWNhdGlvbkNoYWxs ZW5nZTsKIEBjbGFzcyBOU1VSTFJlc3BvbnNlOwogQGNsYXNzIE5TVVJMUmVxdWVzdDsKIAorQHBy b3RvY29sIE5TT2JqZWN0OworCiAvKiEKICAgICBAY2F0ZWdvcnkgIFdlYlJlc291cmNlTG9hZERl bGVnYXRlCiAgICAgQGRpc2N1c3Npb24gSW1wbGVtZW50b3JzIG9mIHRoaXMgcHJvdG9jb2wgd2ls bCByZWNlaXZlIG1lc3NhZ2VzIGluZGljYXRpbmcK