174170 2017-07-05 12:33:45 -0700 Do not pass API::FrameInfo for source frame or clear out page of target frame on API navigation 2017-07-05 13:10:27 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates beidson ggaren webkit-bug-importer oldest_to_newest 1325706 0 dbates 2017-07-05 12:33:45 -0700 For an API initiated navigation we pass API::FrameInfo for both the source and target frame that have a null page pointer. This condition is subtle to check for and error prone. It is also unclear how meaningful it is to pass frame info for the source frame for an API-initiated navigation as well as the value of clearing out the pointer for the page in the target page. As a step towards improving the -decidePolicyForNavigationAction: delegate API we should not pass frame info for the source frame and not nullify the page pointer of the target frame when the navigation is initiated by API. An embedding client can then determine that the delegate callback originated from API by checking if we have a non-null source frame. This is unlike to be the last change we make to the design of this callback. We will look to further iterate on this design towards ensuring it is straightforward for an embedding client to determine when -decidePolicyForNavigationAction: is called as a result of an API navigation. 1325707 1 webkit-bug-importer 2017-07-05 12:34:14 -0700 <rdar://problem/33140328> 1325712 2 314642 dbates 2017-07-05 12:43:53 -0700 Created attachment 314642 Patch and unit tests 1325723 3 dbates 2017-07-05 13:10:27 -0700 Committed r219149: <http://trac.webkit.org/changeset/219149> 314642 2017-07-05 12:43:53 -0700 2017-07-05 13:01:25 -0700 Patch and unit tests bug-174170-20170705124352.patch text/plain 7379 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzE5YjQ2OWE4ZjAyMTNm NTc3NTBhYzA4Njg2ZWEwNWRiOGZmYTNjOC4uNjRhYjdlNmQxYWRiYjFjN2QzZDM1YTRhMzg1MWJm YzVmMWU0NmMwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE3LTA3LTA1ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBEbyBub3QgcGFzcyBBUEk6 OkZyYW1lSW5mbyBmb3Igc291cmNlIGZyYW1lIG9yIGNsZWFyIG91dCBwYWdlIG9mIHRhcmdldCBm cmFtZSBvbgorICAgICAgICBBUEkgbmF2aWdhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MTcwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8z MzE0MDMyOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBcyBhIHN0ZXAgdG93YXJkcyBtYWtpbmcgaXQgc3RyYWlnaHRmb3J3YXJkIGZvciBhbiBlbWJl ZGRpbmcgY2xpZW50IHRvIGRldGVybWluZSB3aGV0aGVyCisgICAgICAgIGEgV2ViUGFnZVByb3h5 OjpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKCkgY2FsbGJhY2sgd2FzIGluaXRpYXRl ZCBmcm9tIEFQSSB3ZQorICAgICAgICBzaG91bGQgbm90IHBhc3MgZnJhbWUgaW5mbyBmb3IgdGhl IHNvdXJjZSBmcmFtZSBhbmQgc2hvdWxkIG5vdCBudWxsaWZ5IHRoZSBwYWdlIHBvaW50ZXIKKyAg ICAgICAgaW4gdGhlIHRhcmdldCBmcmFtZSBpbmZvLgorCisgICAgICAgIEN1cnJlbnRseSB3ZSBh bHdheXMgcGFzcyBmcmFtZSBpbmZvIGZvciB0aGUgc291cmNlIGZyYW1lIGFuZCBudWxsaWZ5IHRo ZSBwYWdlIHBvaW50ZXIKKyAgICAgICAgaW4gYm90aCB0aGUgc291cmNlIGZyYW1lIGluZm8gYW5k IHRhcmdldCBmcmFtZSBpbmZvIGlmIHRoZSBuYXZpZ2F0aW9uIHdhcyBpbml0aWF0ZWQgZnJvbQor ICAgICAgICBBUEkuIFRoaXMgc2VlbXMgc3VidGxlIGFuZCBlcnJvciBwcm9uZS4gSW5zdGVhZCB3 ZSBzaG91bGQgbm90IHBhc3MgZnJhbWUgaW5mbyBmb3IKKyAgICAgICAgdGhlIHNvdXJjZSBmcmFt ZSBhbmQgbm90IG51bGxpZnkgdGhlIHBhZ2UgcG9pbnRlciBpbiB0aGUgdGFyZ2V0IGZyYW1lIGlu Zm8gYXMgYSBzdGVwCisgICAgICAgIHRvd2FyZHMgbWFraW5nIHVzaW5nIHRoaXMgQVBJIGxlc3Mg ZXJyb3ItcHJvbmUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0 aW9uKToKKwogMjAxNy0wNy0wNSAgQWRhIENoYW4gIDxhZGFjaGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBGaXggY3Jhc2ggaW4gVUlLaXQ6ICtbVUlWaWV3Q29udHJvbGxlciBfdmlld0NvbnRyb2xs ZXJGb3JGdWxsU2NyZWVuUHJlc2VudGF0aW9uRnJvbVZpZXc6XQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCA0NDg1NmFiYmFjYTU4NjFkYzkxZWRlNGZkNDQ3 M2M5MzUwYTBkZmJhLi5iNGI4OTI4NjBlNGZiYTYxM2NlYzgxMTNjNjlkZTRlZjc3YWQzOTkxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtMzYzOSwxNCAr MzYzOSwxMCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFj dGlvbih1aW50NjRfdCBmcmFtZUlELCBjb25zdCBTZWN1cgogICAgIGlmIChtX25hdmlnYXRpb25D bGllbnQpIHsKICAgICAgICAgUmVmUHRyPEFQSTo6RnJhbWVJbmZvPiBkZXN0aW5hdGlvbkZyYW1l SW5mbyA9IEFQSTo6RnJhbWVJbmZvOjpjcmVhdGUoKmZyYW1lLCBmcmFtZVNlY3VyaXR5T3JpZ2lu LnNlY3VyaXR5T3JpZ2luKCkpOwogICAgICAgICBSZWZQdHI8QVBJOjpGcmFtZUluZm8+IHNvdXJj ZUZyYW1lSW5mbzsKLSAgICAgICAgaWYgKG9yaWdpbmF0aW5nRnJhbWUgPT0gZnJhbWUpCisgICAg ICAgIGlmICghZnJvbUFQSSAmJiBvcmlnaW5hdGluZ0ZyYW1lID09IGZyYW1lKQogICAgICAgICAg ICAgc291cmNlRnJhbWVJbmZvID0gZGVzdGluYXRpb25GcmFtZUluZm87Ci0gICAgICAgIGVsc2UK KyAgICAgICAgZWxzZSBpZiAoIWZyb21BUEkpCiAgICAgICAgICAgICBzb3VyY2VGcmFtZUluZm8g PSBBUEk6OkZyYW1lSW5mbzo6Y3JlYXRlKG9yaWdpbmF0aW5nRnJhbWVJbmZvRGF0YSwgbV9wcm9j ZXNzLT53ZWJQYWdlKG9yaWdpbmF0aW5nUGFnZUlEKSk7Ci0gICAgICAgIGlmIChmcm9tQVBJKSB7 Ci0gICAgICAgICAgICBzb3VyY2VGcmFtZUluZm8tPmNsZWFyUGFnZSgpOwotICAgICAgICAgICAg ZGVzdGluYXRpb25GcmFtZUluZm8tPmNsZWFyUGFnZSgpOwotICAgICAgICB9CiAKICAgICAgICAg YXV0byB1c2VySW5pdGlhdGVkQWN0aXZpdHkgPSBtX3Byb2Nlc3MtPnVzZXJJbml0aWF0ZWRBY3Rp dml0eShuYXZpZ2F0aW9uQWN0aW9uRGF0YS51c2VyR2VzdHVyZVRva2VuSWRlbnRpZmllcik7CiAg ICAgICAgIGJvb2wgc2hvdWxkT3BlbkFwcExpbmtzID0gIW1fc2hvdWxkU3VwcHJlc3NBcHBMaW5r c0luTmV4dE5hdmlnYXRpb25Qb2xpY3lEZWNpc2lvbiAmJiAoIWRlc3RpbmF0aW9uRnJhbWVJbmZv IHx8IGRlc3RpbmF0aW9uRnJhbWVJbmZvLT5pc01haW5GcmFtZSgpKSAmJiAhaG9zdHNBcmVFcXVh bChVUkwoUGFyc2VkVVJMU3RyaW5nLCBtX21haW5GcmFtZS0+dXJsKCkpLCByZXF1ZXN0LnVybCgp KSAmJiBuYXZpZ2F0aW9uQWN0aW9uRGF0YS5uYXZpZ2F0aW9uVHlwZSAhPSBXZWJDb3JlOjpOYXZp Z2F0aW9uVHlwZTo6QmFja0ZvcndhcmQ7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggMmQ5MjdmYmRmMjZhZDU2ZjVhNDk4NDAxNTZjNmFkNmNiZGY4 NGQ1Ni4uOWMxM2Q1ZTRmZjdjMzg2M2MwYTY0MDhlYzQxMjk4NzljNjQxOWQ3YyAxMDA2NDQKLS0t IGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDE3LTA3LTA1ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAg ICBEbyBub3QgcGFzcyBBUEk6OkZyYW1lSW5mbyBmb3Igc291cmNlIGZyYW1lIG9yIGNsZWFyIG91 dCBwYWdlIG9mIHRhcmdldCBmcmFtZSBvbgorICAgICAgICBBUEkgbmF2aWdhdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MTcwCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8zMzE0MDMyOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGVzdHMgYXMgbmVlZGVkIGZvciB0aGUgYmVoYXZp b3IgY2hhbmdlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2Ev RGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbi5tbToKKyAgICAgICAgKFRFU1QpOgorCiAy MDE3LTA3LTA1ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAg ICAgIFtNZWRpYVN0cmVhbV0gUHJvdGVjdCByZXF1ZXN0IGFuZCB3ZWIgdmlldyBkdXJpbmcgZ1VN IGNsaWVudCBjYWxsYmFjawpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXQyQ29jb2EvRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbi5tbSBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL0RlY2lkZVBvbGljeUZvck5hdmlnYXRpb25B Y3Rpb24ubW0KaW5kZXggN2IyYjhhYmIwOTQ4YzcyZTA4NGE0NTlkZDJkNzZiMDI2ZjMwZmY1Yy4u M2MxNDI4NDc0ZTg0MTA0MDQzM2RhMzkzYTNjOWY4OWJiMjIxYzJhZCAxMDA2NDQKLS0tIGEvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvRGVjaWRlUG9saWN5Rm9yTmF2aWdh dGlvbkFjdGlvbi5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2Nv YS9EZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uLm1tCkBAIC05MSwxMCArOTEsMTEgQEAg VEVTVChXZWJLaXQyLCBEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uUmVsb2FkKQogICAg IFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmZGVjaWRlZFBvbGljeSk7CiAKICAgICBFWFBFQ1Rf RVEoV0tOYXZpZ2F0aW9uVHlwZVJlbG9hZCwgW2FjdGlvbiBuYXZpZ2F0aW9uVHlwZV0pOwotICAg IEVYUEVDVF9UUlVFKFthY3Rpb24gc291cmNlRnJhbWVdID09IFthY3Rpb24gdGFyZ2V0RnJhbWVd KTsKKyAgICBFWFBFQ1RfVFJVRShbYWN0aW9uIHNvdXJjZUZyYW1lXSAhPSBbYWN0aW9uIHRhcmdl dEZyYW1lXSk7CisgICAgRVhQRUNUX0VRKG5pbCwgW2FjdGlvbiBzb3VyY2VGcmFtZV0pOwogICAg IEVYUEVDVF9XS19TVFJFUShmaXJzdFVSTCwgW1tbYWN0aW9uIHJlcXVlc3RdIFVSTF0gYWJzb2x1 dGVTdHJpbmddKTsKLSAgICBFWFBFQ1RfV0tfU1RSRVEoZmlyc3RVUkwsIFtbW1thY3Rpb24gc291 cmNlRnJhbWVdIHJlcXVlc3RdIFVSTF0gYWJzb2x1dGVTdHJpbmddKTsKLSAgICBFWFBFQ1RfRVEo bmlsLCBbW2FjdGlvbiBzb3VyY2VGcmFtZV0gd2ViVmlld10pOworICAgIEVYUEVDVF9XS19TVFJF UShmaXJzdFVSTCwgW1tbW2FjdGlvbiB0YXJnZXRGcmFtZV0gcmVxdWVzdF0gVVJMXSBhYnNvbHV0 ZVN0cmluZ10pOworICAgIEVYUEVDVF9FUSh3ZWJWaWV3LmdldCgpLCBbW2FjdGlvbiB0YXJnZXRG cmFtZV0gd2ViVmlld10pOwogCiAgICAgbmV3V2ViVmlldyA9IG51bGxwdHI7CiAgICAgYWN0aW9u ID0gbnVsbHB0cjsKQEAgLTEyMCwxMCArMTIxLDExIEBAIFRFU1QoV2ViS2l0MiwgRGVjaWRlUG9s aWN5Rm9yTmF2aWdhdGlvbkFjdGlvblJlbG9hZEZyb21PcmlnaW4pCiAgICAgVGVzdFdlYktpdEFQ STo6VXRpbDo6cnVuKCZkZWNpZGVkUG9saWN5KTsKIAogICAgIEVYUEVDVF9FUShXS05hdmlnYXRp b25UeXBlUmVsb2FkLCBbYWN0aW9uIG5hdmlnYXRpb25UeXBlXSk7Ci0gICAgRVhQRUNUX1RSVUUo W2FjdGlvbiBzb3VyY2VGcmFtZV0gPT0gW2FjdGlvbiB0YXJnZXRGcmFtZV0pOworICAgIEVYUEVD VF9UUlVFKFthY3Rpb24gc291cmNlRnJhbWVdICE9IFthY3Rpb24gdGFyZ2V0RnJhbWVdKTsKKyAg ICBFWFBFQ1RfRVEobmlsLCBbYWN0aW9uIHNvdXJjZUZyYW1lXSk7CiAgICAgRVhQRUNUX1dLX1NU UkVRKGZpcnN0VVJMLCBbW1thY3Rpb24gcmVxdWVzdF0gVVJMXSBhYnNvbHV0ZVN0cmluZ10pOwot ICAgIEVYUEVDVF9XS19TVFJFUShmaXJzdFVSTCwgW1tbW2FjdGlvbiBzb3VyY2VGcmFtZV0gcmVx dWVzdF0gVVJMXSBhYnNvbHV0ZVN0cmluZ10pOwotICAgIEVYUEVDVF9FUShuaWwsIFtbYWN0aW9u IHNvdXJjZUZyYW1lXSB3ZWJWaWV3XSk7CisgICAgRVhQRUNUX1dLX1NUUkVRKGZpcnN0VVJMLCBb W1tbYWN0aW9uIHRhcmdldEZyYW1lXSByZXF1ZXN0XSBVUkxdIGFic29sdXRlU3RyaW5nXSk7Cisg ICAgRVhQRUNUX0VRKHdlYlZpZXcuZ2V0KCksIFtbYWN0aW9uIHRhcmdldEZyYW1lXSB3ZWJWaWV3 XSk7CiAKICAgICBuZXdXZWJWaWV3ID0gbnVsbHB0cjsKICAgICBhY3Rpb24gPSBudWxscHRyOwpA QCAtMTUzLDEwICsxNTUsMTEgQEAgVEVTVChXZWJLaXQyLCBEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0 aW9uQWN0aW9uR29CYWNrKQogICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmZGVjaWRlZFBv bGljeSk7CiAKICAgICBFWFBFQ1RfRVEoV0tOYXZpZ2F0aW9uVHlwZUJhY2tGb3J3YXJkLCBbYWN0 aW9uIG5hdmlnYXRpb25UeXBlXSk7Ci0gICAgRVhQRUNUX1RSVUUoW2FjdGlvbiBzb3VyY2VGcmFt ZV0gPT0gW2FjdGlvbiB0YXJnZXRGcmFtZV0pOworICAgIEVYUEVDVF9UUlVFKFthY3Rpb24gc291 cmNlRnJhbWVdICE9IFthY3Rpb24gdGFyZ2V0RnJhbWVdKTsKKyAgICBFWFBFQ1RfRVEobmlsLCBb YWN0aW9uIHNvdXJjZUZyYW1lXSk7CiAgICAgRVhQRUNUX1dLX1NUUkVRKGZpcnN0VVJMLCBbW1th Y3Rpb24gcmVxdWVzdF0gVVJMXSBhYnNvbHV0ZVN0cmluZ10pOwotICAgIEVYUEVDVF9XS19TVFJF UShzZWNvbmRVUkwsIFtbW1thY3Rpb24gc291cmNlRnJhbWVdIHJlcXVlc3RdIFVSTF0gYWJzb2x1 dGVTdHJpbmddKTsKLSAgICBFWFBFQ1RfRVEobmlsLCBbW2FjdGlvbiBzb3VyY2VGcmFtZV0gd2Vi Vmlld10pOworICAgIEVYUEVDVF9XS19TVFJFUShzZWNvbmRVUkwsIFtbW1thY3Rpb24gdGFyZ2V0 RnJhbWVdIHJlcXVlc3RdIFVSTF0gYWJzb2x1dGVTdHJpbmddKTsKKyAgICBFWFBFQ1RfRVEod2Vi Vmlldy5nZXQoKSwgW1thY3Rpb24gdGFyZ2V0RnJhbWVdIHdlYlZpZXddKTsKIAogICAgIG5ld1dl YlZpZXcgPSBudWxscHRyOwogICAgIGFjdGlvbiA9IG51bGxwdHI7CkBAIC0xOTAsMTAgKzE5Mywx MSBAQCBURVNUKFdlYktpdDIsIERlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb25Hb0Zvcndh cmQpCiAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkZWNpZGVkUG9saWN5KTsKIAogICAg IEVYUEVDVF9FUShXS05hdmlnYXRpb25UeXBlQmFja0ZvcndhcmQsIFthY3Rpb24gbmF2aWdhdGlv blR5cGVdKTsKLSAgICBFWFBFQ1RfVFJVRShbYWN0aW9uIHNvdXJjZUZyYW1lXSA9PSBbYWN0aW9u IHRhcmdldEZyYW1lXSk7CisgICAgRVhQRUNUX1RSVUUoW2FjdGlvbiBzb3VyY2VGcmFtZV0gIT0g W2FjdGlvbiB0YXJnZXRGcmFtZV0pOworICAgIEVYUEVDVF9FUShuaWwsIFthY3Rpb24gc291cmNl RnJhbWVdKTsKICAgICBFWFBFQ1RfV0tfU1RSRVEoc2Vjb25kVVJMLCBbW1thY3Rpb24gcmVxdWVz dF0gVVJMXSBhYnNvbHV0ZVN0cmluZ10pOwotICAgIEVYUEVDVF9XS19TVFJFUShmaXJzdFVSTCwg W1tbW2FjdGlvbiBzb3VyY2VGcmFtZV0gcmVxdWVzdF0gVVJMXSBhYnNvbHV0ZVN0cmluZ10pOwot ICAgIEVYUEVDVF9FUShuaWwsIFtbYWN0aW9uIHNvdXJjZUZyYW1lXSB3ZWJWaWV3XSk7CisgICAg RVhQRUNUX1dLX1NUUkVRKGZpcnN0VVJMLCBbW1tbYWN0aW9uIHRhcmdldEZyYW1lXSByZXF1ZXN0 XSBVUkxdIGFic29sdXRlU3RyaW5nXSk7CisgICAgRVhQRUNUX0VRKHdlYlZpZXcuZ2V0KCksIFtb YWN0aW9uIHRhcmdldEZyYW1lXSB3ZWJWaWV3XSk7CiAKICAgICBuZXdXZWJWaWV3ID0gbnVsbHB0 cjsKICAgICBhY3Rpb24gPSBudWxscHRyOwo=