174167 2017-07-05 11:37:39 -0700 Add a logging channel for IOSurface allocations 2022-07-27 04:54:40 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 simon.fraser simon.fraser jhebst8810 simon.fraser thorton oldest_to_newest 1325676 0 simon.fraser 2017-07-05 11:37:39 -0700 Add a logging channel for IOSurface allocations 1325677 1 314629 simon.fraser 2017-07-05 11:38:41 -0700 Created attachment 314629 Patch 1325678 2 314629 thorton 2017-07-05 11:41:06 -0700 Comment on attachment 314629 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314629&action=review > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:50 > inline std::unique_ptr<WebCore::IOSurface> WebCore::IOSurface::surfaceFromPool(IntSize size, IntSize contextSize, CGColorSpaceRef colorSpace, Format pixelFormat) Then I guess you can drop these WebCore::s 314629 2017-07-05 11:38:41 -0700 2017-07-05 11:41:06 -0700 Patch bug-174167-20170705113840.patch text/plain 5945 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTgyYzRlMmNiMzQzYzBk ZTE4OGVmMTEwYjRhMWYyMDgyNzFlZjk4MC4uYTAxNDI4MWZmMTE5MzI5MjkwOTQzMTE1MzU1NmI5 MDAyYWI4MDBkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA3LTA1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBhIGxvZ2dp bmcgY2hhbm5lbCBmb3IgSU9TdXJmYWNlIGFsbG9jYXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQxNjcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYW4gIklPU3VyZmFjZSIgbG9nIGNoYW5u ZWwsIG1ha2UgSU9TdXJmYWNlIFRleHRTdHJlYW0tbG9nZ2FibGUsIGFuZCBsb2cgY2FjaGVkCisg ICAgICAgIGFuZCBuZXcgSU9TdXJmYWNlIGFsbG9jYXRpb25zLgorCisgICAgICAgICogcGxhdGZv cm0vTG9nZ2luZy5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFj ZS5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbToKKyAg ICAgICAgKFdlYkNvcmU6OldlYkNvcmU6OklPU3VyZmFjZTo6Y3JlYXRlKToKKyAgICAgICAgKFdl YkNvcmU6OldlYkNvcmU6OklPU3VyZmFjZTo6c3VyZmFjZUlEKToKKyAgICAgICAgKFdlYkNvcmU6 Om9wZXJhdG9yPDwpOgorCiAyMDE3LTA3LTA0ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFs bGF3YUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2aWV3IGZvbGxvdy11cCBh ZnRlciByMjE4OTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5n LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmgKaW5kZXggMmJjOTc4OWYzODJl YWFmNDQyZDU1YjU5YTcxMzM5NmJlNGYyYTg5ZS4uZTI3MTk2ZmM3YmNlYTgyNmE2ZDVkOTk1NWRm MDVmZjkzNDRjMGQ5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2lu Zy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaApAQCAtNTIsNiArNTIs NyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgTShGdWxsc2NyZWVuKSBcCiAgICAgTShHYW1l cGFkKSBcCiAgICAgTShIaXN0b3J5KSBcCisgICAgTShJT1N1cmZhY2UpIFwKICAgICBNKEljb25E YXRhYmFzZSkgXAogICAgIE0oSW1hZ2VzKSBcCiAgICAgTShJbmRleGVkREIpIFwKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLmgKaW5kZXgg MDBhZDJjYjM0MzlmYmI5YjI2YjExYWIxYjZmZDM3ZTNmMzI2MDAyNC4uNWQwNjdhOTE2YzM2ZTE4 MDI0OGE0ZjE1ZDA2YmNiZDkxZjZkNzY3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLmgKQEAgLTIzLDggKzIzLDcgQEAKICAqIE9G IFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VD SCBEQU1BR0UuCiAgKi8KIAotI2lmbmRlZiBJT1N1cmZhY2VfaAotI2RlZmluZSBJT1N1cmZhY2Vf aAorI3ByYWdtYSBvbmNlCiAKICNpZiBVU0UoSU9TVVJGQUNFKQogCkBAIC0zNCw2ICszMyw3IEBA CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIE1hY2hTZW5kUmlnaHQ7CitjbGFzcyBUZXh0 U3RyZWFtOwogCiBjbGFzcyBJT1N1cmZhY2UgZmluYWwgewogICAgIFdURl9NQUtFX0ZBU1RfQUxM T0NBVEVEOwpAQCAtODcsNiArODcsNyBAQCBwdWJsaWM6CiAgICAgc2l6ZV90IHRvdGFsQnl0ZXMo KSBjb25zdCB7IHJldHVybiBtX3RvdGFsQnl0ZXM7IH0KICAgICBDR0NvbG9yU3BhY2VSZWYgY29s b3JTcGFjZSgpIGNvbnN0IHsgcmV0dXJuIG1fY29sb3JTcGFjZS5nZXQoKTsgfQogICAgIFdFQkNP UkVfRVhQT1JUIEZvcm1hdCBmb3JtYXQoKSBjb25zdDsKKyAgICBJT1N1cmZhY2VJRCBzdXJmYWNl SUQoKSBjb25zdDsKIAogICAgIFdFQkNPUkVfRVhQT1JUIGJvb2wgaXNJblVzZSgpIGNvbnN0Owog CkBAIC0xMTgsOCArMTE5LDkgQEAgcHJpdmF0ZToKICAgICBSZXRhaW5QdHI8SU9TdXJmYWNlUmVm PiBtX3N1cmZhY2U7CiB9OwogCitXRUJDT1JFX0VYUE9SVCBUZXh0U3RyZWFtJiBvcGVyYXRvcjw8 KFRleHRTdHJlYW0mLCBjb25zdCBXZWJDb3JlOjpJT1N1cmZhY2UmKTsKKwogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gVVNFKElPU1VSRkFDRSkKIAotI2VuZGlmIC8vIElPU3Vy ZmFjZV9oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2Nv YS9JT1N1cmZhY2UubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9J T1N1cmZhY2UubW0KaW5kZXggZGIyZjE0ZDg0OTRjZjM1Nzk1Y2RlNTRiZDEwZGZiMTdhNzVlMDgz YS4uZmYwODg2ZmY2YmViMjMzNWNlNGUyMGVhOGRmZDZlZmJiYjVjMDBjZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLm1tCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbQpAQCAt MzYsNiArMzYsNyBAQAogI2ltcG9ydCAiSW1hZ2VCdWZmZXJEYXRhQ0cuaCIKICNpbXBvcnQgIkxv Z2dpbmcuaCIKICNpbXBvcnQgIk1hY2hTZW5kUmlnaHQuaCIKKyNpbXBvcnQgIlRleHRTdHJlYW0u aCIKICNpbXBvcnQgPHd0Zi9Bc3NlcnRpb25zLmg+CiAjaW1wb3J0IDx3dGYvTWF0aEV4dHJhcy5o PgogCkBAIC00NCw3ICs0NSw3IEBACiBOU1N0cmluZyAqIGNvbnN0IFdlYklPU3VyZmFjZUFjY2Vs ZXJhdG9yVW53aXJlU3VyZmFjZUtleSA9IEAiVW53aXJlU3VyZmFjZSI7CiAjZW5kaWYKIAotdXNp bmcgbmFtZXNwYWNlIFdlYkNvcmU7CituYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGlubGluZSBzdGQ6 OnVuaXF1ZV9wdHI8V2ViQ29yZTo6SU9TdXJmYWNlPiBXZWJDb3JlOjpJT1N1cmZhY2U6OnN1cmZh Y2VGcm9tUG9vbChJbnRTaXplIHNpemUsIEludFNpemUgY29udGV4dFNpemUsIENHQ29sb3JTcGFj ZVJlZiBjb2xvclNwYWNlLCBGb3JtYXQgcGl4ZWxGb3JtYXQpCiB7CkBAIC02MywxMiArNjQsMTgg QEAgc3RkOjp1bmlxdWVfcHRyPFdlYkNvcmU6OklPU3VyZmFjZT4gV2ViQ29yZTo6SU9TdXJmYWNl OjpjcmVhdGUoSW50U2l6ZSBzaXplLCBDR0MKIAogc3RkOjp1bmlxdWVfcHRyPFdlYkNvcmU6OklP U3VyZmFjZT4gV2ViQ29yZTo6SU9TdXJmYWNlOjpjcmVhdGUoSW50U2l6ZSBzaXplLCBJbnRTaXpl IGNvbnRleHRTaXplLCBDR0NvbG9yU3BhY2VSZWYgY29sb3JTcGFjZSwgRm9ybWF0IHBpeGVsRm9y bWF0KQogewotICAgIGlmIChhdXRvIGNhY2hlZFN1cmZhY2UgPSBzdXJmYWNlRnJvbVBvb2woc2l6 ZSwgY29udGV4dFNpemUsIGNvbG9yU3BhY2UsIHBpeGVsRm9ybWF0KSkKKyAgICBpZiAoYXV0byBj YWNoZWRTdXJmYWNlID0gc3VyZmFjZUZyb21Qb29sKHNpemUsIGNvbnRleHRTaXplLCBjb2xvclNw YWNlLCBwaXhlbEZvcm1hdCkpIHsKKyAgICAgICAgTE9HX1dJVEhfU1RSRUFNKElPU3VyZmFjZSwg c3RyZWFtIDw8ICJJT1N1cmZhY2U6OmNyZWF0ZSB0b29rIGZyb20gcG9vbDogIiA8PCAqY2FjaGVk U3VyZmFjZSk7CiAgICAgICAgIHJldHVybiBjYWNoZWRTdXJmYWNlOworICAgIH0KICAgICBib29s IHN1Y2Nlc3MgPSBmYWxzZTsKICAgICBhdXRvIHN1cmZhY2UgPSBzdGQ6OnVuaXF1ZV9wdHI8SU9T dXJmYWNlPihuZXcgSU9TdXJmYWNlKHNpemUsIGNvbnRleHRTaXplLCBjb2xvclNwYWNlLCBwaXhl bEZvcm1hdCwgc3VjY2VzcykpOwotICAgIGlmICghc3VjY2VzcykKKyAgICBpZiAoIXN1Y2Nlc3Mp IHsKKyAgICAgICAgTE9HKElPU3VyZmFjZSwgIklPU3VyZmFjZTo6Y3JlYXRlIGZhaWxlZCB0byBj cmVhdGUgJWR4JWQgc3VyZmFjZSIsIHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSk7CiAgICAg ICAgIHJldHVybiBudWxscHRyOworICAgIH0KKworICAgIExPR19XSVRIX1NUUkVBTShJT1N1cmZh Y2UsIHN0cmVhbSA8PCAiSU9TdXJmYWNlOjpjcmVhdGUgY3JlYXRlZCAiIDw8ICpzdXJmYWNlKTsK ICAgICByZXR1cm4gc3VyZmFjZTsKIH0KIApAQCAtMzU2LDYgKzM2MywxMSBAQCBXZWJDb3JlOjpJ T1N1cmZhY2U6OkZvcm1hdCBXZWJDb3JlOjpJT1N1cmZhY2U6OmZvcm1hdCgpIGNvbnN0CiAgICAg cmV0dXJuIEZvcm1hdDo6UkdCQTsKIH0KIAorSU9TdXJmYWNlSUQgV2ViQ29yZTo6SU9TdXJmYWNl OjpzdXJmYWNlSUQoKSBjb25zdAoreworICAgIHJldHVybiBJT1N1cmZhY2VHZXRJRChtX3N1cmZh Y2UuZ2V0KCkpOworfQorCiBib29sIFdlYkNvcmU6OklPU3VyZmFjZTo6aXNJblVzZSgpIGNvbnN0 CiB7CiAgICAgcmV0dXJuIElPU3VyZmFjZUlzSW5Vc2UobV9zdXJmYWNlLmdldCgpKTsKQEAgLTQx Niw0ICs0MjgsNDMgQEAgdm9pZCBXZWJDb3JlOjpJT1N1cmZhY2U6OmNvbnZlcnRUb0Zvcm1hdChz dGQ6OnVuaXF1ZV9wdHI8V2ViQ29yZTo6SU9TdXJmYWNlPiYmIGkKIH0KICNlbmRpZiAvLyBQTEFU Rk9STShJT1MpCiAKK3N0YXRpYyBUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KFRleHRTdHJlYW0mIHRz LCBXZWJDb3JlOjpJT1N1cmZhY2U6OkZvcm1hdCBmb3JtYXQpCit7CisgICAgc3dpdGNoIChmb3Jt YXQpIHsKKyAgICBjYXNlIFdlYkNvcmU6OklPU3VyZmFjZTo6Rm9ybWF0OjpSR0JBOgorICAgICAg ICB0cyA8PCAiUkdCQSI7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgV2ViQ29yZTo6SU9TdXJm YWNlOjpGb3JtYXQ6OllVVjQyMjoKKyAgICAgICAgdHMgPDwgIllVVjQyMiI7CisgICAgICAgIGJy ZWFrOworICAgIGNhc2UgV2ViQ29yZTo6SU9TdXJmYWNlOjpGb3JtYXQ6OlJHQjEwOgorICAgICAg ICB0cyA8PCAiUkdCMTAiOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFdlYkNvcmU6OklPU3Vy ZmFjZTo6Rm9ybWF0OjpSR0IxMEE4OgorICAgICAgICB0cyA8PCAiUkdCMTBBOCI7CisgICAgICAg IGJyZWFrOworICAgIH0KKyAgICByZXR1cm4gdHM7Cit9CisKK3N0YXRpYyBUZXh0U3RyZWFtJiBv cGVyYXRvcjw8KFRleHRTdHJlYW0mIHRzLCBXZWJDb3JlOjpJT1N1cmZhY2U6OlN1cmZhY2VTdGF0 ZSBzdGF0ZSkKK3sKKyAgICBzd2l0Y2ggKHN0YXRlKSB7CisgICAgY2FzZSBXZWJDb3JlOjpJT1N1 cmZhY2U6OlN1cmZhY2VTdGF0ZTo6VmFsaWQ6CisgICAgICAgIHRzIDw8ICJ2YWxpZCI7CisgICAg ICAgIGJyZWFrOworICAgIGNhc2UgV2ViQ29yZTo6SU9TdXJmYWNlOjpTdXJmYWNlU3RhdGU6OkVt cHR5OgorICAgICAgICB0cyA8PCAiZW1wdHkiOworICAgICAgICBicmVhazsKKyAgICB9CisgICAg cmV0dXJuIHRzOworfQorCitUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KFRleHRTdHJlYW0mIHRzLCBj b25zdCBXZWJDb3JlOjpJT1N1cmZhY2UmIHN1cmZhY2UpCit7CisgICAgcmV0dXJuIHRzIDw8ICJJ T1N1cmZhY2UgIiA8PCBzdXJmYWNlLnN1cmZhY2VJRCgpIDw8ICIgc2l6ZSAiIDw8IHN1cmZhY2Uu c2l6ZSgpIDw8ICIgZm9ybWF0ICIgPDwgc3VyZmFjZS5mb3JtYXQoKSA8PCAiIHN0YXRlICIgPDwg c3VyZmFjZS5zdGF0ZSgpOworfQorCit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCisKICNlbmRpZiAv LyBVU0UoSU9TVVJGQUNFKQo=