174160 2017-07-05 09:47:49 -0700 [iOS] WKActionSheetAssistants can outlive their host views 2017-07-05 11:08:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes adachan bdakin commit-queue ddkilzer enrica thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1325604 0 aestes 2017-07-05 09:47:49 -0700 [iOS] WKActionSheetAssistants can outlive their host views 1325605 1 aestes 2017-07-05 09:52:00 -0700 rdar://problem/20638607 1325619 2 314612 aestes 2017-07-05 10:16:41 -0700 Created attachment 314612 Patch 1325658 3 314612 commit-queue 2017-07-05 11:08:35 -0700 Comment on attachment 314612 Patch Clearing flags on attachment: 314612 Committed r219139: <http://trac.webkit.org/changeset/219139> 1325659 4 commit-queue 2017-07-05 11:08:37 -0700 All reviewed patches have been landed. Closing bug. 314612 2017-07-05 10:16:41 -0700 2017-07-05 11:08:35 -0700 Patch bug-174160-20170705101640.patch text/plain 7063 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODIwNGJjYmU1MDhmYjhl MDk4ZDJiNWViZmU5NjBhNjMyNzkwYmMzOC4uYTJlMjE5ZWExZjVlNzJkODZhOGE2MzkyN2E2YTY0 Njc1MmIyOWRlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDE3LTA3LTA1ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBXS0FjdGlvblNoZWV0 QXNzaXN0YW50cyBjYW4gb3V0bGl2ZSB0aGVpciBob3N0IHZpZXdzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQxNjAKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzIwNjM4NjA3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQga2VlcHMgYSByYXcgcG9pbnRlciB0byBp dHMgaG9zdCBVSVZpZXcsIGFuZCBub3RoaW5nIGNsZWFycyBpdCB3aGVuCisgICAgICAgIHRoZSBo b3N0IHZpZXcgaXMgZGVhbGxvY2F0ZWQuIElmIHRoZSBhc3Npc3RhbnQgb3V0bGl2ZXMgdGhlIHZp ZXcsIHdlIGNhbiBlbmQgdXAgYWNjZXNzaW5nIGEKKyAgICAgICAgcG9pbnRlciB0byBhIGRlYWxs b2NhdGVkIFVJVmlldyBhbmQgY3Jhc2hpbmcuCisKKyAgICAgICAgSSBkb24ndCBrbm93IGhvdyB0 byByZXByb2R1Y2Ugc3VjaCBhIGNyYXNoLCBidXQgdGhpcyBwYXRjaCBndWFyZHMgYWdhaW5zdCBp dCBieSBkb2luZyB0aGUKKyAgICAgICAgZm9sbG93aW5nOgorCisgICAgICAgIDEuIE1ha2UgX3Zp ZXcgYSBXZWFrT2JqQ1B0ciBpbiBXS0FjdGlvblNoZWV0QXNzaXN0YW50IHRvIGVuc3VyZSBpdCBn ZXRzIHNldCB0byBuaWwgd2hlbiB0aGUKKyAgICAgICAgICAgVUlWaWV3IGlzIGRlYWxsb2NhdGVk LgorICAgICAgICAyLiBDYWxsIC1bV0tBY3Rpb25TaGVldEFzc2lzdGFudCBjbGVhbnVwU2hlZXRd IHdoZW4gYSBXS0NvbnRlbnRWaWV3IG9yIFdLUERGVmlldyBpcworICAgICAgICAgICBkZWFsbG9j YXRlZCwgb3Igd2hlbiB0aGUgV2ViIHByb2Nlc3MgY3Jhc2hlcy4gVGhpcyB3aWxsIGVuc3VyZSB0 aGUgYWN0aW9uIHNoZWV0IGlzCisgICAgICAgICAgIGRpc21pc3NlZCBhbmQgcHJldmVudCB0aGUg dXNlciBmcm9tIHRhcHBpbmcgb24gYW4gYWN0aW9uIHRoYXQncyBubyBsb25nZXIgdmFsaWQuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW06CisgICAg ICAgICgtW1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQgc3VwZXJ2aWV3Rm9yU2hlZXRdKToKKyAgICAg ICAgKC1bV0tBY3Rpb25TaGVldEFzc2lzdGFudCBfcHJlc2VudGF0aW9uUmVjdEZvclNoZWV0R2l2 ZW5Qb2ludDppbkhvc3RWaWV3Ol0pOgorICAgICAgICAoLVtXS0FjdGlvblNoZWV0QXNzaXN0YW50 IHByZXNlbnRhdGlvblJlY3RGb3JFbGVtZW50VXNpbmdDbG9zZXN0SW5kaWNhdGVkUmVjdF0pOgor ICAgICAgICAoLVtXS0FjdGlvblNoZWV0QXNzaXN0YW50IHByZXNlbnRhdGlvblJlY3RGb3JJbmRp Y2F0ZWRFbGVtZW50XSk6CisgICAgICAgICgtW1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQgX3Nob3Vs ZFByZXNlbnRBdFRvdWNoTG9jYXRpb25Gb3JFbGVtZW50UmVjdDpdKToKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250 ZW50VmlldyBjbGVhbnVwSW50ZXJhY3Rpb25dKToKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dL UERGVmlldy5tbToKKyAgICAgICAgKC1bV0tQREZWaWV3IGRlYWxsb2NdKToKKwogMjAxNy0wNy0w NCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFu dXAgc29tZSBTdHJpbmdCdWlsZGVyIHVzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCmluZGV4IGFlZTk5N2EyZmI2MTFi M2QxMjI4N2I2N2U4YzQ0NTM5MjQyMjY1MTEuLjFiMTQwNmJjMjAzMjY3MzI1YWU3NGI1MGVjMWI4 NTViNDQ3ODMzOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tB Y3Rpb25TaGVldEFzc2lzdGFudC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9z L1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW0KQEAgLTg5LDcgKzg5LDcgQEAgQGltcGxlbWVudGF0 aW9uIFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQgewogICAgIFJldGFpblB0cjxXS0FjdGlvblNoZWV0 PiBfaW50ZXJhY3Rpb25TaGVldDsKICAgICBSZXRhaW5QdHI8X1dLQWN0aXZhdGVkRWxlbWVudElu Zm8+IF9lbGVtZW50SW5mbzsKICAgICBzdGQ6Om9wdGlvbmFsPFdlYktpdDo6SW50ZXJhY3Rpb25J bmZvcm1hdGlvbkF0UG9zaXRpb24+IF9wb3NpdGlvbkluZm9ybWF0aW9uOwotICAgIFVJVmlldyAq X3ZpZXc7CisgICAgV2Vha09iakNQdHI8VUlWaWV3PiBfdmlldzsKICAgICBCT09MIF9uZWVkc0xp bmtJbmRpY2F0b3I7CiAgICAgQk9PTCBfaXNQcmVzZW50aW5nRERVc2VySW50ZXJmYWNlOwogICAg IEJPT0wgX2hhc1BlbmRpbmdBY3Rpb25TaGVldDsKQEAgLTEzMCwxNCArMTMwLDE1IEBAIC0gKEJP T0wpc3luY2hyb25vdXNseVJldHJpZXZlUG9zaXRpb25JbmZvcm1hdGlvbgogCiAtIChVSVZpZXcg KilzdXBlcnZpZXdGb3JTaGVldAogewotICAgIFVJVmlldyAqdmlldyA9IFtfdmlldyB3aW5kb3dd OworICAgIFVJVmlldyAqdmlldyA9IF92aWV3LmdldEF1dG9yZWxlYXNlZCgpOworICAgIFVJVmll dyAqc3VwZXJ2aWV3ID0gW3ZpZXcgd2luZG93XTsKIAogICAgIC8vIEZJWE1FOiBXZWJLaXQgaGFz IGEgZGVsZWdhdGUgdG8gcmV0cmlldmUgdGhlIHN1cGVydmlldyBmb3IgdGhlIGltYWdlIHNoZWV0 IChzdXBlcnZpZXdGb3JJbWFnZVNoZWV0Rm9yV2ViVmlldykKICAgICAvLyBEbyB3ZSBuZWVkIGl0 IGluIFdLMj8KIAogICAgIC8vIEZpbmQgdGhlIHRvcCBtb3N0IHZpZXcgd2l0aCBhIHZpZXcgY29u dHJvbGxlcgogICAgIFVJVmlld0NvbnRyb2xsZXIgKmNvbnRyb2xsZXIgPSBuaWw7Ci0gICAgVUlW aWV3ICpjdXJyZW50VmlldyA9IF92aWV3OworICAgIFVJVmlldyAqY3VycmVudFZpZXcgPSB2aWV3 OwogICAgIHdoaWxlIChjdXJyZW50VmlldykgewogICAgICAgICBVSVZpZXdDb250cm9sbGVyICph Q29udHJvbGxlciA9IFtVSVZpZXdDb250cm9sbGVyIHZpZXdDb250cm9sbGVyRm9yVmlldzpjdXJy ZW50Vmlld107CiAgICAgICAgIGlmIChhQ29udHJvbGxlcikKQEAgLTE0NiwxNCArMTQ3LDE0IEBA IC0gKFVJVmlldyAqKXN1cGVydmlld0ZvclNoZWV0CiAgICAgICAgIGN1cnJlbnRWaWV3ID0gW2N1 cnJlbnRWaWV3IHN1cGVydmlld107CiAgICAgfQogICAgIGlmIChjb250cm9sbGVyKQotICAgICAg ICB2aWV3ID0gY29udHJvbGxlci52aWV3OworICAgICAgICBzdXBlcnZpZXcgPSBjb250cm9sbGVy LnZpZXc7CiAKLSAgICByZXR1cm4gdmlldzsKKyAgICByZXR1cm4gc3VwZXJ2aWV3OwogfQogCiAt IChDR1JlY3QpX3ByZXNlbnRhdGlvblJlY3RGb3JTaGVldEdpdmVuUG9pbnQ6KENHUG9pbnQpcG9p bnQgaW5Ib3N0VmlldzooVUlWaWV3ICopaG9zdFZpZXcKIHsKLSAgICBDR1BvaW50IHByZXNlbnRh dGlvblBvaW50ID0gW2hvc3RWaWV3IGNvbnZlcnRQb2ludDpwb2ludCBmcm9tVmlldzpfdmlld107 CisgICAgQ0dQb2ludCBwcmVzZW50YXRpb25Qb2ludCA9IFtob3N0VmlldyBjb252ZXJ0UG9pbnQ6 cG9pbnQgZnJvbVZpZXc6X3ZpZXcuZ2V0QXV0b3JlbGVhc2VkKCldOwogICAgIENHUmVjdCBwcmVz ZW50YXRpb25SZWN0ID0gQ0dSZWN0TWFrZShwcmVzZW50YXRpb25Qb2ludC54LCBwcmVzZW50YXRp b25Qb2ludC55LCAxLjAsIDEuMCk7CiAKICAgICByZXR1cm4gQ0dSZWN0SW5zZXQocHJlc2VudGF0 aW9uUmVjdCwgLTIyLjAsIC0yMi4wKTsKQEAgLTE4OSw3ICsxOTAsNyBAQCAtIChDR1JlY3QpcHJl c2VudGF0aW9uUmVjdEZvckVsZW1lbnRVc2luZ0Nsb3Nlc3RJbmRpY2F0ZWRSZWN0CiAgICAgZm9y IChhdXRvIHBhdGggOiBXZWJDb3JlOjpQYXRoVXRpbGl0aWVzOjpwYXRoc1dpdGhTaHJpbmtXcmFw cGVkUmVjdHMoaW5kaWNhdGVkUmVjdHMsIDApKSB7CiAgICAgICAgIGF1dG8gYm91bmRpbmdSZWN0 ID0gcGF0aC5mYXN0Qm91bmRpbmdSZWN0KCk7CiAgICAgICAgIGlmIChib3VuZGluZ1JlY3QuY29u dGFpbnModG91Y2hMb2NhdGlvbikpCi0gICAgICAgICAgICByZXR1cm4gQ0dSZWN0SW5zZXQoW3Zp ZXcgY29udmVydFJlY3Q6KENHUmVjdClib3VuZGluZ1JlY3QgZnJvbVZpZXc6X3ZpZXddLCAtcHJl c2VudGF0aW9uRWxlbWVudFJlY3RQYWRkaW5nLCAtcHJlc2VudGF0aW9uRWxlbWVudFJlY3RQYWRk aW5nKTsKKyAgICAgICAgICAgIHJldHVybiBDR1JlY3RJbnNldChbdmlldyBjb252ZXJ0UmVjdDoo Q0dSZWN0KWJvdW5kaW5nUmVjdCBmcm9tVmlldzpfdmlldy5nZXRBdXRvcmVsZWFzZWQoKV0sIC1w cmVzZW50YXRpb25FbGVtZW50UmVjdFBhZGRpbmcsIC1wcmVzZW50YXRpb25FbGVtZW50UmVjdFBh ZGRpbmcpOwogICAgIH0KIAogICAgIHJldHVybiBDR1JlY3RaZXJvOwpAQCAtMjAzLDcgKzIwNCw3 IEBAIC0gKENHUmVjdClwcmVzZW50YXRpb25SZWN0Rm9ySW5kaWNhdGVkRWxlbWVudAogICAgICAg ICByZXR1cm4gQ0dSZWN0WmVybzsKIAogICAgIGF1dG8gZWxlbWVudEJvdW5kcyA9IF9wb3NpdGlv bkluZm9ybWF0aW9uLT5ib3VuZHM7Ci0gICAgcmV0dXJuIENHUmVjdEluc2V0KFt2aWV3IGNvbnZl cnRSZWN0OmVsZW1lbnRCb3VuZHMgZnJvbVZpZXc6X3ZpZXddLCAtcHJlc2VudGF0aW9uRWxlbWVu dFJlY3RQYWRkaW5nLCAtcHJlc2VudGF0aW9uRWxlbWVudFJlY3RQYWRkaW5nKTsKKyAgICByZXR1 cm4gQ0dSZWN0SW5zZXQoW3ZpZXcgY29udmVydFJlY3Q6ZWxlbWVudEJvdW5kcyBmcm9tVmlldzpf dmlldy5nZXRBdXRvcmVsZWFzZWQoKV0sIC1wcmVzZW50YXRpb25FbGVtZW50UmVjdFBhZGRpbmcs IC1wcmVzZW50YXRpb25FbGVtZW50UmVjdFBhZGRpbmcpOwogfQogCiAtIChDR1JlY3QpaW5pdGlh bFByZXNlbnRhdGlvblJlY3RJbkhvc3RWaWV3Rm9yU2hlZXQKQEAgLTM5NCw4ICszOTUsOSBAQCAt ICh2b2lkKXNob3dJbWFnZVNoZWV0CiAKIC0gKEJPT0wpX3Nob3VsZFByZXNlbnRBdFRvdWNoTG9j YXRpb25Gb3JFbGVtZW50UmVjdDooQ0dSZWN0KWVsZW1lbnRSZWN0CiB7Ci0gICAgYXV0byBhcHBh cmVudEVsZW1lbnRSZWN0ID0gW192aWV3IGNvbnZlcnRSZWN0OmVsZW1lbnRSZWN0IHRvVmlldzpf dmlldy53aW5kb3ddOwotICAgIGF1dG8gd2luZG93UmVjdCA9IF92aWV3LndpbmRvdy5ib3VuZHM7 CisgICAgVUlWaWV3ICp2aWV3ID0gX3ZpZXcuZ2V0QXV0b3JlbGVhc2VkKCk7CisgICAgYXV0byBh cHBhcmVudEVsZW1lbnRSZWN0ID0gW3ZpZXcgY29udmVydFJlY3Q6ZWxlbWVudFJlY3QgdG9WaWV3 OnZpZXcud2luZG93XTsKKyAgICBhdXRvIHdpbmRvd1JlY3QgPSB2aWV3LndpbmRvdy5ib3VuZHM7 CiAgICAgYXBwYXJlbnRFbGVtZW50UmVjdCA9IENHUmVjdEludGVyc2VjdGlvbihhcHBhcmVudEVs ZW1lbnRSZWN0LCB3aW5kb3dSZWN0KTsKIAogICAgIGF1dG8gbGVmdEluc2V0ID0gQ0dSZWN0R2V0 TWluWChhcHBhcmVudEVsZW1lbnRSZWN0KSAtIENHUmVjdEdldE1pblgod2luZG93UmVjdCk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tCmluZGV4IDFkZTU0ZmU1NGU4NDJiMzQ2MmM0YzZjOGRjN2ZhOGQ4NmY5NjA1 NWMuLjg3M2RjNTU1ZGUxNmFkZDhkZWRhMmE2MmNhYzQ1ODJjMjg0YjAyZTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tCkBAIC02MDIsNyArNjAyLDEwIEBAIC0gKHZvaWQpY2xlYW51cEludGVyYWN0aW9uCiB7 CiAgICAgX3dlYlNlbGVjdGlvbkFzc2lzdGFudCA9IG5pbDsKICAgICBfdGV4dFNlbGVjdGlvbkFz c2lzdGFudCA9IG5pbDsKKyAgICAKKyAgICBbX2FjdGlvblNoZWV0QXNzaXN0YW50IGNsZWFudXBT aGVldF07CiAgICAgX2FjdGlvblNoZWV0QXNzaXN0YW50ID0gbmlsOworICAgIAogICAgIF9zbWFy dE1hZ25pZmljYXRpb25Db250cm9sbGVyID0gbmlsOwogICAgIF9kaWRBY2Nlc3NvcnlUYWJJbml0 aWF0ZUZvY3VzID0gTk87CiAgICAgX2lzRXhwZWN0aW5nRmFzdFNpbmdsZVRhcENvbW1pdCA9IE5P OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcubW0g Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLUERGVmlldy5tbQppbmRleCBjYjhkY2Ux NzZjZTRjZTQ1ZTdhMWQzMTY4MzE1ZDI4YjcwOTRiNjUwLi5lYzJmMzMxNWIyMDNjMGZjZTAzMzNh NTIyMDg1Mzc2OTQ5Zjc5YjI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1dLUERGVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLUERG Vmlldy5tbQpAQCAtMTQyLDYgKzE0Miw3IEBAIC0gKHZvaWQpZGVhbGxvYwogICAgIFtzZWxmIF9j bGVhclBhZ2VzXTsKICAgICBbX3BhZ2VOdW1iZXJJbmRpY2F0b3IgcmVtb3ZlRnJvbVN1cGVydmll d107CiAgICAgZGlzcGF0Y2hfcmVsZWFzZShfZmluZFF1ZXVlKTsKKyAgICBbX2FjdGlvblNoZWV0 QXNzaXN0YW50IGNsZWFudXBTaGVldF07CiAgICAgW3N1cGVyIGRlYWxsb2NdOwogfQogCg==