<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>174155</bug_id>
          
          <creation_ts>2017-07-05 03:24:54 -0700</creation_ts>
          <short_desc>Upgrade GCC baseline</short_desc>
          <delta_ts>2017-07-06 05:12:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annulen</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>darin</cc>
    
    <cc>gustavo</cc>
    
    <cc>jbicha</cc>
    
    <cc>jfbastien</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>saam</cc>
    
    <cc>sam</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1325546</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-07-05 03:24:54 -0700</bug_when>
    <thetext>We met the conclusion that we can upgrade GCC baseline at start of July![1].

According to the Debian&apos;s package information, GCC of the current stable (stretch, recently released) is 6.3.0.
And Ubuntu 16.04&apos;s GCC is 5.4.0.

And the table of the features is here.
https://gcc.gnu.org/projects/cxx-status.html
https://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html

https://gcc.gnu.org/gcc-5/changes.html
https://gcc.gnu.org/gcc-6/changes.html
https://gcc.gnu.org/gcc-7/changes.html

If we can upgrade our GCC to 5~, we have (almost) full feature of C++14 including relaxed-constexpr.
If we can upgrade our GCC to 6~, we have some part of C++17. (Like, u8 literal, extended static_assert(cond)).
And if we can upgrade our GCC to 7~, we have bunch of C++17. It includes std::optional, std::variant, std::conjunction.

[1]: https://lists.webkit.org/pipermail/webkit-dev/2017-June/029220.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325548</commentid>
    <comment_count>1</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-07-05 03:30:17 -0700</bug_when>
    <thetext>Even if we take very conservative version (GCC 5), it means that we have full-featured C++14 including related-constexpr. (And it is also supported in MSVC 2017).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325551</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-07-05 03:38:52 -0700</bug_when>
    <thetext>GTK and WPE are ready for GCC 5, except for a couple nonessential bots that are not run by Igalia. We would prefer to defer requiring GCC 6 until next summer.

AFAIK the only thing we have to change is the version number in OptionsGTK.cmake?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325552</commentid>
    <comment_count>3</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-07-05 03:46:19 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #2)
&gt; GTK and WPE are ready for GCC 5, except for a couple nonessential bots that
&gt; are not run by Igalia. We would prefer to defer requiring GCC 6 until next
&gt; summer.

Anyway, the large part of C++17 is shipped in GCC 7. So I think if we would like to use C++17, we need to upgrade GCC to 7 at least.
So, personally, GCC 5 for now seems fine to me.
It would be nice if we can upgrade our GCC to 7 next summer...

BTW, to use C++14 relaxed constexpr, we need to upgrade our MSVC to 2017 too.
I think it is ok because Windows does not have bunch of distributions which does not have the easy way to install MSVC 2017.

&gt; AFAIK the only thing we have to change is the version number in
&gt; OptionsGTK.cmake?

I think so.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325553</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-07-05 04:10:46 -0700</bug_when>
    <thetext>(In reply to Yusuke Suzuki from comment #3)
&gt; (In reply to Michael Catanzaro from comment #2)
&gt; &gt; GTK and WPE are ready for GCC 5, except for a couple nonessential bots that
&gt; &gt; are not run by Igalia. We would prefer to defer requiring GCC 6 until next
&gt; &gt; summer.
&gt; 
&gt; Anyway, the large part of C++17 is shipped in GCC 7. So I think if we would
&gt; like to use C++17, we need to upgrade GCC to 7 at least.
&gt; So, personally, GCC 5 for now seems fine to me.
&gt; It would be nice if we can upgrade our GCC to 7 next summer...
&gt; 

According to https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy

* Its fine to require now at least GCC 5.3 (that is what Ubuntu 16.04 ships)

* On May of 2018 (when Ubuntu 18.04 will be released -- next LTS) it will be fine to require at least GCC 6.3 (that is what Debian 9 ships currently).

* It won&apos;t be fine to require GCC &gt;= 7 until at least 2019-2020 (when Debian 10 will be released)


I understand the desire to use new compiler features, but at the same time I understand that requiring a too much new version of the compiler will cause trouble for many users. This is specially true for embedded users where the version of the compiler/toolchain is not something you can upgrade easier.

I think our current policy is a good compromise between using new compiler features and allowing WebKit to be built with a reasonably old toolchain.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325554</commentid>
    <comment_count>5</comment_count>
      <attachid>314601</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-07-05 04:44:08 -0700</bug_when>
    <thetext>Created attachment 314601
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325555</commentid>
    <comment_count>6</comment_count>
      <attachid>314602</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-07-05 04:47:13 -0700</bug_when>
    <thetext>Created attachment 314602
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325560</commentid>
    <comment_count>7</comment_count>
      <attachid>314602</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-07-05 06:59:26 -0700</bug_when>
    <thetext>Comment on attachment 314602
Patch

Should we move this version check to a more generic cmake file so it applies to all ports (including WPE)? Perhaps on the top level CMakeLists.txt ?
At the same time, i think we can remove other workarounds we have for GCC &lt; 5.3.0 like the one done on https://trac.webkit.org/changeset/184857</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325570</commentid>
    <comment_count>8</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-07-05 08:22:44 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #7)
&gt; Comment on attachment 314602 [details]
&gt; Patch
&gt; 
&gt; Should we move this version check to a more generic cmake file so it applies
&gt; to all ports (including WPE)? Perhaps on the top level CMakeLists.txt ?

I think the toplevel CMakeLists.txt is a reasonable location for this.

&gt; At the same time, i think we can remove other workarounds we have for GCC &lt;
&gt; 5.3.0 like the one done on https://trac.webkit.org/changeset/184857

Yeah good catch. Problem is, it&apos;s hard to find these since they&apos;re scattered in different places.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325875</commentid>
    <comment_count>9</comment_count>
      <attachid>314676</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-07-05 19:17:58 -0700</bug_when>
    <thetext>Created attachment 314676
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325880</commentid>
    <comment_count>10</comment_count>
      <attachid>314679</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-07-05 19:23:38 -0700</bug_when>
    <thetext>Created attachment 314679
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325920</commentid>
    <comment_count>11</comment_count>
      <attachid>314679</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-07-05 21:00:50 -0700</bug_when>
    <thetext>Comment on attachment 314679
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314679&amp;action=review

&gt; Source/WTF/wtf/Compiler.h:98
&gt; +#if !GCC_VERSION_AT_LEAST(5, 3, 0)
&gt; +#error &quot;Please use a newer version of GCC. WebKit requires GCC 5.3.0 or newer to compile.&quot;

This seems pretty arbitrary. Since there&apos;s one fewer significant digit in the version now, it&apos;s like setting the requirement at 4.9.3. I would just set it at 5.0 and be done with it.

But this is fine too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325932</commentid>
    <comment_count>12</comment_count>
      <attachid>314679</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-07-05 21:46:05 -0700</bug_when>
    <thetext>Comment on attachment 314679
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314679&amp;action=review

&gt;&gt; Source/WTF/wtf/Compiler.h:98
&gt;&gt; +#error &quot;Please use a newer version of GCC. WebKit requires GCC 5.3.0 or newer to compile.&quot;
&gt; 
&gt; This seems pretty arbitrary. Since there&apos;s one fewer significant digit in the version now, it&apos;s like setting the requirement at 4.9.3. I would just set it at 5.0 and be done with it.
&gt; 
&gt; But this is fine too.

It would be fine. I&apos;ve changed it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1325933</commentid>
    <comment_count>13</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-07-05 21:51:18 -0700</bug_when>
    <thetext>Committed r219186: &lt;http://trac.webkit.org/changeset/219186&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1326009</commentid>
    <comment_count>14</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-07-06 05:12:57 -0700</bug_when>
    <thetext>Done: Installed clang-3.8 from jessie-backports on the Debian Stable (currently: Jessie) bot and set it as compiler with the CC/CXX environment variables https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>314601</attachid>
            <date>2017-07-05 04:44:08 -0700</date>
            <delta_ts>2017-07-05 04:47:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-174155-20170705204407.patch</filename>
            <type>text/plain</type>
            <size>1518</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0
aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDk0YTVh
OWY1OTczZGI2MWYxOGJjM2M2MjBlNDk5NjI2OGQzZjIyMjUuLjg1NzgwYzc5YjFiMmIxNDU4ODdi
Y2QyMGM2ZGJiODE4YWJmZDIyNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL
LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC03LDggKzcsOCBA
QCBzZXQoUFJPSkVDVF9WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OX01BSk9SfS4ke1BST0pFQ1Rf
VkVSU0lPTl9NSU5PUn0uJHtQUk9KRUNUXwogc2V0KFdFQktJVEdUS19BUElfVkVSU0lPTiA0LjAp
CiAKIGlmIChDTUFLRV9DWFhfQ09NUElMRVJfSUQgU1RSRVFVQUwgIkdOVSIpCi0gICAgaWYgKENN
QUtFX0NYWF9DT01QSUxFUl9WRVJTSU9OIFZFUlNJT05fTEVTUyAiNC45LjAiKQotICAgICAgICBt
ZXNzYWdlKEZBVEFMX0VSUk9SICJHQ0MgNC45LjAgaXMgcmVxdWlyZWQgdG8gYnVpbGQgV2ViS2l0
R1RLKywgdXNlIGEgbmV3ZXIgR0NDIHZlcnNpb24gb3IgY2xhbmciKQorICAgIGlmIChDTUFLRV9D
WFhfQ09NUElMRVJfVkVSU0lPTiBWRVJTSU9OX0xFU1MgIjUuNC4wIikKKyAgICAgICAgbWVzc2Fn
ZShGQVRBTF9FUlJPUiAiR0NDIDUuNC4wIGlzIHJlcXVpcmVkIHRvIGJ1aWxkIFdlYktpdEdUSyss
IHVzZSBhIG5ld2VyIEdDQyB2ZXJzaW9uIG9yIGNsYW5nIikKICAgICBlbmRpZiAoKQogZW5kaWYg
KCkKIApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDZiZmQyMzBjMTIz
NTNmNjY4NDg5NDc1N2NjNmI4ZTA1NDZkN2UxOWUuLmFjMjdmMTU3MTI5MTljYzJkYzcyNGYxNDFk
ZTY0YWExZmQzOGIyOWMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAg
LTEsMyArMSwxNiBAQAorMjAxNy0wNy0wNSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdt
YWlsLmNvbT4KKworICAgICAgICBVcGdyYWRlIEdDQyBiYXNlbGluZQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MTU1CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBidW1wcyB0aGUgdmVy
c2lvbiBvZiBHQ0MgZnJvbSA0LjkuMCB0byA1LjQuMCwKKyAgICAgICAgd2hpY2ggaXMgc2hpcHBl
ZCB3aXRoIFVidW50dSAxNi4wNCBMVFMuIEFuZCB0aGUgbGF0ZXN0CisgICAgICAgIERlYmlhbiBz
dGFibGUgKHN0cmV0Y2gpIGFscmVhZHkgc2hpcHMgbmV3ZXIgR0NDICg2LjMuMCkuCisKKyAgICAg
ICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToKKwogMjAxNy0wNi0yOCAgU3RlcGhh
biBTemFibyAgPHN0ZXBoYW4uc3phYm9AYW0uc29ueS5jb20+CiAKICAgICAgICAgW1dpbl0gQnVp
bGQgSlNDT25seSBvbiBXaW5kb3dzIHdpdGggY2xhbmctY2wK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>314602</attachid>
            <date>2017-07-05 04:47:13 -0700</date>
            <delta_ts>2017-07-05 19:17:56 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-174155-20170705204712.patch</filename>
            <type>text/plain</type>
            <size>1518</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0
aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDk0YTVh
OWY1OTczZGI2MWYxOGJjM2M2MjBlNDk5NjI2OGQzZjIyMjUuLjQ3MTIxYWYxMmU0OTUzY2E3OGI4
MDJlMGM1N2JiNjMyMzcwYjk5ZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL
LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC03LDggKzcsOCBA
QCBzZXQoUFJPSkVDVF9WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OX01BSk9SfS4ke1BST0pFQ1Rf
VkVSU0lPTl9NSU5PUn0uJHtQUk9KRUNUXwogc2V0KFdFQktJVEdUS19BUElfVkVSU0lPTiA0LjAp
CiAKIGlmIChDTUFLRV9DWFhfQ09NUElMRVJfSUQgU1RSRVFVQUwgIkdOVSIpCi0gICAgaWYgKENN
QUtFX0NYWF9DT01QSUxFUl9WRVJTSU9OIFZFUlNJT05fTEVTUyAiNC45LjAiKQotICAgICAgICBt
ZXNzYWdlKEZBVEFMX0VSUk9SICJHQ0MgNC45LjAgaXMgcmVxdWlyZWQgdG8gYnVpbGQgV2ViS2l0
R1RLKywgdXNlIGEgbmV3ZXIgR0NDIHZlcnNpb24gb3IgY2xhbmciKQorICAgIGlmIChDTUFLRV9D
WFhfQ09NUElMRVJfVkVSU0lPTiBWRVJTSU9OX0xFU1MgIjUuMy4wIikKKyAgICAgICAgbWVzc2Fn
ZShGQVRBTF9FUlJPUiAiR0NDIDUuMy4wIGlzIHJlcXVpcmVkIHRvIGJ1aWxkIFdlYktpdEdUSyss
IHVzZSBhIG5ld2VyIEdDQyB2ZXJzaW9uIG9yIGNsYW5nIikKICAgICBlbmRpZiAoKQogZW5kaWYg
KCkKIApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDZiZmQyMzBjMTIz
NTNmNjY4NDg5NDc1N2NjNmI4ZTA1NDZkN2UxOWUuLmM5ZDhkMGRmNDdmNTdiMjZjMTRhMjhjYTFl
MGU5NDVlNjE1NTk5YmIgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAg
LTEsMyArMSwxNiBAQAorMjAxNy0wNy0wNSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdt
YWlsLmNvbT4KKworICAgICAgICBVcGdyYWRlIEdDQyBiYXNlbGluZQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MTU1CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBidW1wcyB0aGUgdmVy
c2lvbiBvZiBHQ0MgZnJvbSA0LjkuMCB0byA1LjMuMCwKKyAgICAgICAgd2hpY2ggaXMgc2hpcHBl
ZCB3aXRoIFVidW50dSAxNi4wNCBMVFMuIEFuZCB0aGUgbGF0ZXN0CisgICAgICAgIERlYmlhbiBz
dGFibGUgKHN0cmV0Y2gpIGFscmVhZHkgc2hpcHMgbmV3ZXIgR0NDICg2LjMuMCkuCisKKyAgICAg
ICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToKKwogMjAxNy0wNi0yOCAgU3RlcGhh
biBTemFibyAgPHN0ZXBoYW4uc3phYm9AYW0uc29ueS5jb20+CiAKICAgICAgICAgW1dpbl0gQnVp
bGQgSlNDT25seSBvbiBXaW5kb3dzIHdpdGggY2xhbmctY2wK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>314676</attachid>
            <date>2017-07-05 19:17:58 -0700</date>
            <delta_ts>2017-07-05 19:23:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-174155-20170706111757.patch</filename>
            <type>text/plain</type>
            <size>5017</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWI0OTM5YjI3M2Q0ZDU0
MTM2MzJmYmIzNTIzNWNjMDlhNmI2MDhjNC4uZTQyYTBmZDRjMTU5N2QzZDgzNzdmNmNjMDI5OTVl
MzM2MGZjMjY5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE3LTA3LTA1ICBZdXN1
a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCisgICAgICAgIFVwZ3JhZGUgR0ND
IGJhc2VsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0xNzQxNTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBSZW1vdmUgd29ya2Fyb3VuZCBmb3Igb2xkIEdDQy4KKworICAgICAgICAqIENNYWtlTGlzdHMu
dHh0OgorCisyMDE3LTA3LTA1ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29t
PgorCiAgICAgICAgIFtXVEZdIENsZWFuIHVwIFN0cmluZ1N0YXRpY3MuY3BwIGJ5IHVzaW5nIExh
enlOZXZlckRlc3Ryb3llZDw+IGZvciBBdG9tcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MTUwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggY2U3
YjE2OGVmYjQ3MzZjNjBlYzFhNzY5MDkxMGY0ZTllMGNkNGUwYy4uZTVkZWQyMmQzZjZhMGUwMTgy
ZmUzZjE1MWY3Mzk3ODM0NWRkNWRhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VM
aXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTQwMzYsMTIg
KzQwMzYsNiBAQCBpZiAoU0hBUkVEX0NPUkUpCiAgICAgaW5zdGFsbChUQVJHRVRTIFdlYkNvcmUg
REVTVElOQVRJT04gIiR7TElCX0lOU1RBTExfRElSfSIpCiBlbmRpZiAoKQogCi0jIFtBUk1dIEJ1
aWxkIFNWR1BhdGhFbGVtZW50LmNwcCB3aXRoIC1PMiBkdWUgdG8gYSBHQ0MgYnVnCi0jIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUzNzcKLWlmICgoQ01BS0VfQ1hY
X0NPTVBJTEVSX0lEIFNUUkVRVUFMICJHTlUiKSBBTkQgV1RGX0NQVV9BUk0gQU5EIChDTUFLRV9D
WFhfQ09NUElMRVJfVkVSU0lPTiBWRVJTSU9OX0dSRUFURVIgIjQuOSIpIEFORCAoQ01BS0VfQ1hY
X0NPTVBJTEVSX1ZFUlNJT04gVkVSU0lPTl9MRVNTICI0LjkuMyIpKQotICAgIHNldF9zb3VyY2Vf
ZmlsZXNfcHJvcGVydGllcyhzdmcvU1ZHUGF0aEVsZW1lbnQuY3BwIFBST1BFUlRJRVMgQ09NUElM
RV9GTEFHUyAiLU8yIikKLWVuZGlmICgpCi0KIGlmIChNU1ZDKQogICAgIHNldF90YXJnZXRfcHJv
cGVydGllcyhXZWJDb3JlIFBST1BFUlRJRVMKICAgICAgICAgQ09NUElMRV9QREJfTkFNRSAke1dl
YkNvcmVfT1VUUFVUX05BTUV9CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5j
bWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDk0YTVhOWY1OTczZGI2
MWYxOGJjM2M2MjBlNDk5NjI2OGQzZjIyMjUuLjYzN2FjNjU5Y2YxNjllYjczNDE5NWVmYzU4MDRj
ZTZkMmQxMzA5MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisr
KyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC02LDEyICs2LDYgQEAgc2V0KFBS
T0pFQ1RfVkVSU0lPTl9NSUNSTyA0KQogc2V0KFBST0pFQ1RfVkVSU0lPTiAke1BST0pFQ1RfVkVS
U0lPTl9NQUpPUn0uJHtQUk9KRUNUX1ZFUlNJT05fTUlOT1J9LiR7UFJPSkVDVF9WRVJTSU9OX01J
Q1JPfSkKIHNldChXRUJLSVRHVEtfQVBJX1ZFUlNJT04gNC4wKQogCi1pZiAoQ01BS0VfQ1hYX0NP
TVBJTEVSX0lEIFNUUkVRVUFMICJHTlUiKQotICAgIGlmIChDTUFLRV9DWFhfQ09NUElMRVJfVkVS
U0lPTiBWRVJTSU9OX0xFU1MgIjQuOS4wIikKLSAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAi
R0NDIDQuOS4wIGlzIHJlcXVpcmVkIHRvIGJ1aWxkIFdlYktpdEdUSyssIHVzZSBhIG5ld2VyIEdD
QyB2ZXJzaW9uIG9yIGNsYW5nIikKLSAgICBlbmRpZiAoKQotZW5kaWYgKCkKLQogIyBMaWJ0b29s
IGxpYnJhcnkgdmVyc2lvbiwgbm90IHRvIGJlIGNvbmZ1c2VkIHdpdGggQVBJIHZlcnNpb24uCiAj
IFNlZSBodHRwOi8vd3d3LmdudS5vcmcvc29mdHdhcmUvbGlidG9vbC9tYW51YWwvaHRtbF9ub2Rl
L0xpYnRvb2wtdmVyc2lvbmluZy5odG1sCiBDQUxDVUxBVEVfTElCUkFSWV9WRVJTSU9OU19GUk9N
X0xJQlRPT0xfVFJJUExFKFdFQktJVDIgNjAgMCAyMykKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFr
ZS9XZWJLaXRIZWxwZXJzLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UK
aW5kZXggMjgzNWZjYWY3MGFjNjU2OWNlYmJmOGY4Mzg5MDQzZTFhZTE4NzI4YS4uNmU0NjM4M2Yz
OGMwY2Q1NjM1NmViNmY3ZDE2ZWViYWYxZWU3ZDgwNCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtl
L1dlYktpdEhlbHBlcnMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21h
a2UKQEAgLTIyLDExICsyMiw2IEBAIG1hY3JvKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxB
R1MgX3RhcmdldCkKICAgICAgICAgICAgIHNldChPTERfQ09NUElMRV9GTEFHUyAiLVduby1wYXJl
bnRoZXNlcy1lcXVhbGl0eSAke09MRF9DT01QSUxFX0ZMQUdTfSIpCiAgICAgICAgIGVuZGlmICgp
CiAKLSAgICAgICAgIyBTdXBwcmVzcyAtV21pc3NpbmctZmllbGQtaW5pdGlhbGl6ZXJzIGR1ZSB0
byBhIEdDQyBidWcsIHNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTU3ODg4IGZvciBkZXRhaWxzLgotICAgICAgICBpZiAoIiR7Q01BS0VfQ1hYX0NPTVBJTEVSX0lE
fSIgU1RSRVFVQUwgIkdOVSIgQU5EIENNQUtFX0NYWF9DT01QSUxFUl9WRVJTSU9OIE1BVENIRVMg
IjRcXC45IikKLSAgICAgICAgICAgIHNldChPTERfQ09NUElMRV9GTEFHUyAiLVduby1taXNzaW5n
LWZpZWxkLWluaXRpYWxpemVycyAke09MRF9DT01QSUxFX0ZMQUdTfSIpCi0gICAgICAgIGVuZGlm
ICgpCi0KICAgICAgICAgIyBFbmFibGUgd2FybmluZ3MgYnkgZGVmYXVsdAogICAgICAgICBpZiAo
Tk9UICR7T1BUSU9OX0lHTk9SRUNYWF9XQVJOSU5HU30pCiAgICAgICAgICAgICBzZXQoT0xEX0NP
TVBJTEVfRkxBR1MgIi1XYWxsIC1XZXh0cmEgLVdjYXN0LWFsaWduIC1XZm9ybWF0LXNlY3VyaXR5
IC1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlIC1XcG9pbnRlci1hcml0aCAtV3VuZGVmIC1Xd3Jp
dGUtc3RyaW5ncyAke09MRF9DT01QSUxFX0ZMQUdTfSIpCmRpZmYgLS1naXQgYS9DTWFrZUxpc3Rz
LnR4dCBiL0NNYWtlTGlzdHMudHh0CmluZGV4IDQ5YWU5ZmFmMmI4YjRiNWNlOTc2ODM4ZmQ4YTI1
MWJhMmRjOTQ2NzQuLjNkZDZmNGU0MzM5NjE0MDgwYWExNzdmNjhlMTlmZjBhMmNhMzc0NTggMTAw
NjQ0Ci0tLSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC00Niw2ICs0
NiwxMiBAQCBpZiAoJHtDTUFLRV9DWFhfQ09NUElMRVJfSUR9IFNUUkVRVUFMICJDbGFuZyIgT1Ig
JHtDTUFLRV9DWFhfQ09NUElMRVJfSUR9IFNUUkVRVQogICAgIHNldChDT01QSUxFUl9JU19DTEFO
RyBPTikKIGVuZGlmICgpCiAKK2lmICgke0NNQUtFX0NYWF9DT01QSUxFUl9JRH0gU1RSRVFVQUwg
IkdOVSIpCisgICAgaWYgKCR7Q01BS0VfQ1hYX0NPTVBJTEVSX1ZFUlNJT059IFZFUlNJT05fTEVT
UyAiNS4zLjAiKQorICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJHQ0MgNS4zLjAgaXMgcmVx
dWlyZWQgdG8gYnVpbGQgV2ViS2l0R1RLKywgdXNlIGEgbmV3ZXIgR0NDIHZlcnNpb24gb3IgY2xh
bmciKQorICAgIGVuZGlmICgpCitlbmRpZiAoKQorCiBpZiAoQ01BS0VfQ09NUElMRVJfSVNfR05V
Q1hYIE9SIENPTVBJTEVSX0lTX0NMQU5HKQogICAgIHNldChDT01QSUxFUl9JU19HQ0NfT1JfQ0xB
TkcgT04pCiBlbmRpZiAoKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4
IGQ2ZDFiYTA3YTA2YTMzZjIxNDE1ZDZkMmUxMmM4MjdlMWM0ZjgyYjkuLjU1Yjc2OWQ3NmU1OTFl
M2U1NDBkM2Y0MmIzMWQxNTgxNzBmZmY3ZDQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D
aGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxNy0wNy0wNSAgWXVzdWtlIFN1enVraSAgPHV0
YXRhbmUudGVhQGdtYWlsLmNvbT4KKworICAgICAgICBVcGdyYWRlIEdDQyBiYXNlbGluZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MTU1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBi
dW1wcyB0aGUgdmVyc2lvbiBvZiBHQ0MgZnJvbSA0LjkuMCB0byA1LjMuMCwKKyAgICAgICAgd2hp
Y2ggaXMgc2hpcHBlZCB3aXRoIFVidW50dSAxNi4wNCBMVFMuIEFuZCB0aGUgbGF0ZXN0CisgICAg
ICAgIERlYmlhbiBzdGFibGUgKHN0cmV0Y2gpIGFscmVhZHkgc2hpcHMgbmV3ZXIgR0NDICg2LjMu
MCkuCisgICAgICAgIFJlbW92ZSB3b3JrYXJvdW5kIGZvciBvbGQgR0NDLiBBbmQgbW92ZSBHQ0Mg
dmVyc2lvbiBjaGVjaworICAgICAgICB0byB0aGUgdG9wLWxldmVsIENNYWtlTGlzdHMudHh0Lgor
CisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlv
bnNHVEsuY21ha2U6CisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2U6
CisKIDIwMTctMDctMDUgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAog
ICAgICAgICBbV2luQ2Fpcm9dIENvbnNvbGlkYXRlIENNYWtlIGNvZGUgcmVsYXRlZCB0byBDVVJM
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>314679</attachid>
            <date>2017-07-05 19:23:38 -0700</date>
            <delta_ts>2017-07-05 21:00:50 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-174155-20170706112337.patch</filename>
            <type>text/plain</type>
            <size>6411</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDcyZTk3MTliMTI0NDVkNTAwZDg5ZWU5
NWQxMjAzODU4YjNjNDFmMGIuLjM5YzMwODA0ZjBmZWRiMjIzNjU0YjQyMjM1ZWJmYzA5N2E1ZGEx
YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTctMDctMDUgIFl1c3VrZSBTdXp1a2kgIDx1dGF0
YW5lLnRlYUBnbWFpbC5jb20+CiAKKyAgICAgICAgVXBncmFkZSBHQ0MgYmFzZWxpbmUKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDE1NQorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0NvbXBpbGVy
Lmg6CisKKzIwMTctMDctMDUgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+
CisKICAgICAgICAgW1dURl0gQ2xlYW4gdXAgU3RyaW5nU3RhdGljcy5jcHAgYnkgdXNpbmcgTGF6
eU5ldmVyRGVzdHJveWVkPD4gZm9yIEF0b21zCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQxNTAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv
Q2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDViNDkzOWIyNzNkNGQ1
NDEzNjMyZmJiMzUyMzVjYzA5YTZiNjA4YzQuLmU0MmEwZmQ0YzE1OTdkM2Q4Mzc3ZjZjYzAyOTk1
ZTMzNjBmYzI2OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T
b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxNy0wNy0wNSAgWXVz
dWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAorICAgICAgICBVcGdyYWRlIEdD
QyBiYXNlbGluZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTc0MTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgUmVtb3ZlIHdvcmthcm91bmQgZm9yIG9sZCBHQ0MuCisKKyAgICAgICAgKiBDTWFrZUxpc3Rz
LnR4dDoKKworMjAxNy0wNy0wNSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNv
bT4KKwogICAgICAgICBbV1RGXSBDbGVhbiB1cCBTdHJpbmdTdGF0aWNzLmNwcCBieSB1c2luZyBM
YXp5TmV2ZXJEZXN0cm95ZWQ8PiBmb3IgQXRvbXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDE1MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0
Zi9Db21waWxlci5oIGIvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaAppbmRleCBjYjZmODlhZjNj
ZjMxNGIwN2M0MDcyOWMzYjYyODQxZmRiZTg5Y2NiLi5lMmI0NTQ3ZTE4ZDBjOGIyM2Q5ODY1YzRh
NzhiZjczOGQxZDllMjExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCisr
KyBiL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgKQEAgLTk0LDggKzk0LDggQEAKICNkZWZpbmUg
R0NDX1ZFUlNJT04gKF9fR05VQ19fICogMTAwMDAgKyBfX0dOVUNfTUlOT1JfXyAqIDEwMCArIF9f
R05VQ19QQVRDSExFVkVMX18pCiAjZGVmaW5lIEdDQ19WRVJTSU9OX0FUX0xFQVNUKG1ham9yLCBt
aW5vciwgcGF0Y2gpIChHQ0NfVkVSU0lPTiA+PSAobWFqb3IgKiAxMDAwMCArIG1pbm9yICogMTAw
ICsgcGF0Y2gpKQogCi0jaWYgIUdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDksIDApCi0jZXJyb3Ig
IlBsZWFzZSB1c2UgYSBuZXdlciB2ZXJzaW9uIG9mIEdDQy4gV2ViS2l0IHJlcXVpcmVzIEdDQyA0
LjkuMCBvciBuZXdlciB0byBjb21waWxlLiIKKyNpZiAhR0NDX1ZFUlNJT05fQVRfTEVBU1QoNSwg
MywgMCkKKyNlcnJvciAiUGxlYXNlIHVzZSBhIG5ld2VyIHZlcnNpb24gb2YgR0NDLiBXZWJLaXQg
cmVxdWlyZXMgR0NDIDUuMy4wIG9yIG5ld2VyIHRvIGNvbXBpbGUuIgogI2VuZGlmCiAKICNpZiBk
ZWZpbmVkKF9fU1REQ19WRVJTSU9OX18pICYmIF9fU1REQ19WRVJTSU9OX18gPj0gMjAxMTEyTApk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29y
ZS9DTWFrZUxpc3RzLnR4dAppbmRleCBjZTdiMTY4ZWZiNDczNmM2MGVjMWE3NjkwOTEwZjRlOWUw
Y2Q0ZTBjLi5lNWRlZDIyZDNmNmEwZTAxODJmZTNmMTUxZjczOTc4MzQ1ZGQ1ZGExIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9D
TWFrZUxpc3RzLnR4dApAQCAtNDAzNiwxMiArNDAzNiw2IEBAIGlmIChTSEFSRURfQ09SRSkKICAg
ICBpbnN0YWxsKFRBUkdFVFMgV2ViQ29yZSBERVNUSU5BVElPTiAiJHtMSUJfSU5TVEFMTF9ESVJ9
IikKIGVuZGlmICgpCiAKLSMgW0FSTV0gQnVpbGQgU1ZHUGF0aEVsZW1lbnQuY3BwIHdpdGggLU8y
IGR1ZSB0byBhIEdDQyBidWcKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE0NTM3NwotaWYgKChDTUFLRV9DWFhfQ09NUElMRVJfSUQgU1RSRVFVQUwgIkdOVSIpIEFO
RCBXVEZfQ1BVX0FSTSBBTkQgKENNQUtFX0NYWF9DT01QSUxFUl9WRVJTSU9OIFZFUlNJT05fR1JF
QVRFUiAiNC45IikgQU5EIChDTUFLRV9DWFhfQ09NUElMRVJfVkVSU0lPTiBWRVJTSU9OX0xFU1Mg
IjQuOS4zIikpCi0gICAgc2V0X3NvdXJjZV9maWxlc19wcm9wZXJ0aWVzKHN2Zy9TVkdQYXRoRWxl
bWVudC5jcHAgUFJPUEVSVElFUyBDT01QSUxFX0ZMQUdTICItTzIiKQotZW5kaWYgKCkKLQogaWYg
KE1TVkMpCiAgICAgc2V0X3RhcmdldF9wcm9wZXJ0aWVzKFdlYkNvcmUgUFJPUEVSVElFUwogICAg
ICAgICBDT01QSUxFX1BEQl9OQU1FICR7V2ViQ29yZV9PVVRQVVRfTkFNRX0KZGlmZiAtLWdpdCBh
L1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsu
Y21ha2UKaW5kZXggOTRhNWE5ZjU5NzNkYjYxZjE4YmMzYzYyMGU0OTk2MjY4ZDNmMjIyNS4uNjM3
YWM2NTljZjE2OWViNzM0MTk1ZWZjNTgwNGNlNmQyZDEzMDkwZiAxMDA2NDQKLS0tIGEvU291cmNl
L2NtYWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h
a2UKQEAgLTYsMTIgKzYsNiBAQCBzZXQoUFJPSkVDVF9WRVJTSU9OX01JQ1JPIDQpCiBzZXQoUFJP
SkVDVF9WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OX01BSk9SfS4ke1BST0pFQ1RfVkVSU0lPTl9N
SU5PUn0uJHtQUk9KRUNUX1ZFUlNJT05fTUlDUk99KQogc2V0KFdFQktJVEdUS19BUElfVkVSU0lP
TiA0LjApCiAKLWlmIChDTUFLRV9DWFhfQ09NUElMRVJfSUQgU1RSRVFVQUwgIkdOVSIpCi0gICAg
aWYgKENNQUtFX0NYWF9DT01QSUxFUl9WRVJTSU9OIFZFUlNJT05fTEVTUyAiNC45LjAiKQotICAg
ICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJHQ0MgNC45LjAgaXMgcmVxdWlyZWQgdG8gYnVpbGQg
V2ViS2l0R1RLKywgdXNlIGEgbmV3ZXIgR0NDIHZlcnNpb24gb3IgY2xhbmciKQotICAgIGVuZGlm
ICgpCi1lbmRpZiAoKQotCiAjIExpYnRvb2wgbGlicmFyeSB2ZXJzaW9uLCBub3QgdG8gYmUgY29u
ZnVzZWQgd2l0aCBBUEkgdmVyc2lvbi4KICMgU2VlIGh0dHA6Ly93d3cuZ251Lm9yZy9zb2Z0d2Fy
ZS9saWJ0b29sL21hbnVhbC9odG1sX25vZGUvTGlidG9vbC12ZXJzaW9uaW5nLmh0bWwKIENBTENV
TEFURV9MSUJSQVJZX1ZFUlNJT05TX0ZST01fTElCVE9PTF9UUklQTEUoV0VCS0lUMiA2MCAwIDIz
KQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UgYi9Tb3VyY2Uv
Y21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQppbmRleCAyODM1ZmNhZjcwYWM2NTY5Y2ViYmY4Zjgz
ODkwNDNlMWFlMTg3MjhhLi42ZTQ2MzgzZjM4YzBjZDU2MzU2ZWI2ZjdkMTZlZWJhZjFlZTdkODA0
IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQorKysgYi9Tb3Vy
Y2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQpAQCAtMjIsMTEgKzIyLDYgQEAgbWFjcm8oV0VC
S0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyBfdGFyZ2V0KQogICAgICAgICAgICAgc2V0KE9M
RF9DT01QSUxFX0ZMQUdTICItV25vLXBhcmVudGhlc2VzLWVxdWFsaXR5ICR7T0xEX0NPTVBJTEVf
RkxBR1N9IikKICAgICAgICAgZW5kaWYgKCkKIAotICAgICAgICAjIFN1cHByZXNzIC1XbWlzc2lu
Zy1maWVsZC1pbml0aWFsaXplcnMgZHVlIHRvIGEgR0NDIGJ1Zywgc2VlIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc4ODggZm9yIGRldGFpbHMuCi0gICAgICAgIGlm
ICgiJHtDTUFLRV9DWFhfQ09NUElMRVJfSUR9IiBTVFJFUVVBTCAiR05VIiBBTkQgQ01BS0VfQ1hY
X0NPTVBJTEVSX1ZFUlNJT04gTUFUQ0hFUyAiNFxcLjkiKQotICAgICAgICAgICAgc2V0KE9MRF9D
T01QSUxFX0ZMQUdTICItV25vLW1pc3NpbmctZmllbGQtaW5pdGlhbGl6ZXJzICR7T0xEX0NPTVBJ
TEVfRkxBR1N9IikKLSAgICAgICAgZW5kaWYgKCkKLQogICAgICAgICAjIEVuYWJsZSB3YXJuaW5n
cyBieSBkZWZhdWx0CiAgICAgICAgIGlmIChOT1QgJHtPUFRJT05fSUdOT1JFQ1hYX1dBUk5JTkdT
fSkKICAgICAgICAgICAgIHNldChPTERfQ09NUElMRV9GTEFHUyAiLVdhbGwgLVdleHRyYSAtV2Nh
c3QtYWxpZ24gLVdmb3JtYXQtc2VjdXJpdHkgLVdtaXNzaW5nLWZvcm1hdC1hdHRyaWJ1dGUgLVdw
b2ludGVyLWFyaXRoIC1XdW5kZWYgLVd3cml0ZS1zdHJpbmdzICR7T0xEX0NPTVBJTEVfRkxBR1N9
IikKZGlmZiAtLWdpdCBhL0NNYWtlTGlzdHMudHh0IGIvQ01ha2VMaXN0cy50eHQKaW5kZXggNDlh
ZTlmYWYyYjhiNGI1Y2U5NzY4MzhmZDhhMjUxYmEyZGM5NDY3NC4uM2RkNmY0ZTQzMzk2MTQwODBh
YTE3N2Y2OGUxOWZmMGEyY2EzNzQ1OCAxMDA2NDQKLS0tIGEvQ01ha2VMaXN0cy50eHQKKysrIGIv
Q01ha2VMaXN0cy50eHQKQEAgLTQ2LDYgKzQ2LDEyIEBAIGlmICgke0NNQUtFX0NYWF9DT01QSUxF
Ul9JRH0gU1RSRVFVQUwgIkNsYW5nIiBPUiAke0NNQUtFX0NYWF9DT01QSUxFUl9JRH0gU1RSRVFV
CiAgICAgc2V0KENPTVBJTEVSX0lTX0NMQU5HIE9OKQogZW5kaWYgKCkKIAoraWYgKCR7Q01BS0Vf
Q1hYX0NPTVBJTEVSX0lEfSBTVFJFUVVBTCAiR05VIikKKyAgICBpZiAoJHtDTUFLRV9DWFhfQ09N
UElMRVJfVkVSU0lPTn0gVkVSU0lPTl9MRVNTICI1LjMuMCIpCisgICAgICAgIG1lc3NhZ2UoRkFU
QUxfRVJST1IgIkdDQyA1LjMuMCBpcyByZXF1aXJlZCB0byBidWlsZCBXZWJLaXRHVEsrLCB1c2Ug
YSBuZXdlciBHQ0MgdmVyc2lvbiBvciBjbGFuZyIpCisgICAgZW5kaWYgKCkKK2VuZGlmICgpCisK
IGlmIChDTUFLRV9DT01QSUxFUl9JU19HTlVDWFggT1IgQ09NUElMRVJfSVNfQ0xBTkcpCiAgICAg
c2V0KENPTVBJTEVSX0lTX0dDQ19PUl9DTEFORyBPTikKIGVuZGlmICgpCmRpZmYgLS1naXQgYS9D
aGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZDZkMWJhMDdhMDZhMzNmMjE0MTVkNmQyZTEyYzgy
N2UxYzRmODJiOS4uNTViNzY5ZDc2ZTU5MWUzZTU0MGQzZjQyYjMxZDE1ODE3MGZmZjdkNCAxMDA2
NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3
LTA3LTA1ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAg
IFVwZ3JhZGUgR0NDIGJhc2VsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0xNzQxNTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBUaGlzIHBhdGNoIGJ1bXBzIHRoZSB2ZXJzaW9uIG9mIEdDQyBmcm9tIDQu
OS4wIHRvIDUuMy4wLAorICAgICAgICB3aGljaCBpcyBzaGlwcGVkIHdpdGggVWJ1bnR1IDE2LjA0
IExUUy4gQW5kIHRoZSBsYXRlc3QKKyAgICAgICAgRGViaWFuIHN0YWJsZSAoc3RyZXRjaCkgYWxy
ZWFkeSBzaGlwcyBuZXdlciBHQ0MgKDYuMy4wKS4KKyAgICAgICAgUmVtb3ZlIHdvcmthcm91bmQg
Zm9yIG9sZCBHQ0MuIEFuZCBtb3ZlIEdDQyB2ZXJzaW9uIGNoZWNrCisgICAgICAgIHRvIHRoZSB0
b3AtbGV2ZWwgQ01ha2VMaXN0cy50eHQuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAg
ICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2Uv
Y21ha2UvV2ViS2l0SGVscGVycy5jbWFrZToKKwogMjAxNy0wNy0wNSAgRG9uIE9sbXN0ZWFkICA8
ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb10gQ29uc29saWRhdGUg
Q01ha2UgY29kZSByZWxhdGVkIHRvIENVUkwK
</data>
<flag name="review"
          id="335543"
          type_id="1"
          status="+"
          setter="mcatanzaro"
    />
          </attachment>
      

    </bug>

</bugzilla>