174149 2017-07-04 21:19:54 -0700 CSSFontStyleValue::isItalic seems a bit bogus. 2022-07-15 11:07:10 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ecobos mmaxfield commit-queue dino hyatt jonlee koivisto mmaxfield sandervv+webkit simon.fraser thorton webkit-bug-importer oldest_to_newest 1325527 0 ecobos 2017-07-04 21:19:54 -0700 bool isItalic() const { if (!obliqueValue) { auto valueID = fontStyleValue->valueID(); return valueID == CSSValueItalic || CSSValueOblique; } return obliqueValue->value<float>(CSSPrimitiveValue::CSS_DEG) >= static_cast<float>(italicValue()); } Note how "|| CSSValueOblique" makes the first return always return true. I'm not familiar with this code, so I'm not sure how to best test it. Happy to fix it with indications on how to test it. I've CCd the original patch author and reviewer so you can take a look (and fix) if you want to. 1325747 1 mmaxfield 2017-07-05 13:46:37 -0700 Good catch! 1325809 2 314662 mmaxfield 2017-07-05 16:10:41 -0700 Created attachment 314662 Patch 1325813 3 314662 thorton 2017-07-05 16:21:31 -0700 Comment on attachment 314662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314662&action=review > Source/WebCore/ChangeLog:12 > + * css/CSSFontStyleValue.h: Write some words! > Source/WebCore/css/CSSFontStyleValue.h:50 > { Should this be called isItalicOrOblique? > LayoutTests/editing/execCommand/italicizeByCharacter-normal.html:11 > +<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script> This is the ugliest <script> I've seen in a long time :) 1325846 4 314662 commit-queue 2017-07-05 17:26:34 -0700 Comment on attachment 314662 Patch Clearing flags on attachment: 314662 Committed r219173: <http://trac.webkit.org/changeset/219173> 1325847 5 commit-queue 2017-07-05 17:26:36 -0700 All reviewed patches have been landed. Closing bug. 1325855 6 mmaxfield 2017-07-05 18:14:26 -0700 (In reply to Tim Horton from comment #3) > Comment on attachment 314662 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314662&action=review > > > Source/WebCore/ChangeLog:12 > > + * css/CSSFontStyleValue.h: > > Write some words! > > > Source/WebCore/css/CSSFontStyleValue.h:50 > > { > > Should this be called isItalicOrOblique? > > > LayoutTests/editing/execCommand/italicizeByCharacter-normal.html:11 > > +<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script> > > This is the ugliest <script> I've seen in a long time :) Oh no, I didn't actually do anything you said!!! :( I'll do it in a follow-up patch. 1337466 7 mmaxfield 2017-08-10 09:59:40 -0700 Committed r220531: <http://trac.webkit.org/changeset/220531> 1337468 8 webkit-bug-importer 2017-08-10 10:00:55 -0700 <rdar://problem/33829710> 1337510 9 314662 simon.fraser 2017-08-10 11:24:52 -0700 Comment on attachment 314662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314662&action=review > Source/WebCore/ChangeLog:3 > + CSSFontStyleValue::isItalic seems a bit bogus. Vaguest bug title ever. 1337539 10 koivisto 2017-08-10 12:25:33 -0700 > > + CSSFontStyleValue::isItalic seems a bit bogus. > > Vaguest bug title ever. "CSSFontStyleValue::isItalic has high bogosity." 1884100 11 bfulgham 2022-07-15 11:07:10 -0700 *** Bug 173970 has been marked as a duplicate of this bug. *** 314662 2017-07-05 16:10:41 -0700 2017-07-05 17:26:34 -0700 Patch bug-174149-20170705161040.patch text/plain 4057 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2U5ODMzYmNiZGEzYWUw YjVmNDk4NTIwNzNkYjZlMTY1YmI5YWU2MS4uZTUwMjlhODc1NmRlMzRjMjE1ZDFkNmRkYWQxZmJk NGY3ZjNjNGQ5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA3LTA1ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQ1NTRm9udFN0 eWxlVmFsdWU6OmlzSXRhbGljIHNlZW1zIGEgYml0IGJvZ3VzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MTQ5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2ltcGxlIHR5cG8uCisKKyAgICAgICAgVGVz dDogZWRpdGluZy9leGVjQ29tbWFuZC9pdGFsaWNpemVCeUNoYXJhY3Rlci1ub3JtYWwuaHRtbAor CisgICAgICAgICogY3NzL0NTU0ZvbnRTdHlsZVZhbHVlLmg6CisKIDIwMTctMDctMDUgIFdlbnNv biBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgV2hlbiBkcmFnZ2lu ZyBhIHNlbGVjdGlvbiwgY2xlYXJpbmcgdGhlIHNlbGVjdGlvbiBpbiBkcmFnc3RhcnQgc2hvdWxk IG5vdCBjcmFzaCB0aGUgd2ViIHByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NGb250U3R5bGVWYWx1ZS5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRTdHlsZVZh bHVlLmgKaW5kZXggYzIxYmMyOTM5MWRmN2QyZDljYTMxMzFjZTBmMDczNjAyNTZjNTMwNy4uYzRh OTM1NmZhMjQ1NzE0ZDM1ODY1YjMxYTdlOGMwYjZiYWUwZGFlNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvY3NzL0NTU0ZvbnRTdHlsZVZhbHVlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU0ZvbnRTdHlsZVZhbHVlLmgKQEAgLTUwLDcgKzUwLDcgQEAgcHVibGljOgogICAgIHsKICAg ICAgICAgaWYgKCFvYmxpcXVlVmFsdWUpIHsKICAgICAgICAgICAgIGF1dG8gdmFsdWVJRCA9IGZv bnRTdHlsZVZhbHVlLT52YWx1ZUlEKCk7Ci0gICAgICAgICAgICByZXR1cm4gdmFsdWVJRCA9PSBD U1NWYWx1ZUl0YWxpYyB8fCBDU1NWYWx1ZU9ibGlxdWU7CisgICAgICAgICAgICByZXR1cm4gdmFs dWVJRCA9PSBDU1NWYWx1ZUl0YWxpYyB8fCB2YWx1ZUlEID09IENTU1ZhbHVlT2JsaXF1ZTsKICAg ICAgICAgfQogICAgICAgICByZXR1cm4gb2JsaXF1ZVZhbHVlLT52YWx1ZTxmbG9hdD4oQ1NTUHJp bWl0aXZlVmFsdWU6OkNTU19ERUcpID49IHN0YXRpY19jYXN0PGZsb2F0PihpdGFsaWNWYWx1ZSgp KTsKICAgICB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggMjMyOGVjM2YyYjI0ZWRiZjAxNDVmOTcxNTg0Y2FkMGI0ZmUzMDBl Zi4uNjAwZjNhM2VlZmI4NDdmZjczM2VmNGUyMzYxNDQwYzY3ODFlNjZlNSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTA3LTA1ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBs ZS5jb20+CisKKyAgICAgICAgQ1NTRm9udFN0eWxlVmFsdWU6OmlzSXRhbGljIHNlZW1zIGEgYml0 IGJvZ3VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc0MTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBlZGl0aW5nL2V4ZWNDb21tYW5kL2l0YWxpY2l6ZUJ5Q2hhcmFjdGVyLW5vcm1hbC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvaXRhbGljaXplQnlD aGFyYWN0ZXItbm9ybWFsLmh0bWw6IEFkZGVkLgorCiAyMDE3LTA3LTA1ICBaYWxhbiBCdWp0YXMg IDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIxNzUyMik6ICJTaG93 IE15IFJlbGF0aW9uc2hpcCIgbGluayBpbiBmYW1pbHlzZWFyY2gub3JnIGRvZXMgbm90IHdvcmsu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2l0YWxpY2l6ZUJ5 Q2hhcmFjdGVyLW5vcm1hbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWND b21tYW5kL2l0YWxpY2l6ZUJ5Q2hhcmFjdGVyLW5vcm1hbC1leHBlY3RlZC50eHQKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uN2Q5MTRkMWZmYmZhOTM0MDkwZWY4ZjVkYzFhNzcwZDMyMzEwZTM3NQotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaXRhbGljaXplQnlDaGFyYWN0 ZXItbm9ybWFsLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDQgQEAKK1RoaXMgdGVzdHMgaXRhbGlj aXppbmcgdGhlIGZpcnN0IGNoYXJhY3Rlci4gVGhlIGRvdWJsZSBxdW90YXRpb24gYXQgdGhlIGJl Z2lubmluZyBtdXN0IGJlIGl0YWxpY2l6ZWQuCisKKyJUaGUgcXVpY2sgYnJvd24gZm94IGp1bXBz IG92ZXIgdGhlIGxhenkgZG9nIiB1c2VzIGV2ZXJ5IGxldHRlciBpbiB0aGUgZW5nbGlzaCBsYW5n dWFnZS4KK2V4ZWNJdGFsaWNDb21tYW5kOiA8c3BhbiBpZD0idGVzdCI+PGk+IjwvaT48L3NwYW4+ PHNwYW4gc3R5bGU9ImZvbnQtc3R5bGU6IG5vcm1hbDsiPlRoZSBxdWljayBicm93biBmb3gganVt cHMgb3ZlciB0aGUgbGF6eSBkb2ciIHVzZXMgZXZlcnkgbGV0dGVyIGluIHRoZSBlbmdsaXNoIGxh bmd1YWdlLiA8L3NwYW4+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21t YW5kL2l0YWxpY2l6ZUJ5Q2hhcmFjdGVyLW5vcm1hbC5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGlu Zy9leGVjQ29tbWFuZC9pdGFsaWNpemVCeUNoYXJhY3Rlci1ub3JtYWwuaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li5mMjJhZjgzMTdmYjViNzFkODk3NjBlODZmZDRiOTg4ZmFiNTY0NWZhCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9pdGFsaWNpemVCeUNoYXJhY3Rl ci1ub3JtYWwuaHRtbApAQCAtMCwwICsxLDM4IEBACis8aHRtbD4gCis8aGVhZD4KKworPHN0eWxl PgorLmVkaXRpbmcgeyAKKyAgICBib3JkZXI6IDJweCBzb2xpZCByZWQ7IAorICAgIHBhZGRpbmc6 IDEycHg7IAorICAgIGZvbnQtc2l6ZTogMjRweDsgCit9Cis8L3N0eWxlPgorPHNjcmlwdCBzcmM9 Li4vZWRpdGluZy5qcyBsYW5ndWFnZT0iSmF2YVNjcmlwdCIgdHlwZT0idGV4dC9KYXZhU2NyaXB0 IiA+PC9zY3JpcHQ+CisKKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIGVkaXRpbmdUZXN0KCkgeworICAg IGV4ZWNFeHRlbmRTZWxlY3Rpb25Gb3J3YXJkQnlDaGFyYWN0ZXJDb21tYW5kKCk7CisgICAgaXRh bGljQ29tbWFuZCgpOworfQorCis8L3NjcmlwdD4KKworPHRpdGxlPkVkaXRpbmcgVGVzdDwvdGl0 bGU+IAorPC9oZWFkPiAKKzxib2R5PgorPHA+VGhpcyB0ZXN0cyBpdGFsaWNpemluZyB0aGUgZmly c3QgY2hhcmFjdGVyLiAgVGhlIGRvdWJsZSBxdW90YXRpb24gYXQgdGhlIGJlZ2lubmluZyBtdXN0 IGJlIGl0YWxpY2l6ZWQuPC9wPgorPGRpdiBjb250ZW50ZWRpdGFibGUgaWQ9InJvb3QiIGNsYXNz PSJlZGl0aW5nIj4KKzxzcGFuIGlkPSJ0ZXN0IiBzdHlsZT0iZm9udC1zdHlsZTogbm9ybWFsOyI+ IlRoZSBxdWljayBicm93biBmb3gganVtcHMgb3ZlciB0aGUgbGF6eSBkb2ciIHVzZXMgZXZlcnkK K2xldHRlciBpbiB0aGUgZW5nbGlzaCBsYW5ndWFnZS4KKzwvc3Bhbj4KKzwvZGl2PgorCis8c2Ny aXB0PgorcnVuRHVtcEFzVGV4dEVkaXRpbmdUZXN0KCk7Cis8L3NjcmlwdD4KKworPC9ib2R5Pgor PC9odG1sPgorCg==