174147 2017-07-04 21:06:55 -0700 Style sharing check for fullscreen element seems bogus. 2017-07-05 16:42:18 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 160196 P2 Normal --- 1 ecobos ecobos buildbot koivisto sam oldest_to_newest 1325522 0 ecobos 2017-07-04 21:06:55 -0700 Seems like a typo... I'm not sure how to add a test for something like uses the fullscreen API (plus, style sharing seems somewhat obscure to test on isolation). But happy to do so if there's an straight-forward way to do it. 1325524 1 314596 ecobos 2017-07-04 21:08:54 -0700 Created attachment 314596 Patch 1325526 2 buildbot 2017-07-04 21:11:35 -0700 Attachment 314596 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1325532 3 ecobos 2017-07-04 22:10:40 -0700 Oh, I'd swear I had seen that typo before. It was indeed the first patch I tried to submit to WebKit! This is a dupe of https://bugs.webkit.org/show_bug.cgi?id=160196 *** This bug has been marked as a duplicate of bug 160196 *** 314596 2017-07-04 21:08:54 -0700 2017-07-05 16:42:18 -0700 Patch bug-174147-20170705060853.patch text/plain 1600 ecobos U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFkZTI0YzJkNzFjODMz OTNhOTMwMzNmNWUxYzkwMzlmODE1Yjg4Ny4uODBlZTIwM2Q4ODRiNWE1OWJmMmExNjhkNzY1Zjgz NmI4MTgyYTdiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTA3LTA0ICBFbWls aW8gQ29ib3Mgw4FsdmFyZXogIDxlY29ib3NAaWdhbGlhLmNvbT4KIAorICAgICAgICBTdHlsZSBz aGFyaW5nIGNoZWNrIGZvciBmdWxsc2NyZWVuIGVsZW1lbnQgc2VlbXMgYm9ndXMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQxNDcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9P UFMhKS4KKworICAgICAgICAqIHN0eWxlL1N0eWxlU2hhcmluZ1Jlc29sdmVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlN0eWxlOjpTaGFyaW5nUmVzb2x2ZXI6OmNhblNoYXJlU3R5bGVXaXRoRWxl bWVudCk6CisKKzIwMTctMDctMDQgIEVtaWxpbyBDb2JvcyDDgWx2YXJleiAgPGVjb2Jvc0BpZ2Fs aWEuY29tPgorCiAgICAgICAgIFByb2Nlc3NpbmdJbnN0cnVjdGlvbjo6Y2xlYXJFeGlzdGluZ0Nh Y2hlZFNoZWV0IGRvZXNuJ3QgcmVhbGx5IGV4aXN0LgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MTQ2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3N0eWxlL1N0eWxlU2hhcmluZ1Jlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0eWxl L1N0eWxlU2hhcmluZ1Jlc29sdmVyLmNwcAppbmRleCBiN2EyODQ5NmFlNTJjODY5NTIyYjE4MDI5 ZDcxMGJiNzUzZWUxMjAzLi40ODBmNGRjNzMyYWU3ZjM0YjI3ZWE4ZGU4ZWY0NTZiZDBjNzgzYTY5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVNoYXJpbmdSZXNvbHZlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVTaGFyaW5nUmVzb2x2ZXIuY3BwCkBA IC0yOTIsNyArMjkyLDcgQEAgYm9vbCBTaGFyaW5nUmVzb2x2ZXI6OmNhblNoYXJlU3R5bGVXaXRo RWxlbWVudChjb25zdCBDb250ZXh0JiBjb250ZXh0LCBjb25zdCBTdHkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQotICAgIGlmICgmZWxlbWVudCA9 PSBtX2RvY3VtZW50LndlYmtpdEN1cnJlbnRGdWxsU2NyZWVuRWxlbWVudCgpIHx8ICZlbGVtZW50 ID09IG1fZG9jdW1lbnQud2Via2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVtZW50KCkpCisgICAgaWYg KCZjYW5kaWRhdGVFbGVtZW50ID09IG1fZG9jdW1lbnQud2Via2l0Q3VycmVudEZ1bGxTY3JlZW5F bGVtZW50KCkgfHwgJmVsZW1lbnQgPT0gbV9kb2N1bWVudC53ZWJraXRDdXJyZW50RnVsbFNjcmVl bkVsZW1lbnQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogI2VuZGlmCiAgICAgcmV0dXJuIHRy dWU7Cg==