174145 2017-07-04 20:45:06 -0700 We resolve one extra element's style when calling getComputedStyle on a display: none subtree, I think 2017-07-05 11:01:50 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ecobos ecobos buildbot cdumez cmarcelo commit-queue dbates esprehn+autocc kangil.han koivisto oldest_to_newest 1325518 0 ecobos 2017-07-04 20:45:06 -0700 Noticed this while trying to construct a test-case for bug 172753. In Element::resolveComputedStyle: elementsRequiringComputedStyle.prepend(&ancestor); if (auto* existingStyle = ancestor.existingComputedStyle()) { computedStyle = existingStyle; break; } I think that we resolve style when not needed for that ancestor we find an existing computed style for... Also, I think, that we resolve the first element inheriting from itself, which seems wrong (though I don't think it's observable, fwiw)... Will post a patch here to run through CI, and will update for review when needed. 1325519 1 314594 ecobos 2017-07-04 20:49:57 -0700 Created attachment 314594 Patch 1325631 2 koivisto 2017-07-05 10:34:40 -0700 Nice find, r=me 1325652 3 314594 commit-queue 2017-07-05 11:01:48 -0700 Comment on attachment 314594 Patch Clearing flags on attachment: 314594 Committed r219138: <http://trac.webkit.org/changeset/219138> 1325653 4 commit-queue 2017-07-05 11:01:50 -0700 All reviewed patches have been landed. Closing bug. 314594 2017-07-04 20:49:57 -0700 2017-07-05 11:01:48 -0700 Patch bug-174145-20170705054956.patch text/plain 1799 ecobos U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5MTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDMxY2QwYmFiY2E2YzEy Nzc1YTBiY2ZmMmVkMzlkZGZlYmY5NTkyYS4uMTAyYWVkZWEwNTdmMzVkMzM5NTBiNjkzNTk5NTdi ZTU0M2VjOWY1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA3LTA0ICBFbWls aW8gQ29ib3Mgw4FsdmFyZXogIDxlY29ib3NAaWdhbGlhLmNvbT4KKworICAgICAgICBEb24ndCBy ZXNvbHZlIGFuIGV4dHJhIGNvbXB1dGVkIHN0eWxlIGZvciBnZXRDb21wdXRlZFN0eWxlIGluIGEg ZGlzcGxheTogbm9uZSBzdWJ0cmVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc0MTQ1CisKKyAgICAgICAgQmVmb3JlIHRoaXMsIHdlIHdlcmUgYWxz byByZXNvbHZpbmcgdGhlIGZpcnN0IGFuY2VzdG9yJ3Mgc3R5bGUgYXMKKyAgICAgICAgaW5oZXJp dGluZyBmcm9tIGl0c2VsZiwgd2hpY2ggZmVsdCBwcmV0dHkgd3JvbmcgKHRob3VnaCBJIHRoaW5r IGl0J3MKKyAgICAgICAgbm90IG9ic2VydmFibGUpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAobm9uLW9ic2VydmFibGUgYmVo YXZpb3IpLgorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RWxlbWVudDo6cmVzb2x2ZUNvbXB1dGVkU3R5bGUpOgorCiAyMDE3LTA2LTE3ICBFbWlsaW8gQ29i b3Mgw4FsdmFyZXogIDxlY29ib3NAaWdhbGlhLmNvbT4KIAogICAgICAgICBEb24ndCBhbHdheXMg cmVjYWxjIHRoZSBzdHlsZSBvZiBkaXNwbGF5OiBjb250ZW50cyBlbGVtZW50cy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50LmNwcAppbmRleCA2OTA0MmE4YjBiMzRlOTdmNDlhMDRiOWI0MTNiYzE3ZDg3MzAxZDg1 Li4zZTViZTAwMzAwNTRmMmZhNjgwOWQ5MzRhZGExY2I0Y2JhOGJhZjAxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0Vs ZW1lbnQuY3BwCkBAIC0yNjkwLDExICsyNjkwLDExIEBAIGNvbnN0IFJlbmRlclN0eWxlJiBFbGVt ZW50OjpyZXNvbHZlQ29tcHV0ZWRTdHlsZSgpCiAgICAgLy8gQ29sbGVjdCBhbmNlc3RvcnMgdW50 aWwgd2UgZmluZCBvbmUgdGhhdCBoYXMgc3R5bGUuCiAgICAgYXV0byBjb21wb3NlZEFuY2VzdG9y cyA9IGNvbXBvc2VkVHJlZUFuY2VzdG9ycygqdGhpcyk7CiAgICAgZm9yIChhdXRvJiBhbmNlc3Rv ciA6IGNvbXBvc2VkQW5jZXN0b3JzKSB7Ci0gICAgICAgIGVsZW1lbnRzUmVxdWlyaW5nQ29tcHV0 ZWRTdHlsZS5wcmVwZW5kKCZhbmNlc3Rvcik7CiAgICAgICAgIGlmIChhdXRvKiBleGlzdGluZ1N0 eWxlID0gYW5jZXN0b3IuZXhpc3RpbmdDb21wdXRlZFN0eWxlKCkpIHsKICAgICAgICAgICAgIGNv bXB1dGVkU3R5bGUgPSBleGlzdGluZ1N0eWxlOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg IH0KKyAgICAgICAgZWxlbWVudHNSZXF1aXJpbmdDb21wdXRlZFN0eWxlLnByZXBlbmQoJmFuY2Vz dG9yKTsKICAgICB9CiAKICAgICAvLyBSZXNvbHZlIGFuZCBjYWNoZSBzdHlsZXMgc3RhcnRpbmcg ZnJvbSB0aGUgbW9zdCBkaXN0YW50IGFuY2VzdG9yLgo=