174143 2017-07-04 17:12:27 -0700 Crash in UIKit: +[UIViewController _viewControllerForFullScreenPresentationFromView:] 2017-07-05 10:44:05 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan aestes bdakin commit-queue ddkilzer thorton wenson_hsieh oldest_to_newest 1325497 0 adachan 2017-07-04 17:12:27 -0700 <rdar://problem/28384582> The crash happens in WKActionSheet.mm: - (void)willRotate { ..... UIView *view = [_sheetDelegate hostViewForSheet]; UIViewController *presentingViewController = [UIViewController _viewControllerForFullScreenPresentationFromView:view]; ... } We cannot guarantee that the action sheet belongs in a window, and view could be nil. Passing nil to -[UIViewController _viewControllerForFullScreenPresentationFromView:] causes an exception to be thrown. 1325503 1 314588 adachan 2017-07-04 17:39:55 -0700 Created attachment 314588 Patch 1325515 2 314588 wenson_hsieh 2017-07-04 19:49:52 -0700 Comment on attachment 314588 Patch r=me, this check and the explanation seem reasonable, though I think we still need a wk2r+. I don't know any simple way to test this, but we could make a TestWebKitAPI test case that simulates this situation by broadcasting UIWindowWillRotateNotification after presenting a popover in a WKWebView that's been removed from its UIWindow. 1325618 3 314588 bdakin 2017-07-05 10:16:39 -0700 Comment on attachment 314588 Patch wk2r=me! 1325637 4 314588 commit-queue 2017-07-05 10:44:03 -0700 Comment on attachment 314588 Patch Clearing flags on attachment: 314588 Committed r219136: <http://trac.webkit.org/changeset/219136> 1325638 5 commit-queue 2017-07-05 10:44:05 -0700 All reviewed patches have been landed. Closing bug. 314588 2017-07-04 17:39:55 -0700 2017-07-05 10:44:03 -0700 Patch 0001-Fix-crash-in-UIKit-UIViewController-_viewControllerF.patch text/plain 2489 adachan RnJvbSA1MzMxYWQ5MDExNTRmYWU1MTVlNDYyNTI2MjMyOWVlODBiMmU0OTIyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IFR1 ZSwgNCBKdWwgMjAxNyAxNzozMDo0OSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBjcmFzaCBp biBVSUtpdDogK1tVSVZpZXdDb250cm9sbGVyCiBfdmlld0NvbnRyb2xsZXJGb3JGdWxsU2NyZWVu UHJlc2VudGF0aW9uRnJvbVZpZXc6XQogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3NDE0MyA8cmRhcjovL3Byb2JsZW0vMjgzODQ1ODI+CgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCkluIC1bV0tBY3Rpb25TaGVldCB3aWxsUm90YXRlXSwgd2UgY2FuJ3QgZ3Vh cmFudGVlIHRoYXQgdGhlIGFjdGlvbiBzaGVldCBiZWxvbmdzCmluIGEgd2luZG93LCBhbmQgcGFz c2luZyBuaWwgdG8gK1tVSVZpZXdDb250cm9sbGVyIF92aWV3Q29udHJvbGxlckZvckZ1bGxTY3Jl ZW5QcmVzZW50YXRpb25Gcm9tVmlldzpdCnRocm93cyBhbiBleGNlcHRpb24uIFRvIGZpeCB0aGlz LCBiYWlsIGVhcmx5IGlmIHRoZSByZXN1bHQgZnJvbSAtaG9zdFZpZXdGb3JTaGVldCBpcyBuaWwu CgoqIFVJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldC5tbToKKC1bV0tBY3Rpb25TaGVldCB3aWxs Um90YXRlXSk6Ci0tLQogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgIHwgMTUgKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dL QWN0aW9uU2hlZXQubW0gfCAgMyArKysKIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygr KQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwppbmRleCA4MjA0YmNiZTUwOC4uMGI2ZTU0YWJkOWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxNy0wNy0wNCAgQWRhIENoYW4gIDxhZGFjaGFuQGFwcGxlLmNvbT4K KworICAgICAgICBGaXggY3Jhc2ggaW4gVUlLaXQ6ICtbVUlWaWV3Q29udHJvbGxlciBfdmlld0Nv bnRyb2xsZXJGb3JGdWxsU2NyZWVuUHJlc2VudGF0aW9uRnJvbVZpZXc6XQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0MTQzCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yODM4NDU4Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbiAtW1dLQWN0aW9uU2hlZXQgd2lsbFJvdGF0ZV0sIHdlIGNhbid0IGd1 YXJhbnRlZSB0aGF0IHRoZSBhY3Rpb24gc2hlZXQgYmVsb25ncworICAgICAgICBpbiBhIHdpbmRv dywgYW5kIHBhc3NpbmcgbmlsIHRvICtbVUlWaWV3Q29udHJvbGxlciBfdmlld0NvbnRyb2xsZXJG b3JGdWxsU2NyZWVuUHJlc2VudGF0aW9uRnJvbVZpZXc6XQorICAgICAgICB0aHJvd3MgYW4gZXhj ZXB0aW9uLiBUbyBmaXggdGhpcywgYmFpbCBlYXJseSBpZiB0aGUgcmVzdWx0IGZyb20gLWhvc3RW aWV3Rm9yU2hlZXQgaXMgbmlsLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNo ZWV0Lm1tOgorICAgICAgICAoLVtXS0FjdGlvblNoZWV0IHdpbGxSb3RhdGVdKToKKwogMjAxNy0w Ny0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIENs ZWFudXAgc29tZSBTdHJpbmdCdWlsZGVyIHVzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9XS0FjdGlvblNoZWV0Lm1tCmluZGV4IGFkNGE4N2ZkYTFmLi42YjVlZDhkMTg3MiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0Lm1tCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldC5tbQpAQCAtMTUz LDYgKzE1Myw5IEBACiAgICAgLy8gICAgdmlldyBjb250cm9sbGVyLCB3aXRob3V0IHJlLXByZXNl bnRpbmcgdGhlIGFsZXJ0IGNvbnRyb2xsZXIuCiAKICAgICBVSVZpZXcgKnZpZXcgPSBbX3NoZWV0 RGVsZWdhdGUgaG9zdFZpZXdGb3JTaGVldF07CisgICAgaWYgKCF2aWV3KQorICAgICAgICByZXR1 cm47CisKICAgICBVSVZpZXdDb250cm9sbGVyICpwcmVzZW50aW5nVmlld0NvbnRyb2xsZXIgPSBb VUlWaWV3Q29udHJvbGxlciBfdmlld0NvbnRyb2xsZXJGb3JGdWxsU2NyZWVuUHJlc2VudGF0aW9u RnJvbVZpZXc6dmlld107CiAKICAgICAvLyB0b3BQcmVzZW50ZWRWaWV3Q29udHJvbGxlciBpcyBl aXRoZXIgc2VsZiAoY2FzZXMgKGEpIGFuZCAoYikgYWJvdmUpIG9yIGFuIGFjdGlvbidzIHZpZXcg Y29udHJvbGxlcgotLSAKMi4xMy4wIChBcHBsZSBHaXQtODgpCgo=